November 2023 - gerrit-log - lists.osmocom.org

[M] Change in libosmocore[master]: LAPD: Add support for RTS based polling and T200

by neels

Attention is currently required from: jolly. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email ) Change subject: LAPD: Add support for RTS based polling and T200 ...................................................................... Patch Set 8: Code-Review+1 (4 comments) File include/osmocom/isdn/lapd_core.h: https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/096a5c7e_e9c0ff67 PS8, Line 88: #define LAPD_F_RTS 0x0001 (an enum would be nicer IMHO) File src/isdn/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/a08beb95_979c4df4 PS8, Line 220: Function to (just drop the words "Function to", rationale: it is obvious that it is a function) https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/37864d12_f292a897 PS8, Line 400: \ref '\ref' is not valid doxygen here, see https://osmocom.org/projects/cellular-infrastructure/wiki/Guidelines_for_AP… https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/8dbf6784_2d0d40c0 PS8, Line 1785: Function call when a LAPD frame is ready to sent. this is hard to understand, could you make this an "imperative form" description of what the function does, like Send the next LAPD frame. (if that is correct). That is the shortest and clearest form of doc. thanks -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib961b5a44911b99b0487641533301749c0286995 Gerrit-Change-Number: 34985 Gerrit-PatchSet: 8 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 22 Nov 2023 22:17:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-bsc[master]: use X6 timer for REL ACK, not T3111

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35088?usp=email ) Change subject: use X6 timer for REL ACK, not T3111 ...................................................................... use X6 timer for REL ACK, not T3111 The lchan FSM timers were originally implemented to model earlier code as closely as possible. Now it has come up that T3111 is used in the wrong place: 3GPP TS 44.018 says: T3111: This timer is used to delay the channel deactivation after disconnection of the main signalling link. Its purpose is to let some time for possible repetition of the disconnection. Its value is equal to the value of T3110. Before this patch, we use it also to time the RF REL ACK message. That is pretty bad, because T3111 is only 2 seconds by default, making RF CHAN REL vulnerable for timeout. When a user increased T3111 to alleviate the problem, the result is that each lchan also delays its normal channel release procedure by the configured amount of time. Very inelegant. Instead, use the X6 timer for REL ACK, because X6 already times the CHAN ACTIV ACK, which is semantically identical. Compatibility / user impact: No negative impact expected. We can assume that every user out there has X6 configured to work for CHAN ACTIV ACK. From that logic, switching channel release ACK to the same timer is guaranteed to be what the user intends. We could instruct users in the release notes that they may now choose T3111 freely (as short as 2 seconds) without jeopardising channel release anymore. Related: SYS#6655 Change-Id: Ibd118fa23e5deb4381bc31b11a7b495f57901d6c --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 40 insertions(+), 1 deletion(-) Approvals: osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 1b012bd..d6dfe3a 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -330,7 +330,7 @@ [LCHAN_ST_WAIT_RLL_RTP_ESTABLISH] = { .T = 3101 }, [LCHAN_ST_WAIT_RLL_RTP_RELEASED] = { .T = 3109 }, [LCHAN_ST_WAIT_BEFORE_RF_RELEASE] = { .T = 3111 }, - [LCHAN_ST_WAIT_RF_RELEASE_ACK] = { .T = 3111 }, + [LCHAN_ST_WAIT_RF_RELEASE_ACK] = { .T = -6 }, [LCHAN_ST_WAIT_AFTER_ERROR] = { .T = -3111 }, [LCHAN_ST_WAIT_RR_CHAN_MODE_MODIFY_ACK] = { .T = -13 }, [LCHAN_ST_WAIT_RSL_CHAN_MODE_MODIFY_ACK] = { .T = -14 }, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35088?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd118fa23e5deb4381bc31b11a7b495f57901d6c Gerrit-Change-Number: 35088 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[M] Change in osmo-bsc[master]: recover BORKEN lchans for missing ACK scenarios

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30252?usp=email ) Change subject: recover BORKEN lchans for missing ACK scenarios ...................................................................... Patch Set 13: -Code-Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic4728b3efe843ea63e2a0b54b1ea8a925347484a Gerrit-Change-Number: 30252 Gerrit-PatchSet: 13 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Nov 2023 21:54:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[M] Change in osmo-bsc[master]: recover BORKEN lchans for missing ACK scenarios

by neels

Attention is currently required from: osmith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30252?usp=email ) Change subject: recover BORKEN lchans for missing ACK scenarios ...................................................................... Patch Set 13: (1 comment) Patchset: PS13: > a few BSC_Tests. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30252?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic4728b3efe843ea63e2a0b54b1ea8a925347484a Gerrit-Change-Number: 30252 Gerrit-PatchSet: 13 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Nov 2023 21:54:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: bsc: tests recovery from BORKEN after release failed

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35098?usp=email ) Change subject: bsc: tests recovery from BORKEN after release failed ...................................................................... Patch Set 1: (1 comment) This change is ready for review. Patchset: PS1: > some tests still fail, seems to be those that use the BORKEN state as part of the test setup on testing again, actually all seems fine. My TC_paging_500req always fails on N=209 fail reason: "Retrans of "000000" happened before Rx initial trans for all reqs. rx_paging_num=209" but same with current master. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35098?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b4ddfc4a337808d9d5ec538c25fd390b1b2530f Gerrit-Change-Number: 35098 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 22 Nov 2023 21:53:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: fixup for osmo-hnbgw-with-pfcp.cfg

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35099?usp=email ) Change subject: hnbgw: fixup for osmo-hnbgw-with-pfcp.cfg ...................................................................... hnbgw: fixup for osmo-hnbgw-with-pfcp.cfg Drop a config line that should not be committed; it was added during local testing of logging patches that are still unmerged. Change-Id: Ie29c0e0d80c9318c104fe884868a30c17b6997bb --- M hnbgw/osmo-hnbgw-with-pfcp.cfg 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: neels: Looks good to me, approved Jenkins Builder: Verified diff --git a/hnbgw/osmo-hnbgw-with-pfcp.cfg b/hnbgw/osmo-hnbgw-with-pfcp.cfg index 6407e41..ffe5e09 100644 --- a/hnbgw/osmo-hnbgw-with-pfcp.cfg +++ b/hnbgw/osmo-hnbgw-with-pfcp.cfg @@ -20,7 +20,6 @@ logging level lpfcp info logging level lsua notice logging level lsccp notice - logging print timestamp date ! line vty no login -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie29c0e0d80c9318c104fe884868a30c17b6997bb Gerrit-Change-Number: 35099 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: fixup for osmo-hnbgw-with-pfcp.cfg

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35099?usp=email ) Change subject: hnbgw: fixup for osmo-hnbgw-with-pfcp.cfg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie29c0e0d80c9318c104fe884868a30c17b6997bb Gerrit-Change-Number: 35099 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 22 Nov 2023 21:48:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: fixup for osmo-hnbgw-with-pfcp.cfg

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35099?usp=email ) Change subject: hnbgw: fixup for osmo-hnbgw-with-pfcp.cfg ...................................................................... hnbgw: fixup for osmo-hnbgw-with-pfcp.cfg Drop a config line that should not be committed; it was added during local testing of logging patches that are still unmerged. Change-Id: Ie29c0e0d80c9318c104fe884868a30c17b6997bb --- M hnbgw/osmo-hnbgw-with-pfcp.cfg 1 file changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/35099/1 diff --git a/hnbgw/osmo-hnbgw-with-pfcp.cfg b/hnbgw/osmo-hnbgw-with-pfcp.cfg index 6407e41..ffe5e09 100644 --- a/hnbgw/osmo-hnbgw-with-pfcp.cfg +++ b/hnbgw/osmo-hnbgw-with-pfcp.cfg @@ -20,7 +20,6 @@ logging level lpfcp info logging level lsua notice logging level lsccp notice - logging print timestamp date ! line vty no login -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie29c0e0d80c9318c104fe884868a30c17b6997bb Gerrit-Change-Number: 35099 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: bsc: tests recovery from BORKEN after release failed

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35098?usp=email ) Change subject: bsc: tests recovery from BORKEN after release failed ...................................................................... bsc: tests recovery from BORKEN after release failed Related: osmo-bsc Ic4728b3efe843ea63e2a0b54b1ea8a925347484a Related: SYS#6655 Change-Id: I9b4ddfc4a337808d9d5ec538c25fd390b1b2530f --- M bsc/BSC_Tests.ttcn 1 file changed, 139 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/35098/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 57b44e0..1fc42ba 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -8529,7 +8529,8 @@ } friend function f_perform_clear(RSL_DCHAN_PT rsl_pt := RSL, RSLEM_PROC_PT rsl_proc_pt := RSL_PROC, - template PDU_ML3_NW_MS exp_rr_rel_tmpl := tr_RRM_RR_RELEASE) + template PDU_ML3_NW_MS exp_rr_rel_tmpl := tr_RRM_RR_RELEASE, + boolean send_rel_ack := true) runs on MSC_ConnHdlr { var default ack_dlcx := activate(as_mgcp_ack_all_dlcx()); var default ack_rel_req := activate(as_rsl_ack_all_rel_req()); @@ -8549,8 +8550,10 @@ } [] rsl_pt.receive(tr_RSL_RF_CHAN_REL(g_chan_nr)) { f_logp(BSCVTY, "Got RSL RF Chan Rel, sending Rel Ack"); - rsl_pt.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr)); - f_rslem_unregister(0, g_chan_nr, PT := rsl_proc_pt); + if (send_rel_ack) { + rsl_pt.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr)); + f_rslem_unregister(0, g_chan_nr, PT := rsl_proc_pt); + } } } deactivate(ack_dlcx); @@ -12439,6 +12442,125 @@ f_shutdown_helper(ho := true); } +private function f_vty_expect_borken(TELNETasp_PT pt, boolean expect_borken) +{ + var charstring lchan_summary; + lchan_summary := f_vty_transceive_ret(pt, "show lchan summary"); + var boolean found_borken := (f_strstr(lchan_summary, "State BORKEN") >= 0); + if (found_borken != expect_borken) { + if (expect_borken) { + setverdict(fail, "Expected 'BORKEN' state in ", lchan_summary); + } else { + setverdict(fail, "Expected no 'BORKEN' state in ", lchan_summary); + } + mtc.stop; + } +} + +private function f_tc_unbreak_lchan_after_missing_rel_ack(integer test_variant) runs on MSC_ConnHdlr { + + /* Establish a channel, so we can mess with the release of it. */ + var template PDU_BSSAP exp_compl := f_gen_exp_compl(); + var PDU_BSSAP ass_cmd := f_gen_ass_req(); + + ass_cmd.pdu.bssmap.assignmentRequest.channelType := valueof(ts_BSSMAP_IE_ChannelType); + ass_cmd.pdu.bssmap.assignmentRequest.codecList := valueof(ts_BSSMAP_IE_CodecList({ts_CodecFR})); + + f_establish_fully(ass_cmd, exp_compl); + + /* shorten X28, the time after which a BORKEN lchan recovers, from 30s to something short */ + f_vty_enter_cfg_network(BSCVTY); + f_vty_transceive(BSCVTY, "timer X28 3"); + f_vty_transceive(BSCVTY, "end"); + + /* Allow us to include handling of Channel Activation in this component, to test recovery from BORKEN */ + f_rslem_set_auto_chan_act_ack(RSL_PROC, false); + + /* give a moment before releasing */ + f_sleep(2.0); + + /* Perform a channel release, but omit the RF CHAN REL ACK. The aim is to get the lchan to go BORKEN. */ + f_perform_clear(send_rel_ack := false); + + f_vty_expect_borken(BSCVTY, false); + + /* After a timeout of X6, the lchan ends up in LCHAN_ST_BORKEN */ + f_sleep(6.0); + + f_vty_expect_borken(BSCVTY, true); + + /* Now within two seconds, we expect OsmoBSC to attempt recovering from the broken state. + * + * test_variant == 1: + * It will first attempt a Channel Activation. If the BTS accepts that, it means the state is back in sync. + * Then OsmoBSC releases the lchan again and makes it available for use. + * + * test_variant == 2: + * It will first attempt a Channel Activation and the BTS NACKs that. + * It will then attempt a release, which we ACK, and the channel will be available again. + */ + + /* Receive the Channel Activation */ + var ASP_RSL_Unitdata rx_rsl_ud; + RSL.receive(tr_ASP_RSL_UD(tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV), sid := ?)) -> value rx_rsl_ud; + + var RslChannelNr chan_nr; + var RSL_IE_Body ie; + if (f_rsl_find_ie(rx_rsl_ud.rsl, RSL_IE_CHAN_NR, ie) == true) { + chan_nr := ie.chan_nr; + } else { + setverdict(fail, "Unable to find RSL_IE_CHAN_NR in ", rx_rsl_ud); + return; + } + + if (test_variant == 1) { + RSL.send(ts_ASP_RSL_UD(ts_RSL_CHAN_ACT_ACK(chan_nr, 23), rx_rsl_ud.streamId)); + + /* Back in sync, receive the Channel Release */ + RSL.receive(tr_RSL_RF_CHAN_REL(chan_nr)); + RSL.send(ts_RSL_RF_CHAN_REL_ACK(chan_nr)); + } else if (test_variant == 2) { + RSL.send(ts_ASP_RSL_UD(ts_RSL_CHAN_ACT_NACK(chan_nr, RSL_ERR_EQUIPMENT_FAIL), rx_rsl_ud.streamId)); + + /* Instead tries a release */ + RSL.receive(tr_RSL_RF_CHAN_REL(chan_nr)); + RSL.send(ts_RSL_RF_CHAN_REL_ACK(chan_nr)); + /* That worked, channel usable again */ + } else { + setverdict(fail, "undefined test_variant ", test_variant); + } + + f_vty_expect_borken(BSCVTY, false); + setverdict(pass); +} + +/* Test recovery path from a BORKEN lchan */ +private function f_TC_unbreak_lchan_after_missing_rel_ack_1(charstring id) runs on MSC_ConnHdlr { + f_tc_unbreak_lchan_after_missing_rel_ack(test_variant := 1); +} +testcase TC_unbreak_lchan_after_missing_rel_ack_1() runs on test_CT { + var TestHdlrParams pars := f_gen_test_hdlr_pars(); + var MSC_ConnHdlr vc_conn; + f_init(1, true); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_TC_unbreak_lchan_after_missing_rel_ack_1), pars); + vc_conn.done; + f_shutdown_helper(); +} + +private function f_TC_unbreak_lchan_after_missing_rel_ack_2(charstring id) runs on MSC_ConnHdlr { + f_tc_unbreak_lchan_after_missing_rel_ack(test_variant := 2); +} +testcase TC_unbreak_lchan_after_missing_rel_ack_2() runs on test_CT { + var TestHdlrParams pars := f_gen_test_hdlr_pars(); + var MSC_ConnHdlr vc_conn; + f_init(1, true); + f_sleep(1.0); + vc_conn := f_start_handler(refers(f_TC_unbreak_lchan_after_missing_rel_ack_2), pars); + vc_conn.done; + f_shutdown_helper(); +} + control { /* CTRL interface testing */ execute( TC_ctrl_msc_connection_status() ); @@ -12792,6 +12914,9 @@ /* Run TC_ho_out_of_this_bsc last, because it may trigger a segfault before osmo-bsc's patch * with change-id I5a3345ab0005a73597f5c27207480912a2f5aae6 */ execute( TC_ho_out_of_this_bsc() ); + + execute( TC_unbreak_lchan_after_missing_rel_ack_1() ); + execute( TC_unbreak_lchan_after_missing_rel_ack_2() ); } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35098?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9b4ddfc4a337808d9d5ec538c25fd390b1b2530f Gerrit-Change-Number: 35098 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 7 months

1
0
0 0

[M] Change in libosmocore[master]: osmo_io: Factor out and use common send function from backend

by lynxis lazus

Attention is currently required from: daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35078?usp=email ) Change subject: osmo_io: Factor out and use common send function from backend ...................................................................... Patch Set 1: (1 comment) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/35078/comment/8cbca25d_4e44408c PS1, Line 188: iofd_msghdr_free(msghdr); > I don't understand? Are you saying that the -EAGAIN case was previously missed (only checking for < […] Yes, previous you didn't checked for -EAGAIN, now you're checking it and doing things based on it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6da2653d32aedd0e7872be0cf90a841b56462e59 Gerrit-Change-Number: 35078 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Wed, 22 Nov 2023 19:06:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

1 year, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2023