November 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-pcu[master]: TBF status: Fix VTY output text
by keith 12 Nov '23

12 Nov '23

keith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email ) Change subject: TBF status: Fix VTY output text ...................................................................... TBF status: Fix VTY output text The vty command 'show bts pdch' had the UL and DL TBF count reversed. The patch corrects this. Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7 --- M src/pcu_vty_functions.cpp 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/03/35003/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7 Gerrit-Change-Number: 35003 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-pcu[master]: Fix VTY output txt
by keith 12 Nov '23

12 Nov '23

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email ) Change subject: Fix VTY output txt ...................................................................... Fix VTY output txt The vty command 'show bts pdch' had the UL and DL TBF count reversed. Patch corrects this. Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7 --- M src/pcu_vty_functions.cpp 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/03/35003/1 diff --git a/src/pcu_vty_functions.cpp b/src/pcu_vty_functions.cpp index 8dd147c..09a1d77 100644 --- a/src/pcu_vty_functions.cpp +++ b/src/pcu_vty_functions.cpp @@ -289,7 +289,7 @@ for (ts_nr = 0; ts_nr < ARRAY_SIZE(trx->pdch); ts_nr++) { const struct gprs_rlcmac_pdch *pdch = &trx->pdch[ts_nr]; - vty_out(vty, " TS%u: PDCH %s, %u UL TBFs, %u DL TBFs%s", pdch->ts_no, + vty_out(vty, " TS%u: PDCH %s, %u DL TBFs, %u UL TBFs%s", pdch->ts_no, pdch->is_enabled() ? "enabled" : "disabled", pdch->num_tbfs(GPRS_RLCMAC_DL_TBF), pdch->num_tbfs(GPRS_RLCMAC_UL_TBF), VTY_NEWLINE); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic906ca9d02811cb96e4530af43fbc3769f6afce7 Gerrit-Change-Number: 35003 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: add config option diameter_connect_timer
by lynxis lazus 11 Nov '23

11 Nov '23

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35002?usp=email ) Change subject: osmo_dia2gsup: add config option diameter_connect_timer ...................................................................... osmo_dia2gsup: add config option diameter_connect_timer The diameter_connect_timer can be set to reduce the ttcn3 timing. Otherwise every test case would need to wait for at least one connect timer period to succeed. Related: OS#5657 Change-Id: I669a76022d866824e7b4e9f30dd7e51aa714ae7d --- M src/osmo_dia2gsup.erl 1 file changed, 20 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/02/35002/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index 90f5ddc..5a817fd 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -70,10 +70,12 @@ % DIAMETER side SvcName = ?MODULE, diameter:start_service(SvcName, ?SERVICE(SvcName)), + Ip = application:get_env(osmo_dia2gsup, diameter_ip, "127.0.0.8"), Port = application:get_env(osmo_dia2gsup, diameter_port, 3868), Proto = application:get_env(osmo_dia2gsup, diameter_proto, sctp), - listen({address, Proto, element(2,inet:parse_address(Ip)), Port}), + ConnectTimer = application:get_env(osmo_dia2gsup, diameter_connect_timer, 30000), + listen(?SVC_NAME, {address, Proto, element(2,inet:parse_address(Ip)), Port}, {timer, ConnectTimer}), lager:info("Diameter HSS Application started on IP ~s, ~p port ~p~n", [Ip, Proto, Port]), {ok, State}. @@ -114,14 +116,12 @@ %% Internal Function Definitions %% ------------------------------------------------------------------ -listen(Name, {address, Protocol, IPAddr, Port}) -> +listen(Name, {address, Protocol, IPAddr, Port}, {timer, ConnectTimer}) -> TransOpts = [{transport_module, tmod(Protocol)}, {transport_config, [{reuseaddr, true}, - {ip, IPAddr}, {port, Port}]}], + {ip, IPAddr}, {port, Port}]}, + {connect_timer, ConnectTimer}], {ok, _} = diameter:add_transport(Name, {listen, TransOpts}). -listen(Address) -> - listen(?SVC_NAME, Address). - tmod(tcp) -> diameter_tcp; tmod(sctp) -> diameter_sctp. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I669a76022d866824e7b4e9f30dd7e51aa714ae7d Gerrit-Change-Number: 35002 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo_dia2gsup[master]: osmo_dia2gsup: set Origin-State-Id
by lynxis lazus 11 Nov '23

11 Nov '23

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35001?usp=email ) Change subject: osmo_dia2gsup: set Origin-State-Id ...................................................................... osmo_dia2gsup: set Origin-State-Id To allow the remote side to detect restarts. See RFC6733. Related: OS#6155 Change-Id: I3693bad6030d41db4e28bd5f343c5db912789344 --- M src/osmo_dia2gsup.erl 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/01/35001/1 diff --git a/src/osmo_dia2gsup.erl b/src/osmo_dia2gsup.erl index a4edd71..90f5ddc 100644 --- a/src/osmo_dia2gsup.erl +++ b/src/osmo_dia2gsup.erl @@ -31,6 +31,7 @@ -define(SERVICE(Name), [{'Origin-Host', application:get_env(osmo_dia2gsup, origin_host, "hss.localdomain")}, {'Origin-Realm', application:get_env(osmo_dia2gsup, origin_realm, "localdomain")}, {'Vendor-Id', application:get_env(osmo_dia2gsup, vendor_id, 0)}, + {'Origin-State-Id', diameter:origin_state_id()}, {'Product-Name', "osmo_dia2gsup"}, {'Auth-Application-Id', []}, {'Vendor-Specific-Application-Id', [?APPID_S6]}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/35001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3693bad6030d41db4e28bd5f343c5db912789344 Gerrit-Change-Number: 35001 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[L] Change in osmo-bsc[master]: Introduce per-BTS timers, RLC timer commands
by arehbein 11 Nov '23

11 Nov '23

Attention is currently required from: pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email ) Change subject: Introduce per-BTS timers, RLC timer commands ...................................................................... Patch Set 12: (2 comments) This change is ready for review. File src/osmo-bsc/bsc_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/f585d0ed_a267887c PS3, Line 241: bts->timer_groups[OSMO_BSC_BTS_TDEF_GROUPS_RLC].tdefs = bts->gprs.cell.rlc_cfg.timers; > Hm yeah didn't think of that, I'll remove the timers from the `rlc_cfg` struct. Done File tests/nanobts_omlattr/nanobts_omlattr_test.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/37f64bbc_70226341 PS2, Line 228: 0x02, 0x00, 0x02, 0xa3, 0x00, 0x09, > to me they already are aligned (the timer names and the respective values below). […] I have aligned all columns vertically -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2c24110d8c977d6cc74c3c8e77bcc709ad9d2675 Gerrit-Change-Number: 31878 Gerrit-PatchSet: 12 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 11 Nov 2023 18:13:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in docker-playground[master]: ttcn3-dia2gsup-test/osmo_dia2gsup: set connect timer to 200 ms
by lynxis lazus 11 Nov '23

11 Nov '23

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35000?usp=email ) Change subject: ttcn3-dia2gsup-test/osmo_dia2gsup: set connect timer to 200 ms ...................................................................... ttcn3-dia2gsup-test/osmo_dia2gsup: set connect timer to 200 ms Related: OS#5657 Change-Id: I22839cdf76120bb6152b32059822001cbd7979d8 --- M ttcn3-dia2gsup-test/osmo_dia2gsup.config 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/00/35000/1 diff --git a/ttcn3-dia2gsup-test/osmo_dia2gsup.config b/ttcn3-dia2gsup-test/osmo_dia2gsup.config index dc0b876..4403935 100644 --- a/ttcn3-dia2gsup-test/osmo_dia2gsup.config +++ b/ttcn3-dia2gsup-test/osmo_dia2gsup.config @@ -5,6 +5,7 @@ {diameter_ip, "172.18.10.20"}, {diameter_port, 3868}, {diameter_proto, sctp}, + {diameter_connect_timer, 200}, {origin_host, "hss.localdomain"}, {origin_realm, "localdomain"}, -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I22839cdf76120bb6152b32059822001cbd7979d8 Gerrit-Change-Number: 35000 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: dia2gsup: sleep(1) to forget diameter state
by lynxis lazus 11 Nov '23

11 Nov '23

lynxis lazus has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34999?usp=email ) Change subject: dia2gsup: sleep(1) to forget diameter state ...................................................................... dia2gsup: sleep(1) to forget diameter state Sleep to allow the remote to forget the connection (see diameter connect timer). Related: OS#5657 Change-Id: Ib909eff5c381c6271b9d16e383bed3e78ca454da --- M dia2gsup/DIA2GSUP_Tests.ttcn 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/34999/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib909eff5c381c6271b9d16e383bed3e78ca454da Gerrit-Change-Number: 34999 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ttcn3-hacks[master]: dia2gsup: sleep(1) to forget diameter state
by lynxis lazus 11 Nov '23

11 Nov '23

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34999?usp=email ) Change subject: dia2gsup: sleep(1) to forget diameter state ...................................................................... dia2gsup: sleep(1) to forget diameter state Sleep to allow the remote to forget the connection (see diameter connect timer). Change-Id: Ib909eff5c381c6271b9d16e383bed3e78ca454da --- M dia2gsup/DIA2GSUP_Tests.ttcn 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/99/34999/1 diff --git a/dia2gsup/DIA2GSUP_Tests.ttcn b/dia2gsup/DIA2GSUP_Tests.ttcn index 673038c..e12f17b 100644 --- a/dia2gsup/DIA2GSUP_Tests.ttcn +++ b/dia2gsup/DIA2GSUP_Tests.ttcn @@ -159,6 +159,8 @@ g_Tguard.start(t_guard); activate(as_Tguard()); + /* Sleep to allow the remote to forget the connection (see diameter connect timer). */ + f_sleep(1.0); f_init_gsup(testcasename()); f_init_diameter(testcasename()); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib909eff5c381c6271b9d16e383bed3e78ca454da Gerrit-Change-Number: 34999 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

1 0

[M] Change in ...osmo_dia2gsup[master]: gsup: implement a (re-)connect the GSUP link if it fails
by laforge 11 Nov '23

11 Nov '23

Attention is currently required from: daniel, fixeria, lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email ) Change subject: gsup: implement a (re-)connect the GSUP link if it fails ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34285?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Id531d202ded123786d7a41dd0d7c3695af59fc2d Gerrit-Change-Number: 34285 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 11 Nov 2023 13:03:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: client: replace two assertions with graceful error handling
by fixeria 10 Nov '23

10 Nov '23

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34997?usp=email ) Change subject: client: replace two assertions with graceful error handling ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia5d8a9aff565399a85a5b116d7029fedcab234e0 Gerrit-Change-Number: 34997 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 Nov 2023 13:48:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0