Attention is currently required from: dexter, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34869?usp=email )
Change subject: running: fix link to MNCC for External Call Control
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-msc/+/34869/comment/42055048_4edf411d
PS1, Line 11: outdated
Not sure what you mean by "outdated" here. Label `mncc` points to the MNCC chapter, explaining what MNCC is all about. Label `mncc-external` explains the aspects of using an external MNCC handler. I see no problem here. Maybe the chapter name is confusing?
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34869?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I5b0fd848e6b28bf670d9994da8a56cb613158290
Gerrit-Change-Number: 34869
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Oct 2023 16:08:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: dexter, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email )
Change subject: manuals: add section about the SGs interface.
......................................................................
Patch Set 1:
(3 comments)
File doc/manuals/chapters/sgs.adoc:
https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/f66de8d8_e1f96e55
PS1, Line 4: SGs/SGsAP
The interface is called SGs. The application layer protocol for it is SGsAP. SO if you want to mention both and stay correct, you'd have to phrase it like "offers a SGs interface using the SGsAP protocol" or the like.
https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/4794f557_2275e5d8
PS1, Line 5: LTE/EPC
you used "2G (GERAN)" before, then here it would make sense to use the same format e.g. "4G (EUTRAN)" or if needed "4G (EUTRAN/LTE)"
https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/861d2b51_9da779e3
PS1, Line 44: In case multiple instances of OsmoMSC run in parallel, it is advised to use a
: different vlr-name for each instance
you might want to add that they of course need to be bound to different IP addresses. btw: the vlr-name is usually the DNS name for the IP address of that VLR/MSC, so they should agree.
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic7c17511ee19cb7f6d5069b27beb661ecb4b0be8
Gerrit-Change-Number: 34870
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Oct 2023 16:07:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/34871?usp=email )
Change subject: vlr_sgs: fix VTY setting for SGs counter.
......................................................................
vlr_sgs: fix VTY setting for SGs counter.
When trying to modify the value of an SGs counter (eg. ns11), then the
setting is nevers stored. The reason for this is that OsmoMSC uses the
wrong string table to compare the user input.
Related: OS#6008
Change-Id: I0358c1ec0026c37fda6db1f3af3145393df25cfd
---
M include/osmocom/msc/vlr_sgs.h
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/71/34871/1
diff --git a/include/osmocom/msc/vlr_sgs.h b/include/osmocom/msc/vlr_sgs.h
index 7231449..aade5d3 100644
--- a/include/osmocom/msc/vlr_sgs.h
+++ b/include/osmocom/msc/vlr_sgs.h
@@ -69,7 +69,7 @@
extern const struct value_string sgs_state_counter_names[];
static inline const char *vlr_sgs_state_counter_name(enum vlr_sgs_state_ctr Ns)
{
- return get_value_string(sgs_state_timer_names, Ns);
+ return get_value_string(sgs_state_counter_names, Ns);
}
/* This callback function is called when an SGs location update is complete */
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34871?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I0358c1ec0026c37fda6db1f3af3145393df25cfd
Gerrit-Change-Number: 34871
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/34869?usp=email )
Change subject: running: fix link to MNCC for External Call Control
......................................................................
running: fix link to MNCC for External Call Control
The label of the section 18 "MNCC for External Call Control" is
reachable under the label <<mncc>> and not under <<mncc-external>>,
which seems to be outdated.
Change-Id: I5b0fd848e6b28bf670d9994da8a56cb613158290
---
M doc/manuals/chapters/running.adoc
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/69/34869/1
diff --git a/doc/manuals/chapters/running.adoc b/doc/manuals/chapters/running.adoc
index d6e734b..0db5761 100644
--- a/doc/manuals/chapters/running.adoc
+++ b/doc/manuals/chapters/running.adoc
@@ -72,7 +72,7 @@
mncc external /tmp/mncc_socket
----
-More on MNCC in <<mncc-external>>.
+More on MNCC in <<mncc>>.
The SGs interface by default listens on 0.0.0.0:29118. Configure a different IP and/or port for each osmo-msc instance.
You may also want to configure different VLR names:
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34869?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I5b0fd848e6b28bf670d9994da8a56cb613158290
Gerrit-Change-Number: 34869
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: newchange