October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: scripts/tarballs: gapk > v1.0: use make dist-bzip2
by osmith 26 Oct '23

26 Oct '23

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email ) Change subject: scripts/tarballs: gapk > v1.0: use make dist-bzip2 ...................................................................... scripts/tarballs: gapk > v1.0: use make dist-bzip2 Use autotools logic to build tarballs for gapk above version v1.0. Related: OS#6227 Change-Id: If9a04b458553e311cf8b891b204244db2b1ae2d8 --- M scripts/tarballs/prefer-configure.sh 1 file changed, 28 insertions(+), 7 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/tarballs/prefer-configure.sh b/scripts/tarballs/prefer-configure.sh index f9f8613..295b239 100755 --- a/scripts/tarballs/prefer-configure.sh +++ b/scripts/tarballs/prefer-configure.sh @@ -11,13 +11,22 @@ case "$PROJECT" in gapk) - # Running gapk's configure involves running libgsmhr/fetch_sources.py, - # which according to git log doesn't really work unless using the - # version from master and it looks like we don't want to distribute - # these sources directly... or else we should just add them to the git - # repository and not rely on downloading a remote archive that may just - # change at any time. So create a simple git archive instead. - exit 1 + case "$TAG" in + v0.*|v1.0) + # Running gapk's configure involves running libgsmhr/fetch_sources.py, + # which according to git log doesn't really work unless using the + # version from master and it looks like we don't want to distribute + # these sources directly... or else we should just add them to the git + # repository and not rely on downloading a remote archive that may just + # change at any time. So create a simple git archive instead. + exit 1 + ;; + *) + # Fixed above v1.0 + # https://gerrit.osmocom.org/c/gapk/+/34892/1 + exit 0 + ;; + esac ;; *) exit 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If9a04b458553e311cf8b891b204244db2b1ae2d8 Gerrit-Change-Number: 34901 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ci[master]: scripts/tarballs: gapk > v1.0: use make dist-bzip2
by fixeria 26 Oct '23

26 Oct '23

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email ) Change subject: scripts/tarballs: gapk > v1.0: use make dist-bzip2 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If9a04b458553e311cf8b891b204244db2b1ae2d8 Gerrit-Change-Number: 34901 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Oct 2023 09:17:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: scripts/tarballs: gapk > v1.0: use make dist-bzip2
by osmith 26 Oct '23

26 Oct '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email ) Change subject: scripts/tarballs: gapk > v1.0: use make dist-bzip2 ...................................................................... scripts/tarballs: gapk > v1.0: use make dist-bzip2 Use autotools logic to build tarballs for gapk above version v1.0. Related: OS#6227 Change-Id: If9a04b458553e311cf8b891b204244db2b1ae2d8 --- M scripts/tarballs/prefer-configure.sh 1 file changed, 28 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/01/34901/1 diff --git a/scripts/tarballs/prefer-configure.sh b/scripts/tarballs/prefer-configure.sh index f9f8613..295b239 100755 --- a/scripts/tarballs/prefer-configure.sh +++ b/scripts/tarballs/prefer-configure.sh @@ -11,13 +11,22 @@ case "$PROJECT" in gapk) - # Running gapk's configure involves running libgsmhr/fetch_sources.py, - # which according to git log doesn't really work unless using the - # version from master and it looks like we don't want to distribute - # these sources directly... or else we should just add them to the git - # repository and not rely on downloading a remote archive that may just - # change at any time. So create a simple git archive instead. - exit 1 + case "$TAG" in + v0.*|v1.0) + # Running gapk's configure involves running libgsmhr/fetch_sources.py, + # which according to git log doesn't really work unless using the + # version from master and it looks like we don't want to distribute + # these sources directly... or else we should just add them to the git + # repository and not rely on downloading a remote archive that may just + # change at any time. So create a simple git archive instead. + exit 1 + ;; + *) + # Fixed above v1.0 + # https://gerrit.osmocom.org/c/gapk/+/34892/1 + exit 0 + ;; + esac ;; *) exit 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34901?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If9a04b458553e311cf8b891b204244db2b1ae2d8 Gerrit-Change-Number: 34901 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[M] Change in osmo-ttcn3-hacks[master]: epdg: Test Handover from Wifi back to LTE
by osmith 26 Oct '23

26 Oct '23

Attention is currently required from: fixeria, lynxis lazus, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895?usp=email ) Change subject: epdg: Test Handover from Wifi back to LTE ...................................................................... Patch Set 1: (3 comments) File epdg/EPDG_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895/comment/99921568_69f4… PS1, Line 451: setverdict(pass); you explicitly mention cause="Access changed from non-3gpp to 3gpp" below. maybe check the cause here? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895/comment/1b31a2ea_a10b… PS1, Line 459: /* f_gtp2_register_udmsg('63'O); TODO: is this needed? */ do you want to keep this? (if the test works without it, I guess it is not needed?) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895/comment/842fee6b_9852… PS1, Line 533: Brearer Bearer -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I299faf28fa51dbc5d2de6c72a39a01eca67a5775 Gerrit-Change-Number: 34895 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 26 Oct 2023 08:52:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in pysim[master]: runtime: fix tracking of selected_adf
by fixeria 26 Oct '23

26 Oct '23

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34897?usp=email ) Change subject: runtime: fix tracking of selected_adf ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4cc0c58ff887422b4f3954d35c8380ddc00baa1d Gerrit-Change-Number: 34897 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Oct 2023 08:13:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp
by neels 26 Oct '23

26 Oct '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email ) Change subject: add fmtp string to ptmap: allow all possible fmtp ...................................................................... Patch Set 1: (1 comment) This change is ready for review. Patchset: PS1: ttcn3 tests still fail, @pmaier@sysmocom.de would be great if you could take a look..? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If58590bda8627519ff07e0b6f43aa47a274f052b Gerrit-Change-Number: 34900 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Oct 2023 01:56:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-mgw[master]: mgcp_client_fsm: fix inconsistent API (param_present, param).
by neels 26 Oct '23

26 Oct '23

Attention is currently required from: dexter, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34351?usp=email ) Change subject: mgcp_client_fsm: fix inconsistent API (param_present, param). ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: to put money where my mouth is, i actually implemented my suggestions in alternative patch https://gerrit.osmocom.org/c/osmo-mgw/+/34900 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34351?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I50d737f3f3d45e4004c64101700a471fe75b3436 Gerrit-Change-Number: 34351 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 26 Oct 2023 01:55:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp
by neels 26 Oct '23

26 Oct '23

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email ) Change subject: add fmtp string to ptmap: allow all possible fmtp ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: context: this patch replaces https://gerrit.osmocom.org/c/osmo-mgw/+/34351 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If58590bda8627519ff07e0b6f43aa47a274f052b Gerrit-Change-Number: 34900 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 26 Oct 2023 01:54:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp
by Jenkins Builder 26 Oct '23

26 Oct '23

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email ) Change subject: add fmtp string to ptmap: allow all possible fmtp ...................................................................... Patch Set 1: (1 comment) File include/osmocom/mgcp_client/mgcp_client.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12114): https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/eb876c85_e3480476 PS1, Line 84: const char *fmtp; Statements should start on a tabstop -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If58590bda8627519ff07e0b6f43aa47a274f052b Gerrit-Change-Number: 34900 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 26 Oct 2023 01:50:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-mgw[master]: mgcp_client_fsm: explain member param in struct mgcp_conn_peer better
by neels 26 Oct '23

26 Oct '23

Attention is currently required from: dexter. neels has uploaded a new patch set (#5) to the change originally created by dexter. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34350?usp=email ) The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: mgcp_client_fsm: explain member param in struct mgcp_conn_peer better ...................................................................... mgcp_client_fsm: explain member param in struct mgcp_conn_peer better The struct member param specifies additional codec parameters. Let's improve its explaination. Change-Id: Iea4dc1e72fccaa464ce503fae88b5d8a867b1d19 Related: OS#6171 --- M include/osmocom/mgcp_client/mgcp_client_fsm.h 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/50/34350/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34350?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iea4dc1e72fccaa464ce503fae88b5d8a867b1d19 Gerrit-Change-Number: 34350 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0