October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-ci[master]: obs: build_binpkg: no network during build
by pespin 06 Oct '23

06 Oct '23

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34676?usp=email ) Change subject: obs: build_binpkg: no network during build ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: isn't there some way to do that when launching the docker container instead of doing it from within the container? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I00282552e9988d66fdc269c6230f0e1432ace360 Gerrit-Change-Number: 34676 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Oct 2023 12:32:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: debian/rules: extract build_dep.tar.gz first
by osmith 06 Oct '23

06 Oct '23

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34675?usp=email ) Change subject: debian/rules: extract build_dep.tar.gz first ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @osmith@sysmocom.de this probably needs to be applied to osmo_dia2gsup. […] -> https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34677 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34675?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I2bb0b5f608cd5d9a24c2a367425c524447bd002c Gerrit-Change-Number: 34675 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Oct 2023 12:31:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in ...osmo_dia2gsup[master]: debian/rules: extract build_dep.tar.gz first
by osmith 06 Oct '23

06 Oct '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34677?usp=email ) Change subject: debian/rules: extract build_dep.tar.gz first ...................................................................... debian/rules: extract build_dep.tar.gz first Currently dh_auto_build is a no-op, but move extracting depends up in case we add a Makefile here too. Related: osmo-epdg I2bb0b5f608cd5d9a24c2a367425c524447bd002c Change-Id: Ib64671a8b4629dde1e21b18a6405f7ae7d87a46f --- M debian/rules 1 file changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/77/34677/1 diff --git a/debian/rules b/debian/rules index 89863f8..69e31ed 100755 --- a/debian/rules +++ b/debian/rules @@ -8,8 +8,8 @@ dh $@ override_dh_auto_build: - dh_auto_build if [ -e build_dep.tar.gz ] ; then tar xzf ./build_dep.tar.gz ; fi + dh_auto_build rebar3 compile rebar3 escriptize rebar3 eunit -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34677?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: Ib64671a8b4629dde1e21b18a6405f7ae7d87a46f Gerrit-Change-Number: 34677 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in ...osmo-epdg[master]: debian/source/format: new file
by pespin 06 Oct '23

06 Oct '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34674?usp=email ) Change subject: debian/source/format: new file ...................................................................... debian/source/format: new file Fix for: dpkg-source: warning: no source format specified in debian/source/format, see dpkg-source(1) dpkg-source: info: using source format '1.0' Change-Id: I8a1e5c76a5d302643311882c09ef49f4d3c5f5cd --- A debian/source/format 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/debian/source/format b/debian/source/format new file mode 100644 index 0000000..89ae9db --- /dev/null +++ b/debian/source/format @@ -0,0 +1 @@ +3.0 (native) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I8a1e5c76a5d302643311882c09ef49f4d3c5f5cd Gerrit-Change-Number: 34674 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: debian/rules: extract build_dep.tar.gz first
by pespin 06 Oct '23

06 Oct '23

pespin has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34675?usp=email ) Change subject: debian/rules: extract build_dep.tar.gz first ...................................................................... debian/rules: extract build_dep.tar.gz first dh_auto_build runs the default target of the Makefile in the top directory. Extract the build deps before running it, to avoid downloading the build dependencies again (which fails in OBS as we build without network there). Remove the redundant "rebar3 compile" and "rebare3 escriptize" commands, which are part of the default target in the Makefile. debian/rules was copied from osmo_dia2gsup, but there it works as-is because osmo_dia2gsup has no Makefile (-> dh_auto_build is a no-op). Change-Id: I2bb0b5f608cd5d9a24c2a367425c524447bd002c --- M debian/rules 1 file changed, 20 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian/rules b/debian/rules index 89863f8..72a2bb6 100755 --- a/debian/rules +++ b/debian/rules @@ -8,10 +8,8 @@ dh $@ override_dh_auto_build: - dh_auto_build if [ -e build_dep.tar.gz ] ; then tar xzf ./build_dep.tar.gz ; fi - rebar3 compile - rebar3 escriptize + dh_auto_build rebar3 eunit override_dh_clean: -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34675?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I2bb0b5f608cd5d9a24c2a367425c524447bd002c Gerrit-Change-Number: 34675 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in ...osmo-epdg[master]: debian/rules: extract build_dep.tar.gz first
by pespin 06 Oct '23

06 Oct '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34675?usp=email ) Change subject: debian/rules: extract build_dep.tar.gz first ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: @osmith@sysmocom.de this probably needs to be applied to osmo_dia2gsup.git -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34675?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I2bb0b5f608cd5d9a24c2a367425c524447bd002c Gerrit-Change-Number: 34675 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Oct 2023 12:19:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in ...osmo-epdg[master]: debian/source/format: new file
by pespin 06 Oct '23

06 Oct '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34674?usp=email ) Change subject: debian/source/format: new file ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34674?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I8a1e5c76a5d302643311882c09ef49f4d3c5f5cd Gerrit-Change-Number: 34674 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Oct 2023 12:18:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in osmo-ttcn3-hacks[master]: BTS_Tests: separate generating g_AllChannels[] into a function
by pespin 06 Oct '23

06 Oct '23

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34672?usp=email ) Change subject: BTS_Tests: separate generating g_AllChannels[] into a function ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab2d009b977255b16028c77a9b96df48d270ed1c Gerrit-Change-Number: 34672 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 Oct 2023 12:18:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: obs: build_binpkg: no network during build
by osmith 06 Oct '23

06 Oct '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/34676?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: obs: build_binpkg: no network during build ...................................................................... obs: build_binpkg: no network during build Simulate that we don't have network during package builds in gerrit verifications, like it is the case when the packages will be built by OBS. I've also considered using network namespaces via "unshare -n" or bubblewrap, but it wouldn't be possible to create a loopback device inside the network namespace inside docker (maybe with --privileged, but not worth it) and e.g. the osmo-mgw tests rely on lo. Depends: osmo-epdg I2bb0b5f608cd5d9a24c2a367425c524447bd002c Change-Id: I00282552e9988d66fdc269c6230f0e1432ace360 --- M scripts/obs/build_binpkg.py M scripts/obs/data/build_binpkg.Dockerfile M scripts/obs/data/build_deb.sh M scripts/obs/data/build_rpm.sh 4 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/76/34676/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I00282552e9988d66fdc269c6230f0e1432ace360 Gerrit-Change-Number: 34676 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0

[S] Change in osmo-ci[master]: obs: build_binpkg: no network during build
by osmith 06 Oct '23

06 Oct '23

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/34676?usp=email to look at the new patch set (#2). Change subject: obs: build_binpkg: no network during build ...................................................................... obs: build_binpkg: no network during build Simulate that we don't have network during package builds in gerrit verifications, like it is the case when the packages will be built by OBS. I've also considered using network namespaces via "unshare -n" or bubblewrap, but it wouldn't be possible to create a loopback device inside the network namespace inside docker (maybe with --privileged, but not worth it) and e.g. the osmo-mgw tests rely on lo. Depends: osmo-epdg I2bb0b5f608cd5d9a24c2a367425c524447bd002c Change-Id: I00282552e9988d66fdc269c6230f0e1432ace360 --- M scripts/obs/build_binpkg.py M scripts/obs/data/build_binpkg.Dockerfile M scripts/obs/data/build_deb.sh M scripts/obs/data/build_rpm.sh 4 files changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/76/34676/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34676?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I00282552e9988d66fdc269c6230f0e1432ace360 Gerrit-Change-Number: 34676 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 0