Attention is currently required from: laforge, fixeria.
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30992
to look at the new patch set (#5).
Change subject: layer23: Introduce APN VTY node
......................................................................
layer23: Introduce APN VTY node
Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e
---
M doc/examples/modem/modem.cfg
M src/host/layer23/include/osmocom/bb/common/Makefile.am
A src/host/layer23/include/osmocom/bb/common/apn.h
M src/host/layer23/include/osmocom/bb/common/ms.h
M src/host/layer23/include/osmocom/bb/common/settings.h
M src/host/layer23/include/osmocom/bb/modem/vty.h
M src/host/layer23/src/common/Makefile.am
A src/host/layer23/src/common/apn.c
M src/host/layer23/src/common/ms.c
M src/host/layer23/src/common/settings.c
M src/host/layer23/src/modem/app_modem.c
M src/host/layer23/src/modem/vty.c
12 files changed, 365 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/92/30992/5
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e
Gerrit-Change-Number: 30992
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 )
Change subject: layer23: Introduce APN VTY node
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> lookes more like a WIP patch to me?
It's definetly impossible to submit a full working patch with the entire thing, since there are so many things which are still missing. Since several people are working on different areas I'm simply pushing a set of patches adding the first stones on different places which later con can be extended and glued together.
I'm basically filling holes. Having a way to configure APNs is one those. Other fields will come in the future, but once this is merged it becomes easier to add new stuff for people working on other stuff too.
So yes, don't take these patches as fully working implementations. Some interfaces will change, some implementations will change. But we need to start with something.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e
Gerrit-Change-Number: 30992
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Jan 2023 18:47:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 )
Change subject: layer23: Introduce netdev.{c,h}
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> I'm not sure if we really want to import all that legacy code from osmo-ggsn, which back then suppor […]
We can later on move that to libosmocore or libosmonetif if we want, but for now I'd like to keep it here.
Regarding dropping non-linux stuff, I'm fine dropping it but I'd prefer doing that as a followup patch since in this one I'm mostly importing stuff as much as is as it can be.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22
Gerrit-Change-Number: 30993
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 17 Jan 2023 18:21:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30994 )
Change subject: layer23: Introduce tun.{c,h}
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
I'm not sure if we really want to import all that legacy code from osmo-ggsn, which back then supported a variety of operating systems. At the very least all the untested/unmaintained non-linux stuff should be removed. And all-in-all it might be a candidate for libosmocore?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd
Gerrit-Change-Number: 30994
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Jan 2023 18:18:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 )
Change subject: layer23: Introduce netdev.{c,h}
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
Patchset:
PS4:
I'm not sure if we really want to import all that legacy code from osmo-ggsn, which back then supported a variety of operating systems. At the very least all the untested/unmaintained non-linux stuff should be removed. And all-in-all it might be a candidate for libosmocore?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22
Gerrit-Change-Number: 30993
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Jan 2023 18:18:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 )
Change subject: layer23: Introduce APN VTY node
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
lookes more like a WIP patch to me?
File src/host/layer23/include/osmocom/bb/common/apn.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/06ba8e5f_66c6acd1
PS4, Line 29: struct apn_name {
: struct llist_head list;
: char *name;
: };
this doesn't seem to be used? I also don't understand how it should/might be.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e
Gerrit-Change-Number: 30992
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Jan 2023 18:16:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
