January 2023 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: isdn: Add V.110 encoder/decoder

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30762 ) Change subject: isdn: Add V.110 encoder/decoder ...................................................................... Patch Set 4: (3 comments) File src/isdn/v110.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2898): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/c7124bf4_97a9235c PS4, Line 1: /* V.110 frames according to ITU-T V.110 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2898): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/cff5420e_9f12f768 PS4, Line 82: ra_bits[2*8 +7] = fr->x_bits[0]; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2898): https://gerrit.osmocom.org/c/libosmocore/+/30762/comment/cacca063_55ef2a8c PS4, Line 83: ra_bits[7*8 +7] = fr->x_bits[1]; need consistent spacing around '+' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b5fd3847d3bfb0a0f763e0574893962ec699680 Gerrit-Change-Number: 30762 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 21 Jan 2023 21:47:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: isdndlc: Fix documentation

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30761 ) Change subject: isdndlc: Fix documentation ...................................................................... Patch Set 4: (7 comments) File src/core/isdnhdlc.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/b8beaacc_d30e1154 PS4, Line 100: excluding the CRC. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/81c00346_5f33a401 PS4, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/8afbd40a_586206fe PS4, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. Avoid multiple line dereference - prefer 'CRC.returns' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/548c4ab5_6dc553f0 PS4, Line 104: returns -OSMO_HDLC_FRAMING_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/f329879c_1b951bca PS4, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/1d937146_d501f561 PS4, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. Avoid multiple line dereference - prefer 'OSMO_HDLC_FRAMING_ERROR.If' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2897): https://gerrit.osmocom.org/c/libosmocore/+/30761/comment/3579baef_53469d6a PS4, Line 105: If a CRC error is found the function returns -OSMO_HDLC_CRC_ERROR. need consistent spacing around '-' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30761 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib5def2ae3c79f408f2ee0bb4c20fba1437d30c64 Gerrit-Change-Number: 30761 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 21 Jan 2023 21:47:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: isdn: Add V.110 encoder/decoder

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30762 to look at the new patch set (#4). Change subject: isdn: Add V.110 encoder/decoder ...................................................................... isdn: Add V.110 encoder/decoder Change-Id: I1b5fd3847d3bfb0a0f763e0574893962ec699680 --- M include/osmocom/isdn/Makefile.am A include/osmocom/isdn/v110.h M src/isdn/Makefile.am M src/isdn/libosmoisdn.map A src/isdn/v110.c M tests/Makefile.am M tests/testsuite.at A tests/v110/test_frame.c A tests/v110/test_frame.ok A tests/v110/test_ra1.c A tests/v110/test_ra1.ok 11 files changed, 951 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/62/30762/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30762 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b5fd3847d3bfb0a0f763e0574893962ec699680 Gerrit-Change-Number: 30762 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: create libosmoisdn sub-library

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30376 to look at the new patch set (#6). Change subject: create libosmoisdn sub-library ...................................................................... create libosmoisdn sub-library There are some parts of libosmogsm which are not really GSM specific, but rather ISDN bits that were inherited by GSM. This includes the I.460 multiplex as well as the core LAPD protocol. Let's move those bits to its own libosmoisdn library, before we add more ISDN specific bits to the wrong place. Backwards-compatibility is created by making libosmogsm depend on libosmoisdn, and by providing wrapper include files for source compatibility. Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 --- M .gitignore M Doxyfile.codec.in M Doxyfile.coding.in M Doxyfile.core.in M Doxyfile.ctrl.in M Doxyfile.gb.in M Doxyfile.gsm.in A Doxyfile.isdn.in M Doxyfile.vty.in M Makefile.am M configure.ac M contrib/libosmocore.spec.in M debian/control M debian/copyright M debian/libosmocore.dirs A debian/libosmoisdn-doc.doc-base A debian/libosmoisdn-doc.install A debian/libosmoisdn0.install M debian/rules M include/osmocom/Makefile.am M include/osmocom/gsm/i460_mux.h M include/osmocom/gsm/lapd_core.h A include/osmocom/isdn/Makefile.am A include/osmocom/isdn/i460_mux.h A include/osmocom/isdn/lapd_core.h M libosmogsm.pc.in A libosmoisdn.pc.in M src/Makefile.am M src/gsm/Makefile.am A src/isdn/Makefile.am R src/isdn/i460_mux.c R src/isdn/lapd_core.c A src/isdn/libosmoisdn.map M tests/Makefile.am M tests/i460_mux/i460_mux_test.c 35 files changed, 2,223 insertions(+), 311 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/76/30376/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30376 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib1a6c762322fd5047be3188b1df22408ef06aa50 Gerrit-Change-Number: 30376 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers)

by arehbein

Attention is currently required from: arehbein. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30982 to look at the new patch set (#3). Change subject: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) ...................................................................... bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) Related: SYS#6287 Change-Id: I79aeffd93089086f57c66787fe20b439a4d8b6b4 --- M src/osmo-bsc/neighbor_ident_ctrl.c M tests/ctrl/osmo-bsc-neigh-test.cfg M tests/ctrl_test_runner.py 3 files changed, 111 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/30982/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79aeffd93089086f57c66787fe20b439a4d8b6b4 Gerrit-Change-Number: 30982 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers)

by Jenkins Builder

Attention is currently required from: arehbein. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30982 ) Change subject: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/neighbor_ident_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2895): https://gerrit.osmocom.org/c/osmo-bsc/+/30982/comment/53cc2e41_735d6bfa PS2, Line 119: if (n->type == NEIGHBOR_TYPE_BTS_NR) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79aeffd93089086f57c66787fe20b439a4d8b6b4 Gerrit-Change-Number: 30982 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Sat, 21 Jan 2023 21:28:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers)

by arehbein

Attention is currently required from: arehbein. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30982 to look at the new patch set (#2). Change subject: bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) ...................................................................... bsc_ctrl_commands: Add GET for bts neighbor-list (local bts numbers) Related: SYS#6287 Change-Id: I79aeffd93089086f57c66787fe20b439a4d8b6b4 --- M src/osmo-bsc/neighbor_ident_ctrl.c M tests/ctrl/osmo-bsc-neigh-test.cfg M tests/ctrl_test_runner.py 3 files changed, 112 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/82/30982/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30982 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I79aeffd93089086f57c66787fe20b439a4d8b6b4 Gerrit-Change-Number: 30982 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc: Log error regarding BTS number explicitly

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31030 ) Change subject: osmo-bsc: Log error regarding BTS number explicitly ...................................................................... osmo-bsc: Log error regarding BTS number explicitly Related: OS#5864 Change-Id: I64d12b3ebadbf550ecb72ccde2845951e3e309ee --- M src/osmo-bsc/bts_vty.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/30/31030/1 diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 50e49b8..08166ca 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -116,8 +116,8 @@ struct gsm_bts *bts; if (bts_nr > gsmnet->num_bts) { - vty_out(vty, "%% The next unused BTS number is %u%s", - gsmnet->num_bts, VTY_NEWLINE); + vty_out(vty, "%% BTS number %d not valid (next BTS number must be %u)%s", + bts_nr, gsmnet->num_bts, VTY_NEWLINE); return CMD_WARNING; } else if (bts_nr == gsmnet->num_bts) { /* allocate a new one */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I64d12b3ebadbf550ecb72ccde2845951e3e309ee Gerrit-Change-Number: 31030 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc: Fix 'apply-config-file' CTRL command

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31029 ) Change subject: osmo-bsc: Fix 'apply-config-file' CTRL command ...................................................................... osmo-bsc: Fix 'apply-config-file' CTRL command Make 'apply-config-file' check the neighbor config, just as is done after config parsing on startup Related: OS#5866 Change-Id: I24ae8cd7e5e0d15eab9fd04b1858072bf0bad36a --- M src/osmo-bsc/bsc_ctrl.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/31029/1 diff --git a/src/osmo-bsc/bsc_ctrl.c b/src/osmo-bsc/bsc_ctrl.c index ca246e7..c1e1a3d 100644 --- a/src/osmo-bsc/bsc_ctrl.c +++ b/src/osmo-bsc/bsc_ctrl.c @@ -43,6 +43,7 @@ #include <osmocom/bsc/a_reset.h> #include <osmocom/bsc/ctrl.h> #include <osmocom/bsc/handover_ctrl.h> +#include <osmocom/bsc/neighbor_ident.h> static int verify_net_apply_config_file(struct ctrl_cmd *cmd, const char *value, void *_data) { @@ -75,7 +76,6 @@ } rc = vty_read_config_filep(cfile, NULL); - LOGP(DCTRL, LOGL_NOTICE, "Applying VTY snippet from %s returned %d\n", cmd->value, rc); if (rc) { cmd->reply = talloc_asprintf(cmd, "ParseError=%d", rc); if (!cmd->reply) @@ -83,6 +83,15 @@ goto close_ret; } + rc = neighbors_check_cfg(); + if (rc) { + cmd->reply = talloc_asprintf(cmd, "Errors in neighbor configuration"); + if (!cmd->reply) + cmd->reply = "OOM"; + goto close_ret; + } + LOGP(DCTRL, LOGL_NOTICE, "Applying VTY snippet from %s returned %d\n", cmd->value, rc); + cmd->reply = "OK"; cmd_ret = CTRL_CMD_REPLY; close_ret: -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I24ae8cd7e5e0d15eab9fd04b1858072bf0bad36a Gerrit-Change-Number: 31029 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: Introduce netns API

by Jenkins Builder

Attention is currently required from: osmith, laforge, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31024 ) Change subject: Introduce netns API ...................................................................... Patch Set 4: (1 comment) File src/core/netns.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2891): https://gerrit.osmocom.org/c/libosmocore/+/31024/comment/676ed04b_41c987ab PS4, Line 122: rc = mkdir(NETNS_PREFIX_PATH, S_IRWXU|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH); Symbolic permissions 'S_IRWXU|S_IRGRP|S_IXGRP|S_IROTH|S_IXOTH' are not preferred. Consider using octal permissions '0755'. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0f2fba2fa42250a07211a7b7f479498f27c529da Gerrit-Change-Number: 31024 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 20 Jan 2023 19:37:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023