January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: layer23: Introduce APN VTY node

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 ) Change subject: layer23: Introduce APN VTY node ...................................................................... Patch Set 6: (1 comment) File doc/examples/modem/modem.cfg: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/ad76d443_39394211 PS6, Line 11: ! tun-netns netns_modem4 > why is this commented out? Because it can be used but won't be enabled by default. Still, as an example cfg file I thought it may be a good idea to have it listed here so that a new user quickly knows this is supported. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e Gerrit-Change-Number: 30992 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Jan 2023 11:53:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: Introduce netns API

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31024 ) Change subject: Introduce netns API ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/core/netns.c: https://gerrit.osmocom.org/c/libosmocore/+/31024/comment/e988990f_a2fdf158 PS2, Line 170: if (rc < 0) > Ack Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0f2fba2fa42250a07211a7b7f479498f27c529da Gerrit-Change-Number: 31024 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Jan 2023 11:21:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce APN VTY node

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30992 ) Change subject: layer23: Introduce APN VTY node ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File doc/examples/modem/modem.cfg: https://gerrit.osmocom.org/c/osmocom-bb/+/30992/comment/50a74ab6_b1ec44af PS6, Line 11: ! tun-netns netns_modem4 why is this commented out? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I7b4eaa0de428b418bb1d89bd544694e89beb3e6e Gerrit-Change-Number: 30992 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Jan 2023 11:17:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: install-coverity: ensure it's not installed twice

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30917 ) Change subject: ansible: install-coverity: ensure it's not installed twice ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30917 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I95549983bb6bd47e04eb37c73afe5409637f87d3 Gerrit-Change-Number: 30917 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Jan 2023 10:58:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: .gitignore: make poky regex more specific

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30914 ) Change subject: ansible: .gitignore: make poky regex more specific ...................................................................... ansible: .gitignore: make poky regex more specific Otherwise it would also prevent changes to the poky role Change-Id: I3ac9a6129323f27ba387b44d8293d7b134716af8 --- M ansible/.gitignore 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ansible/.gitignore b/ansible/.gitignore index 2fa603c..b23a1b1 100644 --- a/ansible/.gitignore +++ b/ansible/.gitignore @@ -1,4 +1,4 @@ -poky-* +poky-*toolchain* cov-analysis-*.tar.gz *.retry *.swo -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3ac9a6129323f27ba387b44d8293d7b134716af8 Gerrit-Change-Number: 30914 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: .gitignore: make poky regex more specific

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30914 ) Change subject: ansible: .gitignore: make poky regex more specific ...................................................................... Patch Set 3: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I3ac9a6129323f27ba387b44d8293d7b134716af8 Gerrit-Change-Number: 30914 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Jan 2023 10:57:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: replace deprecated include by import_tasks

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30912 ) Change subject: ansible: replace deprecated include by import_tasks ...................................................................... ansible: replace deprecated include by import_tasks include_tasks and import_tasks have similar functionality. Use import_tasks when importing non-variable depending files. Further use import_tasks when not used within a loop. Closes: OS#5797 Change-Id: I29766c65b9e1601a20aa8f20a438e8368c65f6a8 --- M ansible/roles/docker/tasks/main.yml M ansible/roles/osmocom-workstation/tasks/main.yml 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ansible/roles/docker/tasks/main.yml b/ansible/roles/docker/tasks/main.yml index aa0fe4b..f64ae96 100644 --- a/ansible/roles/docker/tasks/main.yml +++ b/ansible/roles/docker/tasks/main.yml @@ -57,4 +57,4 @@ shell: "docker info | grep -q 'Storage Driver: overlay2' || rm -rf /var/lib/docker/vfs" # After docker is set up, add docuum to clean old docker images -- include: docuum.yml +- import_tasks: docuum.yml diff --git a/ansible/roles/osmocom-workstation/tasks/main.yml b/ansible/roles/osmocom-workstation/tasks/main.yml index ae29111..0331207 100644 --- a/ansible/roles/osmocom-workstation/tasks/main.yml +++ b/ansible/roles/osmocom-workstation/tasks/main.yml @@ -9,8 +9,8 @@ shell: /usr/bin/zsh groups: docker -- name: include git repos - include: git-repos.yml +- name: import git repos + import_tasks: git-repos.yml - name: install distribution packages apt: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30912 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I29766c65b9e1601a20aa8f20a438e8368c65f6a8 Gerrit-Change-Number: 30912 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: install-poky-sdk: ensure it's not installed twice

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30913 ) Change subject: ansible: install-poky-sdk: ensure it's not installed twice ...................................................................... ansible: install-poky-sdk: ensure it's not installed twice Check if the poky path already exists. Even this wouldn't detect if the poky has been only installed half way. Related: OS#5801 Change-Id: I8ff8e72a5974378327d4692341b0a371c667b741 --- M ansible/roles/install-poky-sdk/tasks/main.yml 1 file changed, 37 insertions(+), 32 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/ansible/roles/install-poky-sdk/tasks/main.yml b/ansible/roles/install-poky-sdk/tasks/main.yml index 4b41bd2..7c1e9a9 100644 --- a/ansible/roles/install-poky-sdk/tasks/main.yml +++ b/ansible/roles/install-poky-sdk/tasks/main.yml @@ -9,40 +9,45 @@ cache_valid_time: 3600 update_cache: yes -- name: copy poky installer - copy: - src: "{{ poky_installer_file }}" - dest: "/tmp/{{ poky_installer_file }}" - mode: 0750 - register: poky_copy - ignore_errors: yes - tags: [poky] - -- name: execute poky installer - command: "/tmp/{{ poky_installer_file }} -y -d '{{ poky_dest }}'" - args: - creates: "{{ poky_dest }}" - when: poky_copy.failed == False - tags: [poky] - -- name: change owner/group to jenkins user - file: +- name: check if poky needs to be installed + stat: path: "{{ poky_dest }}" - owner: "{{ jenkins_user }}" - group: "{{ jenkins_user }}" - recurse: yes - when: poky_copy.failed == False + register: poky_stat tags: [poky] -- name: remove poky installer - file: - path: "/tmp/{{ poky_installer_file }}" - state: absent - when: poky_copy.failed == False +- name: install poky if required tags: [poky] + when: poky_stat.stat.exists == False + block: + - name: copy poky installer + copy: + src: "{{ poky_installer_file }}" + dest: "/tmp/{{ poky_installer_file }}" + mode: 0750 + register: poky_copy + ignore_errors: yes -- name: "Please download {{ poky_installer_file }} to your ansible directory to allow ansible to install poky" - debug: - msg: "Ansible can not find or copy {{ poky_installer_file }}" - when: poky_copy.failed == True - tags: [poky] + - name: execute poky installer + command: "/tmp/{{ poky_installer_file }} -y -d '{{ poky_dest }}'" + args: + creates: "{{ poky_dest }}" + when: poky_copy.failed == False + + - name: change owner/group to jenkins user + file: + path: "{{ poky_dest }}" + owner: "{{ jenkins_user }}" + group: "{{ jenkins_user }}" + recurse: yes + when: poky_copy.failed == False + + - name: remove poky installer + file: + path: "/tmp/{{ poky_installer_file }}" + state: absent + when: poky_copy.failed == False + + - name: "Please download {{ poky_installer_file }} to your ansible directory to allow ansible to install poky" + debug: + msg: "Ansible can not find or copy {{ poky_installer_file }}" + when: poky_copy.failed == True -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8ff8e72a5974378327d4692341b0a371c667b741 Gerrit-Change-Number: 30913 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: install-poky-sdk: ensure it's not installed twice

by laforge

Attention is currently required from: lynxis lazus. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30913 ) Change subject: ansible: install-poky-sdk: ensure it's not installed twice ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8ff8e72a5974378327d4692341b0a371c667b741 Gerrit-Change-Number: 30913 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 23 Jan 2023 10:57:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_network: improve coment

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31021 ) Change subject: mgcp_network: improve coment ...................................................................... mgcp_network: improve coment the comment that explains the AMR frame format check is a bit difficult to understand, lets rephrase it. Change-Id: I07f12c03449e1e8eda8bdd3edad6d1007f5ba48d --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index d93e695..d6028a2 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1537,12 +1537,11 @@ if (!trunk->rtp_accept_all && check_rtp_origin(conn_src, from_addr)) return -1; - /* If AMR is configured for the ingress connection and conversion of the - * framing mode (octet-aligned vs. bandwith-efficient) is explicitly - * defined, then we check if the incoming payload matches that - * expectation. */ + /* Handle AMR frame format conversion (octet-aligned vs. bandwith-efficient) */ if (mc->proto == MGCP_PROTO_RTP && mgcp_codec_amr_align_mode_is_indicated(conn_src->end.codec)) { + /* Make sure that the incoming AMR frame format matches the frame format that the call agent has + * communicated via SDP when the connection was created/modfied. */ int oa = amr_oa_check((char*)msgb_data(msg), msgb_length(msg)); if (oa < 0) return -1; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/31021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I07f12c03449e1e8eda8bdd3edad6d1007f5ba48d Gerrit-Change-Number: 31021 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023