January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-sgsn[master]: vty: Fix wrong value_string used to print llme state

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30855 ) Change subject: vty: Fix wrong value_string used to print llme state ...................................................................... vty: Fix wrong value_string used to print llme state Change-Id: Id3eec91b47029964092087858e4ae3a824929ce3 --- M src/sgsn/gprs_llc_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/sgsn/gprs_llc_vty.c b/src/sgsn/gprs_llc_vty.c index 24e404b..124daa3 100644 --- a/src/sgsn/gprs_llc_vty.c +++ b/src/sgsn/gprs_llc_vty.c @@ -79,7 +79,7 @@ get_value_string(gprs_cipher_names, llme->algo), llme->iov_ui, llme->cksn, llme->age_timestamp == GPRS_LLME_RESET_AGE ? 0 : (int)(now_tp.tv_sec - (time_t)llme->age_timestamp), - get_value_string(gprs_llc_state_strs, llme->state), VTY_NEWLINE); + get_value_string(gprs_llc_llme_state_names, llme->state), VTY_NEWLINE); for (i = 0; i < ARRAY_SIZE(valid_sapis); i++) { struct gprs_llc_lle *lle; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30855 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id3eec91b47029964092087858e4ae3a824929ce3 Gerrit-Change-Number: 30855 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-sgsn[master]: cosmetic: gprs_llc_vty.c: Fix trailing whitespace

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30854 ) Change subject: cosmetic: gprs_llc_vty.c: Fix trailing whitespace ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30854 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I543fd784f7e1a0f7c82bd7c79e073104becc88da Gerrit-Change-Number: 30854 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jan 2023 18:23:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-netif[master]: osmo-amr-inspect: Improve robustness reading from stdin

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30837 ) Change subject: osmo-amr-inspect: Improve robustness reading from stdin ...................................................................... Patch Set 1: (1 comment) File utils/osmo-amr-inspect.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30837/comment/caf0a34b_99f714ac PS1, Line 260: sizeof(buf > Are you sure this is correct? You're asking osmo_hexparse() to parse the whole buffer (2048 bytes), […] Yes, that was a bug before this change too, see API doc: """ /*! Parse a string containing hexadecimal digits * \param[in] str string containing ASCII encoded hexadecimal digits * \param[out] b output buffer * \param[in] max_len maximum space in output buffer * \returns number of parsed octets, or -1 on error */ int osmo_hexparse(const char *str, uint8_t *b, unsigned int max_len) { ... for (strpos = str; (c = *strpos); strpos++) { ... } """ So hexparse is reading from hex_buf until finding a null character. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I460f1deb7455b3b6a85a090bdcad8e21a883db68 Gerrit-Change-Number: 30837 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jan 2023 18:23:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: libosmocore: Deprecate APIs telnet_init(_dynip)()

by arehbein

Attention is currently required from: neels, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30703 ) Change subject: libosmocore: Deprecate APIs telnet_init(_dynip)() ...................................................................... Patch Set 6: (3 comments) Patchset: PS4: > FYI, you cannot change patches that have been merged to master. […] Thanks for the info neels, makes sense File src/vty/telnet_interface.c: https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/e577a4d1_f85018b7 PS4, Line 45: \ref > ('\ref' is to reference files, not functions. we've been using it wrongly for some time. […] Done https://gerrit.osmocom.org/c/libosmocore/+/30703/comment/3f246a06_60140ba6 PS4, Line 96: \deprecated > (interesting, i wasn't aware of the \deprecated cmd yet) Saw it used somewhere else in our codebase while grepping for the word in order to see how we deprecate functions :) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jan 2023 17:51:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in mncc-python[master]: rtpsourcec: Fix compilation on Debian 11 / gcc-10.2.1

by daniel

Attention is currently required from: laforge. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/mncc-python/+/30858 ) Change subject: rtpsourcec: Fix compilation on Debian 11 / gcc-10.2.1 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/30858 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: I57d13faa8052b6f15890ce9c6c74efa927d2e2ab Gerrit-Change-Number: 30858 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 04 Jan 2023 17:50:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: libosmocore: Deprecate APIs telnet_init(_dynip)()

by arehbein

Attention is currently required from: arehbein, pespin. Hello Jenkins Builder, neels, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30703 to look at the new patch set (#6). Change subject: libosmocore: Deprecate APIs telnet_init(_dynip)() ...................................................................... libosmocore: Deprecate APIs telnet_init(_dynip)() Related: OS#5809 Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 --- M include/osmocom/vty/telnet_interface.h M src/vty/telnet_interface.c 2 files changed, 34 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/30703/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 6 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in mncc-python[master]: MNCC data size check: allow trailing data

by daniel

Attention is currently required from: laforge. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/mncc-python/+/30857 ) Change subject: MNCC data size check: allow trailing data ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/mncc-python/+/30857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: mncc-python Gerrit-Branch: master Gerrit-Change-Id: Ic8c24e6988ae2d3c4278c4adccae46e248c893b8 Gerrit-Change-Number: 30857 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 04 Jan 2023 17:49:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-sgsn[master]: Replace gprs_str_to_apn() with libosmocore API osmo_apn_from_str()

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30861 ) Change subject: Replace gprs_str_to_apn() with libosmocore API osmo_apn_from_str() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File tests/sgsn/sgsn_test.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/30861/comment/53cbd5c8_47a9edf8 PS1, Line 40: #include <osmocom/sgsn/gprs_gmm_fsm.h> This looks like an incomplete alphabetical sort (vty should go to the bottom, gsupclient in between sgsn, gprs_gmm_fsm out of place). The only functional change is the addition of apn.h? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ibef55a648f2d58f4fdd24fa553efde530982af2d Gerrit-Change-Number: 30861 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jan 2023 17:48:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: libosmocore: Deprecate APIs telnet_init(_dynip)()

by arehbein

Attention is currently required from: arehbein, pespin. Hello Jenkins Builder, neels, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/30703 to look at the new patch set (#5). Change subject: libosmocore: Deprecate APIs telnet_init(_dynip)() ...................................................................... libosmocore: Deprecate APIs telnet_init(_dynip)() Related: OS#5809 Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 --- M include/osmocom/vty/telnet_interface.h M src/vty/telnet_interface.c 2 files changed, 34 insertions(+), 22 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/03/30703/5 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30703 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd05d3bc2736256aa45e9e7ec15a98bd14a10454 Gerrit-Change-Number: 30703 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: vty: Add check against sensible default value for Ny1

by arehbein

Attention is currently required from: neels, pespin, fixeria. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30602 ) Change subject: vty: Add check against sensible default value for Ny1 ...................................................................... Patch Set 19: (7 comments) File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/4a80a88d_79abf804 PS9, Line 1729: struct gsm_lchan *gl = gsm_bts_get_cbch(bts); > According to the specs, T3124 is set depending on the channel type (I assume 'lchan' stands for 'lin […] Done File src/osmo-bsc/bts.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/8aba729d_6ad38f09 PS18, Line 535: if (!gsm_bts_check_ny1(bts, LOGL_ERROR)) return -EINVAL; > put return always in a separate line. Done https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/9220b3e8_7eaa269f PS18, Line 1726: const struct gsm_lchan *gl = gsm_bts_get_cbch(bts); > I'm still not understanding why are you taking a CBCH channel here, seems totally not related. […] I removed the check. https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/e0a4ab5e_c63b3fce PS18, Line 1729: if (gl) { > no need for {} here. Linter should already have warned about it. I used 'lint_diff.sh' from our Docker tests locally (I think that's where I got it from) and didn't get anything. Looking at it again, I guess I have to run it after creating the commit (seems like it runs on the latest commit, not on local changes, which I was assuming). Apart from that, does Jenkins fail if the linter warns? https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/294beef5_38231b59 PS18, Line 1730: T3124 = (gl->type == GSM_LCHAN_SDCCH) ? GSM_T3124_SDCCH : GSM_T3124_OTHER_CH; > this is always going to be false since gl is CBCH. Done https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/6bb07845_431fe884 PS18, Line 1732: /* Take the higher lower bound to be safe */ > you can then move the comment to the "else" line (1731) Done File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30602/comment/069ed66a_041df112 PS18, Line 95: gsm_bts_check_ny1(bts, LOGL_NOTICE); > I really see no reason for having different log levels. This is the additional check during runtime (vs. startup), so should this function also exit with an error if the check isn't successful? My thinking was if we don't exit, it shouldn't count as an error message. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If3f96a6bd4f9ae32b6421de43c1c5a5d64482089 Gerrit-Change-Number: 30602 Gerrit-PatchSet: 19 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Jan 2023 16:00:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023