Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30866 )
Change subject: gprs_subscriber: Move API declarations to correct header
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30866
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iaa1032c38fa54ad57c472d9120cfbb34b2ae90e9
Gerrit-Change-Number: 30866
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Jan 2023 13:46:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30862 )
Change subject: Move struct sgsn_ggsn_ctx to its own file gtp_ggsn.{c,h}
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30862
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Iad1895f09e43e299df7bb126bf52fdb98268392e
Gerrit-Change-Number: 30862
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Jan 2023 13:46:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30870 )
Change subject: modem: passive decoding of SI{3,4,13} and IA Rest Octets
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
might be worth mentioning that you're migrating from a separate "modem" to a layer23 "app" ?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30870
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I8566a3cdc9f818bed7e28ea4b1957dce735c298b
Gerrit-Change-Number: 30870
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Jan 2023 13:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30870 )
Change subject: modem: passive decoding of SI{3,4,13} and IA Rest Octets
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30870
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I8566a3cdc9f818bed7e28ea4b1957dce735c298b
Gerrit-Change-Number: 30870
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Jan 2023 13:44:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30870
to look at the new patch set (#2).
Change subject: modem: passive decoding of SI{3,4,13} and IA Rest Octets
......................................................................
modem: passive decoding of SI{3,4,13} and IA Rest Octets
Change-Id: I8566a3cdc9f818bed7e28ea4b1957dce735c298b
Related: SYS#5500
---
M src/host/layer23/src/modem/Makefile.am
A src/host/layer23/src/modem/app_modem.c
D src/host/layer23/src/modem/modem_main.c
3 files changed, 324 insertions(+), 170 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/70/30870/2
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30870
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I8566a3cdc9f818bed7e28ea4b1957dce735c298b
Gerrit-Change-Number: 30870
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30870 )
Change subject: modem: passive decoding of SI{3,4,13} and IA Rest Octets
......................................................................
Patch Set 1:
(2 comments)
File src/host/layer23/src/modem/app_modem.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2437):
https://gerrit.osmocom.org/c/osmocom-bb/+/30870/comment/027761d3_43725a89
PS1, Line 292: L1CTL_FBSB_F_FB01SB, 100, 0,
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2437):
https://gerrit.osmocom.org/c/osmocom-bb/+/30870/comment/46124712_0d3aa009
PS1, Line 293: CCCH_MODE_NONE, dbm2rxlev(-85));
code indent should use tabs where possible
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30870
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I8566a3cdc9f818bed7e28ea4b1957dce735c298b
Gerrit-Change-Number: 30870
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 05 Jan 2023 13:33:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmocom-bb/+/30812
to look at the new patch set (#8).
Change subject: layer23/sysinfo: implement decoding of SI13 Rest Octets
......................................................................
layer23/sysinfo: implement decoding of SI13 Rest Octets
Change-Id: Ia6ff7d4e37816c6321b54c1f7f8d7110e557f8c5
Related: SYS#5500
---
M src/host/layer23/include/osmocom/bb/common/sysinfo.h
M src/host/layer23/src/common/sysinfo.c
M src/host/layer23/src/mobile/gsm48_rr.c
3 files changed, 169 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/12/30812/8
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30812
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia6ff7d4e37816c6321b54c1f7f8d7110e557f8c5
Gerrit-Change-Number: 30812
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset