January 2023 - gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: llc: Allow app provided callbacks to retain ownership of passed primi...

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30921 ) Change subject: llc: Allow app provided callbacks to retain ownership of passed primitive ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: we've done this pattern in other places. Maybe it's time to introduce some kind of RET_SUCCESS_TAKEN_OWNERSHIP #define? -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6ea91b8f190a399c4bcf6c7cba9a65809aaf3ddb Gerrit-Change-Number: 30921 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Jan 2023 17:25:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: check trx mo state

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30875 ) Change subject: pcu_sock: check trx mo state ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30875 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7a93826e6b0df187425310cb82854e7d7fb47e72 Gerrit-Change-Number: 30875 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Jan 2023 17:23:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: guard against too many TRX

by laforge

Attention is currently required from: pespin, fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30873 ) Change subject: pcu_sock: guard against too many TRX ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I351080a112f3d3fdf833ee7fa0d77c4cd1d13e42 Gerrit-Change-Number: 30873 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Jan 2023 17:22:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: fix frame number calculation

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30922 ) Change subject: abis_rsl: fix frame number calculation ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: We might want to generalize this and introduce a macro or an inline function for euclidian modulo in libosmocore. There might very well be other locations in osmocom where we need an actual modulo, not just the remainder operation offered by C? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5fb2b0ada8d409730ac22963741fb4ab0026abdd Gerrit-Change-Number: 30922 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Jan 2023 17:22:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: fix frame number calculation

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30922 ) Change subject: abis_rsl: fix frame number calculation ...................................................................... abis_rsl: fix frame number calculation The formula that is used to recover the (relative) frame number from the T1, T2, T3 parameters matches the definition in the spec, but since the partial term t3-t2 can be negative special precaution is required when performing the MOD 26 operation. This is due to the modulo implementation in C/C++, which has a very specific understanding on how to deal with negative input parameters. Change-Id: I5fb2b0ada8d409730ac22963741fb4ab0026abdd Related: OS#5198 --- M src/osmo-bsc/abis_rsl.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/22/30922/1 diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 640ff4d..fe5cfc6 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1817,10 +1817,12 @@ rqd_ta = rqd->ta; /* See also 3GPP TS 04.08, section 10.5.2.38 and 3GPP TS 08.58, section 9.3.8 */ + /* NOTE: The forumula to compute fn was slightly altered to account for the C/C++ + * specific modulo definition. */ t1 = rqd->ref.t1; t2 = rqd->ref.t2; t3 = rqd->ref.t3_low | (rqd->ref.t3_high << 3); - fn = (51 * ((t3-t2) % 26) + t3 + 51 * 26 * t1); + fn = 51 * ((((t3-t2) % 26) + 26) % 26) + t3 + 51 * 26 * t1; LOG_BTS(rqd->bts, DRSL, LOGL_INFO, "CHAN RQD: fn(t1=%u,t3=%u,t2=%u) = %u\n", t1, t3, t2, fn); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30922 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5fb2b0ada8d409730ac22963741fb4ab0026abdd Gerrit-Change-Number: 30922 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: lapd_pcap: fix illegal VLA within struct

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30908 ) Change subject: lapd_pcap: fix illegal VLA within struct ...................................................................... lapd_pcap: fix illegal VLA within struct Another weird and unique gcc supported extension, clang complains: CC input/lapd_pcap.lo input/lapd_pcap.c:134:8: error: fields must have a constant size: 'variable length array in structure' extension will never be supported char buf[msg->len]; ^ The kernel has been VLA-free since 2018, let's try not to make it worse. Change-Id: I547d900ba88c60bae5b53345e1aee104bacd310d --- M src/input/lapd_pcap.c 1 file changed, 22 insertions(+), 19 deletions(-) Approvals: dexter: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/input/lapd_pcap.c b/src/input/lapd_pcap.c index 6e1faf5..f9d17ef 100644 --- a/src/input/lapd_pcap.c +++ b/src/input/lapd_pcap.c @@ -128,44 +128,47 @@ int osmo_pcap_lapd_write(int fd, int direction, struct msgb *msg) { struct timeval tv; - struct { + struct tmp_pkt { struct pcap_rechdr pcap_rechdr; struct pcap_lapdhdr header; - char buf[msg->len]; - } __attribute__((packed)) s; + char buf[0]; + } __attribute__((packed)); + const unsigned int total_pkt_len = sizeof(struct tmp_pkt) + msg->len; + + struct tmp_pkt *s = alloca(total_pkt_len); /* PCAP file has not been opened, skip. */ if (fd < 0) return 0; - memset(&s, 0, sizeof(s)); + memset(s, 0, total_pkt_len); - s.pcap_rechdr.ts_sec = 0; - s.pcap_rechdr.ts_usec = 0; - s.pcap_rechdr.incl_len = msg->len + sizeof(struct pcap_lapdhdr); - s.pcap_rechdr.orig_len = msg->len + sizeof(struct pcap_lapdhdr); + s->pcap_rechdr.ts_sec = 0; + s->pcap_rechdr.ts_usec = 0; + s->pcap_rechdr.incl_len = msg->len + sizeof(struct pcap_lapdhdr); + s->pcap_rechdr.orig_len = msg->len + sizeof(struct pcap_lapdhdr); if (direction == OSMO_LAPD_PCAP_OUTPUT) - s.header.pkttype = htons(LINUX_SLL_OUTGOING); + s->header.pkttype = htons(LINUX_SLL_OUTGOING); else - s.header.pkttype = htons(LINUX_SLL_HOST); - s.header.hatype = 0; - s.header.halen = 0; - s.header.addr[0] = 0x01; /* we are the network side */ - s.header.protocol = ntohs(48); + s->header.pkttype = htons(LINUX_SLL_HOST); + s->header.hatype = 0; + s->header.halen = 0; + s->header.addr[0] = 0x01; /* we are the network side */ + s->header.protocol = ntohs(48); gettimeofday(&tv, NULL); - s.pcap_rechdr.ts_sec = tv.tv_sec; - s.pcap_rechdr.ts_usec = tv.tv_usec; + s->pcap_rechdr.ts_sec = tv.tv_sec; + s->pcap_rechdr.ts_usec = tv.tv_usec; - memcpy(s.buf, msg->data, msg->len); + memcpy(s->buf, msg->data, msg->len); - if (write(fd, &s, sizeof(s)) != sizeof(s)) { + if (write(fd, s, total_pkt_len) != total_pkt_len) { LOGP(DLLAPD, LOGL_ERROR, "cannot write packet to PCAP: %s\n", strerror(errno)); return -1; } - return sizeof(s); + return total_pkt_len; } int osmo_pcap_lapd_close(int fd) -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30908 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I547d900ba88c60bae5b53345e1aee104bacd310d Gerrit-Change-Number: 30908 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in libosmo-gprs[master]: llc: Allow app provided callbacks to retain ownership of passed primi...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30921 ) Change subject: llc: Allow app provided callbacks to retain ownership of passed primitive ...................................................................... llc: Allow app provided callbacks to retain ownership of passed primitive This way the app can, for instance, simply forward the primtiive pointer from LLC callback to SNDCP layer, which will in the end take the ownership of the primitive and free it. Change-Id: I6ea91b8f190a399c4bcf6c7cba9a65809aaf3ddb --- M src/llc/llc_prim.c 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/21/30921/1 diff --git a/src/llc/llc_prim.c b/src/llc/llc_prim.c index e789819..b5fab8f 100644 --- a/src/llc/llc_prim.c +++ b/src/llc/llc_prim.c @@ -142,7 +142,9 @@ rc = g_ctx->llc_up_cb(llc_prim, g_ctx->llc_up_cb_user_data); else rc = llc_up_cb_dummy(llc_prim, g_ctx->llc_up_cb_user_data); - msgb_free(llc_prim->oph.msg); + /* Special return value '1' means: do not free */ + if (rc != 1) + msgb_free(llc_prim->oph.msg); return rc; } @@ -178,7 +180,9 @@ rc = g_ctx->llc_down_cb(llc_prim, g_ctx->llc_down_cb_user_data); else rc = llc_down_cb_dummy(llc_prim, g_ctx->llc_down_cb_user_data); - msgb_free(llc_prim->oph.msg); + /* Special return value '1' means: do not free */ + if (rc != 1) + msgb_free(llc_prim->oph.msg); return rc; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I6ea91b8f190a399c4bcf6c7cba9a65809aaf3ddb Gerrit-Change-Number: 30921 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: abis_om2000: send TS_EV_OML_READY when TRX is fully done

by pespin

Attention is currently required from: laforge, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30748 ) Change subject: abis_om2000: send TS_EV_OML_READY when TRX is fully done ...................................................................... Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30748 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If5251b102c8aa45dfc8cc4ee4e0223d7dc438938 Gerrit-Change-Number: 30748 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Jan 2023 13:21:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: drop unused variable pcu_direct

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30849 ) Change subject: pcu_sock: drop unused variable pcu_direct ...................................................................... pcu_sock: drop unused variable pcu_direct The variable pcu_direct is set to one permanently, lets remove it. Change-Id: I7917ee5abc3347776dc9793cfb4ec3e99df94683 Related: OS#5198 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 1 insertion(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index bfa07f9..1dcab56 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -45,7 +45,6 @@ #include <osmocom/bsc/bts_sm.h> static int pcu_sock_send(struct gsm_bts *bts, struct msgb *msg); -int pcu_direct = 1; static const char *sapi_string[] = { [PCU_IF_SAPI_RACH] = "RACH", @@ -135,9 +134,7 @@ info_ind = &pcu_prim->u.info_ind; info_ind->version = PCU_IF_VERSION; info_ind->flags |= PCU_IF_FLAG_ACTIVE; - - if (pcu_direct) - info_ind->flags |= PCU_IF_FLAG_SYSMO; + info_ind->flags |= PCU_IF_FLAG_SYSMO; /* RAI */ info_ind->mcc = bts->network->plmn.mcc; 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7917ee5abc3347776dc9793cfb4ec3e99df94683 Gerrit-Change-Number: 30849 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: drop unused variable pcu_direct

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/30849 to look at the new patch set (#4). Change subject: pcu_sock: drop unused variable pcu_direct ...................................................................... pcu_sock: drop unused variable pcu_direct The variable pcu_direct is set to one permanently, lets remove it. Change-Id: I7917ee5abc3347776dc9793cfb4ec3e99df94683 Related: OS#5198 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/30849/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7917ee5abc3347776dc9793cfb4ec3e99df94683 Gerrit-Change-Number: 30849 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023