January 2023 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: layer23: Introduce tun.{c,h}

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30994 ) Change subject: layer23: Introduce tun.{c,h} ...................................................................... Patch Set 2: Verified+1 (1 comment) Patchset: PS2: Here I'm merely importing code as much as is from osmo-ggsn.git, hence ignoring the linter. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd Gerrit-Change-Number: 30994 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 10:18:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce netdev.{c,h}

by pespin

pespin has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: deleteVote

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce netdev.{c,h}

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Patch Set 2: Verified+1 (1 comment) Patchset: PS2: Here I'0m merely importing code as much as is from osmo-ggsn.git, hence ignoring the linter. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 10:18:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Add missing header dependencies to several files

by osmith

Attention is currently required from: neels, pespin, fixeria, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30959 ) Change subject: layer23: Add missing header dependencies to several files ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30959 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9819b12d1c24f6ee197daa887452b09418d689e8 Gerrit-Change-Number: 30959 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 10:13:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce netdev.{c,h}

by Jenkins Builder

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30993 ) Change subject: layer23: Introduce netdev.{c,h} ...................................................................... Patch Set 2: (42 comments) File src/host/layer23/include/osmocom/bb/common/netdev.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/64e27442_179cee72 PS2, Line 33: { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/999145ab_69e4914c PS2, Line 33: { open brace '{' following struct go on the same line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1c86fad6_960062b9 PS2, Line 35: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/74ec1f06_8c6c2823 PS2, Line 36: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/15c1f615_66d169c8 PS2, Line 38: unsigned int version:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/a0e25071_6f50b0cc PS2, Line 39: unsigned int ihl:4; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f71e5075_cff6a1ee PS2, Line 43: u_int8_t tos; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9867f050_fd762fea PS2, Line 44: u_int16_t tot_len; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e187b552_bade468f PS2, Line 45: u_int16_t id; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/42c22df0_b9b3d2a4 PS2, Line 46: u_int16_t frag_off; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8302801e_dbb0329f PS2, Line 47: u_int8_t ttl; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5f6791c0_f4f2f2bf PS2, Line 48: u_int8_t protocol; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f2ed034f_01b1d5d6 PS2, Line 49: u_int16_t check; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/2331b886_2fb9fb4d PS2, Line 50: u_int32_t saddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/91d581e4_e8997f47 PS2, Line 51: u_int32_t daddr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8ea9c984_3ecfeb5b PS2, Line 53: }; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/5f9086ef_84854b9f PS2, Line 57: struct osmo_sockaddr addr; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/07a1b548_aaea6acf PS2, Line 58: uint8_t prefixlen; please, no spaces at the start of a line File src/host/layer23/src/common/netdev.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f062a5ce_306cbeed PS2, Line 45: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/2c8f8e72_0395be2e PS2, Line 49: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/68126dfd_269ff956 PS2, Line 61: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8ceb15ae_cd23f90f PS2, Line 97: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/63958b21_1ce5dfcb PS2, Line 125: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/fe4e7a7b_a6774d28 PS2, Line 132: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/aff87f7a_24759175 PS2, Line 160: if (ioctl(fd, SIOCSIFDSTADDR, (caddr_t) & ifr) < 0) { space prohibited after that '&' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d38f0191_826d1f83 PS2, Line 172: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/06555899_f1a1e524 PS2, Line 191: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/c1efc235_ff76550a PS2, Line 213: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/1157a443_56d19b1d PS2, Line 214: strncpy(ifr.ifr_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/9ea3b1c8_cb9d31d3 PS2, Line 249: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/bf9e92cc_efe0a2ef PS2, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f3f8fc7b_df50acbc PS2, Line 381: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/2907c4cb_86a2abc2 PS2, Line 387: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/12da3787_7fe0c2ab PS2, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d8cdbc34_35624d39 PS2, Line 530: #elif defined (__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/e031a659_8b34c9f1 PS2, Line 536: strncpy(areq.ifra_name, devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/07bcdae2_fa99c4d0 PS2, Line 608: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/7e7c0559_b5fb91c9 PS2, Line 677: strncpy(ifr.ifr_name, gw_iface, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/f4926312_d5cfba4e PS2, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/d7101aeb_70903e17 PS2, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/93753615_2e48fef6 PS2, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2787): https://gerrit.osmocom.org/c/osmocom-bb/+/30993/comment/8ff44a7e_ea90999e PS2, Line 751: static const uint8_t ll_prefix[] = { 0xfe,0x80, 0,0, 0,0, 0,0 }; space required after that ',' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I6085dc6861687bd4e9c32e86221c0375ad95ba22 Gerrit-Change-Number: 30993 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 10:04:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce tun.{c,h}

by Jenkins Builder

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30994 ) Change subject: layer23: Introduce tun.{c,h} ...................................................................... Patch Set 2: (19 comments) File src/host/layer23/include/osmocom/bb/common/tun.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/e6c76432_b2ff40f2 PS2, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/b539f401_67396aa5 PS2, Line 39: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len); Unnecessary space before function pointer arguments Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/408119bc_1d1e77d1 PS2, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack, "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/c8ff476d_1b0526c1 PS2, Line 53: int (*cb_ind) (struct tun_t * tun, void *pack, Unnecessary space before function pointer arguments File src/host/layer23/src/common/tun.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/4f5e7f6e_6bfc26a1 PS2, Line 48: #elif defined (__FreeBSD__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/4b974623_86f2fcdb PS2, Line 53: #elif defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/30a12072_520a6024 PS2, Line 65: #define SYS_ERR(sub, pri, en, fmt, args...) \ Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/7077f55e_41a14101 PS2, Line 104: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/cf1593e4_436fd48c PS2, Line 123: #if defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/9596077f_d6a92cea PS2, Line 186: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/e261d027_08c963a2 PS2, Line 214: strcpy(ifr.ifr_name, dev_name); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/baa51f05_0c71a348 PS2, Line 221: strncpy((*tun)->devname, ifr.ifr_name, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/0bc8c8fa_2fb30731 PS2, Line 229: } else { else is not generally useful after a break or return Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/609375ad_4f7c403b PS2, Line 230: strncpy((*tun)->devname, dev_name, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/3209d461_d41d7b3b PS2, Line 243: #elif defined(__FreeBSD__) || defined (__APPLE__) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/c714d7d9_f2eccfcc PS2, Line 273: strncpy(areq.ifra_name, (*tun)->devname, IFNAMSIZ); Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY() Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/1d47c53d_eb7716e8 PS2, Line 283: while (ioctl(fd, SIOCDIFADDR, (void *)&areq) != -1) ; space prohibited before semicolon Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/bcd6ca32_0a5f35ea PS2, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len)) "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2786): https://gerrit.osmocom.org/c/osmocom-bb/+/30994/comment/1dea2092_e07cd7b4 PS2, Line 319: int (*cb_ind) (struct tun_t * tun, void *pack, unsigned len)) Unnecessary space before function pointer arguments -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd Gerrit-Change-Number: 30994 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 10:02:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: Introduce tun.{c,h}

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994 to look at the new patch set (#2). Change subject: layer23: Introduce tun.{c,h} ...................................................................... layer23: Introduce tun.{c,h} This module provides several operations on tun devices (interfaces). These functionalitites will be used by the "modem" app to set up tunnels for each APN in a follow-up patch. The code is basically an import from osmo-ggsn.git 97f60e3dca581797007524e0006ca9fafad59713 src/lib/tun.{c,h}, with small modifications to make use of osmo_sockaddr instead of osmo-ggsn.git specific in46_addr. Related: OS#5503 Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd --- M src/host/layer23/include/osmocom/bb/common/Makefile.am A src/host/layer23/include/osmocom/bb/common/tun.h M src/host/layer23/src/common/Makefile.am A src/host/layer23/src/common/tun.c 4 files changed, 461 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/94/30994/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30994 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Id8611b720ada17a3c602872fe095bb91eeb17bcd Gerrit-Change-Number: 30994 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen()

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30986 ) Change subject: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen() ...................................................................... Patch Set 3: Code-Review+1 (3 comments) File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/3993ed4e_ed15d8a0 PS2, Line 1306: > cosmetic: no need for a space Done https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/533d126a_2da27274 PS2, Line 1323: > cosmetic: no need for a space Done File tests/socket/socket_test.c: https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/d7059695_59e1d04e PS2, Line 420: chcking > checking, same below Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I75e75e251c6776801fffdde745aebedf21c68799 Gerrit-Change-Number: 30986 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 09:57:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30986 ) Change subject: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen() ...................................................................... socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen() Implementation is imported from osmo-ggsn.git 97f60e3dca581797007524e0006ca9fafad59713 in46a_netmasklen() and adapter to work with an osmo_sockaddr. This will be used by osmocom-bb's "modem" app. Change-Id: I75e75e251c6776801fffdde745aebedf21c68799 --- M TODO-RELEASE M include/osmocom/core/socket.h M src/socket.c M tests/socket/socket_test.c 4 files changed, 118 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/TODO-RELEASE b/TODO-RELEASE index 6ac8db8..86363e1 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,5 +7,5 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line -libosmocore new API osmo_sockaddr_is_any() +libosmocore new API osmo_sockaddr_is_any(), osmo_sockaddr_netmask_to_prefixlen() libosmocore ABI breakage OSMO_NUM_DLIB change affecting internal_cat[] diff --git a/include/osmocom/core/socket.h b/include/osmocom/core/socket.h index 06db5d0..3ed9cc6 100644 --- a/include/osmocom/core/socket.h +++ b/include/osmocom/core/socket.h @@ -50,6 +50,8 @@ int osmo_sockaddr_to_octets(uint8_t *dst, size_t dst_maxlen, const struct osmo_sockaddr *os); int osmo_sockaddr_from_octets(struct osmo_sockaddr *os, const void *src, size_t src_len); +int osmo_sockaddr_netmask_to_prefixlen(const struct osmo_sockaddr *addr); + const char *osmo_sockaddr_to_str(const struct osmo_sockaddr *sockaddr); char *osmo_sockaddr_to_str_buf(char *buf, size_t buf_len, const struct osmo_sockaddr *sockaddr); diff --git a/src/socket.c b/src/socket.c index 3d945e7..ee49c27 100644 --- a/src/socket.c +++ b/src/socket.c @@ -1291,6 +1291,63 @@ } } +static unsigned int in6_addr_netmask_to_prefixlen(const struct in6_addr *netmask) +{ + #if defined(__linux__) + #define ADDRFIELD(i) s6_addr32[i] + #else + #define ADDRFIELD(i) __u6_addr.__u6_addr32[i] + #endif + + unsigned int i, j, prefix = 0; + + for (j = 0; j < 4; j++) { + uint32_t bits = netmask->ADDRFIELD(j); + uint8_t *b = (uint8_t *)&bits; + for (i = 0; i < 4; i++) { + while (b[i] & 0x80) { + prefix++; + b[i] = b[i] << 1; + } + } + } + + #undef ADDRFIELD + + return prefix; +} + +static unsigned int in_addr_netmask_to_prefixlen(const struct in_addr *netmask) +{ + uint32_t bits = netmask->s_addr; + uint8_t *b = (uint8_t *)&bits; + unsigned int i, prefix = 0; + + for (i = 0; i < 4; i++) { + while (b[i] & 0x80) { + prefix++; + b[i] = b[i] << 1; + } + } + return prefix; +} + +/*! Convert netmask to prefix length representation + * \param[in] netmask sockaddr containing a netmask (consecutive list of 1-bit followed by consecutive list of 0-bit) + * \returns prefix length representation of the netmask (count of 1-bit from the start of the netmask), negative on error. + */ +int osmo_sockaddr_netmask_to_prefixlen(const struct osmo_sockaddr *netmask) +{ + switch (netmask->u.sa.sa_family) { + case AF_INET6: + return in6_addr_netmask_to_prefixlen(&netmask->u.sin6.sin6_addr); + case AF_INET: + return in_addr_netmask_to_prefixlen(&netmask->u.sin.sin_addr); + default: + return -ENOTSUP; + } +} + /*! Initialize a unix domain socket (including bind/connect) * \param[in] type Socket type like SOCK_DGRAM, SOCK_STREAM * \param[in] proto Protocol like IPPROTO_TCP, IPPROTO_UDP diff --git a/tests/socket/socket_test.c b/tests/socket/socket_test.c index d090fba..b3b9584 100644 --- a/tests/socket/socket_test.c +++ b/tests/socket/socket_test.c @@ -385,6 +385,63 @@ OSMO_ASSERT(!strncmp("[2003:1234:5678:90ab:cdef:1234:4321:4321]:23420", result, sizeof(buf))); } +static void test_osa_netmask_prefixlen(void) +{ + struct osmo_sockaddr ipv4; + struct osmo_sockaddr ipv6; + int rc; + + ipv4.u.sin = (struct sockaddr_in){ + .sin_family = AF_INET, + }; + + ipv4.u.sin.sin_addr.s_addr = inet_addr("0.0.0.0"); + rc = osmo_sockaddr_netmask_to_prefixlen(&ipv4); + OSMO_ASSERT(rc == 0); + + ipv4.u.sin.sin_addr.s_addr = inet_addr("255.0.0.0"); + rc = osmo_sockaddr_netmask_to_prefixlen(&ipv4); + OSMO_ASSERT(rc == 8); + + ipv4.u.sin.sin_addr.s_addr = inet_addr("255.255.0.0"); + rc = osmo_sockaddr_netmask_to_prefixlen(&ipv4); + OSMO_ASSERT(rc == 16); + + ipv4.u.sin.sin_addr.s_addr = inet_addr("255.255.255.0"); + rc = osmo_sockaddr_netmask_to_prefixlen(&ipv4); + OSMO_ASSERT(rc == 24); + + ipv4.u.sin.sin_addr.s_addr = inet_addr("255.255.255.255"); + rc = osmo_sockaddr_netmask_to_prefixlen(&ipv4); + OSMO_ASSERT(rc == 32); + + ipv4.u.sin.sin_addr.s_addr = inet_addr("0.255.0.0"); + rc = osmo_sockaddr_netmask_to_prefixlen(&ipv4); + /* FIXME: This shows the implementation is not that robust checking validity of input netmask: */ + OSMO_ASSERT(rc == 8); + + ipv6.u.sin6 = (struct sockaddr_in6){ + .sin6_family = AF_INET6, + }; + + inet_pton(AF_INET6, "fe::", &ipv6.u.sin6.sin6_addr); + rc = osmo_sockaddr_netmask_to_prefixlen(&ipv6); + OSMO_ASSERT(rc == 7); + + inet_pton(AF_INET6, "ff::", &ipv6.u.sin6.sin6_addr); + rc = osmo_sockaddr_netmask_to_prefixlen(&ipv6); + OSMO_ASSERT(rc == 8); + + inet_pton(AF_INET6, "ff:ff::", &ipv6.u.sin6.sin6_addr); + rc = osmo_sockaddr_netmask_to_prefixlen(&ipv6); + OSMO_ASSERT(rc == 16); + + inet_pton(AF_INET6, "ff:ff::ff", &ipv6.u.sin6.sin6_addr); + rc = osmo_sockaddr_netmask_to_prefixlen(&ipv6); + /* FIXME: This shows the implementation is not that robust checking validity of input netmask: */ + OSMO_ASSERT(rc == 24); +} + const struct log_info_cat default_categories[] = { }; @@ -407,6 +464,7 @@ test_get_ip_and_port(); test_sockinit_osa(); test_osa_str(); + test_osa_netmask_prefixlen(); return EXIT_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I75e75e251c6776801fffdde745aebedf21c68799 Gerrit-Change-Number: 30986 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen()

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30986 ) Change subject: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I75e75e251c6776801fffdde745aebedf21c68799 Gerrit-Change-Number: 30986 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 09:56:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023