Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29257 )
Change subject: osmux: Move osmux_xfrm_output_set_tx_cb() further down to the xfrm_output section
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29257
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I46628d1f712e9c5c56c306e27c34ff45731c0172
Gerrit-Change-Number: 29257
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Sep 2022 12:58:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29256 )
Change subject: osmux: Drop long time deprecated APIs
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
My general point on old APIs:
The primary point of our API compatibility is to make sure older versions of osmo-foo programs can still be built against more recent libosmo-*.
Third-party applications are relevant in general, but not in this specific case where OSMUX is so super osmocom specific, that I doubt any exist.
In general I'm against removing compatibility APIs if there's old osmo-foo applications that would no longer build.
In this instance, it is again less of a concern, as OSMUX was always optionally and has had very few users we know of.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29256
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Icbdd364a8161a8113dbf1406716946f684d0a853
Gerrit-Change-Number: 29256
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Sep 2022 12:58:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29254 )
Change subject: debian-bullseye-titan: Discontinue the use of git://
......................................................................
debian-bullseye-titan: Discontinue the use of git://
Change-Id: I188a04dd6ecae3c92186d5cbf6cd002ad518efc3
---
M debian-bullseye-titan/Dockerfile
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
diff --git a/debian-bullseye-titan/Dockerfile b/debian-bullseye-titan/Dockerfile
index 342cc08..f636003 100644
--- a/debian-bullseye-titan/Dockerfile
+++ b/debian-bullseye-titan/Dockerfile
@@ -37,7 +37,7 @@
apt-get clean
# This is required for obtaining talloc reports from the SUT
-RUN pip3 install git+git://git.osmocom.org/python/osmo-python-tests
+RUN pip3 install git+https://gitea.osmocom.org/cellular-infrastructure/osmo-python-tests
# somehow Debian folks updated the gcc version but not titan :/
RUN sed -i 's/^#error/\/\/#error/' /usr/include/titan/cversion.h
@@ -57,7 +57,7 @@
git config --global user.name "Dock Er"
# clone osmo-ttcn3-hacks and deps, invalidate cache if deps change (OS#5017)
-RUN git clone git://git.osmocom.org/osmo-ttcn3-hacks.git && \
+RUN git clone https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks && \
make -j8 -C /osmo-ttcn3-hacks deps
ADD https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/raw/branch/master/deps/Mak… /tmp/deps-Makefile
RUN if ! diff -q /tmp/deps-Makefile /osmo-ttcn3-hacks/deps/Makefile; then \
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29254
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I188a04dd6ecae3c92186d5cbf6cd002ad518efc3
Gerrit-Change-Number: 29254
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged