September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: jobs/gerrit-lint: add osmo-ci branch parameter

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29296 ) Change subject: jobs/gerrit-lint: add osmo-ci branch parameter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic4134e6755014b3e5fbf6d3225e49c0ca5b27f9b Gerrit-Change-Number: 29296 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Sep 2022 15:31:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-lint: hardcode shell command

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29295 ) Change subject: jobs/gerrit-lint: hardcode shell command ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iad23da08898205fafd1ae36256c8f7b6d7506d40 Gerrit-Change-Number: 29295 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Sep 2022 15:26:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: lint: annotate lines in gerrit

by osmith

Attention is currently required from: laforge, pespin, fixeria, lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 ) Change subject: lint: annotate lines in gerrit ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/26393/comment/c7011ff8_cc9670d8 PS1, Line 13: The jenkins nodes needs to access the gerrit via ssh > I don't think the complexity of the extra job is worth it (and to do it right, if we do allow untrus […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49 Gerrit-Change-Number: 26393 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 08 Sep 2022 15:22:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: lint: annotate lines in gerrit

by osmith

Attention is currently required from: laforge, pespin, fixeria, lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 ) Change subject: lint: annotate lines in gerrit ...................................................................... Patch Set 2: (2 comments) File lint/checkpatch/checkpatch_json.py: https://gerrit.osmocom.org/c/osmo-ci/+/26393/comment/0b3473cb_b0a9c0e2 PS1, Line 3: # from coreboot rev 9cae17d028d4bd3b278fc89ada8e06287917e213 > I'd note the exact commit in the commit message, but not in the file. […] Done File lint/lint_diff.sh: https://gerrit.osmocom.org/c/osmo-ci/+/26393/comment/1336d844_247fdcf6 PS1, Line 34: if ! git diff -U0 "$COMMIT" | "$SCRIPT_DIR/checkpatch/checkpatch_osmo.sh" > gerrit_report ; then > This condition doesn't need to check if errors were found or not, because above it does "exit 0" if […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49 Gerrit-Change-Number: 26393 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 08 Sep 2022 15:22:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: lint: annotate lines in gerrit

by osmith

Attention is currently required from: laforge, fixeria, lynxis lazus. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/26393 ) Change subject: lint: annotate lines in gerrit ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS2: should be ready to go now, please review. example of how it looks like: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29294 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1a48ddb976e0f53bfc0552d0be11e42ba68d9e49 Gerrit-Change-Number: 26393 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 08 Sep 2022 15:21:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-lint: add osmo-ci branch parameter

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29296 ) Change subject: jobs/gerrit-lint: add osmo-ci branch parameter ...................................................................... jobs/gerrit-lint: add osmo-ci branch parameter Extend the jobs to clone the trusted osmo-ci.git repository from which we execute the linter next to the untrusted code from gerrit, and add a parameter for the osmo-ci branch. Change-Id: Ic4134e6755014b3e5fbf6d3225e49c0ca5b27f9b --- M jobs/gerrit-lint.yml 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/96/29296/1 diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml index f1fa389..6883f1e 100644 --- a/jobs/gerrit-lint.yml +++ b/jobs/gerrit-lint.yml @@ -107,8 +107,16 @@ </br></br> Related issue: <a href="https://osmocom.org/issues/5087">OS#5087</a> + parameters: + - string: + name: BRANCH_CI + description: | + osmo-ci.git branch + default: 'master' + scm: - git: + basedir: 'code-from-gerrit' url: '{obj:repos_url}' credentials-id: d5eda5e9-b59d-44ba-88d2-43473cb6e42d branches: @@ -120,6 +128,13 @@ skip-tag: true submodule: recursive: false + - git: + basedir: 'osmo-ci' + url: '{gerrit_url}/osmo-ci' + credentials-id: d5eda5e9-b59d-44ba-88d2-43473cb6e42d + branches: + - '$BRANCH_CI' + wipe-workspace: true triggers: - gerrit: @@ -145,7 +160,7 @@ server-name: gerrit.osmocom.org builders: - - shell: '~/osmo-ci/lint/lint_diff.sh HEAD~1' + - shell: 'cd code-from-gerrit && ../osmo-ci/lint/lint_diff.sh HEAD~1' wrappers: - ansicolor: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29296 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic4134e6755014b3e5fbf6d3225e49c0ca5b27f9b Gerrit-Change-Number: 29296 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-lint: add ssh credentials

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29297 ) Change subject: jobs/gerrit-lint: add ssh credentials ...................................................................... jobs/gerrit-lint: add ssh credentials Prepare for having jenkins post gerrit review comments. Change-Id: I27477c6c448a4b06ea49b020b6cfa534445cf31c --- M jobs/gerrit-lint.yml 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/97/29297/1 diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml index 6883f1e..7b43e7e 100644 --- a/jobs/gerrit-lint.yml +++ b/jobs/gerrit-lint.yml @@ -165,5 +165,9 @@ wrappers: - ansicolor: colormap: xterm + wrappers: + - ssh-agent-credentials: + users: + - d5eda5e9-b59d-44ba-88d2-43473cb6e42d # vim: expandtab tabstop=2 shiftwidth=2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29297 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I27477c6c448a4b06ea49b020b6cfa534445cf31c Gerrit-Change-Number: 29297 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-ci[master]: jobs/gerrit-lint: hardcode shell command

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29295 ) Change subject: jobs/gerrit-lint: hardcode shell command ...................................................................... jobs/gerrit-lint: hardcode shell command Don't allow overriding cmd per repository anymore. This was used in the gerrit-osmo-ci-lint job to run the linter from the checked out osmo-ci.git repository (the one with the untrusted code submitted to gerrit). This would become problematic with a future patch that will attach the ssh agent to the lint jobs (so jenkins can leave review comments over at gerrit). Change-Id: Iad23da08898205fafd1ae36256c8f7b6d7506d40 --- M jobs/gerrit-lint.yml 1 file changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/95/29295/1 diff --git a/jobs/gerrit-lint.yml b/jobs/gerrit-lint.yml index 9a1c1c5..f1fa389 100644 --- a/jobs/gerrit-lint.yml +++ b/jobs/gerrit-lint.yml @@ -5,7 +5,6 @@ name: gerrit-lint # following default values can be overridden by each repo disabled: false - cmd: '~/osmo-ci/lint/lint_diff.sh HEAD~1' gerrit_url: 'ssh://jenkins@gerrit.osmocom.org:29418' repos_url: '{gerrit_url}/{repos}' gerrit_project: '{repos}' @@ -34,10 +33,7 @@ - osmo-hnodeb - osmo-hnbgw - osmo-upf - - - osmo-ci: - # Run the lint script from the checked out branch - cmd: 'lint/lint_diff.sh HEAD~1' + - osmo-ci - osmo_dia2gsup: repos_url: '{gerrit_url}/erlang/{repos}' @@ -149,7 +145,7 @@ server-name: gerrit.osmocom.org builders: - - shell: '{obj:cmd}' + - shell: '~/osmo-ci/lint/lint_diff.sh HEAD~1' wrappers: - ansicolor: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29295 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iad23da08898205fafd1ae36256c8f7b6d7506d40 Gerrit-Change-Number: 29295 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-bsc-nat[master]: [do not merge]: linter tests

by Jenkins Builder

Attention is currently required from: osmith. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29294 ) Change subject: [do not merge]: linter tests ...................................................................... Patch Set 1: (2 comments) File test: Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-nat-lint-140): https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29294/comment/42d58106_fc475ec0 PS1, Line 2: this line has a trailing white space trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-osmo-bsc-nat-lint-140): https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29294/comment/97416c08_3cf099f0 PS1, Line 4: this line has a speling error 'speling' may be misspelled - perhaps 'spelling'? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29294 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I76c99d7779818b9b1e77c546b76b95db914c621b Gerrit-Change-Number: 29294 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Sep 2022 15:08:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libosmocore[master]: vty: Allow using hex and octal representations in cmd numeric ranges

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19422 ) Change subject: vty: Allow using hex and octal representations in cmd numeric ranges ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I think this can now be re-started using the conclusions from the ticket? Yes, I'm in the middle of other stuff (osmux) right now though. I can work on this at point too or pass it to someone else too, I'm with with either. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2b7fbbf5502c28374c21dbff548232680da27d4 Gerrit-Change-Number: 19422 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 08 Sep 2022 14:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022