September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bsc: Add testscase & infra to validate Osmux support BTS<->BSC

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 ) Change subject: bsc: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... Patch Set 6: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e82eb9d995de988b812001e1c4cf6923509de66 Gerrit-Change-Number: 29010 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 09 Sep 2022 16:15:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Use osmo_sockaddr wherever possible

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/29309 to look at the new patch set (#3). Change subject: osmux: Use osmo_sockaddr wherever possible ...................................................................... osmux: Use osmo_sockaddr wherever possible This cleans up all the code, and makes it a lot easier to add IPv6 support later on (mostly only a matter of adding an IPv6 bind address in VTY). Similar changes were done to the Osmux code being added to osmo-bts. Related: SYS#5987 Change-Id: I5a100fc654f88d29b2bcd85889a5a92aef3d576d --- M include/osmocom/mgcp/osmux.h M src/libosmo-mgcp/mgcp_osmux.c 2 files changed, 59 insertions(+), 55 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/09/29309/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I5a100fc654f88d29b2bcd85889a5a92aef3d576d Gerrit-Change-Number: 29309 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: Add Osmux support on the Abis-side data plane

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/29007 to look at the new patch set (#3). Change subject: Add Osmux support on the Abis-side data plane ...................................................................... Add Osmux support on the Abis-side data plane Related: SYS#5987 Change-Id: I48483b278ff829ee29d3e7fbcab0dd3a54728825 --- M TODO-RELEASE M include/osmocom/bsc/bts.h M include/osmocom/bsc/lchan.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_vty.c M src/osmo-bsc/lchan_rtp_fsm.c 7 files changed, 111 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/29007/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I48483b278ff829ee29d3e7fbcab0dd3a54728825 Gerrit-Change-Number: 29007 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-bsc[master]: Add Osmux support on the Abis-side data plane

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29007 ) Change subject: Add Osmux support on the Abis-side data plane ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29007 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I48483b278ff829ee29d3e7fbcab0dd3a54728825 Gerrit-Change-Number: 29007 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 09 Sep 2022 16:08:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-smlc[master]: Add git-review config

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/29314 ) Change subject: Add git-review config ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/29314 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ia16bb7936e9382dcc51d9122bd7582d75eb7ae15 Gerrit-Change-Number: 29314 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 09 Sep 2022 16:04:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-mgw[master]: osmux: don't store conn ptr inside shared osmux_handle

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29318 ) Change subject: osmux: don't store conn ptr inside shared osmux_handle ...................................................................... osmux: don't store conn ptr inside shared osmux_handle The struct osmux_handle is a shared structure which goes together 1-1 with libosmo-netif's struct osmux_in_handle, which is common to all CIDs to be muxed together. Hence, it makes no sense to store a specific conn object to it, since it actually manages several of them. Hence, all the conn specific stuff must be handled beforehand, not at osmux deliver time. Related: SYS#5987 Change-Id: Ie739b556e9eb7d3133e798831a09728c7cc87135 --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/18/29318/1 diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index d9bccb4..f72af81 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -36,7 +36,6 @@ struct osmux_handle { struct llist_head head; - struct mgcp_conn_rtp *conn; struct osmux_in_handle *in; struct osmo_sockaddr rem_addr; int refcnt; @@ -48,14 +47,8 @@ static void osmux_deliver_cb(struct msgb *batch_msg, void *data) { struct osmux_handle *handle = data; - struct mgcp_conn_rtp *conn = handle->conn; socklen_t dest_len; - if (!conn->end.output_enabled) { - msgb_free(batch_msg); - return; - } - switch (handle->rem_addr.u.sa.sa_family) { case AF_INET6: dest_len = sizeof(handle->rem_addr.u.sin6); @@ -130,7 +123,6 @@ h = talloc_zero(osmux, struct osmux_handle); if (!h) return NULL; - h->conn = conn; h->rem_addr = *rem_addr; h->refcnt++; @@ -192,6 +184,9 @@ int ret; struct msgb *msg; + if (!conn->end.output_enabled) + return -1; + if (conn->osmux.state != OSMUX_STATE_ENABLED) { LOGPCONN(conn->conn, DOSMUX, LOGL_INFO, "forwarding RTP to Osmux conn not yet enabled, dropping (cid=%d)\n", conn->osmux.cid); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ie739b556e9eb7d3133e798831a09728c7cc87135 Gerrit-Change-Number: 29318 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 9 months

1
0
0 0

Change in osmo-smlc[master]: Set working directory in systemd service file

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-smlc/+/29317 ) Change subject: Set working directory in systemd service file ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-smlc/+/29317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-smlc Gerrit-Branch: master Gerrit-Change-Id: Ie8b014e8eac23221a6a7087bb2b886014323680b Gerrit-Change-Number: 29317 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 09 Sep 2022 15:59:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-sip-connector[master]: Set working directory in systemd service file

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/29316 ) Change subject: Set working directory in systemd service file ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Idad82186d6ef7f00487cf162306b0733886fc129 Gerrit-Change-Number: 29316 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 09 Sep 2022 15:59:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-pcap[master]: Set working directory in systemd service file

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/29315 ) Change subject: Set working directory in systemd service file ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/29315 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I39c48167cbe74b599c8edc3659e787792cbcfdfd Gerrit-Change-Number: 29315 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 09 Sep 2022 15:56:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-uecups[master]: Add git-review config

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/29313 ) Change subject: Add git-review config ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/29313 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I7b822474d554e822fb13d9953e4c6959097a6293 Gerrit-Change-Number: 29313 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 09 Sep 2022 15:37:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022