September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: bsc: Add testscase & infra to validate Osmux support BTS<->BSC

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 ) Change subject: bsc: Add testscase & infra to validate Osmux support BTS<->BSC ...................................................................... Patch Set 8: (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010/comment/ea61c0b9_267a… PS8, Line 1278: osmux on This breaks -latest and -2022qX jobs, because there is no such command. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29010 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6e82eb9d995de988b812001e1c4cf6923509de66 Gerrit-Change-Number: 29010 Gerrit-PatchSet: 8 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Sep 2022 06:54:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in docker-playground[master]: ttcn3-bts: Add osmux configurations

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29338 ) Change subject: ttcn3-bts: Add osmux configurations ...................................................................... Patch Set 2: (2 comments) File ttcn3-bts-test/jenkins.sh: https://gerrit.osmocom.org/c/docker-playground/+/29338/comment/bf8c68ee_c69… PS2, Line 148: image_suffix_is_latest I am not 100% sure, but this is not going to work for Centos jobs, which may have IMAGE_SUFFIX like '2022q2-centos8'. https://gerrit.osmocom.org/c/docker-playground/+/29338/comment/3909ec05_f59… PS2, Line 149: logging level osmux info There is no such line in osmo-bts.gen.cfg, am I wrong? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29338 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I185b77eb4fa05501f098d89b80b66168349175bb Gerrit-Change-Number: 29338 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 14 Sep 2022 05:38:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in pysim[master]: Revert "contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5"

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/29276 ) Change subject: Revert "contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5" ...................................................................... Revert "contrib/jenkins.sh: pylint v2.15 is unstable, pin v2.14.5" This reverts commit 12175d358850cfbfe40c060292d8273cabc23cbc. The upstream has fixed the regression: https://github.com/PyCQA/pylint/issues/7375 which was actually not in pylint itself but in its dependency: https://github.com/PyCQA/astroid/pull/1763 https://github.com/PyCQA/astroid/releases/tag/v2.12.6 Change-Id: I1bf36e0c6db14a10ff4eab57bae238401dbd7fd0 Closes: OS#5668 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: neels: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index a061c7e..fbcd73c 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -26,7 +26,7 @@ # Ignore E0401: import-error # pySim/utils.py:276: E0401: Unable to import 'Crypto.Cipher' (import-error) # pySim/utils.py:277: E0401: Unable to import 'Crypto.Util.strxor' (import-error) -pip install pylint==2.14.5 # FIXME: 2.15 is crashing, see OS#5668 +pip install pylint python -m pylint -j0 --errors-only \ --disable E1102 \ --disable E0401 \ -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29276 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I1bf36e0c6db14a10ff4eab57bae238401dbd7fd0 Gerrit-Change-Number: 29276 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-msc[master]: After RX of an SMPP Submit, send the SMS we just received.

by neels

Attention is currently required from: keith. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28342 ) Change subject: After RX of an SMPP Submit, send the SMS we just received. ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: is this essentially bypassing the SMS queue? Each incoming SMS gets sent immediately? (I know the sms queue in osmo-msc is a strange beast) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9af51ef0d9c2e6c5acc5128efd6195df881b680c Gerrit-Change-Number: 28342 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 13 Sep 2022 21:59:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in libsmpp34[master]: binaries/Makefile: s/INCLUDES/AM_CPPFLAGS/

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libsmpp34/+/29081 ) Change subject: binaries/Makefile: s/INCLUDES/AM_CPPFLAGS/ ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: looks perfectly good, but apparently the build is broken by this? -- To view, visit https://gerrit.osmocom.org/c/libsmpp34/+/29081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerrit-Change-Id: I9343f53c125be8e4c7590164a8541d9fe114deb5 Gerrit-Change-Number: 29081 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 21:50:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-msc[master]: Make esme struct shared

by neels

Attention is currently required from: laforge, pespin, msuraev, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 ) Change subject: Make esme struct shared ...................................................................... Patch Set 20: (2 comments) File include/osmocom/smpp/smpp.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/a92f05af_e8da2e61 PS19, Line 14: struct esme { > prefer 'struct smpp_esme' since it is from smpp. […] does that mean you disagree here? File include/osmocom/smpp/smpp_smsc.h: https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/b06a9b74_d636e9bd PS19, Line 32: struct esme *esme; > Hi Neels, it's fine the way the patch is now, I actually pointed towards the current directon, since […] there is a point at which hiding struct details is more of a hindrance than helping. When a struct is not public API of a library, IMHO it is better to openly share the structs than using opaque structs with tons of functions for every struct access, and dynamic allocations that cannot be optimized by the compiler. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70 Gerrit-Change-Number: 28846 Gerrit-PatchSet: 20 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 21:43:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Improve logging around hnb_context and sctp conn lifecycle

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29337 ) Change subject: Improve logging around hnb_context and sctp conn lifecycle ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-hnbgw/hnbgw.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29337/comment/2e270566_b9f8fbf3 PS1, Line 264: LOGL_ERROR is this really an ERROR? -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I44c79d86924ead84246b3d4937a6becae5d29185 Gerrit-Change-Number: 29337 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 21:38:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: hnb_context_release(): Make sure assigned conn is freed

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336 ) Change subject: hnb_context_release(): Make sure assigned conn is freed ...................................................................... Patch Set 1: Code-Review+1 (5 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336/comment/a66199dc_88ac2030 PS1, Line 13: life life is life? https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336/comment/fa35410a_db07b3f5 PS1, Line 14: synchronous isn't release always async, because it involves messages to/from remote? File src/osmo-hnbgw/hnbgw.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336/comment/b6f592a2_76d82cb4 PS1, Line 304: return 0; /* hnb_context is being freed, nothing do be done */ (i thought now it is just hnb->hnb_registered == false?) ("hnb_context is being freed" seems inaccurate, the hnb already *is* NULL, long gone) https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336/comment/a2685d20_29cafd22 PS1, Line 306: /* hnb: conn became broken, let's release the associated hnb. maybe "conn closed on an active hnb_context" ... then again, if hnb_registered == false then this could be the usual code path, i.e. neither broken nor still active? https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336/comment/5aeabc6c_fb836877 PS1, Line 374: to call calling -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29336 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I44fea7ec74f14e0458861c92da4acf685ff695c1 Gerrit-Change-Number: 29336 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 21:37:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Don't permit anything but HNB (de)registration until HNB is registered

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 ) Change subject: Don't permit anything but HNB (de)registration until HNB is registered ...................................................................... Patch Set 3: (1 comment) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334/comment/2d5b462e_1b5bb7ba PS3, Line 550: } I'd prefer exit-early here instead of else {... This should also make the patch easier to read, avoiding indenting the entire block -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29334 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Iaa62ce89f4ffbff868309bfb8b1df7ebcca5c44a Gerrit-Change-Number: 29334 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 21:10:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-hnbgw[master]: Don't process RUA messages if HNB is not registered

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29333 ) Change subject: Don't process RUA messages if HNB is not registered ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I85442e8adfefadc3bf3ed795eaef7677eb0b36e9 Gerrit-Change-Number: 29333 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Sep 2022 21:08:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022