August 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD

by msuraev

Attention is currently required from: neels. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 to look at the new patch set (#7). Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD Limit length of optional Data parameter is 130 bytes according to ITU-T Rec Q.713 §4.2..§4.5. If we receive CR, CC or RLSD message with bigger data - cache it if necessary and send via separate DT1 message after connection becomes active. While at it, clarify the order of comments in the encoding routine to match the spec. Fixes: OS#5579 Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a --- M src/sccp_scoc.c 1 file changed, 131 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/84/29084/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR and CC

by msuraev

Attention is currently required from: neels. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR and CC ...................................................................... Patch Set 6: (14 comments) This change is ready for review. File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/52a2d23a_0f5b8ac5 PS6, Line 675: ional: import > unrelated change? I think it's related: we arrange comments to match the sequence of message parts. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/fe3442cf_63806b97 PS6, Line 104: uint8_t opt_data_len; > please store a msgb with the data to be cached. […] I don't think it's worth it bothering with dynamic allocation for overhead of 2.5Mb per 10k connections but ok. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/a60f79d3_14b207b2 PS6, Line 105: int opt_data_cached_from; > opt_data_cached_msgtype ... […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/9bfc7ac9_6bb0e3c7 PS6, Line 106: > if it still needs multiple elements, i would prefer […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/d3877f3b_fb6084e3 PS6, Line 583: /* Cache the optional data (if necessary) and return indication whether cache was used */ > "return true if the data was cached" […] It would create unnecessary inconvenience for the caller. Also, I think it's a bad idea to modify message to-be-sent - I'd rather keep current const to corresponding parameter and avoid unnecessary fiddling with the data. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/f6eddae7_f0388241 PS6, Line 595: void xua_opt_data_clear_cache(struct sccp_connection *conn) > this patch is only editing sccp_scoc. […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/481c4328_582cf55a PS6, Line 619: /* Check optional Data size limit, cache if necessary, return indication whether original data should be sent */ > "return true if..." […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/c92d621b_739e4b4d PS6, Line 633: return !xua_opt_data_cached(conn, prim, msg_type); : break; > drop these two lines, the cases are identical Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/d4bcd1c8_50920ef4 PS6, Line 639: if (msgb_l2len(prim->oph.msg) > SCCP_MAX_OPTIONAL_DATA) { > would prefer if only one function implements the actual length check (code dup) Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/7b193378_296fc679 PS6, Line 641: "dropping optional data with length %u exceeding max of %u according to ITU-T Rec. Q.713 §4.4\n", > dropping? so the data never gets sent? could make sense for a Connection-Refused, but explaining tha […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/56c48d64_b5232bb1 PS6, Line 646: case SUA_CO_RELRE: /* §4.5 Released (RLSD) */ > i think the idea here is to first send a DT1 with the data that is too large and then sending the "e […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/73df0ac0_d51100d2 PS6, Line 986: struct xua_common_hdr hdr = XUA_HDR(SUA_MSGC_CO, SUA_CO_COAK); > only hdr. […] Done https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/7df461c1_54e6f805 PS6, Line 1003: /* N. B: we've ignored CREF sending errors as there's no recovery option anyway */ > "COREF" ? […] Why unrelated? It's certainly worth it to explain why in the above case we use cache while in here we don't. https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/802dad94_deceb681 PS6, Line 1027: xua_opt_data_clear_cache(conn); > seems that this cleanup should be done in the fsm's cleanup() cb and in the IDLE stat's onenter() fu […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 6 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 12:57:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-hnbgw in openSUSE_Factory_ARM/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-hnbgw failed to build in openSUSE_Factory_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnbgw Last lines of build log: [ 45s] Provides: config(osmo-hnbgw) = 1.3.0.17.9f65.202208210052-1.1 osmo-hnbgw = 1.3.0.17.9f65.202208210052-1.1 osmo-hnbgw(armv7hl-32) = 1.3.0.17.9f65.202208210052-1.1 [ 45s] Requires(interp): /bin/sh /bin/sh /bin/sh /bin/sh [ 45s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 45s] Requires(pre): /bin/sh systemd [ 45s] Requires(post): /bin/sh systemd [ 45s] Requires(preun): /bin/sh systemd [ 45s] Requires(postun): /bin/sh systemd [ 45s] Requires: ld-linux-armhf.so.3 ld-linux-armhf.so.3(GLIBC_2.4) libasn1c.so.1 libc.so.6 libc.so.6(GLIBC_2.34) libc.so.6(GLIBC_2.4) libgcc_s.so.1 libgcc_s.so.1(GCC_3.5) libosmo-hnbap.so.0 libosmo-mgcp-client.so.9 libosmo-ranap.so.5 libosmo-rua.so.0 libosmo-sigtran.so.7 libosmocore.so.19 libosmoctrl.so.0 libosmoctrl.so.0(LIBOSMOCTRL_1.0) libosmogsm.so.18 libosmogsm.so.18(LIBOSMOGSM_1.0) libosmonetif.so.8 libosmovty.so.9 libtalloc.so.2 libtalloc.so.2(TALLOC_2.0.2) [ 45s] Processing files: osmo-hnbgw-debugsource-1.3.0.17.9f65.202208210052-1.1.armv7hl [ 45s] Provides: osmo-hnbgw-debugsource = 1.3.0.17.9f65.202208210052-1.1 osmo-hnbgw-debugsource(armv7hl-32) = 1.3.0.17.9f65.202208210052-1.1 [ 45s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 45s] Processing files: osmo-hnbgw-debuginfo-1.3.0.17.9f65.202208210052-1.1.armv7hl [ 45s] Provides: debuginfo(build-id) = 5db072b49dc4a00a7ac3ddde996f068bb92b6b26 osmo-hnbgw-debuginfo = 1.3.0.17.9f65.202208210052-1.1 osmo-hnbgw-debuginfo(armv7hl-32) = 1.3.0.17.9f65.202208210052-1.1 [ 45s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 45s] Recommends: osmo-hnbgw-debugsource(armv7hl-32) = 1.3.0.17.9f65.202208210052-1.1 [ 45s] Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/abuild/rpmbuild/BUILDROOT/osmo-hnbgw-1.3.0.17.9f65.202208210052-1.1.arm [ 45s] error: Installed (but unpackaged) file(s) found: [ 45s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 45s] [ 45s] RPM build errors: [ 45s] Installed (but unpackaged) file(s) found: [ 45s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 45s] ### VM INTERACTION START ### [ 45s] [ 36.748050][ T1] sysrq: Power Off [ 45s] [ 36.765243][ T16] reboot: Power down [ 45s] ### VM INTERACTION END ### [ 45s] [ 45s] obs-arm-11 failed "build osmo-hnbgw.spec" at Sun Aug 21 12:51:10 UTC 2022. [ 45s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-hnbgw in openSUSE_Factory_ARM/aarch64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-hnbgw failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-hnbgw Last lines of build log: [ 33s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 33s] Requires(pre): /bin/sh systemd [ 33s] Requires(post): /bin/sh systemd [ 33s] Requires(preun): /bin/sh systemd [ 33s] Requires(postun): /bin/sh systemd [ 33s] Requires: ld-linux-aarch64.so.1()(64bit) ld-linux-aarch64.so.1(GLIBC_2.17)(64bit) libasn1c.so.1()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.17)(64bit) libc.so.6(GLIBC_2.34)(64bit) libosmo-hnbap.so.0()(64bit) libosmo-mgcp-client.so.9()(64bit) libosmo-ranap.so.5()(64bit) libosmo-rua.so.0()(64bit) libosmo-sigtran.so.7()(64bit) libosmocore.so.19()(64bit) libosmoctrl.so.0()(64bit) libosmoctrl.so.0(LIBOSMOCTRL_1.0)(64bit) libosmogsm.so.18()(64bit) libosmogsm.so.18(LIBOSMOGSM_1.0)(64bit) libosmonetif.so.8()(64bit) libosmovty.so.9()(64bit) libtalloc.so.2()(64bit) libtalloc.so.2(TALLOC_2.0.2)(64bit) [ 33s] Processing files: osmo-hnbgw-debugsource-1.3.0.17.9f65.202208210052-1.1.aarch64 [ 33s] Provides: osmo-hnbgw-debugsource = 1.3.0.17.9f65.202208210052-1.1 osmo-hnbgw-debugsource(aarch-64) = 1.3.0.17.9f65.202208210052-1.1 [ 33s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 33s] Processing files: osmo-hnbgw-debuginfo-1.3.0.17.9f65.202208210052-1.1.aarch64 [ 33s] Provides: debuginfo(build-id) = 4ca1ae0f813aafd97e17ba6c2c8f58ce0269ca1e osmo-hnbgw-debuginfo = 1.3.0.17.9f65.202208210052-1.1 osmo-hnbgw-debuginfo(aarch-64) = 1.3.0.17.9f65.202208210052-1.1 [ 33s] Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 [ 33s] Recommends: osmo-hnbgw-debugsource(aarch-64) = 1.3.0.17.9f65.202208210052-1.1 [ 33s] Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/abuild/rpmbuild/BUILDROOT/osmo-hnbgw-1.3.0.17.9f65.202208210052-1.1.aarch64 [ 33s] error: Installed (but unpackaged) file(s) found: [ 33s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 33s] [ 33s] RPM build errors: [ 33s] Installed (but unpackaged) file(s) found: [ 33s] /usr/share/doc/packages/osmo-hnbgw/examples/osmo-hnbgw/osmo-hnbgw-pfcp.cfg [ 33s] ### VM INTERACTION START ### [ 33s] mount: /: mount point is busy. [ 33s] Warning: 'remount -o ro /' failed. Triple Syncing.. [ 33s] [ 27.696636][ T1] sysrq: Power Off [ 33s] [ 27.697056][ T16] reboot: Power down [ 33s] ### VM INTERACTION END ### [ 33s] [ 33s] obs-arm-10 failed "build osmo-hnbgw.spec" at Sun Aug 21 12:50:52 UTC 2022. [ 33s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

Change in pysim[master]: proactive: Avoid clobbering the output of the command that triggered ...

by fixeria

Attention is currently required from: laforge, Christian Amsüss. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29066 ) Change subject: proactive: Avoid clobbering the output of the command that triggered the FETCH ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2b794a5c5bc808b9703b4bc679c119341a0ed41c Gerrit-Change-Number: 29066 Gerrit-PatchSet: 2 Gerrit-Owner: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Comment-Date: Sun, 21 Aug 2022 12:27:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in pysim[master]: proactive: Send a Terminal Response automatically after a Fetch

by laforge

Attention is currently required from: Christian Amsüss. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29067 ) Change subject: proactive: Send a Terminal Response automatically after a Fetch ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I43bc994e7517b5907fb40a98d84797c54056c47d Gerrit-Change-Number: 29067 Gerrit-PatchSet: 2 Gerrit-Owner: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Comment-Date: Sun, 21 Aug 2022 11:57:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in pysim[master]: Add new pySim.ota library, implement SIM OTA crypto

by laforge

Attention is currently required from: laforge, pespin, Christian Amsüss, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29033 ) Change subject: Add new pySim.ota library, implement SIM OTA crypto ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: so somewhere in the changes from 5 -> 7 we have a regression in the command encoding. I yet have to figure out where this is coming from. I don't see any changes other than the PCNT? ====================================================================== FAIL: test_cmd_3des_ciphered (test_ota.Test_SMS_3DES) ---------------------------------------------------------------------- Traceback (most recent call last): File "/space/home/laforge/projects/git/pysim/tests/test_ota.py", line 71, in test_cmd_3des_ciphered self.assertEqual(b2h(r), '00180d04193535b000000c8478b552a4ffc5a8f099b83cad7123') AssertionError: '00180d04193535b00000e3ec80a849b554421276af3883927c20' != '00180d04193535b000000c8478b552a4ffc5a8f099b83cad7123' - 00180d04193535b00000e3ec80a849b554421276af3883927c20 + 00180d04193535b000000c8478b552a4ffc5a8f099b83cad7123 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84 Gerrit-Change-Number: 29033 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 11:53:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in pysim[master]: Add new pySim.ota library, implement SIM OTA crypto

by laforge

Attention is currently required from: pespin, Christian Amsüss, dexter. Hello Jenkins Builder, pespin, Christian Amsüss, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/29033 to look at the new patch set (#7). Change subject: Add new pySim.ota library, implement SIM OTA crypto ...................................................................... Add new pySim.ota library, implement SIM OTA crypto This introduces a hierarchy of classes implementing * ETS TS 102 225 (general command structure) * 3GPP TS 31.115 (dialects for SMS-PP) In this initial patch only the SMS "dialect" is supported, but it is foreseen that USSD/SMSCB/HTTPS dialects can be added at a later point. Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84 --- M contrib/jenkins.sh A pySim/ota.py A pySim/sms.py M requirements.txt M setup.py A tests/test_ota.py 6 files changed, 585 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/33/29033/7 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84 Gerrit-Change-Number: 29033 Gerrit-PatchSet: 7 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in pysim[master]: Add new pySim.ota library, implement SIM OTA crypto

by laforge

Attention is currently required from: pespin, Christian Amsüss, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/29033 ) Change subject: Add new pySim.ota library, implement SIM OTA crypto ...................................................................... Patch Set 6: (9 comments) File pySim/ota.py: https://gerrit.osmocom.org/c/pysim/+/29033/comment/57493321_f2f0ac00 PS4, Line 44: S 102 225 Table 5 : ota_status_codes = bidict({ : 0x00: 'PoR OK', : 0x01: 'RC/CC/DS failed', : 0x02: 'CNTR low', : 0x03: 'CNTR high', : 0x04: 'CNTR blocked', : 0x05: 'Ciphering error', : 0x06: 'Unidentified security error', : 0x07: 'Insufficient memory', : 0x08: 'more time', : 0x09: 'TAR unknown', : 0x0a: 'Insufficient security level', : 0x0b: 'Actual Response in SMS-SUBMIT', # 31.115 : 0x0c: 'Actual Response in USSD', # 31.115 : }) > This bidict is redundant with ResponseStatus, and not used anywhere. […] yes, that can be removed. It goes back to some very old first attempts of implementing this months if not years ago. https://gerrit.osmocom.org/c/pysim/+/29033/comment/dcfd2648_d6a0b5e4 PS4, Line 120: algo_auth: str, kid_idx: int, kid: bytes, cntr: int = 0): > I'm very suspicious of the counter having zero as a default; the symmetric algorithm is already init […] I understand the point. the rationale here was that in 99% of all current use cases we won't be using the counter, as we don't have any central database/backend where we would store the current per-card OTA counter. Also, 99% of the sysmoISIM-SJA2 users (which are probably >95% of our overall user base for this feature) have cards with a MSL not requiring counters, as they are used in a research/development setting and if you have multiple different programs talking OTA over time without any centralized counter storage... File pySim/ota.py: https://gerrit.osmocom.org/c/pysim/+/29033/comment/ac77469f_e7816b5b PS5, Line 347: apdu += otak.crypt._get_padding(len_cipher, otak.crypt.blocksize) > This should also set pad_cnt. […] your patch was cherry-picked + squashed, thanks. https://gerrit.osmocom.org/c/pysim/+/29033/comment/ebf6a889_70f16a20 PS5, Line 402: def decode_resp(self, otak: OtaKeyset, spi: dict, data: bytes) -> bytes: > `-> bytes` is currently inaccurate, should be `CompactRemoteResp` (but see below) Done https://gerrit.osmocom.org/c/pysim/+/29033/comment/934b91bf_385bd7e8 PS5, Line 416: res = self.SmsResponsePacket.parse(remainder) > Do we trust this parsing step enought, to […] I'm not sure I understand you here. Why would it be bad if that call would raise some exception, which in turn propagetes further upt to the caller of decode_resp() ? https://gerrit.osmocom.org/c/pysim/+/29033/comment/c79cdf29_b9e4bdb9 PS5, Line 443: cc = otak.auth.check_sig(temp_data, res['cc_rc']) > Needless assign; check_sig is merely called for the exception it'd raise. ack, fixing it in my next version. https://gerrit.osmocom.org/c/pysim/+/29033/comment/85d113f1_874c01f6 PS5, Line 452: return dec > There will need to be an API change later here, as in cases of `res. […] Done File pySim/sms.py: https://gerrit.osmocom.org/c/pysim/+/29033/comment/a109665c_65c7f816 PS5, Line 30: ie_c = Struct('offset'/Tell, 'iei'/Int8ub, 'length'/Int8ub, 'data'/Bytes(this.length)) > There is an updated version of this in your patch series, which is easier to understand and removes […] updated version pushed. https://gerrit.osmocom.org/c/pysim/+/29033/comment/00bc2456_49a7dd02 PS5, Line 39: def __str__(self) -> str: > I think this would be more useful as `__repr__`, especially as it does produce an expression that'd […] squashed your related patch into my patch -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84 Gerrit-Change-Number: 29033 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sun, 21 Aug 2022 11:34:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in pysim[master]: Add new pySim.ota library, implement SIM OTA crypto

by laforge

Attention is currently required from: laforge, pespin, dexter. Hello Jenkins Builder, pespin, Christian Amsüss, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/29033 to look at the new patch set (#6). Change subject: Add new pySim.ota library, implement SIM OTA crypto ...................................................................... Add new pySim.ota library, implement SIM OTA crypto This introduces a hierarchy of classes implementing * ETS TS 102 225 (general command structure) * 3GPP TS 31.115 (dialects for SMS-PP) In this initial patch only the SMS "dialect" is supported, but it is foreseen that USSD/SMSCB/HTTPS dialects can be added at a later point. Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84 --- M contrib/jenkins.sh A pySim/ota.py A pySim/sms.py M requirements.txt M setup.py A tests/test_ota.py 6 files changed, 603 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/33/29033/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I193ff4712c8503279c017b4b1324f0c3d38b9f84 Gerrit-Change-Number: 29033 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Christian Amsüss <chrysn(a)fsfe.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022