lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

August 2022

  • 3 participants
  • 2402 discussions
Change in osmo-ci[master]: obs/lib/config.py: add osmo-upf
by neels 25 Aug '22

25 Aug '22
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29208 ) Change subject: obs/lib/config.py: add osmo-upf ...................................................................... obs/lib/config.py: add osmo-upf Depends: libosmo-pfcp 0.1.2 I6ae6cf59e769214e11447107316d38fe5fad583d Depends: osmo-upf 0.1.1 I1d73255f8cc30feabd3c251bdc3af1682ed4694a Change-Id: Ia65508eaf241b799b5d4b1b81eebdeaa40f4381e --- M scripts/obs/lib/config.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/scripts/obs/lib/config.py b/scripts/obs/lib/config.py index bb8955d..1e569ef 100644 --- a/scripts/obs/lib/config.py +++ b/scripts/obs/lib/config.py @@ -77,6 +77,7 @@ "osmo-sysmon", "osmo-trx", "osmo-uecups", + "osmo-upf", "python/osmo-python-tests", "rtl-sdr", "simtrace2", -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia65508eaf241b799b5d4b1b81eebdeaa40f4381e Gerrit-Change-Number: 29208 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in osmo-ci[master]: obs/lib/config.py: add osmo-upf
by osmith 25 Aug '22

25 Aug '22
Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29208 ) Change subject: obs/lib/config.py: add osmo-upf ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia65508eaf241b799b5d4b1b81eebdeaa40f4381e Gerrit-Change-Number: 29208 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Aug 2022 14:00:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ci[master]: obs/lib/config.py: add osmo-upf
by osmith 25 Aug '22

25 Aug '22
Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29208 ) Change subject: obs/lib/config.py: add osmo-upf ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia65508eaf241b799b5d4b1b81eebdeaa40f4381e Gerrit-Change-Number: 29208 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 25 Aug 2022 13:59:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ci[master]: obs/lib/config.py: add osmo-upf
by neels 25 Aug '22

25 Aug '22
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29208 ) Change subject: obs/lib/config.py: add osmo-upf ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia65508eaf241b799b5d4b1b81eebdeaa40f4381e Gerrit-Change-Number: 29208 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 25 Aug 2022 13:58:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: hnbap: Use protocolExtensions := * in tr and omit in ts templates
by daniel 25 Aug '22

25 Aug '22
daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29206 ) Change subject: hnbap: Use protocolExtensions := * in tr and omit in ts templates ...................................................................... hnbap: Use protocolExtensions := * in tr and omit in ts templates Change-Id: Ic8f9afc9d74507f7d73f52cefc92ed1c2dc4b1bc --- M hnbgw/HNBGW_Tests.ttcn M library/hnbap/HNBAP_Templates.ttcn 2 files changed, 62 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index d3d3a36..b440292 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -638,7 +638,7 @@ { timer T := 2.0; - HNBAP[hnb_idx].send(tr_HNBAP_HNBRegisterRequest(char2oct("TTCN3 HNodeB"), + HNBAP[hnb_idx].send(ts_HNBAP_HNBRegisterRequest(char2oct("TTCN3 HNodeB"), '00F110'O, int2bit(1 + cell_id, 28), int2oct(2, 2), diff --git a/library/hnbap/HNBAP_Templates.ttcn b/library/hnbap/HNBAP_Templates.ttcn index 0e62291..89edf76 100644 --- a/library/hnbap/HNBAP_Templates.ttcn +++ b/library/hnbap/HNBAP_Templates.ttcn @@ -83,6 +83,66 @@ value_ := { sAC := sac } } }, + protocolExtensions := * + } + } + } +} + +template (value) HNBAP_PDU +ts_HNBAP_HNBRegisterRequest(template (value) octetstring hNB_Identity_Info, + template (value) OCT3 plmnid, + template (value) BIT28 cell_identity, + template (value) OCT2 lac, + template (value) OCT1 rac, + template (value) OCT2 sac) := { + initiatingMessage := { + procedureCode := id_HNBRegister, + criticality := reject, + value_ := { + hNBRegisterRequest := { + protocolIEs := { + { + id := HNBAP_Constants.id_HNB_Identity, + criticality := reject, + value_ := { + hNB_Identity := { + hNB_Identity_Info := hNB_Identity_Info, + iE_Extensions := omit + } + } + }, { + id := 8, + criticality := reject, + value_ := { + hNB_Location_Information := { + macroCoverageInfo := omit, + geographicalCoordinates := omit, + iE_Extensions := omit + } + } + }, { + id := 9, + criticality := reject, + value_ := { pLMNidentity := plmnid } + }, { + id := 11, + criticality := reject, + value_ := { cellIdentity := cell_identity } + }, { + id := 6, + criticality := reject, + value_ := { lAC := lac } + }, { + id := 7, + criticality := reject, + value_ := { rAC := rac } + }, { + id := 10, + criticality := reject, + value_ := { sAC := sac } + } + }, protocolExtensions := omit } } @@ -105,7 +165,7 @@ value_ := { RNC_ID := rnc_id } } }, - protocolExtensions := omit /* TODO: Mux Port Number (optional) 9.2.29 */ + protocolExtensions := * /* TODO: Mux Port Number (optional) 9.2.29 */ } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic8f9afc9d74507f7d73f52cefc92ed1c2dc4b1bc Gerrit-Change-Number: 29206 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged
1 0
0 0
Change in libosmo-sccp[master]: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD
by neels 24 Aug '22

24 Aug '22
Attention is currently required from: fixeria, msuraev. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 ) Change subject: SIGTRAN: cache Optional Data for SCCP CR/CC/RLSD ...................................................................... Patch Set 14: Code-Review-1 (11 comments) Patchset: PS14: (marked less important comments as resolved, right from the start) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/d07fbf8a_7ab12466 PS6, Line 583: /* Cache the optional data (if necessary) and return indication whether cache was used */ > It would create unnecessary inconvenience for the caller. […] you are by definition fiddling with the data when dropping the optional data. ah ok i see, you pass a bool into the encoding function instead of modifying the source message. (I think it's a good idea to modify the message to be sent, plus some other design choices that could be more clear, but i'm bike-shedding) https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/e756994a_deca92c8 PS6, Line 1003: /* N. B: we've ignored CREF sending errors as there's no recovery option anyway */ > Why unrelated? It's certainly worth it to explain why in the above case we use cache while in here w […] (would be nicer to have a separate patch for adding missing comments) File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/a531d541_42daaa19 PS8, Line 659: break > Yes? drop the "break;" File src/sccp_scoc.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/3c0f008d_16bdbde9 PS14, Line 594: sua should this be m3ua? @laforge? https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/a1bf4766_f1391f10 PS14, Line 653: static bool xua_opt_data_length_lim(struct sccp_connection *conn, const struct osmo_scu_prim *prim, int msg_type) (this function is decribed as checking a length and returning a bool, but there is an actual data transmisison triggered in here. It would be good to have a clear name and API comment.) https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/6d7de0c4_b74d1033 PS14, Line 675: There's no need to cache the optional data since the connection is still active at this point (is this comment accurate? i don't understand it... so the situation here is A B ------> DT1 ------> RLSD right? how about "Directly send Optional Data first, if it does not fit in the RLSD msg" ) https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/605c6ef9_1a395e16 PS14, Line 713: /* optional: importance */ (would be nicer to have a separate patch for adding missing comments) https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/4b0eab21_2197bd12 PS14, Line 734: /* optional: importance */ (would be nicer to have a separate patch for adding missing comments) https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/efb08c53_8a3dfae9 PS14, Line 789: /* optional: importance */ (would be nicer to have a separate patch for adding missing comments) https://gerrit.osmocom.org/c/libosmo-sccp/+/29084/comment/0b91622a_b0ab061a PS14, Line 1110: xua_opt_data_send_cache(conn, SUA_CO_CORE, xua->hdr.msg_class); I think this is mixed up somehow. This is about too much data in the Connection Request. It should be: A B ------> Conn Req (cache Optional Data) <------ Conn Conf ------> DT1 with cached data This code here looks like A B ------> Conn Req <------ DT1 with cached data (there is no cached data??) <------ Conn Conf -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29084 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I0033faf9da393418930252233ce74d62cd1cef8a Gerrit-Change-Number: 29084 Gerrit-PatchSet: 14 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Wed, 24 Aug 2022 23:59:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-upf[master]: Allow running without a GTP dev
by neels 24 Aug '22

24 Aug '22
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/29210 ) Change subject: Allow running without a GTP dev ...................................................................... Allow running without a GTP dev Allow running without opening a GTP dev for encapsulation/decapsulation. Probe and open the mnl socket for talking to the GTP kernel module only when actual GTP devices exist in the config. A site that is only doing tunnel proxying via netfilter hence does not require GTP support in the kernel. Change-Id: Ibb79b3ce1906136f77a895ff6f691d72a92c9fb9 --- M include/osmocom/upf/upf_gtp.h M src/osmo-upf/osmo_upf_main.c M src/osmo-upf/upf_gtp.c 3 files changed, 8 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/10/29210/1 diff --git a/include/osmocom/upf/upf_gtp.h b/include/osmocom/upf/upf_gtp.h index a67c850..1e0df5e 100644 --- a/include/osmocom/upf/upf_gtp.h +++ b/include/osmocom/upf/upf_gtp.h @@ -69,7 +69,7 @@ int upf_gtp_tun_desc_cmp(const struct upf_gtp_tun_desc *a, const struct upf_gtp_tun_desc *b); -int upf_gtp_genl_open(); +int upf_gtp_genl_ensure_open(); void upf_gtp_genl_close(); int upf_gtp_dev_open(const char *name, bool create_gtp_dev, const char *local_addr, bool listen_for_gtpv0, diff --git a/src/osmo-upf/osmo_upf_main.c b/src/osmo-upf/osmo_upf_main.c index b4888af..65a0e84 100644 --- a/src/osmo-upf/osmo_upf_main.c +++ b/src/osmo-upf/osmo_upf_main.c @@ -331,9 +331,6 @@ } } - if (upf_gtp_genl_open()) - return -1; - if (upf_gtp_devs_open()) return -1; diff --git a/src/osmo-upf/upf_gtp.c b/src/osmo-upf/upf_gtp.c index 6280e45..d75e8d7 100644 --- a/src/osmo-upf/upf_gtp.c +++ b/src/osmo-upf/upf_gtp.c @@ -183,6 +183,12 @@ dev->sgsn_mode = sgsn_mode; + rc = upf_gtp_genl_ensure_open(); + if (rc) { + LOG_GTP_DEV(dev, LOGL_ERROR, "Cannot set up GTP device, failed to open mnl_socket\n"); + return rc; + } + if (listen_for_gtpv0) { rc = osmo_sock_init_osa_ofd(&dev->gtpv0.ofd, SOCK_DGRAM, 0, &dev->gtpv0.local_addr, &any, OSMO_SOCK_F_BIND); @@ -255,13 +261,8 @@ } /* Open an MNL socket which allows to create and remove GTP devices (requires CAP_NET_ADMIN). */ -int upf_gtp_genl_open() +int upf_gtp_genl_ensure_open() { - if (g_upf->gtp.mockup) { - LOGP(DGTP, LOGL_NOTICE, "gtp/mockup active: not opening mnl_socket\n"); - return 0; - } - /* Already open? */ if (g_upf->gtp.nl && g_upf->gtp.genl_id >= 0) return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29210 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ibb79b3ce1906136f77a895ff6f691d72a92c9fb9 Gerrit-Change-Number: 29210 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-upf[master]: drop charts/, duplicated from libosmo-pfcp.git
by neels 24 Aug '22

24 Aug '22
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-upf/+/29211 ) Change subject: drop charts/, duplicated from libosmo-pfcp.git ...................................................................... drop charts/, duplicated from libosmo-pfcp.git When placing libosmo-pfcp in a separate repository, I accidentally duplicated the charts. Since the charts are generally valid for PFCP, libosmo-pfcp is the proper place, not here. Change-Id: I95f11e1525b3bc6b782e5f8aecddea672a104c99 --- M configure.ac M doc/Makefile.am D doc/charts/Makefile.am D doc/charts/pfcp_and_gtp.dot D doc/charts/pfcp_cp_peer_fsm.dot D doc/charts/pfcp_cp_session_fsm.dot D doc/charts/pfcp_heartbeat_fsm.dot D doc/charts/pfcp_overview.dot D doc/charts/pfcp_up_peer_fsm.dot D doc/charts/pfcp_up_session_fsm.dot 10 files changed, 0 insertions(+), 205 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/11/29211/1 diff --git a/configure.ac b/configure.ac index fd5f3fc..f86c0bc 100644 --- a/configure.ac +++ b/configure.ac @@ -206,7 +206,6 @@ doc/Makefile doc/examples/Makefile doc/manuals/Makefile - doc/charts/Makefile contrib/Makefile contrib/systemd/Makefile Makefile) diff --git a/doc/Makefile.am b/doc/Makefile.am index 66103ba..15f36b7 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -1,5 +1,4 @@ SUBDIRS = \ examples \ manuals \ - charts \ $(NULL) diff --git a/doc/charts/Makefile.am b/doc/charts/Makefile.am deleted file mode 100644 index af0736d..0000000 --- a/doc/charts/Makefile.am +++ /dev/null @@ -1,24 +0,0 @@ -msc: \ - $(builddir)/pfcp_msgs.png \ - $(builddir)/pfcp_msgs_gtp.png \ - $(NULL) - -dot: \ - $(builddir)/pfcp_overview.png \ - $(builddir)/pfcp_cp_peer_fsm.png \ - $(builddir)/pfcp_up_peer_fsm.png \ - $(builddir)/pfcp_heartbeat_fsm.png \ - $(builddir)/pfcp_cp_session_fsm.png \ - $(builddir)/pfcp_up_session_fsm.png \ - $(builddir)/pfcp_and_gtp.png \ - $(NULL) - -$(builddir)/%.png: $(srcdir)/%.msc - mscgen -T png -o $@ $< - -$(builddir)/%.png: $(srcdir)/%.dot - dot -Tpng $< > $@ - -.PHONY: poll -poll: - while true; do $(MAKE) msc dot; sleep 1; done diff --git a/doc/charts/pfcp_and_gtp.dot b/doc/charts/pfcp_and_gtp.dot deleted file mode 100644 index 5c160b3..0000000 --- a/doc/charts/pfcp_and_gtp.dot +++ /dev/null @@ -1,20 +0,0 @@ -digraph G { -rankdir=LR -labelloc=t; label="PFCP and GTP" - -SGSN [label="SGSN\n123.44.0.9"] -SGWC [label="SGW-C\n123.44.05"] -subgraph cluster_UPF { - label="OsmoUPF"; - SGWU [label="SGW-U\n123.44.0.6"]; - GTPk [label="kernel GTP\n123.44.0.6"] -} - -SGSN -> SGWC [label="S4\nGTPv2-C"] -SGWC -> SGWU [label="Sxa\nPFCP\nSession Establishment:\n"] -SGSN -> GTPk [label="S4\nGTPv1-U",dir=both] - -MS [label="MS\n192.168.104.176"] -MS -> SGSN [dir=both] - -} diff --git a/doc/charts/pfcp_cp_peer_fsm.dot b/doc/charts/pfcp_cp_peer_fsm.dot deleted file mode 100644 index 101fe07..0000000 --- a/doc/charts/pfcp_cp_peer_fsm.dot +++ /dev/null @@ -1,39 +0,0 @@ -digraph G { -rankdir=TB -labelloc=t; label="PFCP CP peer FSM\nControl Plane side, managing association with remote UP peer" - -cp [label="CP function",shape="box"] - -cp -> WAIT_ASSOC_SETUP_RESP [label="cp_peer_associate()"] - -txrx [label="PFCP socket",shape="box"] -WAIT_ASSOC_SETUP_RESP -> txrx [label="tx_assoc_setup_req()",style=dotted] -txrx -> WAIT_ASSOC_SETUP_RESP [label="EV_RX_ASSOC_SETUP_RESP",style=dotted] -WAIT_ASSOC_SETUP_RESP -> ASSOCIATED [label="Assoc Setup Resp"] - -WAIT_ASSOC_SETUP_RESP -> WAIT_ASSOC_SETUP_RESP [label="retry"] - -heartbeat [label="PFCP heartbeat FSM",shape=box3d] -ASSOCIATED -> heartbeat [label="alloc()",style=dotted] -heartbeat -> ASSOCIATED [label="EV_HEARTBEAT_FAILURE",style=dotted] - -txrx2 [label="PFCP socket",shape="box"] -txrx2 -> ASSOCIATED [label="EV_RX_ASSOC_UPDATE_REQ\n3GPP TS 29.244 6.2.7.3.1",style=dotted] -GRACEFUL_RELEASE -> txrx2 [label="tx_assoc_update_resp()",style=dotted] - -cp_session [label="PFCP CP session FSM",shape=box3d] -cp -> ASSOCIATED [label="cp_peer_session_create()",style=dotted] -ASSOCIATED -> cp_session [label="cp_session_create()",style=dotted] -cp -> cp_session [style=invisible,arrowhead=none] - -ASSOCIATED -> GRACEFUL_RELEASE [label="Association Update\nindicating graceful release"] - -cp -> ASSOCIATED [label="cp_peer_release()",style=dotted] -ASSOCIATED -> term [label="cp_peer_release()\nHeartbeat failure"] - -ASSOCIATED -> WAIT_ASSOC_SETUP_RESP [label="Heartbeat failure"] - -GRACEFUL_RELEASE -> term -term [shape="octagon"] - -} diff --git a/doc/charts/pfcp_cp_session_fsm.dot b/doc/charts/pfcp_cp_session_fsm.dot deleted file mode 100644 index 0319608..0000000 --- a/doc/charts/pfcp_cp_session_fsm.dot +++ /dev/null @@ -1,28 +0,0 @@ -digraph G { -rankdir=TB -labelloc=t; label="PFCP CP session FSM" - -cp [label="CP function",shape=box] -cp -> WAIT_ESTABLISHMENT_RESP [label="cp_session_create(cp_peer)\niff cp_peer in state ASSOCIATED"] - -txrx [label="PFCP socket",shape=box] - -WAIT_ESTABLISHMENT_RESP -> txrx [label="tx_session_est_req()",style=dotted] -txrx -> WAIT_ESTABLISHMENT_RESP [label="EV_RX_SESSION_EST_RESP",style=dotted] - -WAIT_ESTABLISHMENT_RESP -> ESTABLISHED [label="Est Resp"] - -cp -> ESTABLISHED [label="cp_session_modify()",style=dotted] -ESTABLISHED -> WAIT_MODIFICATION_RESP [label="cp_session_modify()"] -WAIT_MODIFICATION_RESP -> txrx [label="tx_session_mod_req()",style=dotted] -txrx -> WAIT_MODIFICATION_RESP [label="EV_RX_SESSION_MOD_RESP",style=dotted,constraint=false] -WAIT_MODIFICATION_RESP -> ESTABLISHED [label="Mod Resp"] - -cp -> ESTABLISHED [label="cp_session_delete()",style=dotted] -ESTABLISHED -> WAIT_DELETION_RESP [label="cp_session_delete()"] -WAIT_DELETION_RESP -> txrx [label="tx_session_del_req()",style=dotted] -txrx -> WAIT_DELETION_RESP [label="EV_RX_SESSION_DEL_RESP",style=dotted,constraint=false] -WAIT_DELETION_RESP -> term -term [shape="octagon"] - -} diff --git a/doc/charts/pfcp_heartbeat_fsm.dot b/doc/charts/pfcp_heartbeat_fsm.dot deleted file mode 100644 index b5b4584..0000000 --- a/doc/charts/pfcp_heartbeat_fsm.dot +++ /dev/null @@ -1,21 +0,0 @@ -digraph G { -rankdir=TB -labelloc=t; label="PFCP heartbeat FSM" - -peer [label="PFCP CP/UP peer FSM",shape=box3d] -txrx [label="PFCP socket",shape=box] - -peer -> IDLE [label="alloc()"] -IDLE -> WAIT_HEARTBEAT_RESP -> IDLE -WAIT_HEARTBEAT_RESP -> term -term [shape="octagon"] - -WAIT_HEARTBEAT_RESP -> txrx [label="tx_heartbeat_req()",style=dotted] -txrx -> WAIT_HEARTBEAT_RESP [label="HEARTBEAT_EV_RX_RESP",style=dotted] - -term -> peer [label="PEER_EV_HEARTBEAT_FAILURE",style=dotted] - -txrx2 [label="PFCP socket",shape=box] -txrx2 -> txrx2 [label="rx Heartbeat Req\ntx Heartbeat Resp",style=dotted] - -} diff --git a/doc/charts/pfcp_overview.dot b/doc/charts/pfcp_overview.dot deleted file mode 100644 index 33fa9a0..0000000 --- a/doc/charts/pfcp_overview.dot +++ /dev/null @@ -1,23 +0,0 @@ -digraph G { -rankdir=TB -labelloc=t; label="PFCP Overview\n3GPP TS 29.244 3.1, 5.8.1" - -subgraph cluster_N1_CP { - label="Node: Control Plane function";style=dotted - N1_E_CP [label="CP Entity"] -} - -subgraph cluster_N2_UP { - label="Node: User Plane function\nNode ID: my-userplane.com\n(FQDN may provide multiple PFCP Entities)";style=dotted - N2_E_UP [label="UP Entity\n8.7.6.1"] - N2_E_UP2 [label="UP Entity\n8.7.6.2"] -} - -subgraph cluster_N3_UP { - label="Node: User Plane function\nNode ID: 1.2.3.4\n(IP address means only one PFCP Entity)";style=dotted - N3_E_UP [label="UP Entity\n1.2.3.4\n(osmo-upf)"] -} - -N1_E_CP -> N3_E_UP [label="PFCP Request"] -N1_E_CP -> N2_E_UP -} diff --git a/doc/charts/pfcp_up_peer_fsm.dot b/doc/charts/pfcp_up_peer_fsm.dot deleted file mode 100644 index 60152f7..0000000 --- a/doc/charts/pfcp_up_peer_fsm.dot +++ /dev/null @@ -1,27 +0,0 @@ -digraph G { -rankdir=TB -labelloc=t; label="PFCP UP peer FSM\nUser Plane side, managing association with remote CP peer" - -txrx [label="PFCP socket",shape="box"] - -txrx -> NOT_ASSOCIATED [label="rx PFCP msg from\nnew remote IP"] -txrx -> NOT_ASSOCIATED [label="EV_RX_ASSOC_SETUP_REQ",style=dotted] - -NOT_ASSOCIATED -> ASSOCIATED [label="Assoc Setup Req",shape="box"] - -heartbeat [label="PFCP heartbeat FSM",shape=box3d] -ASSOCIATED -> heartbeat [label="alloc()",style=dotted] -heartbeat -> ASSOCIATED [label="EV_HEARTBEAT_FAILURE",style=dotted] - -txrx -> ASSOCIATED [label="EV_RX_SESSION_EST_REQ",style=dotted] -up_session [label="PFCP UP session FSM",shape=box3d] -ASSOCIATED -> up_session [label="up_session_create()",style=dotted] - -txrx -> ASSOCIATED [label="EV_RX_ASSOC_UPD_REQ",style=dotted] -ASSOCIATED -> GRACEFUL_RELEASE [label="Association Update\nindicating graceful release"] - -ASSOCIATED -> term [label="Heartbeat failure"] -GRACEFUL_RELEASE -> term -term [shape="octagon"] - -} diff --git a/doc/charts/pfcp_up_session_fsm.dot b/doc/charts/pfcp_up_session_fsm.dot deleted file mode 100644 index b4a06f5..0000000 --- a/doc/charts/pfcp_up_session_fsm.dot +++ /dev/null @@ -1,21 +0,0 @@ -digraph G { -rankdir=TB -labelloc=t; label="PFCP UP session FSM" - -peer [label="PFCP UP peer FSM",shape=box3d] -peer -> ESTABLISHED [label="rx_session_est_req()"] - -txrx [label="PFCP socket",shape="box"] -txrx2 [label="PFCP socket",shape="box"] - -txrx -> ESTABLISHED [label="EV_RX_SESSION_MOD_REQ",style=dotted] -ESTABLISHED -> txrx [label="tx_session_mod_resp()",style=dotted,constraint=false] -ESTABLISHED -> ESTABLISHED [label="Mod"] - -txrx2 -> ESTABLISHED [label="EV_RX_SESSION_DEL_REQ",style=dotted] -ESTABLISHED -> txrx2 [label="tx_session_del_resp()",style=dotted,constraint=false] - -ESTABLISHED -> term [label="Deletion"] -term [shape="octagon"] - -} -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29211 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I95f11e1525b3bc6b782e5f8aecddea672a104c99 Gerrit-Change-Number: 29211 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-upf[master]: GTP mockup: list active GTP endecaps actions
by neels 24 Aug '22

24 Aug '22
neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28986 ) Change subject: GTP mockup: list active GTP endecaps actions ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752 Gerrit-Change-Number: 28986 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon
1 0
0 0
Change in osmo-upf[master]: example cfg: tweak logging
by neels 24 Aug '22

24 Aug '22
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/29144 ) Change subject: example cfg: tweak logging ...................................................................... example cfg: tweak logging Related: SYS#5599 Change-Id: I6b767b2e9f023cdbe5d2ea014e2d41878e848d24 --- M doc/examples/osmo-upf/osmo-upf-create-dev.cfg M doc/examples/osmo-upf/osmo-upf-mockup.cfg M doc/examples/osmo-upf/osmo-upf.cfg 3 files changed, 1 insertion(+), 6 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/doc/examples/osmo-upf/osmo-upf-create-dev.cfg b/doc/examples/osmo-upf/osmo-upf-create-dev.cfg index 54ca643..e4e25f9 100644 --- a/doc/examples/osmo-upf/osmo-upf-create-dev.cfg +++ b/doc/examples/osmo-upf/osmo-upf-create-dev.cfg @@ -6,8 +6,7 @@ logging print category-hex 0 logging print file basename last logging print extended-timestamp 1 - logging level set-all info -#logging level set-all debug + logging level set-all notice timer pfcp x24 5000 pfcp diff --git a/doc/examples/osmo-upf/osmo-upf-mockup.cfg b/doc/examples/osmo-upf/osmo-upf-mockup.cfg index e943a57..f1aafa9 100644 --- a/doc/examples/osmo-upf/osmo-upf-mockup.cfg +++ b/doc/examples/osmo-upf/osmo-upf-mockup.cfg @@ -6,9 +6,7 @@ logging print category-hex 0 logging print file basename last logging print extended-timestamp 1 - logging level set-all debug logging level set-all notice - logging level set-all info timer pfcp x24 5000 pfcp diff --git a/doc/examples/osmo-upf/osmo-upf.cfg b/doc/examples/osmo-upf/osmo-upf.cfg index 0f241a5..77b6871 100644 --- a/doc/examples/osmo-upf/osmo-upf.cfg +++ b/doc/examples/osmo-upf/osmo-upf.cfg @@ -6,9 +6,7 @@ logging print category-hex 0 logging print file basename last logging print extended-timestamp 1 - logging level set-all debug logging level set-all notice - logging level set-all info timer pfcp x24 5000 pfcp 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/29144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I6b767b2e9f023cdbe5d2ea014e2d41878e848d24 Gerrit-Change-Number: 29144 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 19
  • 20
  • 21
  • 22
  • 23
  • 24
  • 25
  • ...
  • 241
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.