August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: MSC_Tests: SpeechCodecList IE shall be present in BSSMAP HandoverRequest

by msuraev

Attention is currently required from: osmith, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28920 ) Change subject: MSC_Tests: SpeechCodecList IE shall be present in BSSMAP HandoverRequest ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: While looking tr_BSSMAP_HandoverRequest() in library/BSSMAP_Templates.ttcn I only see encryption-related info. Could you clarify how adding it checks for SpeechCodecList? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28920 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2e0ecbcced9f94d2b44d981db353007cad3ae959 Gerrit-Change-Number: 28920 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 14:42:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-msc[master]: Add ESME-specific logging

by msuraev

Attention is currently required from: pespin, msuraev. Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28845 to look at the new patch set (#12). Change subject: Add ESME-specific logging ...................................................................... Add ESME-specific logging Related: OS#5568 Change-Id: Ie5ddde762350385f8d18ee1d441584a41b0290ec Signed-off-by: Max <msuraev(a)sysmocom.de> --- M include/osmocom/smpp/smpp.h M src/libsmpputil/smpp_msc.c M src/libsmpputil/smpp_smsc.c M src/utils/smpp_mirror.c 4 files changed, 47 insertions(+), 70 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/45/28845/12 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie5ddde762350385f8d18ee1d441584a41b0290ec Gerrit-Change-Number: 28845 Gerrit-PatchSet: 12 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-msc[master]: Introduce libsmpputil

by msuraev

Attention is currently required from: pespin, msuraev. Hello Jenkins Builder, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28844 to look at the new patch set (#12). Change subject: Introduce libsmpputil ...................................................................... Introduce libsmpputil As part of preparation for libosmo-netif migration let's move common SMPP code into separate build-time library and use it for both smpp_mirror and OsmoMSC renaming the files if necessary. While at it we also fix id/password legth limits in smpp_mirror and drop unused fields from ESME struct. Related: OS#5568 Change-Id: I61910651bc7c188dc2fb67d96189a66a47e7e8fb --- M configure.ac M include/osmocom/Makefile.am M include/osmocom/msc/Makefile.am D include/osmocom/msc/smpp.h A include/osmocom/smpp/Makefile.am A include/osmocom/smpp/smpp.h R include/osmocom/smpp/smpp_smsc.h M src/Makefile.am M src/libmsc/Makefile.am M src/libmsc/gsm_04_11.c A src/libsmpputil/Makefile.am R src/libsmpputil/smpp_msc.c R src/libsmpputil/smpp_smsc.c R src/libsmpputil/smpp_utils.c R src/libsmpputil/smpp_vty.c M src/osmo-msc/Makefile.am M src/osmo-msc/msc_main.c M src/utils/Makefile.am M src/utils/smpp_mirror.c M tests/db_sms/Makefile.am M tests/msc_vlr/Makefile.am M tests/smpp/Makefile.am M tests/smpp/smpp_test.c M tests/sms_queue/Makefile.am M tests/stubs.c 25 files changed, 113 insertions(+), 100 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/44/28844/12 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28844 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I61910651bc7c188dc2fb67d96189a66a47e7e8fb Gerrit-Change-Number: 28844 Gerrit-PatchSet: 12 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: cbsp: Fix decoding of Fail List

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28941 ) Change subject: cbsp: Fix decoding of Fail List ...................................................................... Patch Set 2: (1 comment) File src/gsm/cbsp.c: https://gerrit.osmocom.org/c/libosmocore/+/28941/comment/1da1e398_2cdddec3 PS2, Line 546: cur += gsm0808_cell_id_size(ent->id_discr); Before this patch, since cur was not increased as done here, cur was still pointing to one byte before it should in here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I16ed9bd65109a7ce32ff43c5789b4544479838e7 Gerrit-Change-Number: 28941 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 05 Aug 2022 14:29:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: cbsp: Guard against malformed msgb without l1h,l2h being passed

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28940 ) Change subject: cbsp: Guard against malformed msgb without l1h,l2h being passed ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ie8854c780cfd96e67df10c1fc38c6b99ec07422f Gerrit-Change-Number: 28940 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 14:27:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: tests: Run smscb/gsm0341_test during make check

by pespin

Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28939 ) Change subject: tests: Run smscb/gsm0341_test during make check ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icd4feced06afb749de994195c6b338df006749ad Gerrit-Change-Number: 28939 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 14:27:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: tests: Run smscb/gsm0341_test during make check

by pespin

Attention is currently required from: laforge, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28939 ) Change subject: tests: Run smscb/gsm0341_test during make check ...................................................................... Patch Set 3: (1 comment) File tests/smscb/gsm0341_test.c: https://gerrit.osmocom.org/c/libosmocore/+/28939/comment/e762f147_3c76a0c6 PS3, Line 40: //cbmsg = gsm0341_build_msg(NULL, 0, rand(), 0, msg_id, 0x0f, 1, 1, payload, payload_octets); > Does this need to be here? Just leaving it there, since i don't know the original idea from whoever wrote the test. This can be extended/improved at a later point, at least we now run some test and it's not left outside of the make check. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icd4feced06afb749de994195c6b338df006749ad Gerrit-Change-Number: 28939 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 05 Aug 2022 14:27:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_create_nack_mme

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28945 ) Change subject: cbc: Introduce test TC_create_nack_mme ...................................................................... cbc: Introduce test TC_create_nack_mme Related: OS#4945 Change-Id: I4589af1ddfac4c6e5bbd99e68ebc4b8dc2d5eb36 --- M cbc/CBC_Tests.ttcn M cbc/MME_ConnectionHandler.ttcn 2 files changed, 24 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/28945/1 diff --git a/cbc/CBC_Tests.ttcn b/cbc/CBC_Tests.ttcn index 8daa3bf..89ef330 100644 --- a/cbc/CBC_Tests.ttcn +++ b/cbc/CBC_Tests.ttcn @@ -160,6 +160,7 @@ sctp_is_client := sctp_is_client, start_fn := refers(f_MME_ConnHdlr_start_fn_void), exp_cbs_msg := omit, + write_replace_warning_req_cause := SBC_AP_Cause_message_accepted, write_replace_warning_ind_cause := omit, write_repl_unknown_TAIs := omit, bcast_cell_id_list := omit @@ -717,6 +718,24 @@ f_shutdown_helper(); } +/* Test MME answering Write-Replace Warning Request with Write-Replace Warning Response cause != accepted */ +private function f_mme_TC_create_nack_mme() runs on MME_ConnHdlr { + f_sbcap_handle_write_replace_warn_req(g_pars.exp_cbs_msg, 0); +} +testcase TC_create_nack_mme() runs on test_CT { + var template (value) List_of_TAIs write_repl_unknown_TAIs; + var template (value) CBS_Message msg := t_CBSmsg(48, 16752); + + f_init(num_bsc := 0, num_mme := 1); + + g_pars_MME[0].start_fn := refers(f_mme_TC_create_nack_mme); + g_pars_MME[0].exp_cbs_msg := valueof(msg); + g_pars_MME[0].write_replace_warning_req_cause := SBcAP_Cause_unspecifed_error; + f_start(); + f_create_and_delete(valueof(msg)); + f_shutdown_helper(); +} + control { execute( TC_rx_keepalive() ); execute( TC_rx_keepalive_timeout() ); @@ -736,6 +755,7 @@ execute( TC_ecbe_create_delete_etws_mme() ); execute( TC_create_nack_bsc() ); + execute( TC_create_nack_mme() ); } } diff --git a/cbc/MME_ConnectionHandler.ttcn b/cbc/MME_ConnectionHandler.ttcn index c49461a..4ab30c6 100644 --- a/cbc/MME_ConnectionHandler.ttcn +++ b/cbc/MME_ConnectionHandler.ttcn @@ -44,6 +44,7 @@ boolean sctp_is_client, void_fn start_fn, CBS_Message exp_cbs_msg optional, + SBC_AP_Cause write_replace_warning_req_cause, SBC_AP_Cause write_replace_warning_ind_cause optional, List_of_TAIs write_repl_unknown_TAIs optional, CellId_Broadcast_List bcast_cell_id_list optional @@ -69,11 +70,12 @@ tx := ts_SBCAP_WRITE_WARNING_RESP_UNKNOWN_TAI( int2bit(msg.msg_id, 16), int2bit(msg.ser_nr, 16), - SBC_AP_Cause_message_accepted, + g_pars.write_replace_warning_req_cause, g_pars.write_repl_unknown_TAIs); } else { tx := ts_SBCAP_WRITE_WARNING_RESP(int2bit(msg.msg_id, 16), - int2bit(msg.ser_nr, 16)); + int2bit(msg.ser_nr, 16), + g_pars.write_replace_warning_req_cause); } f_SBC_AP_send(tx, idx); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28945 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4589af1ddfac4c6e5bbd99e68ebc4b8dc2d5eb36 Gerrit-Change-Number: 28945 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: cbc: Introduce test TC_create_nack_bsc

by pespin

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28943 to look at the new patch set (#2). Change subject: cbc: Introduce test TC_create_nack_bsc ...................................................................... cbc: Introduce test TC_create_nack_bsc Related: OS#4945 Change-Id: Iabeb3e9d86eaf59b76504edf3976a947ae29b911 --- M cbc/BSC_ConnectionHandler.ttcn M cbc/CBC_Tests.ttcn 2 files changed, 44 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/43/28943/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28943 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iabeb3e9d86eaf59b76504edf3976a947ae29b911 Gerrit-Change-Number: 28943 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: sbcap: Add missing cause types

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28944 ) Change subject: sbcap: Add missing cause types ...................................................................... sbcap: Add missing cause types Change-Id: I09526f5ac19c80927b6b8ad1cff874a86e0b3a04 --- M library/sbcap/SBC_AP_Types.ttcn 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/28944/1 diff --git a/library/sbcap/SBC_AP_Types.ttcn b/library/sbcap/SBC_AP_Types.ttcn index cfb043d..4020c96 100644 --- a/library/sbcap/SBC_AP_Types.ttcn +++ b/library/sbcap/SBC_AP_Types.ttcn @@ -10,6 +10,24 @@ /* 3GPP TS 29.168 4.3.4.3.2 Cause */ type enumerated SBC_AP_Cause { - SBC_AP_Cause_message_accepted ('00'O) + SBC_AP_Cause_message_accepted ('00'O), + SBcAP_Cause_parameter_not_recognised ('01'O), + SBcAP_Cause_parameter_value_invalid ('02'O), + SBcAP_Cause_valid_message_not_identified ('03'O), + SBcAP_Cause_tracking_area_not_valid ('04'O), + SBcAP_Cause_unrecognised_message ('05'O), + SBcAP_Cause_missing_mandatory_element ('06'O), + SBcAP_Cause_mME_capacity_exceeded ('07'O), + SBcAP_Cause_mME_memory_exceeded ('08'O), + SBcAP_Cause_warning_broadcast_not_supported ('09'O), + SBcAP_Cause_warning_broadcast_not_operational ('0A'O), + SBcAP_Cause_message_reference_already_used ('0B'O), + SBcAP_Cause_unspecifed_error ('0C'O), + SBcAP_Cause_transfer_syntax_error ('0D'O), + SBcAP_Cause_semantic_error ('0E'O), + SBcAP_Cause_message_not_compatible_with_receiver_state ('0F'O), + SBcAP_Cause_abstract_syntax_error_reject ('10'O), + SBcAP_Cause_abstract_syntax_error_ignore_and_notify ('11'O), + SBcAP_Cause_abstract_syntax_error_falsely_constructed_message ('12'O) } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I09526f5ac19c80927b6b8ad1cff874a86e0b3a04 Gerrit-Change-Number: 28944 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022