August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: update various expected-results.xml

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28989 ) Change subject: update various expected-results.xml ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I850b79526145307246bca40c70ed8e4d586d8c68 Gerrit-Change-Number: 28989 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 15:57:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 ) Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 4: (1 comment) File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/e71527d3_9ab2… PS4, Line 82: template (present) Recovery_Time_Stamp tr_PFCP_Recovery_Timestamp(template LIN4_BO_LAST time_value := ?) := { "template (present) LIN4_BO_LAST time_value := ?" because I don't think it can be ommited here right? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 15:57:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: GTP mockup: allow single GTP devices in mockup mode

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28986 ) Change subject: GTP mockup: allow single GTP devices in mockup mode ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-upf/+/28986/comment/3519200c_45a82711 PS1, Line 16: The GTP mockup was first introduced for VTY tests during 'make check'. ok, you needed mockup mode to run unit tests. https://gerrit.osmocom.org/c/osmo-upf/+/28986/comment/79de3e4c_d7ca75ed PS1, Line 20: TTCN3 tests do query osmo-upf to list currently active tunnels, so the why do you need mockup mode in TTCN3 in first place? Why doesn't open5gs-upfd or osmo-ggsn need it when we run ttcn3 tests? What's really the use case of having some mocked devices and some not? I'm really not following your needs here. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic09a5ccea24086eb04f46e6af669668e5fade752 Gerrit-Change-Number: 28986 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 15:55:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: add comment about fd cleanup

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28985 ) Change subject: add comment about fd cleanup ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ibd471485fde90a14fe19f558b38a49b0b7d62909 Gerrit-Change-Number: 28985 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 15:52:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: main: show just a brief talloc report for vty

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28984 ) Change subject: main: show just a brief talloc report for vty ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-upf/osmo_upf_main.c: https://gerrit.osmocom.org/c/osmo-upf/+/28984/comment/72475035_13262ad3 PS1, Line 380: talloc_report What's the point of printing a report for the VTY context? I can understand doing this for tall_upf_ctx, tall_infra_ctx, and even NULL, but this one is an internal context of libosmovty. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I038951c6d62679e3cfcda51512768d1fbacaa0d1 Gerrit-Change-Number: 28984 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 15:51:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-upf[master]: log: fix/tweak log msg about nft/mockup

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/28983 ) Change subject: log: fix/tweak log msg about nft/mockup ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/28983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I2f77cfe727649bbdcebb4a656ebf97b186134ee8 Gerrit-Change-Number: 28983 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 15:46:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: update various expected-results.xml

by neels

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28989 ) Change subject: update various expected-results.xml ...................................................................... update various expected-results.xml Change-Id: I850b79526145307246bca40c70ed8e4d586d8c68 --- M bsc/expected-results.xml M gbproxy/expected-results.xml A hnbgw/expected-results.xml M hnodeb/expected-results.xml M mgw/expected-results.xml M msc/expected-results.xml M ns/expected-results.xml M pcu/expected-results.xml M pgw/expected-results.xml M sgsn/expected-results.xml 10 files changed, 125 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/28989/1 diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml index 572c657..23217ba 100644 --- a/bsc/expected-results.xml +++ b/bsc/expected-results.xml @@ -1,7 +1,13 @@ <?xml version="1.0"?> -<testsuite name='BSC_Tests' tests='249' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='BSC_Tests' tests='297' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='BSC_Tests' name='TC_ctrl_msc_connection_status' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ctrl_msc0_connection_status' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_stat_num_msc_connected_1' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_stat_num_msc_connected_2' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_stat_num_msc_connected_3' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_stat_num_bts_connected_1' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_stat_num_bts_connected_2' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_stat_num_bts_connected_3' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ctrl' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_si_default' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_si2quater_2_earfcns' time='MASKED'/> @@ -108,6 +114,7 @@ <testcase classname='BSC_Tests' name='TC_rll_rel_ind_sapi_n_reject' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_rll_err_ind_sapi_n_reject' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_rll_timeout_sapi_n_reject' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_rll_sapi_n_reject_dlci_cc' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_paging_imsi_nochan' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_paging_tmsi_nochan' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_paging_tmsi_any' time='MASKED'/> @@ -130,6 +137,8 @@ <testcase classname='BSC_Tests' name='TC_paging_imsi_load' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_paging_counter' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_paging_resp_unsol' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_paging_500req' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_paging_450req_no_paging_load_ind' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_rsl_drop_counter' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_rsl_unknown_unit_id' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_oml_unknown_unit_id' time='MASKED'/> @@ -146,7 +155,6 @@ <testcase classname='BSC_Tests' name='TC_ho_int_a5_3' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_int_a5_4' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_int_radio_link_failure' time='MASKED'/> - <testcase classname='BSC_Tests' name='TC_ho_out_of_this_bsc' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_out_fail_no_msc_response' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_out_fail_rr_ho_failure' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_out_fail_no_result_after_ho_cmd' time='MASKED'/> @@ -155,9 +163,13 @@ <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc_a5_1' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc_a5_3' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc_a5_4' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc_a5_1_3_no_chosen_enc_alg' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc_a5_1_3' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc_a5_mismatch' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc_tla_v6' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_srvcc_eutran_to_geran' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_srvcc_eutran_to_geran_a5_3' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_srvcc_eutran_to_geran_src_sai' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_srvcc_eutran_to_geran_ho_out' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_srvcc_eutran_to_geran_forbid_fast_return' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_srvcc_eutran_to_geran_ho_out_forbid_fast_return' time='MASKED'/> @@ -165,6 +177,7 @@ <testcase classname='BSC_Tests' name='TC_ho_in_fail_msc_clears_after_ho_detect' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_in_fail_no_detect' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_in_fail_no_detect2' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_ho_into_this_bsc_sccp_cr_without_bssap' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_neighbor_config_1' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_neighbor_config_2' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_neighbor_config_3' time='MASKED'/> @@ -179,9 +192,14 @@ <testcase classname='BSC_Tests' name='TC_dyn_pdch_ipa_act_nack' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_dyn_pdch_osmo_act_deact' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_dyn_pdch_osmo_act_nack' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_dyn_ts_sdcch8_act_deact' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_dyn_ts_sdcch8_all_subslots_used' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_dyn_ts_sdcch8_tch_call_act_deact' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_dyn_ts_sdcch8_act_nack' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chopped_ipa_ping' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_chopped_ipa_payload' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_assignment_verify_ms_power_params_ie' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_c0_power_red_mode' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mscpool_L3Compl_on_1_msc' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mscpool_L3Complete_by_imsi_round_robin' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_mscpool_LU_by_tmsi_null_nri_0_round_robin' time='MASKED'/> @@ -197,6 +215,7 @@ <testcase classname='BSC_Tests' name='TC_mscpool_no_allow_attach_valid_nri' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_early_conn_fail' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_late_conn_fail' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_stats_conn_fail' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_assignment_emerg_setup_allow' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_assignment_emerg_setup_deny_msc' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_assignment_emerg_setup_deny_bts' time='MASKED'/> @@ -215,10 +234,25 @@ <testcase classname='BSC_Tests' name='TC_lcs_loc_req_for_idle_ms_no_pag_resp' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_cm_service_during_lcs_loc_req' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_ho_during_lcs_loc_req' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_emerg_call_and_lcs_loc_req' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_emerg_call_and_lcs_loc_req_early_lchan_rel_ind' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_emerg_call_and_lcs_loc_req_early_lchan_conn_fail' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_no_msc' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_refuse_chan_act_to_vamos' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_refuse_mode_modif_to_vamos' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_reassignment_fr' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_cm_reestablishment' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_imm_ass_post_chan_ack' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_imm_ass_pre_chan_ack' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_imm_ass_pre_ts_ack' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_imm_ass_pre_chan_ack_dyn_ts' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_imm_ass_pre_ts_ack_dyn_ts' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_ctrl_trx_rf_locked' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_ratectr_all_available_allocated' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_ratectr_all_available_allocated_dyn' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_cm_serv_rej' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_lost_sdcch_during_assignment' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_ho_out_of_this_bsc' time='MASKED'/> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_only' time='MASKED'/> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_bway_connect' time='MASKED'/> <testcase classname='BSC_Tests_LCLS' name='TC_lcls_gcr_bway_connect_hr' time='MASKED'/> @@ -238,6 +272,8 @@ <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_bsc_client' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_bsc_client_ipv6' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_reset_bss' time='MASKED'/> + <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_cell_rflock_failure_restart' time='MASKED'/> + <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_cell_rsl_down_failure' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_write_bss' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_write_bts_cgi' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_write_bts_no_cbch' time='MASKED'/> @@ -247,12 +283,18 @@ <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_write_lai' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_write_lac' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_write_then_replace' time='MASKED'/> + <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_write_rep_period_num' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_replace_nonexist' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_write_too_many' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_kill_nonexist' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_write_then_kill' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_write_then_reset' time='MASKED'/> + <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_status_q_empty' time='MASKED'/> + <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_status_q_bts_cgi' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_emerg_write_bts_cgi_dchan' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_emerg_write_bts_cgi_cchan' time='MASKED'/> <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_emerg_write_bts_cgi_cchan_disable' time='MASKED'/> + <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_emerg_write_bts_cgi_noreplace' time='MASKED'/> + <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_emerg_write_bts_cgi_replace' time='MASKED'/> + <testcase classname='BSC_Tests_CBSP' name='TC_cbsp_emerg_write_bts_cgi_kill' time='MASKED'/> </testsuite> diff --git a/gbproxy/expected-results.xml b/gbproxy/expected-results.xml index 6221f10..5b9f8b1 100644 --- a/gbproxy/expected-results.xml +++ b/gbproxy/expected-results.xml @@ -1,6 +1,7 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='73' failures='6' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='76' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='GBProxy_Tests' name='TC_BVC_bringup' time='MASKED'/> + <testcase classname='GBProxy_Tests' name='TC_BVC_bringup_conflicting' time='MASKED'/> <testcase classname='GBProxy_Tests' name='TC_ul_unitdata' time='MASKED'/> <testcase classname='GBProxy_Tests' name='TC_ul_unitdata_pool_failure' time='MASKED'/> <testcase classname='GBProxy_Tests' name='TC_dl_unitdata' time='MASKED'/> @@ -19,8 +20,8 @@ <testcase classname='GBProxy_Tests' name='TC_bvc_reset_ptp_from_bss' time='MASKED'/> <testcase classname='GBProxy_Tests' name='TC_bvc_reset_sig_from_bss' time='MASKED'/> <testcase classname='GBProxy_Tests' name='TC_bvc_reset_ptp_from_sgsn' time='MASKED'/> - <testcase classname='GBProxy_Tests' name='TC_bvc_reset_sig_from_sgsn' time='MASKED'/> <testcase classname='GBProxy_Tests' name='TC_bvc_reset_blocked_ptp_from_sgsn' time='MASKED'/> + <testcase classname='GBProxy_Tests' name='TC_bvc_reset_sig_from_sgsn' time='MASKED'/> <testcase classname='GBProxy_Tests' name='TC_paging_ps_ptp_bss' time='MASKED'/> <testcase classname='GBProxy_Tests' name='TC_paging_ps_ptp_lac' time='MASKED'/> <testcase classname='GBProxy_Tests' name='TC_paging_ps_ptp_lac_unknown' time='MASKED'/> @@ -75,5 +76,4 @@ <testcase classname='GBProxy_Tests' name='TC_status_ptp_ul_tmsi' time='MASKED'/> <testcase classname='GBProxy_Tests' name='TC_status_sig_dl_bvci' time='MASKED'/> <testcase classname='GBProxy_Tests' name='TC_status_ptp_dl_bvci' time='MASKED'/> - <testcase classname='GBProxy_Tests' name='TC_ctrl' time='MASKED'/> </testsuite> diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml new file mode 100644 index 0000000..cc77dc6 --- /dev/null +++ b/hnbgw/expected-results.xml @@ -0,0 +1,16 @@ +<?xml version="1.0"?> +<testsuite name='Titan' tests='13' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='HNBGW_Tests' name='TC_hnb_register' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ranap_cs_initial_ue' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ranap_ps_initial_ue' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ranap_cs_initial_ue_empty_cr' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ranap_ps_initial_ue_empty_cr' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ranap_cs_bidir' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ranap_ps_bidir' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_rab_assignment' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_rab_release' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_rab_assign_fail' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_rab_assign_mgcp_to' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ranap_cs_mo_disconnect' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_ranap_ps_mo_disconnect' time='MASKED'/> +</testsuite> diff --git a/hnodeb/expected-results.xml b/hnodeb/expected-results.xml index 39cea9f..f2c456b 100644 --- a/hnodeb/expected-results.xml +++ b/hnodeb/expected-results.xml @@ -1,4 +1,10 @@ <?xml version="1.0"?> -<testsuite name='HNB_Tests' tests='0' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> - +<testsuite name='HNB_Tests' tests='7' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> + <testcase classname='HNB_Tests' name='TC_hnb_register_request_accept' time='MASKED'/> + <testcase classname='HNB_Tests' name='TC_hnb_register_request_reject' time='MASKED'/> + <testcase classname='HNB_Tests' name='TC_mo_conn' time='MASKED'/> + <testcase classname='HNB_Tests' name='TC_paging' time='MASKED'/> + <testcase classname='HNB_Tests' name='TC_cs_mo_call_audio_v0' time='MASKED'/> + <testcase classname='HNB_Tests' name='TC_cs_mo_call' time='MASKED'/> + <testcase classname='HNB_Tests' name='TC_ps_mo_gtp_ping_pong' time='MASKED'/> </testsuite> diff --git a/mgw/expected-results.xml b/mgw/expected-results.xml index b2b63cd..89d5bf0 100644 --- a/mgw/expected-results.xml +++ b/mgw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='65' failures='5' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='71' failures='8' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='MGCP_Test' name='TC_selftest' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_crcx' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_crcx_no_lco' time='MASKED'/> @@ -17,6 +17,7 @@ <testcase classname='MGCP_Test' name='TC_crcx_wildcarded_exhaust' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_mdcx_without_crcx' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_dlcx_without_crcx' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_dlcx_non_existant_ep' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_mdcx_wildcarded' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_dlcx_wildcarded' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_crcx_and_dlcx_ep_callid_connid' time='MASKED'/> @@ -57,8 +58,24 @@ MGCP_Test.ttcn:MASKED TC_e1_crcx_and_dlcx_ep testcase </failure> </testcase> - <testcase classname='MGCP_Test' name='TC_e1_crcx_with_overlap' time='MASKED'/> - <testcase classname='MGCP_Test' name='TC_e1_crcx_loopback' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_e1_crcx_with_overlap' time='MASKED'> + <failure type='fail-verdict'>Response didn't match template + MGCP_Test.ttcn:MASKED MGCP_Test control part + MGCP_Test.ttcn:MASKED TC_e1_crcx_with_overlap testcase + </failure> + </testcase> + <testcase classname='MGCP_Test' name='TC_e1_crcx_loopback' time='MASKED'> + <failure type='fail-verdict'>Response didn't match template + MGCP_Test.ttcn:MASKED MGCP_Test control part + MGCP_Test.ttcn:MASKED TC_e1_crcx_loopback testcase + </failure> + </testcase> + <testcase classname='MGCP_Test' name='TC_e1_dlcx_wildcarded' time='MASKED'> + <failure type='fail-verdict'>Response didn't match template + MGCP_Test.ttcn:MASKED MGCP_Test control part + MGCP_Test.ttcn:MASKED TC_e1_dlcx_wildcarded testcase + </failure> + </testcase> <testcase classname='MGCP_Test' name='TC_crcx_mdcx_ip4' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_crcx_mdcx_ip6' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_ipv4_ipv6' time='MASKED'/> @@ -89,5 +106,9 @@ </failure> </testcase> <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_rtp_osmux_ipv6_ipv4' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_rfci_unordered' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_rtp' time='MASKED'/> + <testcase classname='MGCP_Test' name='TC_two_crcx_mdcx_and_iuup_rtp_rfci_unordered' time='MASKED'/> <testcase classname='MGCP_Test' name='TC_one_crcx_loopback_rtp_implicit' time='MASKED'/> </testsuite> diff --git a/msc/expected-results.xml b/msc/expected-results.xml index ac98215..a77bdc5 100644 --- a/msc/expected-results.xml +++ b/msc/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='199' failures='6' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='203' failures='6' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='MSC_Tests' name='TC_cr_before_reset' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_imsi_noauth_tmsi' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_lu_imsi_noauth_notmsi' time='MASKED'/> @@ -154,6 +154,10 @@ <testcase classname='MSC_Tests' name='TC_lu_and_expire_while_paging' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_paging_response_imsi_unknown' time='MASKED'/> <testcase classname='MSC_Tests' name='TC_paging_response_tmsi_unknown' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_call_re_establishment' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_call_re_establishment_auth' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_call_re_establishment_ciph' time='MASKED'/> + <testcase classname='MSC_Tests' name='TC_cm_serv_wrong_mi' time='MASKED'/> <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_imsi_reject' time='MASKED'/> <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_imsi_timeout_gsup' time='MASKED'/> <testcase classname='MSC_Tests_Iu' name='TC_iu_lu_imsi_auth3g_tmsi' time='MASKED'/> diff --git a/ns/expected-results.xml b/ns/expected-results.xml index 5263981..ef0d01f 100644 --- a/ns/expected-results.xml +++ b/ns/expected-results.xml @@ -1,9 +1,13 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='19' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='24' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='NS_Tests' name='TC_tx_reset' time='MASKED'/> <testcase classname='NS_Tests' name='TC_tx_block' time='MASKED'/> <testcase classname='NS_Tests' name='TC_tx_block_by_vty' time='MASKED'/> <testcase classname='NS_Tests' name='TC_tx_block_by_vty_reset' time='MASKED'/> + <testcase classname='NS_Tests' name='TC_tx_block_unitdata_over_blocked' time='MASKED'/> + <testcase classname='NS_Tests' name='TC_rx_block_unitdata_over_blocked' time='MASKED'/> + <testcase classname='NS_Tests' name='TC_mirror_unitdata_tx_status_blocked' time='MASKED'/> + <testcase classname='NS_Tests' name='TC_tx_blocked_foreign_nsvc' time='MASKED'/> <testcase classname='NS_Tests' name='TC_tx_unblock' time='MASKED'/> <testcase classname='NS_Tests' name='TC_tx_unblock_retries' time='MASKED'/> <testcase classname='NS_Tests' name='TC_reset_wrong_nsei' time='MASKED'/> @@ -19,4 +23,5 @@ <testcase classname='NS_Tests' name='TC_tx_reset_rx_alive' time='MASKED'/> <testcase classname='NS_Tests' name='TC_alive_retries_single_reset' time='MASKED'/> <testcase classname='NS_Tests' name='TC_no_reset_alive_ack' time='MASKED'/> + <testcase classname='NS_Tests' name='TC_tx_unitdata' time='MASKED'/> </testsuite> diff --git a/pcu/expected-results.xml b/pcu/expected-results.xml index dc5aa31..7f138cd 100644 --- a/pcu/expected-results.xml +++ b/pcu/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='99' failures='4' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='110' failures='4' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='PCU_Tests' name='TC_pcuif_suspend' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_pcuif_suspend_active_tbf' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_ta_ptcch_idle' time='MASKED'/> @@ -39,6 +39,8 @@ <testcase classname='PCU_Tests' name='TC_zero_x2031_t3191' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_t3193' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_n3105_max_t3195' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_t3172_wait_ind_size0' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_t3172_wait_ind_size1' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_countdown_procedure' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_ul_all_sizes' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_ul_data_toolong_fills_padding' time='MASKED'/> @@ -52,6 +54,7 @@ <testcase classname='PCU_Tests' name='TC_dl_flow_more_blocks' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_ul_flow_multiple_llc_blocks' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_dl_no_ack_retrans_imm_ass' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_dl_llc_sapi_priority' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_paging_cs_from_bts' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_paging_cs_from_sgsn_sign_ptmsi' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_paging_cs_from_sgsn_sign' time='MASKED'/> @@ -59,6 +62,7 @@ <testcase classname='PCU_Tests' name='TC_paging_ps_from_sgsn_sign_ptmsi' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_paging_ps_from_sgsn_sign' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_paging_ps_from_sgsn_ptp' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_paging_pch_timeout' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_paging_cs_multi_ms_imsi_tmsi' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_paging_cs_multi_ms_imsi' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_paging_cs_multi_ms_tmsi' time='MASKED'/> @@ -87,15 +91,17 @@ </testcase> <testcase classname='PCU_Tests' name='TC_dl_multislot_tbf_ms_class_from_2phase' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_ul_multislot_tbf_ms_class_from_2phase' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_ul_tbf_reestablish_with_pkt_resource_req' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_ul_tbf_reestablish_with_pkt_resource_req_n3105_max' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_ul_tbf_reestablish_with_pkt_dl_ack_nack' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_ul_tbf_reestablish_with_pkt_dl_ack_nack_egprs' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_multiplex_dl_gprs_egprs' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_pcuif_info_ind_subsequent' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_no_ctrl_ack' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_twice' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_success_twice_nocache' time='MASKED'/> - <testcase classname='PCU_Tests' name='TC_nacc_outbound_rac_ci_resolve_conn_refused' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_rac_ci_resolve_timeout' time='MASKED'/> - <testcase classname='PCU_Tests' name='TC_nacc_outbound_rac_ci_resolve_fail_parse_response' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_si_resolve_timeout' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_pkt_cell_chg_notif_dup' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_nacc_outbound_pkt_cell_chg_notif_dup2' time='MASKED'/> @@ -111,6 +117,11 @@ <testcase classname='PCU_Tests' name='TC_rim_ran_info_req_single_rep' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_rim_ran_info_req_single_rep_eutran' time='MASKED'/> <testcase classname='PCU_Tests' name='TC_rim_ran_info_req_single_rep_no_si' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_pdch_energy_saving' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_stat_pdch_avail_occ' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_stat_pdch_avail_occ_ms_not_known_gprs' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_stat_pdch_avail_occ_ms_not_known_egprs' time='MASKED'/> + <testcase classname='PCU_Tests' name='TC_ratectr_all_available_allocated' time='MASKED'/> <testcase classname='PCU_Tests_NS' name='TC_ns_reset' time='MASKED'/> <testcase classname='PCU_Tests_NS' name='TC_ns_reset_retrans' time='MASKED'/> <testcase classname='PCU_Tests_NS' name='TC_ns_alive' time='MASKED'/> diff --git a/pgw/expected-results.xml b/pgw/expected-results.xml index 65daf0e..0643289 100644 --- a/pgw/expected-results.xml +++ b/pgw/expected-results.xml @@ -1,9 +1,10 @@ <?xml version="1.0"?> -<testsuite name='PGW_Tests' tests='6' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='7' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='PGW_Tests' name='TC_tx_echo' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_createSession' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_createSession_ping4' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_createSession_ping4_256' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_createSession_deleteSession' time='MASKED'/> <testcase classname='PGW_Tests' name='TC_deleteSession_unknown' time='MASKED'/> + <testcase classname='PGW_Tests' name='TC_gy_charging_cc_time' time='MASKED'/> </testsuite> diff --git a/sgsn/expected-results.xml b/sgsn/expected-results.xml index 31484d0..944f871 100644 --- a/sgsn/expected-results.xml +++ b/sgsn/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='72' failures='4' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='73' failures='4' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='SGSN_Tests' name='TC_attach' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_mnc3' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_umts_aka_umts_res' time='MASKED'/> @@ -85,8 +85,9 @@ <testcase classname='SGSN_Tests' name='TC_cell_change_different_ci_data' time='MASKED'/> <testcase classname='SGSN_Tests' name='TC_attach_req_id_req_ra_update' time='MASKED'/> <testcase classname='SGSN_Tests_Iu' name='TC_iu_attach' time='MASKED'/> + <testcase classname='SGSN_Tests_Iu' name='TC_iu_attach_encr' time='MASKED'/> <testcase classname='SGSN_Tests_Iu' name='TC_iu_attach_geran_rau' time='MASKED'> - <failure type='fail-verdict'>"BSSGP_Emulation.ttcnpp:818 : Couldn't find Component for TLLI 'C665E43F'O" + <failure type='fail-verdict'>"BSSGP_Emulation.ttcnpp:830 : Couldn't find Component for TLLI 'E918E6AA'O" SGSN_Tests_Iu.ttcn:MASKED SGSN_Tests_Iu control part SGSN_Tests_Iu.ttcn:MASKED TC_iu_attach_geran_rau testcase </failure> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28989 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I850b79526145307246bca40c70ed8e4d586d8c68 Gerrit-Change-Number: 28989 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: cosmetic: tlv.h: Fix trailing whistespace

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28987 ) Change subject: cosmetic: tlv.h: Fix trailing whistespace ...................................................................... cosmetic: tlv.h: Fix trailing whistespace Change-Id: Ief318882def539b35ef15c85566f69220e7edbfe --- M include/osmocom/gsm/tlv.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/87/28987/1 diff --git a/include/osmocom/gsm/tlv.h b/include/osmocom/gsm/tlv.h index 7e6dfb5..6d0008f 100644 --- a/include/osmocom/gsm/tlv.h +++ b/include/osmocom/gsm/tlv.h @@ -322,7 +322,7 @@ } /*! put (append) a TV field */ -static inline uint8_t *tv_put(uint8_t *buf, uint8_t tag, +static inline uint8_t *tv_put(uint8_t *buf, uint8_t tag, uint8_t val) { *buf++ = tag; @@ -344,7 +344,7 @@ * \param[in] tag Tag value * \param[in] val Value (in host byte order!) */ -static inline uint8_t *tv16_put(uint8_t *buf, uint8_t tag, +static inline uint8_t *tv16_put(uint8_t *buf, uint8_t tag, uint16_t val) { *buf++ = tag; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28987 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ief318882def539b35ef15c85566f69220e7edbfe Gerrit-Change-Number: 28987 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in libosmocore[master]: tlv.h: Fix TLVP_PRESENT returning a pointer instead of a boolean

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28988 ) Change subject: tlv.h: Fix TLVP_PRESENT returning a pointer instead of a boolean ...................................................................... tlv.h: Fix TLVP_PRESENT returning a pointer instead of a boolean I was warned by gcc about comparing a pointer with an integer when using TLVP_PRESENT with something like: bool expect = ...; if (expect != TLV_PRESENT(...)) That's indeed dangerous because TLV_PRESENT is considered to return a boolean, as opposite to TLV_VAL. Change-Id: I45cc2745c695e30c37b10f592903ec3775a55492 --- M include/osmocom/gsm/tlv.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/88/28988/1 diff --git a/include/osmocom/gsm/tlv.h b/include/osmocom/gsm/tlv.h index 6d0008f..fd6659c 100644 --- a/include/osmocom/gsm/tlv.h +++ b/include/osmocom/gsm/tlv.h @@ -543,7 +543,7 @@ int tlv_encode_ordered(struct msgb *msg, const struct tlv_definition *def, const struct tlv_parsed *tp, const uint8_t *tag_order, unsigned int tag_order_len); -#define TLVP_PRESENT(x, y) ((x)->lv[y].val) +#define TLVP_PRESENT(x, y) (!!((x)->lv[y].val)) #define TLVP_LEN(x, y) (x)->lv[y].len #define TLVP_VAL(x, y) (x)->lv[y].val -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28988 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I45cc2745c695e30c37b10f592903ec3775a55492 Gerrit-Change-Number: 28988 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP

by neels

Attention is currently required from: neels, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 to look at the new patch set (#4). Change subject: add library/PFCP_*, deps/PFCP ...................................................................... add library/PFCP_*, deps/PFCP Will soon be used by new subdir 'upf' (test osmo-upf), and by 'hnbgw' (test GTP mapping via UPF). Related: SYS#5599 Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f --- M deps/Makefile M library/General_Types.ttcn A library/PFCP_CodecPort.ttcn A library/PFCP_CodecPort_CtrlFunct.ttcn A library/PFCP_CodecPort_CtrlFunctDef.cc A library/PFCP_Emulation.ttcn A library/PFCP_Templates.ttcn 7 files changed, 921 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/28817/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022