July 2022 - gerrit-log - lists.osmocom.org

Change in osmo-cbc[master]: Make cbsp,sbcap mgr available in data model

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28716 ) Change subject: Make cbsp,sbcap mgr available in data model ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28716 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I60c3ded80c38bcf50b831c6e9db719a8d2cba5b1 Gerrit-Change-Number: 28716 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Jul 2022 11:14:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: cbc_vty: use install_element[_ve](), not install_lib_element[_ve]()

by pespin

Attention is currently required from: neels, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28715 ) Change subject: cbc_vty: use install_element[_ve](), not install_lib_element[_ve]() ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28715 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I8c0c8ac66dfc4fc2b8bf9102fba0df2dd988e7c9 Gerrit-Change-Number: 28715 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Jul 2022 11:14:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: cbc_vty: write peer config nodes at the end

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28713 ) Change subject: cbc_vty: write peer config nodes at the end ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28713 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I7623ea5874552e57764327e94a9c3a4de7b71d67 Gerrit-Change-Number: 28713 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Jul 2022 11:14:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Refactor {cbsp,sbcap}_cbc_accept_cb

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28712 ) Change subject: Refactor {cbsp,sbcap}_cbc_accept_cb ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id4f83ec6b0b14e556b1caa9c80e7f68d062fec57 Gerrit-Change-Number: 28712 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Jul 2022 11:14:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: Bump version: 0.1.1

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28730 ) Change subject: Bump version: 0.1.1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Once merged, I'll push a 0.1.1 tag pointing to this patch. This will allow having osmo-dia2gsup in osmocom:latest. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I30c104822a96d14f80cad320b801149f38b886b7 Gerrit-Change-Number: 28730 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 22 Jul 2022 10:57:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in ...osmo_dia2gsup[master]: Bump version: 0.1.1

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28730 ) Change subject: Bump version: 0.1.1 ...................................................................... Bump version: 0.1.1 Change-Id: I30c104822a96d14f80cad320b801149f38b886b7 --- M debian/changelog 1 file changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/30/28730/1 diff --git a/debian/changelog b/debian/changelog index 6e45d35..1872b56 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,16 @@ +osmo-diameter2gsup (0.1.1) unstable; urgency=medium + + [ Daniel Willmann ] + * diameter: Change default bind IP to 127.0.0.8 + + [ Alexander Couzens ] + * add rebar.lock to define known working dependencies + * debian: add missing Build-Depends debhelper + * debian: rework packaging + * debian: add generate_build_dep.sh to vendor erlang dependencies + + -- Oliver Smith <osmith(a)sysmocom.de> Fri, 22 Jul 2022 12:48:34 +0200 + osmo-diameter2gsup (0.1.0) unstable; urgency=medium * Initial release. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/28730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I30c104822a96d14f80cad320b801149f38b886b7 Gerrit-Change-Number: 28730 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

Change in pysim[master]: Introduce APDU/TPDU trace decoder

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28725 ) Change subject: Introduce APDU/TPDU trace decoder ...................................................................... Patch Set 1: (2 comments) File pySim/gsmtap.py: https://gerrit.osmocom.org/c/pysim/+/28725/comment/8960a263_adf7d995 PS1, Line 153: Int8ub > Well, the check in the code allows us to be more flexible, I think it's one of those situation where […] One advantage of using Const is that the parser will fail early with a clean error message, and not somewhere in the middle with less obvious reason like ShortRead. The version check below is done after parsing, so it only works if the bytestream was parsed without exceptions. I any case, this is not critical, you can keep this unchanged. File pySim/ts_31_102.py: https://gerrit.osmocom.org/c/pysim/+/28725/comment/5e0495d8_671c6d30 PS1, Line 303: # 3gPP TS 31.102 Section 7.5.2.1 > why is it unrelated? That DataObject is referenced in the tracer: […] Ah, indeed. Nevermind. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I862d93163d495a294364168f7818641e47b18c0a Gerrit-Change-Number: 28725 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 22 Jul 2022 10:55:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in pysim[master]: Introduce APDU/TPDU trace decoder

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/28725 ) Change subject: Introduce APDU/TPDU trace decoder ...................................................................... Patch Set 1: (2 comments) File pySim/gsmtap.py: https://gerrit.osmocom.org/c/pysim/+/28725/comment/a23abdea_c457679f PS1, Line 153: Int8ub > I would use Const(b'\x02') to enforce GSMTAPv2 (GSMTAP_VERSION). Well, the check in the code allows us to be more flexible, I think it's one of those situation where I can't say one is clearly better than the other. File pySim/ts_31_102.py: https://gerrit.osmocom.org/c/pysim/+/28725/comment/747256b9_e697db5a PS1, Line 303: # 3gPP TS 31.102 Section 7.5.2.1 > unrelated? why is it unrelated? That DataObject is referenced in the tracer: pySim/apdu/ts_31_102.py:from pySim.ts_31_102 import SUCI_TlvDataObject -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28725 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I862d93163d495a294364168f7818641e47b18c0a Gerrit-Change-Number: 28725 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 22 Jul 2022 10:42:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in pysim[master]: ts_31_102: Fix EF_EPSLOCI argument ordering

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/28711 ) Change subject: ts_31_102: Fix EF_EPSLOCI argument ordering ...................................................................... ts_31_102: Fix EF_EPSLOCI argument ordering We were invoking the constructor with the description as 4th positional argument, but that was actually the 'size' argument in this case. Let's swap the order to be aligned with other file constructors. Change-Id: I9acee757f096fef0d8bacbec3b52f56267cd52f6 --- M pySim/ts_31_102.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 5df7369..aa36b71 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -860,8 +860,8 @@ # TS 31.102 Section 4.2.91 class EF_EPSLOCI(TransparentEF): - def __init__(self, fid='6fe3', sfid=0x1e, name='EF.EPSLOCI', size=(18, 18), - desc='EPS Location Information', **kwargs): + def __init__(self, fid='6fe3', sfid=0x1e, name='EF.EPSLOCI', + desc='EPS Location Information', size=(18,18), **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, **kwargs) upd_status_constr = Enum( Byte, updated=0, not_updated=1, roaming_not_allowed=2) 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/28711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9acee757f096fef0d8bacbec3b52f56267cd52f6 Gerrit-Change-Number: 28711 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: l1ctl_server_{start,shutdown}() -> l1ctl_server_{alloc,free}()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28729 ) Change subject: trxcon: l1ctl_server_{start,shutdown}() -> l1ctl_server_{alloc,free}() ...................................................................... trxcon: l1ctl_server_{start,shutdown}() -> l1ctl_server_{alloc,free}() l1ctl_server_start() does not actually start the server, it simply allocates memory and initializes it. l1ctl_server_shutdown() does the opposite. Let's use more precise symbol names. Change-Id: Ie039abdff3911c5b566c760b26c31203824c5764 --- M src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_server.h M src/host/trxcon/src/l1ctl_server.c M src/host/trxcon/src/trxcon.c 3 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/29/28729/1 diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_server.h b/src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_server.h index 003d146..94c0a9c 100644 --- a/src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_server.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_server.h @@ -54,8 +54,8 @@ void *priv; }; -struct l1ctl_server *l1ctl_server_start(void *ctx, const struct l1ctl_server_cfg *cfg); -void l1ctl_server_shutdown(struct l1ctl_server *server); +struct l1ctl_server *l1ctl_server_alloc(void *ctx, const struct l1ctl_server_cfg *cfg); +void l1ctl_server_free(struct l1ctl_server *server); int l1ctl_client_send(struct l1ctl_client *client, struct msgb *msg); void l1ctl_client_conn_close(struct l1ctl_client *client); diff --git a/src/host/trxcon/src/l1ctl_server.c b/src/host/trxcon/src/l1ctl_server.c index 8d57fff..8827900 100644 --- a/src/host/trxcon/src/l1ctl_server.c +++ b/src/host/trxcon/src/l1ctl_server.c @@ -206,7 +206,7 @@ talloc_free(client); } -struct l1ctl_server *l1ctl_server_start(void *ctx, const struct l1ctl_server_cfg *cfg) +struct l1ctl_server *l1ctl_server_alloc(void *ctx, const struct l1ctl_server_cfg *cfg) { struct l1ctl_server *server; int rc; @@ -239,7 +239,7 @@ return server; } -void l1ctl_server_shutdown(struct l1ctl_server *server) +void l1ctl_server_free(struct l1ctl_server *server) { LOGP(DL1C, LOGL_NOTICE, "Shutdown L1CTL server\n"); diff --git a/src/host/trxcon/src/trxcon.c b/src/host/trxcon/src/trxcon.c index 7fa774d..1e12293 100644 --- a/src/host/trxcon/src/trxcon.c +++ b/src/host/trxcon/src/trxcon.c @@ -563,7 +563,7 @@ .conn_close_cb = &l1ctl_conn_close_cb, }; - server = l1ctl_server_start(tall_trxcon_ctx, &server_cfg); + server = l1ctl_server_alloc(tall_trxcon_ctx, &server_cfg); if (server == NULL) { rc = EXIT_FAILURE; goto exit; @@ -587,7 +587,7 @@ exit: if (server != NULL) - l1ctl_server_shutdown(server); + l1ctl_server_free(server); /* Deinitialize logging */ log_fini(); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie039abdff3911c5b566c760b26c31203824c5764 Gerrit-Change-Number: 28729 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022