pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28647 )
Change subject: stream: getsockopt ret socklen_t is unsigned
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Regarding socklen_t being unsigned:
https://pubs.opengroup.org/onlinepubs/7908799/xns/syssocket.h.html
"""
<sys/socket.h> makes available a type, socklen_t, which is an unsigned opaque integral type of length of at least 32 bits. To forestall portability problems, it is recommended that applications should not use values larger than 232 - 1.
"""
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28647
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I181ae5c0480788fc96abd2bb1edf003244884c8f
Gerrit-Change-Number: 28647
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 18 Jul 2022 16:30:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28602 )
Change subject: Add initial SBc-AP support to osmo-cbc
......................................................................
Patch Set 11:
(1 comment)
File src/sbcap_server_fsm.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/ed184afc_0ae5e1f4
PS8, Line 303: //else
> Ack. Neither it's marked as FIXME nor as TODO. […]
This should be kept because I still need to figure out the replace path here. Again, this is an initial implementation, which can be extended and improved step by step once this big amount of code is merged and tests being run.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9
Gerrit-Change-Number: 28602
Gerrit-PatchSet: 11
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Jul 2022 16:23:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment