July 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: stream: getsockopt ret socklen_t is unsigned

by osmith

Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28647 ) Change subject: stream: getsockopt ret socklen_t is unsigned ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28647 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I181ae5c0480788fc96abd2bb1edf003244884c8f Gerrit-Change-Number: 28647 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Jul 2022 09:43:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmo-pfcp[master]: separate pfcp_queue_timer_cb() in req and resp

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337 ) Change subject: separate pfcp_queue_timer_cb() in req and resp ...................................................................... Patch Set 1: (1 comment) File src/libosmo-pfcp/pfcp_endpoint.c: https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337/comment/f551d763_0981e139 PS1, Line 285: } else { > You'll probably want to name the 2 timers differently (put them in a union), since anyway you'll wan […] i don't see a reason to use different timer names. a queue entry is either a request or a response, there will be no double usage, and AFAICT T1 is the name from specs -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: Ic8ab71f5efd4cf669689a0b075f9a52ce66bdd5d Gerrit-Change-Number: 28337 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Jul 2022 09:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-tetra[master]: added brackets; fprintf was erroneously not guarded by if statement

by fixeria

Attention is currently required from: wbokslag. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28593 ) Change subject: added brackets; fprintf was erroneously not guarded by if statement ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28593 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I2e8c365ee261bde998a69f0f3531dfe6f3ec49c7 Gerrit-Change-Number: 28593 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Tue, 19 Jul 2022 09:25:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-tetra[master]: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c

by fixeria

Attention is currently required from: wbokslag, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/28592 ) Change subject: Created tuntap.h to allow for proper use of tun_alloc in tetra_llc.c ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/28592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: If920c15e4dafb48d5df70ce20532ecb19bd01ee3 Gerrit-Change-Number: 28592 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 19 Jul 2022 09:25:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in docker-playground[master]: ttcn3-cbc: Update osmo-cbc.cfg to test SBc-AP

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28604 ) Change subject: ttcn3-cbc: Update osmo-cbc.cfg to test SBc-AP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie6fb464890c4b7b9816ef8602633df107e5e61ee Gerrit-Change-Number: 28604 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Jul 2022 09:22:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in docker-playground[master]: ttcn3-cbc: Update osmo-cbc.cfg to test SBc-AP

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28604 ) Change subject: ttcn3-cbc: Update osmo-cbc.cfg to test SBc-AP ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie6fb464890c4b7b9816ef8602633df107e5e61ee Gerrit-Change-Number: 28604 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Jul 2022 09:12:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: vty: Fix call to OSMO_STRBUF_PRINTF

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28646 ) Change subject: vty: Fix call to OSMO_STRBUF_PRINTF ...................................................................... vty: Fix call to OSMO_STRBUF_PRINTF """ osmo-cbc/src/cbc_vty.c:61:3: error: format not a string literal and no format arguments [-Werror=format-security] 61 | OSMO_STRBUF_PRINTF(sb, peer->remote_host[i]); """ Change-Id: I90e7bdbe9f01dae9269ae4850bc2d7391fee71ec --- M src/cbc_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 5244c3e..916adc2 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -58,7 +58,7 @@ for (i = 0; i < peer->num_remote_host; i++) { if (i > 0) OSMO_STRBUF_PRINTF(sb, ","); - OSMO_STRBUF_PRINTF(sb, peer->remote_host[i]); + OSMO_STRBUF_PRINTF(sb, "%s", peer->remote_host[i]); } vty_out(vty, "|%-20s| %-15s| %-5d| %-6s| %-20s|%s", -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28646 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I90e7bdbe9f01dae9269ae4850bc2d7391fee71ec Gerrit-Change-Number: 28646 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: doc: user manual: fix typo

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28644 ) Change subject: doc: user manual: fix typo ...................................................................... doc: user manual: fix typo Change-Id: I20e595581f7d6145a01e9c0a6b0eb2af7637bfd9 --- M doc/manuals/chapters/configuration.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index 5abb3a8..16464c8 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -51,7 +51,7 @@ ==== Configuring the IP/Port for CBSP to bind to -It can be configure to which IP and TCP port the CBSP protocol binds to. +It can be configured to which IP and TCP port the CBSP protocol binds to. The default is to bind to the 3GPP standard port number 48049 for CBSP at the loopback IP address 127.0.0.1. 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I20e595581f7d6145a01e9c0a6b0eb2af7637bfd9 Gerrit-Change-Number: 28644 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: doc: Document SBc-AP support and config

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28640 ) Change subject: doc: Document SBc-AP support and config ...................................................................... doc: Document SBc-AP support and config Change-Id: Ic14ec2766fce251a6fe52a77d7bc0bbcd8d3afbf --- M doc/manuals/chapters/configuration.adoc M doc/manuals/chapters/overview.adoc M doc/manuals/images/cbc-in-network.dot 3 files changed, 92 insertions(+), 10 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc index 16464c8..98cf4d1 100644 --- a/doc/manuals/chapters/configuration.adoc +++ b/doc/manuals/chapters/configuration.adoc @@ -1,7 +1,7 @@ [[configuration]] == Configuration -=== CBSP / Peer Configuration +=== CBSP Peer Configuration CBSP is the BSC-CBC interface within the 3GPP architecture. It serves to communicate CSB and ETWS messages from the CBC to the BSC, who then @@ -43,8 +43,8 @@ remote-port 46133 remote-ip 1.2.3.4 peer my-bsc-2 - remote-port 46133 - remote-ip 1.2.3.4 + remote-port 46134 + remote-ip 1.2.3.5 ---- For more details on the available configuration commands, please check the OsmoCBC VTY Reference. @@ -64,6 +64,71 @@ local-port 48049 ---- + +=== SBc-AP Peer Configuration + +SBc-AP is the MME-CBC interface within the 3GPP architecture. It serves +to communicate CSB and ETWS messages from the CBC to the MME, who then +subsequently distributes it among the (matching) cells (eNodeBs) within the MME. + +[[config-sbcap]] +==== Configuring the SBc-AP connections + +An MME typically operates as an SCTP server, and the CBC connects as SCTP +client. This would require the CBC to have out-of-band knowledge of all the +MMEs in the network (and their IP addresses). + +In order to comply with the specifications, OsmoCBC supports this mode +of operation as SBc-AP SCTP client. However, to make network operation and +configuration more simple, it also can operate in SCTP server mode, +accepting incoming connections from the MMEs. This way the MMEs need to +know the CBC IP address, but not vice-versa. + +The default port number for the SBc-AP server is 29168, according to the SBc-AP +specification. It uses SCTP payload protocol identifier 24. + +In order to make use of SCTP muti-homing capabilitites, simply configure several +IP addresses when configuring SBc-AP. + +.Example: Configure SCTP server mode and allow arbitrary MMEs to connect +---- +cbc + unknown-peers accept +---- + + +.Example: Configure SCTP client mode and define each BSC +---- +cbc + peer my-mme-1 + protocol sbcap + remote-port 334455 + remote-ip 1.2.3.4 + remote-ip 1.2.3.5 + peer my-mme-2 + protocol sbcap + remote-port 334456 + remote-ip 1.2.3.10 +---- + +For more details on the available configuration commands, please check the OsmoCBC VTY Reference. + +==== Configuring the IP/Port for SBc-AP to bind to + +It can be configured to which IP and SCTP port the SBc-AP protocol binds to. + +The default is to bind to the 3GPP standard port number 29168 for SBc-AP at the +loopback IP address 127.0.0.1 and ::1. + +.Example: Configure SBc-AP to bind to (127.0.0.1,::1):48049 +---- +cbc + sbcap + local-ip 127.0.0.1 + local-ip ::1 + local-port 48049 +---- + [[config-ecbe]] === ECBE (REST Interface) Configuration diff --git a/doc/manuals/chapters/overview.adoc b/doc/manuals/chapters/overview.adoc index c862197..0a7ef23 100644 --- a/doc/manuals/chapters/overview.adoc +++ b/doc/manuals/chapters/overview.adoc @@ -10,7 +10,7 @@ authorities for civil protection, and the various components within the 3GPP network to actually deliver those broadcast and/or emergency messages. -.Role of the CBC inside the 3GPP network architecture +.Role of the CBC inside the 3GPP network architecture (3GPP TS 23.041 §3) [graphviz] ---- include::../images/cbc-in-network.dot[] @@ -23,6 +23,7 @@ implements: - the BSC-CBC interface using the CBSP protocol +- The MME-CBC interface using the SBc-AP protocol - a HTTP/JSON/RESTful interface for external applications - a telnet-based command line interface for configuration and introspection called VTY @@ -30,12 +31,10 @@ - establishing communication with the various Radio Access Network elements such as BSCs within the network - receiving requests to start or remove CBS and ETWS messages from external applications -- distributing the CBS and/or ETWS messages -has connection with the various RANs of the 3GPP cellular network +- distributing the CBS and/or ETWS messages to the various RANs of the 3GPP cellular network -Future versions of OsmoCBC are expected to contain the RNC-CBC interface -with the SABP protocol, as well as the MME-CBC interface using the SBcAP -protocol. Should you be interested in contributing to this effort, +Future versions of OsmoCBC are expected to contain the RNC-CBC interface with +the SABP protocol. Should you be interested in contributing to this effort, please contact the author of this document. === CBSP implementation @@ -57,6 +56,20 @@ For more information, see <<config-cbsp>> on how CBSP is configured. +=== SBc-AP implementation + +SBc-AP (SBc Application Part) is the interface between the Mobility Management +Entity (MME) and the Cell Broadcast Centre (CBC) in 4G networks. It is also the +interface between the Public Warning System – Inter Working Function (PWS-IWF) +and the CBC in 5G networks. It is specified in 3GPP TS 29.168. + +Similarly to what's done with CBSP, OsmoCBC also supports operating SBc-AP as an +SCTP client or an SCTP server. In the first case, OsmoCBC must be passed a list +of MMEs to connect to, while in the second one it will only accept incoming SCTP +connections. + +For more information, see <<config-sbcap>> on how SBc-AP is configured. + === ECBE REST interface 3GPP does not specify the external interface by which competent diff --git a/doc/manuals/images/cbc-in-network.dot b/doc/manuals/images/cbc-in-network.dot index 960156c..da60524 100644 --- a/doc/manuals/images/cbc-in-network.dot +++ b/doc/manuals/images/cbc-in-network.dot @@ -5,13 +5,17 @@ CBC -> BSC [label="CBSP"]; CBC -> RNC [label="SABP"]; CBC -> MME [label="SBc-AP"]; + CBC -> PWSIWF [label="SBc-AP"]; + + PWSIWF -> AMF [label="N50"]; BSC -> BTS [label="A-bis RSL"]; RNC -> NodeB [label="Iub"]; MME -> eNodeB [label="S1-AP"]; + AMF -> gNodeB [label="N2"]; BTS -> UE [label="CBCH"]; NodeB -> UE [label="BMC/CTCH"]; eNodeB -> UE [label="SIB10/11/12"]; - + gNodeB -> UE [label="Uu"]; } -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ic14ec2766fce251a6fe52a77d7bc0bbcd8d3afbf Gerrit-Change-Number: 28640 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-cbc[master]: Fix printf format in 32bit arch

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28645 ) Change subject: Fix printf format in 32bit arch ...................................................................... Fix printf format in 32bit arch Change-Id: I1273a42da2362c2b65169343e3b8d856338b3973 --- M src/sbcap_server_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sbcap_server_fsm.c b/src/sbcap_server_fsm.c index 18167bd..11bbf28 100644 --- a/src/sbcap_server_fsm.c +++ b/src/sbcap_server_fsm.c @@ -206,7 +206,7 @@ if (!ie) return -1; if (ie->size != 2) { - LOGPSBCAPC(client, LOGL_ERROR, "get_msg_id wrong size %ld\n", ie->size); + LOGPSBCAPC(client, LOGL_ERROR, "get_msg_id wrong size %zu\n", ie->size); return -1; } return osmo_load16be(ie->buf); -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28645 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I1273a42da2362c2b65169343e3b8d856338b3973 Gerrit-Change-Number: 28645 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log July 2022