June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: cbsp: Change log level ERROR->INFO on CBSP tx and link down

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28429 ) Change subject: cbsp: Change log level ERROR->INFO on CBSP tx and link down ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: Yes, see pointers. File src/osmo-bsc/cbsp_link.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28429/comment/bdcb4e21_c0f100ed PS1, Line 150: LOGP(DCBS, LOGL_NOTICE, "CBSP Client connected to CBC: %s\n", cbc->client.sock_name); Here https://gerrit.osmocom.org/c/osmo-bsc/+/28429/comment/b9cc3538_44b11b4e PS1, Line 162: LOGP(DCBS, LOGL_NOTICE, "CBSP Client lost connection to %s\n", cbc->client.sock_name); And here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I64356ec6a7b3a4e11a0e66b17efab2788b1ca5cc Gerrit-Change-Number: 28429 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Jun 2022 15:20:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-bsc[master]: cbsp: Avoid encoding CBSP message if link is down

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28428 ) Change subject: cbsp: Avoid encoding CBSP message if link is down ...................................................................... cbsp: Avoid encoding CBSP message if link is down Change-Id: I25c8681d2ee987ac6ebfce42ee409926eb88301d --- M src/osmo-bsc/cbsp_link.c 1 file changed, 7 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/cbsp_link.c b/src/osmo-bsc/cbsp_link.c index 39798df..d8c32ec 100644 --- a/src/osmo-bsc/cbsp_link.c +++ b/src/osmo-bsc/cbsp_link.c @@ -300,6 +300,13 @@ { struct msgb *msg; + if (!cbc->client.cli && !cbc->server.srv) { + LOGP(DCBS, LOGL_ERROR, "Discarding Tx CBSP Message Type %s, link is down\n", + get_value_string(cbsp_msg_type_names, cbsp->msg_type)); + talloc_free(cbsp); + return 0; + } + msg = osmo_cbsp_encode(cbc, cbsp); if (!msg) { LOGP(DCBS, LOGL_ERROR, "Unable to encode CBSP Message Type %s: %s\n", @@ -311,10 +318,6 @@ osmo_stream_cli_send(cbc->client.cli, msg); else if (cbc->server.srv) osmo_stream_srv_send(cbc->server.srv, msg); - else { - LOGP(DCBS, LOGL_ERROR, "Discarding CBSP Message, link is down: %s\n", msgb_hexdump(msg)); - msgb_free(msg); - } talloc_free(cbsp); return 0; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I25c8681d2ee987ac6ebfce42ee409926eb88301d Gerrit-Change-Number: 28428 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years

1
0
0 0

Change in osmo-dev[master]: tmux/ttcn3-bsc-test.sh: configure 4 TRX instances for BTS2

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/28432 ) Change subject: tmux/ttcn3-bsc-test.sh: configure 4 TRX instances for BTS2 ...................................................................... tmux/ttcn3-bsc-test.sh: configure 4 TRX instances for BTS2 Change-Id: I2294c788c1a7d37cb0492c8789b42d993e3f947b --- M ttcn3/tmux/ttcn3-bsc-test.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/ttcn3/tmux/ttcn3-bsc-test.sh b/ttcn3/tmux/ttcn3-bsc-test.sh index 0f76071..2da39f7 100755 --- a/ttcn3/tmux/ttcn3-bsc-test.sh +++ b/ttcn3/tmux/ttcn3-bsc-test.sh @@ -39,6 +39,6 @@ BTS_FEATURES="-fCCN,EGPRS,GPRS,IPv6_NSVC,PAGING_COORDINATION" tmux send-keys -t $SESSION:1.1 "$RESPAWN osmo-bts-omldummy $BTS_FEATURES 127.0.0.1 1234 1" C-m tmux send-keys -t $SESSION:1.2 "$RESPAWN osmo-bts-omldummy $BTS_FEATURES 127.0.0.1 1235 1" C-m -tmux send-keys -t $SESSION:1.3 "$RESPAWN osmo-bts-omldummy $BTS_FEATURES 127.0.0.1 1236 1" C-m +tmux send-keys -t $SESSION:1.3 "$RESPAWN osmo-bts-omldummy $BTS_FEATURES 127.0.0.1 1236 4" C-m tmux attach -t $SESSION:0 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/28432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I2294c788c1a7d37cb0492c8789b42d993e3f947b Gerrit-Change-Number: 28432 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years

1
0
0 0

Change in osmo-dev[master]: tmux/ttcn3-bsc-test.sh: configure 4 TRX instances for BTS2

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/28432 ) Change subject: tmux/ttcn3-bsc-test.sh: configure 4 TRX instances for BTS2 ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/28432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I2294c788c1a7d37cb0492c8789b42d993e3f947b Gerrit-Change-Number: 28432 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Jun 2022 15:15:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-ci[master]: install-coverity: update to 2021.12

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28421 ) Change subject: install-coverity: update to 2021.12 ...................................................................... install-coverity: update to 2021.12 Starting in February 2022, coverity stopped to support the old 2019.03 version that we were using. Unfortunately that didn't generate any e-mail notification to the project admins so it remained undetected until now :( What sucks is that the filename states 2021.12 but then the actual directory created upon extraction is 2021.12.1, meaning our ansible rule breaks. We have to rename the tarball to 2021.12.1 before running the playbook... Closes: OS#5594 Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 --- M ansible/roles/install-coverity/defaults/main.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/ansible/roles/install-coverity/defaults/main.yml b/ansible/roles/install-coverity/defaults/main.yml index 6b97781..d7a8082 100644 --- a/ansible/roles/install-coverity/defaults/main.yml +++ b/ansible/roles/install-coverity/defaults/main.yml @@ -1,4 +1,4 @@ --- -coverity_version: 2019.03 +coverity_version: 2021.12.1 coverity_installer_file: "cov-analysis-linux64-{{ coverity_version }}.tar.gz" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 Gerrit-Change-Number: 28421 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years

1
0
0 0

Change in osmo-ci[master]: install-coverity: update to 2021.12

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28421 ) Change subject: install-coverity: update to 2021.12 ...................................................................... Patch Set 5: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 Gerrit-Change-Number: 28421 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Jun 2022 15:14:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-ci[master]: install-coverity: update to 2021.12

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28421 ) Change subject: install-coverity: update to 2021.12 ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Patchset: PS4: has been deployed already -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I950834cc2ad70979a53a563610bbc9feef1f5f20 Gerrit-Change-Number: 28421 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 28 Jun 2022 15:14:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-gsm-manuals[master]: sigtran: Remove old comment about non-implemented stuff

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28426 ) Change subject: sigtran: Remove old comment about non-implemented stuff ...................................................................... sigtran: Remove old comment about non-implemented stuff As supports multiple ASP with loadshare and override since a long time ago. Change-Id: I703c64a85636c2f9ebbd809e49c0dc8891cb9527 --- M common/chapters/sigtran.adoc 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/common/chapters/sigtran.adoc b/common/chapters/sigtran.adoc index cbf513e..58445bb 100644 --- a/common/chapters/sigtran.adoc +++ b/common/chapters/sigtran.adoc @@ -254,8 +254,8 @@ protocols. An Application Server can have one or more Application Server Processes -associated with it. This functionality (currently not implemented in -Osmocom) can be used for load-balancing or fail-over scenarios. +associated with it. This functionality can be used for load-balancing or +fail-over scenarios. ===== Application Server Process (ASP) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I703c64a85636c2f9ebbd809e49c0dc8891cb9527 Gerrit-Change-Number: 28426 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years

1
0
0 0

Change in osmo-gsm-manuals[master]: sigtran: Use caps in section header

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28427 ) Change subject: sigtran: Use caps in section header ...................................................................... sigtran: Use caps in section header Change-Id: Ie7ff0dced649a29817a5a46e37eaaaf7ee22aea6 --- M common/chapters/sigtran.adoc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/common/chapters/sigtran.adoc b/common/chapters/sigtran.adoc index 58445bb..2cbd84c 100644 --- a/common/chapters/sigtran.adoc +++ b/common/chapters/sigtran.adoc @@ -380,7 +380,7 @@ Osmocom (libosmo-sigtran) implements both the SGP and ASP roles, but not the IPSP role. -==== traffic modes in SIGTRAN +==== Traffic Modes in SIGTRAN Whenever an AS consists of multiple ASPs, the traffic mode expresses how messages are distributed between those ASPs. -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ie7ff0dced649a29817a5a46e37eaaaf7ee22aea6 Gerrit-Change-Number: 28427 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years

1
0
0 0

Change in osmo-gsm-manuals[master]: sigtran: Remove old comment about non-implemented stuff

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28426 ) Change subject: sigtran: Remove old comment about non-implemented stuff ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/28426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I703c64a85636c2f9ebbd809e49c0dc8891cb9527 Gerrit-Change-Number: 28426 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 15:13:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022