May 2022 - gerrit-log - lists.osmocom.org

Build failure of network:osmocom:nightly/osmocom-nightly in openSUSE_Tumbleweed/i586

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmocom-nightly failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmocom-nightly Last lines of build log: /var/cache/obs/worker/root_1/.pkgs/attr.rpm: Input/output error (worker was cloud118:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 1 month

1
0
0 0

Build failure of network:osmocom:nightly/osmo-uecups in Debian_Unstable/x86_64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-uecups failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-uecups Last lines of build log: /var/cache/obs/worker/root_4/.pkgs/libgomp1.deb: Input/output error (worker was cloud118:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 1 month

1
0
0 0

Build failure of network:osmocom:latest/libosmo-sccp in Debian_Unstable/x86_64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/li… Package network:osmocom:latest/libosmo-sccp failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmo-sccp Last lines of build log: Reading from filehandle failed at ./bs_worker line 1379. (worker was cloud118:1) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 1 month

1
0
0 0

Build failure of network:osmocom:latest/libosmocore in Debian_Unstable/x86_64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/li… Package network:osmocom:latest/libosmocore failed to build in Debian_Unstable/x86_64 Check out the package for editing: osc checkout network:osmocom:latest libosmocore Last lines of build log: /var/cache/obs/worker/root_4/.pkgs/libgomp1.deb: Input/output error (worker was cloud118:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 1 month

1
0
0 0

Build failure of network:osmocom:nightly/osmo-msc in openSUSE_Tumbleweed/i586

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-msc failed to build in openSUSE_Tumbleweed/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log: Reading from filehandle failed at ./bs_worker line 1379. (worker was cloud118:4) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 1 month

1
0
0 0

Change in libosmo-abis[master]: input/ipaccess: Don't start zero-ms timer on every write

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28063 ) Change subject: input/ipaccess: Don't start zero-ms timer on every write ...................................................................... input/ipaccess: Don't start zero-ms timer on every write Historically, before November 15, 2010 when commit d49fc5ae24fc9d44d2b284392ab619cc7a69a876 was merged to [back then] OpenBSC, before libosmo-abis became a separate library, we used to have a 10us delay timer for subsequent writes to ip.access nanoBTS 900. ts: Reduce the delay to 0 for OML and RSL This is possible after not sending more than one OML command that requires an extra ACK. For the RSL line we do not need any speed limitation. Ever since the above-mentioned commit, the BSC always sets that timeout to zero, which makes libosmo-abis start a zero-microsecond libosmocore timer, which in turn will make libosmocore call select/poll with zero timeout, which makes the kernel return immediately. Why not remove the timer completely? Because ipaccess-config.c still specifies a non-zero signaling delay, and we cannot be sure that this is really not needed. So let's alter the code to only start the timer if it's non-zero Change-Id: I9c379364e7e6afce35fc6316392b5b33748980f7 --- M src/input/ipaccess.c 1 file changed, 10 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index 9659b36..b995fde 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -494,12 +494,12 @@ int ret; e1i_ts = ipaccess_line_ts(bfd, line); - osmo_fd_write_disable(bfd); /* get the next msg for this timeslot */ msg = e1inp_tx_ts(e1i_ts, &sign_link); if (!msg) { /* no message after tx delay timer */ + osmo_fd_write_disable(bfd); return 0; } @@ -527,11 +527,15 @@ goto err; } - /* set tx delay timer for next event */ - osmo_timer_setup(&e1i_ts->sign.tx_timer, timeout_ts1_write, e1i_ts); - - /* Reducing this might break the nanoBTS 900 init. */ - osmo_timer_schedule(&e1i_ts->sign.tx_timer, 0, e1i_ts->sign.delay); + /* this is some ancient code that apparently exists to slow down writes towards + * some even more ancient nanoBTS 900 units. See git commit + * d49fc5ae24fc9d44d2b284392ab619cc7a69a876 of openbsc.git (now osmo-bsc.git) */ + if (e1i_ts->sign.delay) { + osmo_fd_write_disable(bfd); + /* set tx delay timer for next event */ + osmo_timer_setup(&e1i_ts->sign.tx_timer, timeout_ts1_write, e1i_ts); + osmo_timer_schedule(&e1i_ts->sign.tx_timer, 0, e1i_ts->sign.delay); + } out: msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28063 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9c379364e7e6afce35fc6316392b5b33748980f7 Gerrit-Change-Number: 28063 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in libosmo-abis[master]: input/ipaccess: Don't start zero-ms timer on every write

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28063 ) Change subject: input/ipaccess: Don't start zero-ms timer on every write ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/input/ipaccess.c: https://gerrit.osmocom.org/c/libosmo-abis/+/28063/comment/af0190b7_05c61659 PS1, Line 535: } > I think with this change you are leaving write enabled even if there's no more stuff in the queue to […] with this ancient code I'm not entirely sure if there are any writers which are "scheduled" after this piece of code and which might not call osmo_fd_write_enable(). So best to take it step by step. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28063 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I9c379364e7e6afce35fc6316392b5b33748980f7 Gerrit-Change-Number: 28063 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 08 May 2022 18:31:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: stats: Functions with no arguments should specify(void)

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28067 ) Change subject: stats: Functions with no arguments should specify(void) ...................................................................... stats: Functions with no arguments should specify(void) ... otherwise callers might pass arbitrary arguments without raising a compiler error or warning. Change-Id: Ia2de1d13df5f00dcc42493090734a635029d76b5 --- M include/osmocom/core/stats.h M src/stats.c 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/include/osmocom/core/stats.h b/include/osmocom/core/stats.h index 6544dfa..a034a61 100644 --- a/include/osmocom/core/stats.h +++ b/include/osmocom/core/stats.h @@ -108,7 +108,7 @@ extern struct osmo_stats_config *osmo_stats_config; void osmo_stats_init(void *ctx); -int osmo_stats_report(); +int osmo_stats_report(void); int osmo_stats_set_interval(int interval); diff --git a/src/stats.c b/src/stats.c index 4267284..7b25ab1 100644 --- a/src/stats.c +++ b/src/stats.c @@ -175,7 +175,7 @@ return 0; } -static int start_timer() +static int start_timer(void) { int rc; int interval = osmo_stats_config->interval; @@ -758,7 +758,7 @@ /*** main reporting function ***/ -static void flush_all_reporters() +static void flush_all_reporters(void) { struct osmo_stats_reporter *srep; @@ -781,7 +781,7 @@ } } -int osmo_stats_report() +int osmo_stats_report(void) { /* per group actions */ TRACE(LIBOSMOCORE_STATS_START()); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia2de1d13df5f00dcc42493090734a635029d76b5 Gerrit-Change-Number: 28067 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: stats: Avoid NULL pointer deref in allocation failure paths.

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28068 ) Change subject: stats: Avoid NULL pointer deref in allocation failure paths. ...................................................................... stats: Avoid NULL pointer deref in allocation failure paths. We should either handle talloc returning NULL, or we should OSMO_ASSERT(). Doing neither of the two is a bad idea. Change-Id: I5e8d1cc22cf597f7f50c0f92bf86cb1f1413434c --- M src/stats.c M src/stats_statsd.c 2 files changed, 9 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/stats.c b/src/stats.c index 7b25ab1..16e6f62 100644 --- a/src/stats.c +++ b/src/stats.c @@ -214,7 +214,9 @@ { struct osmo_stats_reporter *srep; srep = talloc_zero(osmo_stats_ctx, struct osmo_stats_reporter); - OSMO_ASSERT(srep); + if (!srep) + return NULL; + srep->type = type; if (name) srep->name = talloc_strdup(srep, name); @@ -486,6 +488,8 @@ } srep->buffer = msgb_alloc(buffer_size, "stats buffer"); + if (!srep->buffer) + goto failed; return 0; @@ -569,6 +573,8 @@ { struct osmo_stats_reporter *srep; srep = osmo_stats_reporter_alloc(OSMO_STATS_REPORTER_LOG, name); + if (!srep) + return NULL; srep->have_net_config = 0; diff --git a/src/stats_statsd.c b/src/stats_statsd.c index b89ec92..b27baff 100644 --- a/src/stats_statsd.c +++ b/src/stats_statsd.c @@ -54,6 +54,8 @@ { struct osmo_stats_reporter *srep; srep = osmo_stats_reporter_alloc(OSMO_STATS_REPORTER_STATSD, name); + if (!srep) + return NULL; srep->have_net_config = 1; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28068 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5e8d1cc22cf597f7f50c0f92bf86cb1f1413434c Gerrit-Change-Number: 28068 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: stats: don't try to save unknown stats reporter types

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28069 ) Change subject: stats: don't try to save unknown stats reporter types ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28069 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2986313375daec1c4959a6a914e3fb2980a5d7ca Gerrit-Change-Number: 28069 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 08 May 2022 18:20:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022