May 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: Revert "fix fallout from: 'stats: new trackers for lchan life duration'"

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28089 ) Change subject: Revert "fix fallout from: 'stats: new trackers for lchan life duration'" ...................................................................... Revert "fix fallout from: 'stats: new trackers for lchan life duration'" This reverts commit a09d78faa97b087e8a17cf29484caf4ffbc27b9e. The whole original patch is also being reverted, so this fix too. Change-Id: Ic9b89b3030eb8cfedabbf20ec8fcbcc225fe028f --- M src/osmo-bsc/lchan_fsm.c 1 file changed, 0 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/89/28089/1 diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index 6854465..d693189 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -528,14 +528,6 @@ lchan->mgw_endpoint_ci_bts = NULL; } - /* Ensure that the osmo_timer in lchan->active_cc is stopped. This is particularly important for lchan FSM - * deallocation, so that the timer is no longer active when the lchan FSM instance gets discarded - * (lchan_fsm_cleanup() calls this function), see OS#5554. - * - * Besides that, it is also good to make sure the timer is stopped when the lchan resets, to avoid any false - * counts being accumulated, however obscure an error situation may be. */ - osmo_time_cc_cleanup(&lchan->active_cc); - /* NUL all volatile state */ *lchan = (struct gsm_lchan){ .ts = lchan->ts, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28089 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic9b89b3030eb8cfedabbf20ec8fcbcc225fe028f Gerrit-Change-Number: 28089 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Revert "stats: new trackers for lchan life duration"

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28090 ) Change subject: Revert "stats: new trackers for lchan life duration" ...................................................................... Revert "stats: new trackers for lchan life duration" This reverts commit 5e2ac29703b4b05f202734698fecdb04b4461bd8. Change-Id: Ibd5123e7f04ae8f4eb8f08b63525527f526f0b2c --- M include/osmocom/bsc/bts.h M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_trx_vty.c M src/osmo-bsc/bts_vty.c M src/osmo-bsc/gsm_data.c M src/osmo-bsc/lchan_fsm.c 7 files changed, 0 insertions(+), 91 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/90/28090/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 0ea019d..58ea39c 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -60,8 +60,6 @@ BTS_CTR_CHAN_ACT_SDCCH, BTS_CTR_CHAN_ACT_TCH, BTS_CTR_CHAN_ACT_NACK, - BTS_CTR_CHAN_TCH_ACTIVE_DECISECONDS_TOTAL, - BTS_CTR_CHAN_SDCCH_ACTIVE_DECISECONDS_TOTAL, BTS_CTR_RSL_UNKNOWN, BTS_CTR_RSL_IPA_NACK, BTS_CTR_RSL_DELETE_IND, diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index 4babe5e..cb20b9e 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -888,8 +888,6 @@ uint8_t interf_band; /* MS power control state */ struct lchan_power_ctrl_state ms_power_ctrl; - /* Interval timing to capture duration per activation and cumulative active time */ - struct osmo_time_cc active_cc; }; /* One Timeslot in a TRX */ @@ -1148,7 +1146,6 @@ char *gsm_ts_name(const struct gsm_bts_trx_ts *ts); char *gsm_ts_and_pchan_name(const struct gsm_bts_trx_ts *ts); void lchan_update_name(struct gsm_lchan *lchan); -uint64_t gsm_lchan_active_duration_ms(const struct gsm_lchan *lchan); static inline char *gsm_lchan_name(const struct gsm_lchan *lchan) { diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 45b4ebe..c04a59e 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -1099,12 +1099,6 @@ [BTS_CTR_CHAN_ACT_NACK] = \ { "chan_act:nack", "Number of Channel Activations that the BTS NACKed" }, - [BTS_CTR_CHAN_TCH_ACTIVE_DECISECONDS_TOTAL] = \ - { "chan_tch:active_deciseconds:total", - "Cumulative number of deciseconds of TCH channel activity" }, - [BTS_CTR_CHAN_SDCCH_ACTIVE_DECISECONDS_TOTAL] = \ - { "chan_sdcch:active_deciseconds:total", - "Cumulative number of deciseconds of SDCCH channel activity" }, [BTS_CTR_RSL_UNKNOWN] = \ { "rsl:unknown", "Number of unknown/unsupported RSL messages received from BTS" }, diff --git a/src/osmo-bsc/bts_trx_vty.c b/src/osmo-bsc/bts_trx_vty.c index d232d46..a3d6033 100644 --- a/src/osmo-bsc/bts_trx_vty.c +++ b/src/osmo-bsc/bts_trx_vty.c @@ -569,13 +569,6 @@ vty_out(vty, "BTS %u, TRX %u, Timeslot %u, Lchan %u: Type %s%s", lchan->ts->trx->bts->nr, lchan->ts->trx->nr, lchan->ts->nr, lchan->nr, gsm_lchant_name(lchan->type), VTY_NEWLINE); - - if (lchan->activate.concluded) { - vty_out(vty, " Activated %s seconds ago%s", - osmo_int_to_float_str_c(OTC_SELECT, gsm_lchan_active_duration_ms(lchan), 3), - VTY_NEWLINE); - } - vty_out_dyn_ts_details(vty, lchan->ts); vty_out(vty, " Connection: %u, State: %s%s%s%s", lchan->conn ? 1: 0, lchan_state_name(lchan), diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 8af96ed..4e60cd8 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -3677,8 +3677,6 @@ struct gsm_bts_trx *trx; int ts_hopping_total; int ts_non_hopping_total; - const struct rate_ctr *activations_tch; - const struct rate_ctr *activations_sdcch; vty_out(vty, "BTS %u is of %s type in band %s, has CI %u LAC %u, " "BSIC %u (NCC=%u, BCC=%u) and %u TRX%s", @@ -3853,29 +3851,6 @@ rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_TOTAL)->current, rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHREQ_NO_CHANNEL)->current, VTY_NEWLINE); - - vty_out(vty, " Channel Activations :%s", VTY_NEWLINE); - activations_tch = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHAN_ACT_TCH); - vty_out(vty, " TCH %"PRIu64"", activations_tch->current); - if (activations_tch->intv[RATE_CTR_INTV_HOUR].rate > 0) { - const struct rate_ctr *active_time_tch_ds = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHAN_TCH_ACTIVE_DECISECONDS_TOTAL); - vty_out(vty, " (avg lifespan %s seconds in last hour)", - osmo_int_to_float_str_c(OTC_SELECT, - 100 * active_time_tch_ds->intv[RATE_CTR_INTV_HOUR].rate - / activations_tch->intv[RATE_CTR_INTV_HOUR].rate, 3)); - } - vty_out(vty, "%s", VTY_NEWLINE); - activations_sdcch = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHAN_ACT_SDCCH); - vty_out(vty, " SDCCH %"PRIu64"", activations_sdcch->current); - if (activations_sdcch->intv[RATE_CTR_INTV_HOUR].rate > 0) { - const struct rate_ctr *active_time_sdcch_ds = rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHAN_SDCCH_ACTIVE_DECISECONDS_TOTAL); - vty_out(vty, " (avg lifespan %s seconds in last hour)", - osmo_int_to_float_str_c(OTC_SELECT, - 100 * active_time_sdcch_ds->intv[RATE_CTR_INTV_HOUR].rate - / activations_sdcch->intv[RATE_CTR_INTV_HOUR].rate, 3)); - } - vty_out(vty, "%s", VTY_NEWLINE); - vty_out(vty, " Channel Failures : %"PRIu64" rf_failures, %"PRIu64" rll failures%s", rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHAN_RF_FAIL)->current, rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_CHAN_RLL_ERR)->current, diff --git a/src/osmo-bsc/gsm_data.c b/src/osmo-bsc/gsm_data.c index 3438eaf..22be92d 100644 --- a/src/osmo-bsc/gsm_data.c +++ b/src/osmo-bsc/gsm_data.c @@ -342,15 +342,6 @@ lchan->nr - (lchan->vamos.is_secondary ? ts->max_primary_lchans : 0)); } -/* If the lchan is currently active, return the duration since activation in milliseconds. - * Otherwise return 0. */ -uint64_t gsm_lchan_active_duration_ms(const struct gsm_lchan *lchan) -{ - if (!lchan->activate.concluded) - return 0; - return lchan->active_cc.total_sum / 1000; -} - /* obtain the MO structure for a given object instance */ static inline struct gsm_abis_mo * gsm_objclass2mo(struct gsm_bts *bts, uint8_t obj_class, diff --git a/src/osmo-bsc/lchan_fsm.c b/src/osmo-bsc/lchan_fsm.c index d693189..5df6c57 100644 --- a/src/osmo-bsc/lchan_fsm.c +++ b/src/osmo-bsc/lchan_fsm.c @@ -200,33 +200,10 @@ static void lchan_on_fully_established(struct gsm_lchan *lchan) { - struct rate_ctr *rate_ctr; - if (lchan->activate.concluded) return; lchan->activate.concluded = true; - /* Assign timekeeper to appropriate rate counter */ - switch (lchan->type) { - case GSM_LCHAN_TCH_H: - case GSM_LCHAN_TCH_F: - rate_ctr = rate_ctr_group_get_ctr(lchan->ts->trx->bts->bts_ctrs, BTS_CTR_CHAN_TCH_ACTIVE_DECISECONDS_TOTAL); - break; - case GSM_LCHAN_SDCCH: - rate_ctr = rate_ctr_group_get_ctr(lchan->ts->trx->bts->bts_ctrs, BTS_CTR_CHAN_SDCCH_ACTIVE_DECISECONDS_TOTAL); - break; - default: - rate_ctr = NULL; - break; - } - lchan->active_cc.cfg.rate_ctr = rate_ctr; - - /* This reset allows showing on vty how long ago a single active lchan was activated. - * This reset does not affect rate_ctr statistics. */ - osmo_time_cc_cleanup(&lchan->active_cc); - /* Start the timekeeper */ - osmo_time_cc_set_flag(&lchan->active_cc, true); - switch (lchan->activate.info.activ_for) { case ACTIVATE_FOR_MS_CHANNEL_REQUEST: /* No signalling to do here, MS is free to use the channel, and should go on to connect @@ -486,16 +463,6 @@ OSMO_ASSERT(lchan->fi); lchan->fi->priv = lchan; lchan_fsm_update_id(lchan); - - /* Configure timekeeper to track this lchan's cumulative active milliseconds */ - lchan->active_cc = (struct osmo_time_cc){ - .cfg = { - .gran_usec = 1*100000, - .forget_sum_usec = 1, - .rate_ctr = NULL, - }, - }; - LOGPFSML(lchan->fi, LOGL_DEBUG, "new lchan\n"); lchan_reset(lchan); } @@ -544,8 +511,6 @@ .tsc_set = 1, .interf_dbm = INTERF_DBM_UNKNOWN, .interf_band = INTERF_BAND_UNKNOWN, - - .active_cc = lchan->active_cc, }; } @@ -553,10 +518,6 @@ { struct gsm_lchan *lchan = lchan_fi_lchan(fi); struct gsm_bts *bts = lchan->ts->trx->bts; - - /* Stop the timekeeper */ - osmo_time_cc_set_flag(&lchan->active_cc, false); - lchan_reset(lchan); osmo_fsm_inst_dispatch(lchan->ts->fi, TS_EV_LCHAN_UNUSED, lchan); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28090 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibd5123e7f04ae8f4eb8f08b63525527f526f0b2c Gerrit-Change-Number: 28090 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in libosmo-abis[master]: input/ipaccess: Remove unneeded osmo_fd_write_enable()

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/28070 ) Change subject: input/ipaccess: Remove unneeded osmo_fd_write_enable() ...................................................................... input/ipaccess: Remove unneeded osmo_fd_write_enable() Recent commit optimize the same function by avoiding an extra poll loop when e1i_ts->sign.delay was zero. Upon doing so, the osmo_fd_write_disable() was moved to some conditional paths. Hence, the WRITE flag is left set and we don't need to set it again in the code path modified in this commit. Fixes: 28fea7746bbc2fb8ca0f677a93559c0c9f4cff09 Change-Id: I84787b6de2a5ccc82bd8f19ce874e73708bc287f --- M src/input/ipaccess.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index b995fde..ca48d21 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -509,7 +509,7 @@ case E1INP_SIGN_OSMO: break; default: - osmo_fd_write_enable(bfd); /* come back for more msg */ + /* leave WRITE flag enabled, come back for more msg */ ret = -EINVAL; goto out; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/28070 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I84787b6de2a5ccc82bd8f19ce874e73708bc287f Gerrit-Change-Number: 28070 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: > I am starting on this now. […] Agree with 1 per BTS. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 22 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 May 2022 10:44:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: iedemam <michael(a)kapsulate.com> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration

by iedemam

iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: I am starting on this now. I will rework the patch to have one timer per BTS instead of one timer per lchan. My instinct to use one per BTS instead of one global for the entire BSC is so that stat summation activity is spread out in smaller chunks instead of in one large task for potentially thousands of lchans. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 22 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 May 2022 07:32:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Build failure of network:osmocom:nightly/osmo-bsc-nat in Debian_11/aarch64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-bsc-nat failed to build in Debian_11/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc-nat Last lines of build log: connect to src-opensuse:5353: Connection refused (worker was obs-arm-9:5) -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: > I agree. […] I agree with Harald the main point is avoid having so many timers. So I'd start by migrating to having 1 timer per BTS, or 1 main BSC timer which triggers ever 500ms-1s and which then iterates to update the data for all its depending lchans. Counting for SDCCH on top of TCH shouldn't make a big different imho if calculated in the same iteration. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 22 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 May 2022 17:12:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: iedemam <michael(a)kapsulate.com> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration

by iedemam

iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: I agree. Some things which would still keep this feature useful to us but will reduce the performance impact: 1) reduce granularity from 0.1s to 1s: While I'd like to keep 100ms resolution, maybe there's no way to do it efficiently. 2) only start timers and track stats on TCH lchans: We're primarily using this to gather Erlang stats and secondarily to glance site health. Even if it's only TCH it still serves that purpose. The biggest BSC we're talking about has 4480 SDCCH lchans defined and 3200 TCH. The combination of 1 and 2 above gives us a full order of magnitude drop and then cuts that in half. Maybe a better starting point? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 22 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 May 2022 17:06:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration

by pespin

Attention is currently required from: iedemam. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: > So due to severe performance regressions, I think we will have to re-open the discussion about this […] I also think having subsecond granularity may not be that interesting given the amount of extra performance penalty induced. Maybe if at all have it at 500ms minimum. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 22 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Wed, 11 May 2022 17:00:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: stats: new trackers for lchan life duration

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 ) Change subject: stats: new trackers for lchan life duration ...................................................................... Patch Set 22: (1 comment) Patchset: PS22: So due to severe performance regressions, I think we will have to re-open the discussion about this code. It adds one osmo_timer for each lchan, and that timer expires every 100ms. So thinking of a system with 80 BTS and each BTS having a single trx with ~ 16 lchan, we end up with 12800 (!) timers expiring each second! This is certainly the single biggest performance hog in osmo-bsc for any setup larger than the most trivial one. Whatever we do, we have to do better than that. Like one timer expiring every 100ms iteratinng over the lchans? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27081 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347 Gerrit-Change-Number: 27081 Gerrit-PatchSet: 22 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 11 May 2022 16:39:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022