May 2022 - gerrit-log - lists.osmocom.org

Change in osmo-msc[master]: vlr: Add rate counters and stat items

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28116 to look at the new patch set (#3). Change subject: vlr: Add rate counters and stat items ...................................................................... vlr: Add rate counters and stat items This should give us some more insight into what is happening inside the MSC's VLR in terms of number of subcribers, rate of successful / unsuccessful GSUP procedures, etc. Related: OS#1974 Change-Id: I681bcfc1875363478190151f2931cad197323ee8 --- M include/osmocom/msc/vlr.h M src/libvlr/vlr.c 2 files changed, 193 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/16/28116/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I681bcfc1875363478190151f2931cad197323ee8 Gerrit-Change-Number: 28116 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: vlr: Split vlr_subscr_rx_imsi_detach()

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28115 ) Change subject: vlr: Split vlr_subscr_rx_imsi_detach() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iffc02f3062ad591ca372a3c6d866066cf63a8830 Gerrit-Change-Number: 28115 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 15 May 2022 14:03:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: vlr: Add rate counters and stat items

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28116 ) Change subject: vlr: Add rate counters and stat items ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I681bcfc1875363478190151f2931cad197323ee8 Gerrit-Change-Number: 28116 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 15 May 2022 14:02:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: sms_queue: refactor sms_pending add/remove code

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/28118 ) Change subject: sms_queue: refactor sms_pending add/remove code ...................................................................... sms_queue: refactor sms_pending add/remove code This avoids every caller from manually having to remember to increment the count, the stat_item and llist_{add,del}. Change-Id: Ice4c73727ef2d7e4118f0ef5fe24cae943c7528f --- M src/libmsc/sms_queue.c 1 file changed, 19 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/18/28118/1 diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c index 31ee6de..c78b4a7 100644 --- a/src/libmsc/sms_queue.c +++ b/src/libmsc/sms_queue.c @@ -204,9 +204,19 @@ return pending; } -/* release a gsm_sms_pending object */ -static void sms_pending_free(struct gsm_sms_pending *pending) +/* add (append) a gsm_sms_pending to the queue pending_sms list */ +static void sms_pending_add(struct gsm_sms_queue *smsq, struct gsm_sms_pending *pending) { + smsq->pending += 1; + smsq_stat_item_inc(smsq, SMSQ_STAT_SMS_RAM_PENDING); + llist_add_tail(&pending->entry, &smsq->pending_sms); +} + +/* release a gsm_sms_pending object */ +static void sms_pending_free(struct gsm_sms_queue *smsq, struct gsm_sms_pending *pending) +{ + smsq->pending -= 1; + smsq_stat_item_dec(smsq, SMSQ_STAT_SMS_RAM_PENDING); vlr_subscr_put(pending->vsub, VSUB_USE_SMS_PENDING); llist_del(&pending->entry); talloc_free(pending); @@ -245,9 +255,7 @@ if (pending->failed_attempts < smsq->max_fail) return sms_pending_resend(pending); - sms_pending_free(pending); - smsq->pending -= 1; - smsq_stat_item_dec(smsq, SMSQ_STAT_SMS_RAM_PENDING); + sms_pending_free(smsq, pending); } /* Resend all SMS that are scheduled for a resend. This is done to @@ -268,9 +276,7 @@ /* the sms is gone? Move to the next */ if (!sms) { - sms_pending_free(pending); - smsq->pending -= 1; - smsq_stat_item_dec(smsq, SMSQ_STAT_SMS_RAM_PENDING); + sms_pending_free(smsq, pending); sms_queue_trigger(smsq); } else { pending->resend = 0; @@ -405,9 +411,7 @@ } attempted += 1; - smsq->pending += 1; - smsq_stat_item_inc(smsq, SMSQ_STAT_SMS_RAM_PENDING); - llist_add_tail(&pending->entry, &smsq->pending_sms); + sms_pending_add(smsq, pending); _gsm411_send_sms(smsq->network, sms->receiver, sms); } while (attempted < attempts && rounds < 1000); @@ -445,9 +449,7 @@ goto no_pending_sms; } - smsq->pending += 1; - smsq_stat_item_inc(smsq, SMSQ_STAT_SMS_RAM_PENDING); - llist_add_tail(&pending->entry, &smsq->pending_sms); + sms_pending_add(smsq, pending); _gsm411_send_sms(smsq->network, sms->receiver, sms); return; @@ -592,21 +594,17 @@ case S_SMS_DELIVERED: smsq_rate_ctr_inc(network->sms_queue, SMSQ_CTR_SMS_DELIVERY_ACK); /* Remember the subscriber and clear the pending entry */ - network->sms_queue->pending -= 1; - smsq_stat_item_dec(network->sms_queue, SMSQ_STAT_SMS_RAM_PENDING); vsub = pending->vsub; vlr_subscr_get(vsub, __func__); db_sms_delete_sent_message_by_id(pending->sms_id); - sms_pending_free(pending); + sms_pending_free(network->sms_queue, pending); /* Attempt to send another SMS to this subscriber */ sms_send_next(vsub); vlr_subscr_put(vsub, __func__); break; case S_SMS_MEM_EXCEEDED: smsq_rate_ctr_inc(network->sms_queue, SMSQ_CTR_SMS_DELIVERY_NOMEM); - network->sms_queue->pending -= 1; - smsq_stat_item_dec(network->sms_queue, SMSQ_STAT_SMS_RAM_PENDING); - sms_pending_free(pending); + sms_pending_free(network->sms_queue, pending); sms_queue_trigger(network->sms_queue); break; case S_SMS_UNKNOWN_ERROR: @@ -679,10 +677,8 @@ llist_for_each_entry_safe(pending, tmp, &smsq->pending_sms, entry) { LOGP(DLSMS, LOGL_NOTICE, "SMSqueue clearing for sub %llu\n", pending->vsub->id); - sms_pending_free(pending); + sms_pending_free(smsq, pending); } - smsq->pending = 0; - smsq_stat_item_set(smsq, SMSQ_STAT_SMS_RAM_PENDING, 0); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ice4c73727ef2d7e4118f0ef5fe24cae943c7528f Gerrit-Change-Number: 28118 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: sms_queue: merge sms_pending_add into sms_pending_from

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/28119 ) Change subject: sms_queue: merge sms_pending_add into sms_pending_from ...................................................................... sms_queue: merge sms_pending_add into sms_pending_from Both callers would immediately execute sms_pending_add() after a successful sms_pending_from(); we can merge those two functions. Change-Id: Iaf37234b3caafd568dd4fe17739be9ec842c2a8d --- M src/libmsc/sms_queue.c 1 file changed, 3 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/19/28119/1 diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c index c78b4a7..4d1c3d0 100644 --- a/src/libmsc/sms_queue.c +++ b/src/libmsc/sms_queue.c @@ -201,15 +201,12 @@ vlr_subscr_get(sms->receiver, VSUB_USE_SMS_PENDING); pending->vsub = sms->receiver; pending->sms_id = sms->id; - return pending; -} + llist_add_tail(&pending->entry, &smsq->pending_sms); -/* add (append) a gsm_sms_pending to the queue pending_sms list */ -static void sms_pending_add(struct gsm_sms_queue *smsq, struct gsm_sms_pending *pending) -{ smsq->pending += 1; smsq_stat_item_inc(smsq, SMSQ_STAT_SMS_RAM_PENDING); - llist_add_tail(&pending->entry, &smsq->pending_sms); + + return pending; } /* release a gsm_sms_pending object */ @@ -411,7 +408,6 @@ } attempted += 1; - sms_pending_add(smsq, pending); _gsm411_send_sms(smsq->network, sms->receiver, sms); } while (attempted < attempts && rounds < 1000); @@ -449,7 +445,6 @@ goto no_pending_sms; } - sms_pending_add(smsq, pending); _gsm411_send_sms(smsq->network, sms->receiver, sms); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaf37234b3caafd568dd4fe17739be9ec842c2a8d Gerrit-Change-Number: 28119 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: vlr: Add rate counters and stat items

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28116 to look at the new patch set (#2). Change subject: vlr: Add rate counters and stat items ...................................................................... vlr: Add rate counters and stat items This should give us some more insight into what is happening inside the MSC's VLR in terms of number of subcribers, rate of successful / unsuccessful GSUP procedures, etc. Related: OS#1974 Change-Id: I681bcfc1875363478190151f2931cad197323ee8 --- M include/osmocom/msc/vlr.h M src/libvlr/vlr.c 2 files changed, 193 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/16/28116/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I681bcfc1875363478190151f2931cad197323ee8 Gerrit-Change-Number: 28116 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Add new Manual "OsmoBSC CBSP Protocol Specification"

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28099 ) Change subject: Add new Manual "OsmoBSC CBSP Protocol Specification" ...................................................................... Add new Manual "OsmoBSC CBSP Protocol Specification" This document decribes the level of CBSP support in the codebase. Related: SYS#5945 Change-Id: I2e18e167281fac3abaf380089ff883738ebaa0a0 --- M doc/manuals/Makefile.am A doc/manuals/cbsp/messages.adoc A doc/manuals/cbsp/procedures.adoc A doc/manuals/osmobsc-cbsp-docinfo.xml A doc/manuals/osmobsc-cbsp.adoc 5 files changed, 266 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/doc/manuals/Makefile.am b/doc/manuals/Makefile.am index c86f215..8b2a8ef 100644 --- a/doc/manuals/Makefile.am +++ b/doc/manuals/Makefile.am @@ -1,10 +1,13 @@ EXTRA_DIST = aoip-mgw-options.adoc \ aoip-mgw-options-docinfo.xml \ + osmobsc-cbsp.adoc \ + osmobsc-cbsp-docinfo.xml \ osmobsc-usermanual.adoc \ osmobsc-usermanual-docinfo.xml \ osmobsc-vty-reference.xml \ osmux-reference.adoc \ osmux-reference-docinfo.xml \ + cbsp \ chapters \ message-sequences \ mgw \ @@ -13,9 +16,10 @@ vty if BUILD_MANUALS - ASCIIDOC = osmobsc-usermanual.adoc osmux-reference.adoc aoip-mgw-options.adoc + ASCIIDOC = osmobsc-usermanual.adoc osmobsc-cbsp.adoc osmux-reference.adoc aoip-mgw-options.adoc include $(OSMO_GSM_MANUALS_DIR)/build/Makefile.asciidoc.inc osmobsc-usermanual.pdf: $(srcdir)/chapters/*.adoc $(srcdir)/chapters/*.dot + osmobsc-cbsp.pdf: $(srcdir)/cbsp/*.adoc #$(srcdir)/cbsp/*.dot $(srcdir)/abis/*.msc aoip-mgw-options.pdf: $(srcdir)/aoip-mgw-options.adoc $(srcdir)/mgw/*.msc VTY_REFERENCE = osmobsc-vty-reference.xml diff --git a/doc/manuals/cbsp/messages.adoc b/doc/manuals/cbsp/messages.adoc new file mode 100644 index 0000000..d595b95 --- /dev/null +++ b/doc/manuals/cbsp/messages.adoc @@ -0,0 +1,73 @@ +== CBSP Messages + +=== List of Messages + +The following tables list the CBSP messages used by OsmoBSC BSC-CBC interface, +grouped by their level of compliance with 3GPP TS 48.049. + +==== Messages Compliant With TS 48.049 + +Specific additions and limitations apply, see the linked sections. + +.Messages compliant with TS 48.049 +[options="header",cols="10%,20%,45%,5%,20%"] +|=== +| TS 48.049 § | This document § | Message | <-/-> | Received/Sent by OsmoBSC +| 8.1.3.1 | - | WRITE-REPLACE | <- | Received +| 8.1.3.2 | - | WRITE-REPLACE COMPLETE | -> | Sent +| 8.1.3.3 | - | WRITE-REPLACE FAILURE | -> | Sent +| 8.1.3.4 | - | KILL | <- | Received +| 8.1.3.5 | - | KILL COMPLETE | -> | Sent +| 8.1.3.6 | - | KILL FAILURE | -> | Sent +| 8.1.3.10 | - | MESSAGE STATUS QUERY | <- | Received +| 8.1.3.11 | - | MESSAGE STATUS QUERY COMPLETE | -> | Sent +| 8.1.3.12 | - | MESSAGE STATUS QUERY FAILURE | -> | Sent +| 8.1.3.16 | - | RESET | <- | Received +| 8.1.3.17 | - | RESET COMPLETE | -> | Sent +| 8.1.3.18 | <<RESET_FAILURE>> | RESET FAILURE | -> | Sent +| 8.1.3.18a | <<KEEP_ALIVE>> | KEEP-ALIVE | <- | Received +| 8.1.3.18b | - | KEEP-ALIVE COMPLETE | -> | Sent +| 8.1.3.19 | <<RESTART>> | RESTART | -> | Sent +|=== + +==== Messages Not Implemented by OsmoBSC + +.3GPP TS 48.049 messages not implemented by OsmoBSC +[options="header",cols="30%,45%,5%,20%"] +|=== +| TS 48.049 § | Message | <-/-> | Received/Sent by OsmoBSC +| 8.1.3.7 | LOAD QUERY | <- | Received +| 8.1.3.8 | LOAD QUERY COMPLETE | -> | Sent +| 8.1.3.9 | LOAD QUERY FAILURE | -> | Sent +| 8.1.3.13 | SET-DRX | <- | Received +| 8.1.3.14 | SET-DRX COMPLETE | -> | Sent +| 8.1.3.15 | SET-DRX FAILURE | -> | Sent +| 8.1.3.20 | FAILURE | -> | Sent +| 8.1.3.21 | ERROR INDICATION | -> | Sent +|=== + + +=== Message Limitation Details + +[[RESET_FAILURE]] +==== RESET FAILURE + +Encoding of this message is implemented, but there is currently no +condition in the OsmoBSC code that would make a RESET operation fail on +an existing cell, except if the CBC were to identify +a non-existent cell in its _Cell List IE_. + +[[KEEP_ALIVE]] +==== KEEP-ALIVE + +The message is received and generates a corresponding KEEP-ALIVE +COMPLETE answer. However, the _Keep Alive Repetition Period IE_ is not +interpreted. + +[[RESTART]] +==== RESTART + +The RESTART message is sent only at the time of establishment of every +CBSP link. It is not sent when subsequent cells become available during +runtime of the CBSP link. + diff --git a/doc/manuals/cbsp/procedures.adoc b/doc/manuals/cbsp/procedures.adoc new file mode 100644 index 0000000..1920149 --- /dev/null +++ b/doc/manuals/cbsp/procedures.adoc @@ -0,0 +1,83 @@ +== CBSP Procedures + +=== List of Procedures + +The following tables list the CBSP procedures used by the OsmoBSC BSC-CBC interface, +grouped by their level of compliance with 3GPP TS 48.049. + +==== Procedures Compliant With TS 48.049 + +Specific additions and limitations apply, see the linked sections. + +.Procedures compliant with TS 48.049 +[options="header",cols="10%,20%,40%,30%"] +|=== +| TS 48.049 § | This document § | Procedure | Originated/Terminated by OsmoBSC +| 7.2 | <<PROC_WRITE_REPLACE>> | Write-Replace | Terminated +| 7.3 | - | Kill | Terminated +| 7.5 | - | Message Status Query | Terminated +| 7.7a | <<PROC_KEEP_ALIVE>> | Keep Alive | Terminated +| 7.8 | <<RESTART_IND>> | Restart Indication | Originated +|=== + + +[[PROC_WRITE_REPLACE]] +===== Write-Replace + +Procedures for _Write_ and _Replace_ of CBS messages as per 3GPP TS 48.049 Section 7.2.2.2 +are fully supported. + +Procedures for _Write_ and _Replace_ of ETWS messages as per 3GPP TS +48.059 Section 7.2.2.2 are fully supported. Transmission of the ETWS +Primary Notification is implemented as follows, assuming related support +is present in the related BTS and PCU software (true for OsmoBTS >= 1.2.0 +and OsmoPCU >= 0.8.0): + +* broadcast to MS in idle mode / packet idle mode by sending a + vendor-specific A-bis RSL message to each affected BTS. A + vendor-specific mechanism is needed as 3GPP TS 48.058 does not specify + any standard message for this. See the section on _Osmocom ETWS + Command_ in <<osmobts-abis-spec>> for more details. +* broadcast to MS in dedicated mode by sending the ETWS PN via every + currently active dedicated channel (SDCCH, FACCH) within the affected + BTSs. + +As an additional clarification to 3GPP TS 48.049, OsmoBSC rejects (via +WRITE-REPLACE FAILURE) any _write_ procedure for an emergency message if +there already is another emergency message active in a cell. The +_replace_ procedure must be used (by specifying the _Old Serial Number +IE_) if the only existing emergency message of a cell shall be replaced. + +[[PROC_KEEP_ALIVE]] +===== Keep-Alive + +The Keep-Alive procedure is implemented only in as far as incoming +Keep-Alive requests are responded to. + +The BSC currently does not use the _Keep Alive Repetition Period IE_. +This is permitted as 3GPP TS 48.049 states the information _may_ be used +by the BSC. + +[[PROC_RESTART_IND]] +===== Restart Indication + +Restart indications are currently only sent whenever any BSC-CBC link is +established. They are not sent once subsequent cells become available +or are re-initialized due to A-bis link failure. + +However, CBSP state for both CBS and Emergency messages is kept +persistent in the BSC and if cells reboot / restart during the duration +of a CBS / emergency message, they will resume broadcasts as expected. + + +==== Procedures Not Implemented by OsmoBSC + +.3GPP TS 48.049 procedures not implemented by OsmoBSC +[options="header",cols="30%,40%,30%"] +|=== +| TS 48.049 § | Procedure | Originated/Terminated by OsmoBSC +| 7.4 | Load Status Enquiry | Terminated +| 7.6 | Set DRX | Terminated +| 7.9 | Failure Indication | Originated +| 7.10 | Error Indication | Originated +|=== diff --git a/doc/manuals/osmobsc-cbsp-docinfo.xml b/doc/manuals/osmobsc-cbsp-docinfo.xml new file mode 100644 index 0000000..a86fd28 --- /dev/null +++ b/doc/manuals/osmobsc-cbsp-docinfo.xml @@ -0,0 +1,36 @@ + +<authorgroup> + <author> + <firstname>Harald</firstname> + <surname>Welte</surname> + <email>hwelte(a)sysmocom.de</email> + <authorinitials>HW</authorinitials> + <affiliation> + <shortaffil>sysmocom</shortaffil> + <orgname>sysmocom - s.f.m.c. GmbH</orgname> + <jobtitle>Managing Director</jobtitle> + </affiliation> + </author> +</authorgroup> + +<copyright> + <year>2022</year> + <holder>sysmocom - s.f.m.c. GmbH</holder> +</copyright> + +<legalnotice> + <para> + Permission is granted to copy, distribute and/or modify this + document under the terms of the GNU Free Documentation License, + Version 1.3 or any later version published by the Free Software + Foundation; with no Invariant Sections, no Front-Cover Texts, + and no Back-Cover Texts. A copy of the license is included in + the section entitled "GNU Free Documentation License". + </para> + <para> + The Asciidoc source code of this manual can be found at + <ulink url="https://git.osmocom.org/osmo-bsc/"> + https://git.osmocom.org/osmo-bsc/ + </ulink> + </para> +</legalnotice> diff --git a/doc/manuals/osmobsc-cbsp.adoc b/doc/manuals/osmobsc-cbsp.adoc new file mode 100644 index 0000000..89af8df --- /dev/null +++ b/doc/manuals/osmobsc-cbsp.adoc @@ -0,0 +1,69 @@ +:gfdl-enabled: + +OsmoBSC CBSP Protocol Specification +=================================== +Harald Welte <hwelte(a)sysmocom.de> + +== Introduction + +This document describes the CBSP interface of *OsmoBSC* as spoken on the +BSC-CBC interface. Based on 3GPP TS 48.049 <<3gpp-ts-48-049>>, this document indicates +which of the 3GPP specified CBSP messages and IEs are implemented +according to 3GPP specifications, which of these are not or not fully +implemented, as well as OsmoBSC-specific extensions to the CBSP +interface not specified by 3GPP. + +For details on the standard CBSP messages and IE definitions, +please refer to the 3GPP documents. + +.3GPP document versions referred to by this document +[cols="20%,80%"] +|=== +|3GPP TS 48.049 | version 12.0.0 Release 12 +|=== + +.IETF documents referred to by his document +[cols="20%,80%"] +|=== +|IETF RFC 793 | Transmission Control Protocol +|=== + +== Overview + +The OsmoBSC BSC-CBC interface consists of CBSP messages transmitted over +TCP. + +The default TCP destination port number is TCP port 48049; this can be +changed by configuration, as described in the OsmoBSC user manual +<<userman-osmobsc>> and/or VTY reference manual <<vty-ref-osmobsc>>. + +.TCP port numbers used by OsmoBTS Abis/IP +[options="header",width="50%",cols="35%,65%"] +|=== +|TCP Port Number|Usage +|48049|CBSP +|=== + +OsmoBSC implements both _TCP server_ and _TCP client_ role; it is hence +configurable whether the CBC establishes the TCP connection to the BSC +(BSC in _TCP server_ role) or if the BSC establishes the TCP connection +to the CBC (BSC in _TCP client_ role). + +Currently, only transport of TCP via IPv4 is implemented. + +Any IP-capable link-layer protocol implemented in the underlying Linux +operating system can be used to transport the IP/TCP/CBSP of OsmoBSC. + + +include::{srcdir}/cbsp/procedures.adoc[] + +include::{srcdir}/cbsp/messages.adoc[] + + +include::./common/chapters/port_numbers.adoc[] + +include::./common/chapters/bibliography.adoc[] + +include::./common/chapters/glossary.adoc[] + +include::./common/chapters/gfdl.adoc[] -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2e18e167281fac3abaf380089ff883738ebaa0a0 Gerrit-Change-Number: 28099 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: smscb: "Warning Security Information is always present in ETWS

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28094 ) Change subject: smscb: "Warning Security Information is always present in ETWS ...................................................................... smscb: "Warning Security Information is always present in ETWS As per TS 48.049 Table 8.1.3.1.1 the WRITE-REPLACE message always has a Warning Security Information IE if it relates to ETWS. This is also implemented in the libosmocore CBSP parser. As the previous Change Id369bb3676ba279bafc234378fbe21dbc7b0614b has pointed out, the CBSP parser structure doesn't even permit any way of handing a decoded message to us without the warning_sec_info static struct member. So as a result, there's also no need to dynamically allocate bts_etws_state.input.sec_info via talloc. We can have it in-line as a static struct member and reduce code complexity and runtime memory allocations. Change-Id: Ib1b8e4af37b1f9f9398b81dad29942e82218c70b --- M include/osmocom/bsc/gsm_data.h M src/osmo-bsc/smscb.c 2 files changed, 4 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h index cb20b9e..6df7c61 100644 --- a/include/osmocom/bsc/gsm_data.h +++ b/include/osmocom/bsc/gsm_data.h @@ -29,6 +29,7 @@ #include <osmocom/gsm/rxlev_stat.h> #include <osmocom/gsm/protocol/gsm_08_58.h> #include <osmocom/gsm/protocol/gsm_12_21.h> +#include <osmocom/gsm/protocol/gsm_03_41.h> #include <osmocom/abis/e1_input.h> #include <osmocom/bsc/meas_rep.h> #include <osmocom/bsc/acc.h> @@ -1098,7 +1099,7 @@ uint16_t msg_id; uint16_t serial_nr; uint16_t warn_type; - uint8_t *sec_info; + uint8_t sec_info[ETWS_SEC_INFO_SIZE]; } input; /* encoded ETWS primary notification */ uint8_t primary[ETWS_PRIM_NOTIF_SIZE]; diff --git a/src/osmo-bsc/smscb.c b/src/osmo-bsc/smscb.c index 3a06697..8e2eb0c 100644 --- a/src/osmo-bsc/smscb.c +++ b/src/osmo-bsc/smscb.c @@ -70,9 +70,7 @@ osmo_store16be(serial_nr, out); etws->msg_id = osmo_htons(msg_id); etws->warning_type = osmo_htons(warn_type); - - if (sec_info) - memcpy(etws->data, sec_info, ETWS_PRIM_NOTIF_SIZE - sizeof(*etws)); + memcpy(etws->data, sec_info, ETWS_PRIM_NOTIF_SIZE - sizeof(*etws)); return ETWS_PRIM_NOTIF_SIZE; } @@ -557,18 +555,11 @@ } } - if (bes->input.sec_info) { - talloc_free(bes->input.sec_info); - bes->input.sec_info = NULL; - } - /* copy over all the data to per-BTS private state */ bes->input.msg_id = wrepl->msg_id; bes->input.serial_nr = wrepl->new_serial_nr; bes->input.warn_type = wrepl->u.emergency.warning_type; - bes->input.sec_info = talloc_named_const(bts, ETWS_SEC_INFO_SIZE, "etws_sec_info"); - if (bes->input.sec_info) - memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, ETWS_SEC_INFO_SIZE); + memcpy(bes->input.sec_info, wrepl->u.emergency.warning_sec_info, sizeof(bes->input.sec_info)); /* generate the encoded ETWS PN */ gen_etws_primary_notification(bes->primary, bes->input.serial_nr, bes->input.msg_id, 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib1b8e4af37b1f9f9398b81dad29942e82218c70b Gerrit-Change-Number: 28094 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Add new Manual "OsmoBSC CBSP Protocol Specification"

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28099 ) Change subject: Add new Manual "OsmoBSC CBSP Protocol Specification" ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2e18e167281fac3abaf380089ff883738ebaa0a0 Gerrit-Change-Number: 28099 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 15 May 2022 11:47:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: vlr: Split vlr_subscr_rx_imsi_detach()

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/28115 ) Change subject: vlr: Split vlr_subscr_rx_imsi_detach() ...................................................................... vlr: Split vlr_subscr_rx_imsi_detach() The function vlr_subscr_rx_imsi_detach() implies that an explicit IMSI DETACH was received. However, that same function was called in other situations such as timer expiration or GSUP CANCEL. Let's clean this up by splitting the function into two parts. No logical change is introduced to the VLR in this patch. Change-Id: Iffc02f3062ad591ca372a3c6d866066cf63a8830 --- M src/libvlr/vlr.c 1 file changed, 11 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/15/28115/1 diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c index fc23b37..f98fee6 100644 --- a/src/libvlr/vlr.c +++ b/src/libvlr/vlr.c @@ -55,6 +55,8 @@ * Convenience functions ***********************************************************************/ +static int vlr_subscr_detach(struct vlr_subscr *vsub); + const struct value_string vlr_ciph_names[] = { OSMO_VALUE_STRING(VLR_CIPH_NONE), OSMO_VALUE_STRING(VLR_CIPH_A5_1), @@ -578,7 +580,7 @@ continue; LOGP(DVLR, LOGL_DEBUG, "%s: Location Update expired\n", vlr_subscr_name(vsub)); - vlr_subscr_rx_imsi_detach(vsub); + vlr_subscr_detach(vsub); } done: @@ -1070,7 +1072,7 @@ vlr_gmm_cause_to_mm_cause(gsup_msg->cause, &gsm48_rej); vlr_subscr_cancel_attach_fsm(vsub, fsm_cause, gsm48_rej); - vlr_subscr_rx_imsi_detach(vsub); + vlr_subscr_detach(vsub); return rc; } @@ -1236,8 +1238,7 @@ return false; } -/* See TS 23.012 version 9.10.0 4.3.2.1 "Process Detach_IMSI_VLR" */ -int vlr_subscr_rx_imsi_detach(struct vlr_subscr *vsub) +static int vlr_subscr_detach(struct vlr_subscr *vsub) { /* paranoia: should any LU or PARQ FSMs still be running, stop them. */ vlr_subscr_cancel_attach_fsm(vsub, OSMO_FSM_TERM_ERROR, GSM48_REJECT_CONGESTION); @@ -1253,6 +1254,12 @@ return 0; } +/* See TS 23.012 version 9.10.0 4.3.2.1 "Process Detach_IMSI_VLR" */ +int vlr_subscr_rx_imsi_detach(struct vlr_subscr *vsub) +{ + return vlr_subscr_detach(vsub); +} + /* Tear down any running FSMs due to MSC connection timeout. * Visit all vsub->*_fsm pointers and give them a queue to send a final reject * message before the entire connection is torn down. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28115 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iffc02f3062ad591ca372a3c6d866066cf63a8830 Gerrit-Change-Number: 28115 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022