May 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: tests: Introduce paging_test

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28001 to look at the new patch set (#3). Change subject: tests: Introduce paging_test ...................................................................... tests: Introduce paging_test Add unit test env to easily test several paging scenarios. Change-Id: Iab61bf6a6eece5f439a19f7a5a0dc068a808ae8a --- M configure.ac M tests/Makefile.am A tests/paging/Makefile.am A tests/paging/paging_test.c A tests/paging/paging_test.ok M tests/testsuite.at 6 files changed, 8,325 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/01/28001/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab61bf6a6eece5f439a19f7a5a0dc068a808ae8a Gerrit-Change-Number: 28001 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: paging: Flush pending paging requests when bts obj freed

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28004 ) Change subject: paging: Flush pending paging requests when bts obj freed ...................................................................... paging: Flush pending paging requests when bts obj freed Change-Id: I3a81eda48cd44c70a2a690a0814a296ba22eaa8e --- M src/osmo-bsc/paging.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/04/28004/1 diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 2ba0fcb..1293739 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -311,6 +311,7 @@ /* Called upon the bts struct being freed */ void paging_destructor(struct gsm_bts *bts) { + paging_flush_bts(bts, NULL); osmo_timer_del(&bts->paging.credit_timer); osmo_timer_del(&bts->paging.work_timer); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28004 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3a81eda48cd44c70a2a690a0814a296ba22eaa8e Gerrit-Change-Number: 28004 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: bts: Properly free ctr/stat when bts object is freed

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28003 ) Change subject: bts: Properly free ctr/stat when bts object is freed ...................................................................... bts: Properly free ctr/stat when bts object is freed Change-Id: Id213e21cf9bfc5439021e459c22ba4704d8cae2b --- M src/osmo-bsc/bts.c M tests/acc/acc_test.c M tests/gsm0408/gsm0408_test.c 3 files changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/03/28003/1 diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 4066cf1..6a6520f 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -163,6 +163,9 @@ osmo_fsm_inst_free(bts->mo.fi); bts->mo.fi = NULL; } + + osmo_stat_item_group_free(bts->bts_statg); + rate_ctr_group_free(bts->bts_ctrs); return 0; } diff --git a/tests/acc/acc_test.c b/tests/acc/acc_test.c index 1e78f73..ce3b0cb 100644 --- a/tests/acc/acc_test.c +++ b/tests/acc/acc_test.c @@ -58,8 +58,6 @@ #define bts_del(bts) _bts_del(bts, __func__) static inline void _bts_del(struct gsm_bts *bts, const char *msg) { - osmo_stat_item_group_free(bts->bts_statg); - rate_ctr_group_free(bts->bts_ctrs); if (osmo_timer_pending(&bts->acc_mgr.rotate_timer)) osmo_timer_del(&bts->acc_mgr.rotate_timer); if (osmo_timer_pending(&bts->acc_ramp.step_timer)) diff --git a/tests/gsm0408/gsm0408_test.c b/tests/gsm0408/gsm0408_test.c index a7270a4..03b2ee1 100644 --- a/tests/gsm0408/gsm0408_test.c +++ b/tests/gsm0408/gsm0408_test.c @@ -137,8 +137,6 @@ #define bts_del(bts) _bts_del(bts, __func__) static inline void _bts_del(struct gsm_bts *bts, const char *msg) { - osmo_stat_item_group_free(bts->bts_statg); - rate_ctr_group_free(bts->bts_ctrs); if (osmo_timer_pending(&bts->acc_mgr.rotate_timer)) osmo_timer_del(&bts->acc_mgr.rotate_timer); /* no need to llist_del(&bts->list), we never registered the bts there. */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id213e21cf9bfc5439021e459c22ba4704d8cae2b Gerrit-Change-Number: 28003 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: tests: Introduce paging_test

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28001 ) Change subject: tests: Introduce paging_test ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iab61bf6a6eece5f439a19f7a5a0dc068a808ae8a Gerrit-Change-Number: 28001 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 02 May 2022 17:01:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: paging: Take into account extra delay of all paging groups in BSC queue

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28002 ) Change subject: paging: Take into account extra delay of all paging groups in BSC queue ...................................................................... paging: Take into account extra delay of all paging groups in BSC queue So far we only calculated the expiration time based on the amount of requests of the same paging group in the BSC queue. However, also extra time has to be taken into account regarding requests of other paging groups. This is important because requests of all paging groups are mixed in the BSC queue, meaning having a lot of requests from other groups before a certain req will anyway delay transmit of that req to some extend. Related: OS#5537 Change-Id: Ib55f947c5d3490b27e1d08d39392992919512f9a --- M src/osmo-bsc/paging.c 1 file changed, 30 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/02/28002/1 diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 2ba0fcb..aabb0d2 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -339,9 +339,11 @@ } #define GSM51_MFRAME_DURATION_us (51 * GSM_TDMA_FN_DURATION_uS) /* 235365 us */ -static unsigned int paging_estimate_delay_us(struct gsm_bts *bts, unsigned int num_reqs); +static unsigned int paging_estimate_delay_us(struct gsm_bts *bts, unsigned int num_reqs, + unsigned int num_reqs_same_group); -static unsigned int calculate_timer_3113(struct gsm_paging_request *req, unsigned int reqs_before) +static unsigned int calculate_timer_3113(struct gsm_paging_request *req, unsigned int reqs_before, + unsigned int reqs_before_same_pgroup) { unsigned int to_us, to; struct gsm_bts *bts = req->bts; @@ -368,7 +370,7 @@ GSM_TDMA_FN_DURATION_uS * rach_tx_integer * rach_max_trans; /* Now add some extra time based on how many requests need to be transmitted before this one: */ - to_us += paging_estimate_delay_us(bts, reqs_before); + to_us += paging_estimate_delay_us(bts, reqs_before, reqs_before_same_pgroup); /* ceiling in seconds + extra time */ to = (to_us + 999999) / 1000000 + d->val; @@ -387,7 +389,7 @@ struct gsm_bts_paging_state *bts_entry = &bts->paging; struct gsm_paging_request *req, *last_initial_req = NULL; unsigned int t3113_timeout_s; - unsigned int reqs_before_same_pgroup = 0; + unsigned int reqs_before = 0, reqs_before_same_pgroup = 0; uint8_t pgroup = gsm0502_calc_paging_group(&bts->si_common.chan_desc, str_to_imsi(params->bsub->imsi)); @@ -409,10 +411,12 @@ } if (req->attempts == 0) { last_initial_req = req; + reqs_before++; if (req->pgroup == pgroup) reqs_before_same_pgroup++; } else if (last_initial_req == NULL) { /* If no req with attempts=0 was found, we'll append to end of list, so keep counting. */ + reqs_before++; if (req->pgroup == pgroup) reqs_before_same_pgroup++; } @@ -437,7 +441,7 @@ else/* Add in the middle of the list after last_initial_req */ __llist_add(&req->entry, &last_initial_req->entry, last_initial_req->entry.next); - t3113_timeout_s = calculate_timer_3113(req, reqs_before_same_pgroup); + t3113_timeout_s = calculate_timer_3113(req, reqs_before, reqs_before_same_pgroup); osmo_timer_schedule(&req->T3113, t3113_timeout_s, 0); /* Trigger scheduler if needed: */ @@ -647,11 +651,28 @@ /*! Conservative estimate of time needed by BTS to schedule a number of paging * requests (num_reqs), based on current load at the BSC queue (doesn't take into * account BTs own buffer) */ -static unsigned int paging_estimate_delay_us(struct gsm_bts *bts, unsigned int num_reqs) +static unsigned int paging_estimate_delay_us(struct gsm_bts *bts, unsigned int num_reqs, + unsigned int num_reqs_same_group) { - unsigned int n_pag_blocks = gsm0502_get_n_pag_blocks(&bts->si_common.chan_desc); - unsigned int n_mframes = (num_reqs + (n_pag_blocks - 1)) / n_pag_blocks; - unsigned int time_us = n_mframes * GSM51_MFRAME_DURATION_us; + unsigned int n_pag_blocks, n_mframes, time_us = 0; + + n_pag_blocks = gsm0502_get_n_pag_blocks(&bts->si_common.chan_desc); + + /* First of all, we need to extend the timeout in relation to the amount + * of paging requests in the BSC queue. In here we don't care about the + * paging group, because they are mixed in the same queue. If don't take + * this into account, it could happen that if lots of requests are + * received at the BSC (from MSC) around the same time, they could time + * out in the BSC queue before arriving at the BTS. We already account of + * same-paging-group ones further below, so don't take them into account + * here: */ + unsigned int num_reqs_other_groups = num_reqs - num_reqs_same_group; + time_us += ((num_reqs_other_groups * GSM51_MFRAME_DURATION_us) + (n_pag_blocks - 1)) / n_pag_blocks; + + /* Now we extend the timeout based on the amount of requests of the same + * paging group before the present one: */ + n_mframes = (num_reqs_same_group + (n_pag_blocks - 1)) / n_pag_blocks; + time_us += n_mframes * GSM51_MFRAME_DURATION_us; /* the multiframes are not consecutive for a paging group, let's add the spacing between: */ if (n_mframes > 1) { unsigned int bs_pa_mfrms = (bts->si_common.chan_desc.bs_pa_mfrms + 2); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib55f947c5d3490b27e1d08d39392992919512f9a Gerrit-Change-Number: 28002 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Check VTY config against features reported by BTS

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 ) Change subject: Check VTY config against features reported by BTS ...................................................................... Check VTY config against features reported by BTS * Don't copy features for osmo-bts and nanobts initially, wait until BTS reported its features * Checks for BTS features in VTY cmds: pass if features are not known (not yet reported by the BTS), fail if the feature is missing * Once BTS reports its features, check relevant VTY config parts again Related: SYS#5922, OS#5538 Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa --- A doc/bts-features.txt M include/osmocom/bsc/bts.h M src/osmo-bsc/abis_nm.c M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts.c M src/osmo-bsc/bts_osmobts.c M src/osmo-bsc/bts_trx.c M src/osmo-bsc/bts_trx_vty.c M src/osmo-bsc/bts_vty.c M tests/Makefile.am A tests/bts_features.vty 12 files changed, 126 insertions(+), 22 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/bts-features.txt b/doc/bts-features.txt new file mode 100644 index 0000000..a38b9a7 --- /dev/null +++ b/doc/bts-features.txt @@ -0,0 +1,42 @@ +Notes about BTS feature check code +--- + +Feature reporting: +- For most BTS we hardcode a list of assumed features in the BTS model's + _init() function, e.g. bts_model_bs11_init(). These features get copied to + bts->features once the BTS model is set. +- nanobts and osmo-bts are special, they support reporting features during OML + bring up (features_get_reported set in struct_gsm_bts_model): + - For osmo-bts, we do not assume any features in the BTS model and just let + it report all available features. + - For nanobts, we wait for the reported features and then extend them with + the features set in the bts model. This is needed because the features enum + gets extended by us for osmo-bts, it may have features that nanobts does + not report but has implemented. +- Once features are available (either through feature reporting or copied from + the bts model), features_known is true in struct gsm_bts. + +Implementing a feature check: +- Check that features_known is true, in case the check may be done before the + BTS is connected and has reported its features (e.g. in VTY config parsing) +- Use osmo_bts_has_feature() +- Example: + if (bts->features_known && !osmo_bts_has_feature(&bts->features, BTS_FEAT_MULTI_TSC)) + +VTY and feature checks: +- Some VTY commands only make sense if a BTS supports a certain feature +- Implement the following checks: + - In the VTY command, check if the BTS has the feature. + - In gsm_bts_check_cfg() (or called funcs like trx_has_valid_pchan_config), + check if the VTY command for the feature is set and if the BTS has the + feature. +- In both cases, do not fail the checks if bts->features_known is false. + +Resulting functionality: +- For BTS that do not support feature reporting, the VTY config is checked + against the hardcoded feature set as it gets parsed. +- For BTS that do support feature reporting, the VTY config is checked when + features get reported. The BTS gets rejected if the config is invalid for the + available features. +- Once a BTS is up and running, VTY commands changing the behavior check + against the available feature sets. diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 7d51707..008eee5 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -295,9 +295,12 @@ struct tlv_definition nm_att_tlvdef; - /* features of a given BTS model set via gsm_bts_model_register() locally */ + /* features of a given BTS model set via gsm_bts_model_register() + * locally, see doc/bts-features.txt */ struct bitvec features; uint8_t _features_data[MAX_BTS_FEATURES/8]; + /* BTS reports features during OML bring up */ + bool features_get_reported; }; struct gsm_gprs_cell { @@ -334,9 +337,13 @@ char version[MAX_VERSION_LENGTH]; char sub_model[MAX_VERSION_LENGTH]; - /* features of a given BTS set/reported via OML */ + /* features of a given BTS either hardcoded or set/reported via OML, + * see doc/bts-features.txt */ struct bitvec features; uint8_t _features_data[MAX_BTS_FEATURES/8]; + /* Features have been reported by the BTS or were copied from the BTS + * model */ + bool features_known; /* Connected PCU version (if any) */ char pcu_version[MAX_VERSION_LENGTH]; diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index b700994..bb44c70 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -600,6 +600,7 @@ } memcpy(bts->_features_data, TLVP_VAL(tp, NM_ATT_MANUF_ID), len); + bts->features_known = true; /* Log each BTS feature in the reported vector */ for (i = 0; i < len * 8; i++) { diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index d452a52..d293862 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -1700,6 +1700,7 @@ static int lchan_act_deact(struct vty *vty, const char **argv, int argc) { struct gsm_bts_trx_ts *ts; + struct gsm_bts *bts; struct gsm_lchan *lchan; bool vamos = (strcmp(argv[3], "vamos-sub-slot") == 0); int ss_nr = atoi(argv[4]); @@ -1725,7 +1726,8 @@ return CMD_WARNING; } - if (vamos && !osmo_bts_has_feature(&ts->trx->bts->features, BTS_FEAT_VAMOS)) { + bts = ts->trx->bts; + if (vamos && bts->features_known && !osmo_bts_has_feature(&bts->features, BTS_FEAT_VAMOS)) { vty_out(vty, "BTS does not support VAMOS%s", VTY_NEWLINE); return CMD_WARNING; } @@ -1955,6 +1957,7 @@ TSC_ARGS_DOC) { struct gsm_bts_trx_ts *ts; + struct gsm_bts *bts; struct gsm_lchan *lchan; int ss_nr = atoi(argv[3]); const char *vamos_str = argv[4]; @@ -1971,7 +1974,8 @@ return CMD_WARNING; } - if (!osmo_bts_has_feature(&ts->trx->bts->features, BTS_FEAT_VAMOS)) { + bts = ts->trx->bts; + if (bts->features_known && !osmo_bts_has_feature(&bts->features, BTS_FEAT_VAMOS)) { vty_out(vty, "%% BTS does not support VAMOS%s", VTY_NEWLINE); return CMD_WARNING; } diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 4066cf1..02cd3a8 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -500,6 +500,14 @@ return -EINVAL; } + if (bts->features_known) { + if (!bts_gprs_mode_is_compat(bts, bts->gprs.mode)) { + LOGP(DNM, LOGL_ERROR, "(bts=%u) GPRS mode set to '%s', but BTS does not support it\n", bts->nr, + bts_gprs_mode_name(bts->gprs.mode)); + return -EINVAL; + } + } + /* Verify the physical channel mapping */ llist_for_each_entry(trx, &bts->trx_list, list) { if (!trx_has_valid_pchan_config(trx)) { @@ -621,11 +629,15 @@ { bts->model = model; - /* Copy hardcoded feature list from BTS model. For some BTS we support - * reporting features at runtime (as of writing nanobts, OsmoBTS), - * which will then replace this list. */ - if (model) + /* Copy hardcoded feature list from BTS model, unless the BTS supports + * reporting features at runtime (as of writing nanobts, OsmoBTS). */ + if (!model || model->features_get_reported) { + memset(bts->_features_data, 0, sizeof(bts->_features_data)); + bts->features_known = false; + } else { memcpy(bts->_features_data, bts->model->_features_data, sizeof(bts->_features_data)); + bts->features_known = true; + } return 0; } diff --git a/src/osmo-bsc/bts_ipaccess_nanobts.c b/src/osmo-bsc/bts_ipaccess_nanobts.c index 1df6537..54848fb 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts.c @@ -131,6 +131,7 @@ [NM_ATT_IPACC_REVOC_DATE] = { TLV_TYPE_TL16V }, }, }, + .features_get_reported = true, }; diff --git a/src/osmo-bsc/bts_osmobts.c b/src/osmo-bsc/bts_osmobts.c index ca5ddb2..078cfe7 100644 --- a/src/osmo-bsc/bts_osmobts.c +++ b/src/osmo-bsc/bts_osmobts.c @@ -205,13 +205,8 @@ sizeof(model_osmobts._features_data); memset(model_osmobts.features.data, 0, model_osmobts.features.data_len); - /* Order alphabetically and remember to adjust bts_init/bts_model_init - * in OsmoBTS to report new features. */ - osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_CCN); - osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_EGPRS); - osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_GPRS); - osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_IPV6_NSVC); - osmo_bts_set_feature(&model_osmobts.features, BTS_FEAT_PAGING_COORDINATION); + /* Adjust bts_init/bts_model_init in OsmoBTS to report new features. + * See also: doc/bts-features.txt */ model_osmobts.nm_att_tlvdef.def[NM_ATT_OSMO_NS_LINK_CFG].type = TLV_TYPE_TL16V; diff --git a/src/osmo-bsc/bts_trx.c b/src/osmo-bsc/bts_trx.c index fa27b05..71d9fbf 100644 --- a/src/osmo-bsc/bts_trx.c +++ b/src/osmo-bsc/bts_trx.c @@ -338,6 +338,20 @@ result = false; } } + + if (trx->bts->features_known) { + const struct bitvec *ft = &trx->bts->features; + + if (ts->hopping.enabled && !osmo_bts_has_feature(ft, BTS_FEAT_HOPPING)) { + LOGP(DNM, LOGL_ERROR, "TS%d has freq. hopping enabled, but BTS does not support it\n", i); + result = false; + } + + if (ts->tsc != -1 && !osmo_bts_has_feature(ft, BTS_FEAT_MULTI_TSC)) { + LOGP(DNM, LOGL_ERROR, "TS%d has TSC != BCC, but BTS does not support it\n", i); + result = false; + } + } } return result; diff --git a/src/osmo-bsc/bts_trx_vty.c b/src/osmo-bsc/bts_trx_vty.c index 27bba2c..a3d6033 100644 --- a/src/osmo-bsc/bts_trx_vty.c +++ b/src/osmo-bsc/bts_trx_vty.c @@ -316,8 +316,9 @@ "Training Sequence Code of the Timeslot\n" "TSC\n") { struct gsm_bts_trx_ts *ts = vty->index; + const struct gsm_bts *bts = ts->trx->bts; - if (!osmo_bts_has_feature(&ts->trx->bts->features, BTS_FEAT_MULTI_TSC)) { + if (bts->features_known && !osmo_bts_has_feature(&bts->features, BTS_FEAT_MULTI_TSC)) { vty_out(vty, "%% This BTS does not support a TSC != BCC, " "falling back to BCC%s", VTY_NEWLINE); ts->tsc = -1; @@ -339,13 +340,12 @@ "Disable frequency hopping\n" "Enable frequency hopping\n") { struct gsm_bts_trx_ts *ts = vty->index; + const struct gsm_bts *bts = ts->trx->bts; int enabled = atoi(argv[0]); - if (enabled && !osmo_bts_has_feature(&ts->trx->bts->features, BTS_FEAT_HOPPING)) { - vty_out(vty, "%% BTS model does not seem to support freq. hopping%s", VTY_NEWLINE); - /* Allow enabling frequency hopping anyway, because the BTS might not have - * connected yet (thus not sent the feature vector), so we cannot know for - * sure. Jet print a warning and let it go. */ + if (enabled && bts->features_known && !osmo_bts_has_feature(&bts->features, BTS_FEAT_HOPPING)) { + vty_out(vty, "%% BTS does not support freq. hopping%s", VTY_NEWLINE); + return CMD_WARNING; } ts->hopping.enabled = enabled; diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 1a708ab..4e60cd8 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -1592,7 +1592,7 @@ struct gsm_bts *bts = vty->index; enum bts_gprs_mode mode = bts_gprs_mode_parse(argv[0], NULL); - if (!bts_gprs_mode_is_compat(bts, mode)) { + if (bts->features_known && !bts_gprs_mode_is_compat(bts, mode)) { vty_out(vty, "%% This BTS type does not support %s%s", argv[0], VTY_NEWLINE); return CMD_WARNING; diff --git a/tests/Makefile.am b/tests/Makefile.am index a5f92ef..4421354 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -43,6 +43,7 @@ power_ctrl.vty \ interf_meas.vty \ acch_overpower.vty \ + bts_features.vty \ ctrl/osmo-bsc-neigh-test.cfg \ ctrl/osmo-bsc-apply-config-file.cfg \ ctrl/osmo-bsc-apply-config-file-invalid.cfg \ diff --git a/tests/bts_features.vty b/tests/bts_features.vty new file mode 100644 index 0000000..3768a4d --- /dev/null +++ b/tests/bts_features.vty @@ -0,0 +1,27 @@ +OsmoBSC> ### see doc/bts-features.txt + +OsmoBSC> enable +OsmoBSC# configure terminal +OsmoBSC(config)# network + +OsmoBSC(config-net)# ### osmo-bts: all feature checks pass before it is connected (features_get_reported is true) +OsmoBSC(config-net)# bts 0 +OsmoBSC(config-net-bts)# gprs mode egprs +OsmoBSC(config-net-bts)# trx 0 +OsmoBSC(config-net-bts-trx)# timeslot 2 +OsmoBSC(config-net-bts-trx-ts)# hopping enabled 1 +OsmoBSC(config-net-bts-trx-ts)# exit +OsmoBSC(config-net-bts-trx)# exit +OsmoBSC(config-net-bts)# exit + +OsmoBSC(config-net)# ### bs11: checks against hardcoded features (features_get_reported is false) +OsmoBSC(config-net)# bts 1 +OsmoBSC(config-net-bts)# type bs11 +OsmoBSC(config-net-bts)# gprs mode egprs +% This BTS type does not support egprs +OsmoBSC(config-net-bts)# trx 0 +OsmoBSC(config-net-bts-trx)# timeslot 2 +OsmoBSC(config-net-bts-trx-ts)# hopping enabled 1 +OsmoBSC(config-net-bts-trx-ts)# exit +OsmoBSC(config-net-bts-trx)# exit +OsmoBSC(config-net-bts)# exit -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: abis_nm: add bts model features to reported ones

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27972 ) Change subject: abis_nm: add bts model features to reported ones ...................................................................... abis_nm: add bts model features to reported ones As pointed out in code review, for nanobts we need to be able to combine the reported features with a list of features we assume that the bts model supports. This is because the enum of features is based on what nanobts is able to report, but was extended for osmo-bts. Related: SYS#5922, OS#5538 Change-Id: I7bdbf28c148877275048e070dce7f503ca5e6226 --- M contrib/jenkins.sh M src/osmo-bsc/abis_nm.c 2 files changed, 17 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 53b30bf..4380f16 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -28,7 +28,9 @@ verify_value_string_arrays_are_terminated.py $(find . -name "*.[hc]") # Check for wrong use of osmo_bts_has_feature (OS#5538) -bts_features_wrong_use="$(grep -r -n 'osmo_bts_has_feature.*->model->features' | grep -v 'jenkins.sh')" || true +bts_features_wrong_use="$(grep -r -n 'osmo_bts_has_feature.*->model->features' \ + | grep -v 'jenkins.sh' \ + | grep -v 'intentional check against bts model')" || true if [ -n "$bts_features_wrong_use" ]; then set +x echo diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c index 62f62b6..b700994 100644 --- a/src/osmo-bsc/abis_nm.c +++ b/src/osmo-bsc/abis_nm.c @@ -613,6 +613,20 @@ LOGPMO(&bts->mo, DNM, LOGL_NOTICE, "Get Attributes Response: feature '%s' is" " supported\n", osmo_bts_features_name(i)); } + + /* Add features from the BTS model: nanobts may support more + * features than it reports, since we extend the enum of + * features for osmo-bts. */ + if (bts->type == GSM_BTS_TYPE_NANOBTS) { + for (i = 0; i < _NUM_BTS_FEAT; i++) { + if (osmo_bts_has_feature(&bts->model->features, i) /* intentional check against bts model */ + && !osmo_bts_has_feature(&bts->features, i)) { + LOGPMO(&bts->mo, DNM, LOGL_NOTICE, "Get Attributes Response: feature '%s' is" + " assumed to be supported\n", osmo_bts_features_name(i)); + osmo_bts_set_feature(&bts->features, i); + } + } + } } /* Parse Attribute Response Info content for 3GPP TS 52.021 §9.4.28 Manufacturer Dependent State */ 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7bdbf28c148877275048e070dce7f503ca5e6226 Gerrit-Change-Number: 27972 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-ci[master]: treewide: rename rpi4-raspbian10 to rpi4-raspbian11

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27393 ) Change subject: treewide: rename rpi4-raspbian10 to rpi4-raspbian11 ...................................................................... treewide: rename rpi4-raspbian10 to rpi4-raspbian11 The raspberries have been upgraded to the debian 11 based raspberry pi OS. Adjust the name to avoid confusion. Related: OS#5453 Change-Id: I0b2e08b11d83243e81b2bb4412ffcc9bc59821ff --- M ansible/hosts M jobs/gerrit-verifications.yml M jobs/master-builds.yml M jobs/update-osmo-ci-on-slaves.yml M jobs/update-osmo-python-on-slaves.yml 5 files changed, 23 insertions(+), 23 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/ansible/hosts b/ansible/hosts index d88147a..ef0d055 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -14,9 +14,9 @@ host2-deb9build-ansible ansible_host=2a01:4f8:120:8470::1:3 osmocom_jenkins_slave_fstrim=True gtp0-deb9build ansible_host=10.34.2.102 osmocom_jenkins_slave_fstrim=True gtp0-deb10build ansible_host=10.34.2.101 osmocom_jenkins_slave_fstrim=True -rpi4-raspbian10build-ansible-1 ansible_host=10.9.25.50 -rpi4-raspbian10build-ansible-2 ansible_host=10.9.25.60 -rpi4-raspbian10build-ansible-3 ansible_host=10.9.25.70 +rpi4-raspbian11build-ansible-1 ansible_host=10.9.25.50 +rpi4-raspbian11build-ansible-2 ansible_host=10.9.25.60 +rpi4-raspbian11build-ansible-3 ansible_host=10.9.25.70 [simtester] simtest ansible_host=10.9.25.80 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 7dc565d..bc0ef58 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -92,7 +92,7 @@ - osmo-bsc-nat - osmo-bts: - slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian10] + slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian11] a1_name: FIRMWARE_VERSION a1: !!python/tuple [master, femtobts_v2.7, superfemto_v2.4, superfemto_v3.0.1pre, superfemto_v3.1, superfemto_v5.1, v2017.01, litecell15, oc2g, oc2g-next] a2_name: BTS_MODEL @@ -101,7 +101,7 @@ a3: !!python/tuple ["1", "0"] combination_filter: > (FIRMWARE_VERSION == "master" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (FIRMWARE_VERSION == "master" && BTS_MODEL == "trx" && WITH_MANUALS == "0" && label == "rpi4-raspbian10") || + (FIRMWARE_VERSION == "master" && BTS_MODEL == "trx" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") || (FIRMWARE_VERSION == "femtobts_v2.7" && BTS_MODEL == "sysmo" && WITH_MANUALS == "1" && label == "osmocom-master-debian9") || (FIRMWARE_VERSION == "superfemto_v2.4" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || (FIRMWARE_VERSION == "superfemto_v3.0.1pre" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || @@ -169,7 +169,7 @@ - osmo-pcap - osmo-pcu: - slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian10] + slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian11] a1_name: FIRMWARE_VERSION a1: !!python/tuple [master, v2017.01, litecell15, oc2g] a2_name: with_vty @@ -185,7 +185,7 @@ (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="litecell15" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || (with_vty == "True" && with_dsp == "oc2g" && FIRMWARE_VERSION=="oc2g" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || (with_vty == "False" && with_dsp == "none" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "1" && label == "osmocom-master-debian9") || - (with_vty == "False" && with_dsp == "none" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "0" && label == "rpi4-raspbian10") + (with_vty == "False" && with_dsp == "none" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") cmd: | {docker_run} \ -e FIRMWARE_VERSION="$FIRMWARE_VERSION" \ @@ -220,7 +220,7 @@ - osmo-sip-connector - osmo-trx: - slave_axis: !!python/tuple [osmocom-master-debian9,rpi4-raspbian10] + slave_axis: !!python/tuple [osmocom-master-debian9,rpi4-raspbian11] a1_name: INSTR a1: !!python/tuple [--with-sse, --without-sse --with-neon, --with-neon-vfpv4] a2_name: WITH_MANUALS @@ -228,8 +228,8 @@ combination_filter: > (INSTR == "--without-sse" && WITH_MANUALS == "1" && label == "osmocom-master-debian9") || (INSTR == "--with-sse" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (INSTR == "--with-neon" && WITH_MANUALS == "0" && label == "rpi4-raspbian10") || - (INSTR == "--with-neon-vfpv4" && WITH_MANUALS == "0" && label == "rpi4-raspbian10") + (INSTR == "--with-neon" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") || + (INSTR == "--with-neon-vfpv4" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") cmd: | {docker_run} \ -e INSTR="$INSTR" \ diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index bcc517d..4491516 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -186,7 +186,7 @@ - osmo-bsc-nat - osmo-bts: - slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian10] + slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian11] a1_name: FIRMWARE_VERSION a1: !!python/tuple [master, femtobts_v2.7, superfemto_v2.4, superfemto_v3.0.1pre, superfemto_v3.1, superfemto_v5.1, v2017.01, origin/nrw/litecell15, origin/nrw/oc2g] a2_name: BTS_MODEL @@ -195,7 +195,7 @@ a3: !!python/tuple ["1", "0"] combination_filter: > (FIRMWARE_VERSION == "master" && WITH_MANUALS == "1" && label == "osmocom-master-debian9") || - (FIRMWARE_VERSION == "master" && BTS_MODEL == "trx" && WITH_MANUALS == "0" && label == "rpi4-raspbian10") || + (FIRMWARE_VERSION == "master" && BTS_MODEL == "trx" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") || (FIRMWARE_VERSION == "femtobts_v2.7" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || (FIRMWARE_VERSION == "superfemto_v2.4" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || (FIRMWARE_VERSION == "superfemto_v3.0.1pre" && BTS_MODEL == "sysmo" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || @@ -280,7 +280,7 @@ - osmo-pcap - osmo-pcu: - slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian10] + slave_axis: !!python/tuple [osmocom-master-debian9, rpi4-raspbian11] a1_name: FIRMWARE_VERSION a1: !!python/tuple [master, v2017.01, origin/nrw/litecell15] a2_name: with_vty @@ -295,7 +295,7 @@ (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="v2017.01" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || (with_vty == "True" && with_dsp == "lc15" && FIRMWARE_VERSION=="origin/nrw/litecell15" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || (with_vty == "False" && with_dsp == "none" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "1" && label == "osmocom-master-debian9") || - (with_vty == "False" && with_dsp == "none" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "0" && label == "rpi4-raspbian10") + (with_vty == "False" && with_dsp == "none" && FIRMWARE_VERSION=="master" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") cmd: | {docker_run} \ -e FIRMWARE_VERSION="$FIRMWARE_VERSION" \ @@ -325,7 +325,7 @@ email: gerrit-log(a)lists.osmocom.org laforge(a)gnumonks.org 246tnt(a)gmail.com - osmo-trx: - slave_axis: !!python/tuple [osmocom-master-debian9,rpi4-raspbian10] + slave_axis: !!python/tuple [osmocom-master-debian9,rpi4-raspbian11] a1_name: INSTR a1: !!python/tuple [--with-sse, --without-sse, --with-neon, --with-neon-vfpv4] a2_name: WITH_MANUALS @@ -333,8 +333,8 @@ combination_filter: > (INSTR == "--without-sse" && WITH_MANUALS == "1" && label == "osmocom-master-debian9") || (INSTR == "--with-sse" && WITH_MANUALS == "0" && label == "osmocom-master-debian9") || - (INSTR == "--with-neon" && WITH_MANUALS == "0" && label == "rpi4-raspbian10") || - (INSTR == "--with-neon-vfpv4" && WITH_MANUALS == "0" && label == "rpi4-raspbian10") + (INSTR == "--with-neon" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") || + (INSTR == "--with-neon-vfpv4" && WITH_MANUALS == "0" && label == "rpi4-raspbian11") cmd: | {docker_run} \ -e INSTR="$INSTR" \ diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index 9fe2d34..1a0c79c 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -10,9 +10,9 @@ - host2-deb9build-ansible - build2-deb9build-ansible - build2-deb10build-ansible - - rpi4-raspbian10build-ansible-1 - - rpi4-raspbian10build-ansible-2 - - rpi4-raspbian10build-ansible-3 + - rpi4-raspbian11build-ansible-1 + - rpi4-raspbian11build-ansible-2 + - rpi4-raspbian11build-ansible-3 - gtp0-deb9build - gtp0-deb10build32 - gtp0-deb10fr diff --git a/jobs/update-osmo-python-on-slaves.yml b/jobs/update-osmo-python-on-slaves.yml index 598d867..aa4cfe3 100644 --- a/jobs/update-osmo-python-on-slaves.yml +++ b/jobs/update-osmo-python-on-slaves.yml @@ -9,9 +9,9 @@ - host2-deb9build-ansible - build2-deb9build-ansible - build2-deb10build-ansible - - rpi4-raspbian10build-ansible-1 - - rpi4-raspbian10build-ansible-2 - - rpi4-raspbian10build-ansible-3 + - rpi4-raspbian11build-ansible-1 + - rpi4-raspbian11build-ansible-2 + - rpi4-raspbian11build-ansible-3 properties: - build-discarder: days-to-keep: 30 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0b2e08b11d83243e81b2bb4412ffcc9bc59821ff Gerrit-Change-Number: 27393 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-ci[master]: treewide: rename rpi4-raspbian10 to rpi4-raspbian11

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27393 ) Change subject: treewide: rename rpi4-raspbian10 to rpi4-raspbian11 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: pretty sure we can merge this, doesn't make sense to keep the old name. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27393 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I0b2e08b11d83243e81b2bb4412ffcc9bc59821ff Gerrit-Change-Number: 27393 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 May 2022 13:29:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Check VTY config against features reported by BTS

by osmith

Attention is currently required from: neels, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27923 ) Change subject: Check VTY config against features reported by BTS ...................................................................... Patch Set 8: Code-Review+2 (1 comment) Patchset: PS8: re-applying +2 after rebase -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27923 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7fca42a39a4bc98a6ea8b9cfab28c4bad3a6a0aa Gerrit-Change-Number: 27923 Gerrit-PatchSet: 8 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 May 2022 13:26:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022