May 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: Update current NM object state before signalling S_NM_STATECHG

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28039 ) Change subject: Update current NM object state before signalling S_NM_STATECHG ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: are we sure all users are fine with that kind of change? esentially the old signal is a 'pre-state-change' signal, and you're now turning it into a [new] post-state-change signal -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib46234e3f3e446e866d27b0dfee65edf4af4d2ba Gerrit-Change-Number: 28039 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:50:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: nm_statechg_signal_data: Convert state ptr to data

by laforge

Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28038 ) Change subject: nm_statechg_signal_data: Convert state ptr to data ...................................................................... Patch Set 3: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/28038/comment/373e21ba_2a85d4d5 PS3, Line 11: fro mem for? https://gerrit.osmocom.org/c/osmo-bsc/+/28038/comment/c168191c_e4cef8e9 PS3, Line 16: easies eases -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28038 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9b648dfd8392b7b40bfe2b38f3345017481f5129 Gerrit-Change-Number: 28038 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:49:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: paging: Avoid unnecessary immediate polling in mainloop

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28053 ) Change subject: paging: Avoid unnecessary immediate polling in mainloop ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28053/comment/ca580fdc_dd65e9bd PS1, Line 472: if (tdiff.tv_sec == 0 && tdiff.tv_nsec == 0) you might even to one step further and also catch small non_zero tv_nsec. Like (tdiff.tv_sec == 0 && tdiff.tv_nsec < 5000) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28053 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie767bdc8d4353aafe375a424e02d698ef7fd3dea Gerrit-Change-Number: 28053 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:45:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: paging: Fix recalculate work timer if waiting for retrans

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28052 ) Change subject: paging: Fix recalculate work timer if waiting for retrans ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28052 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7ce6f436286b50dc31331d218ff256cf7be3f619 Gerrit-Change-Number: 28052 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:44:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: paging: Improve logging

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28051 ) Change subject: paging: Improve logging ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28051/comment/479327f6_99c6a2a9 PS1, Line 265: "Paging delayed: retransmission happens in %lld.%06ld\n", might make sense to add 's' to state the unit of time printed here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3186f841623cad8ed3296ac4d541e5cf4701132d Gerrit-Change-Number: 28051 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libgtpnl[master]: fix some cases of rc == 0 on error

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libgtpnl/+/26990 ) Change subject: fix some cases of rc == 0 on error ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libgtpnl/+/26990 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libgtpnl Gerrit-Branch: master Gerrit-Change-Id: I22fd69709e023572c6c616a4184340a554456faf Gerrit-Change-Number: 26990 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pablo <pablo(a)gnumonks.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:41:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-remsim[master]: rspro_client_fsm: Log clientConnectResult != ok

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28056 ) Change subject: rspro_client_fsm: Log clientConnectResult != ok ...................................................................... rspro_client_fsm: Log clientConnectResult != ok This should aid debugging. Related: SYS#5950 Change-Id: I8f584640758be0cceab61dcb333c81374da3288b --- M src/asn1c_helpers.h M src/rspro_client_fsm.c 2 files changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved; Verified pespin: Looks good to me, but someone else must approve diff --git a/src/asn1c_helpers.h b/src/asn1c_helpers.h index 8d4e676..ac34a8f 100644 --- a/src/asn1c_helpers.h +++ b/src/asn1c_helpers.h @@ -1,5 +1,6 @@ #pragma once +#include <asn_application.h> struct asn_TYPE_descriptor_t; const char *asn_type_name(const asn_TYPE_descriptor_t *td); diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c index bd07330..bd267ca 100644 --- a/src/rspro_client_fsm.c +++ b/src/rspro_client_fsm.c @@ -32,6 +32,7 @@ #include <osmocom/gsm/protocol/ipaccess.h> #include "debug.h" +#include "asn1c_helpers.h" #include "rspro_client_fsm.h" #define S(x) (1 << (x)) @@ -229,6 +230,8 @@ pdu = data; res = rspro_get_result(pdu); if (res != ResultCode_ok) { + LOGPFSML(fi, LOGL_ERROR, "Rx RSPRO connectClientRes(result=%s), closing\n", + asn_enum_name(&asn_DEF_ResultCode, res)); ipa_client_conn_close(srvc->conn); osmo_fsm_inst_dispatch(fi, SRVC_E_TCP_DOWN, NULL); } else { -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8f584640758be0cceab61dcb333c81374da3288b Gerrit-Change-Number: 28056 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-remsim[master]: rspro_client_fsm: Log clientConnectResult != ok

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28056 ) Change subject: rspro_client_fsm: Log clientConnectResult != ok ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I8f584640758be0cceab61dcb333c81374da3288b Gerrit-Change-Number: 28056 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:40:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-remsim[master]: bankd: Log more clearly if we fail to open a PC/SC reader

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28055 ) Change subject: bankd: Log more clearly if we fail to open a PC/SC reader ...................................................................... bankd: Log more clearly if we fail to open a PC/SC reader Related: SYS#5950 Change-Id: I424f585a8a37f21806898e59e350201119645a21 --- M src/bankd/bankd_pcsc.c 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/bankd/bankd_pcsc.c b/src/bankd/bankd_pcsc.c index d7bb39c..ee01c93 100644 --- a/src/bankd/bankd_pcsc.c +++ b/src/bankd/bankd_pcsc.c @@ -237,13 +237,19 @@ &dwActiveProtocol); if (rc == SCARD_S_SUCCESS) result = 0; - else + else { LOGW_PCSC_ERROR(worker, rc, "SCardConnect"); + goto out_readerfree; + } break; } p += strlen(p) + 1; } + if (result < 0) + LOGW(worker, "Error: Cannot find PC/SC reader/slot matching using regex '%s'\n", worker->reader.name); + +out_readerfree: SCardFreeMemory(worker->reader.pcsc.hContext, mszReaders); out_regfree: -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I424f585a8a37f21806898e59e350201119645a21 Gerrit-Change-Number: 28055 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-remsim[master]: bankd: Log more clearly if we fail to open a PC/SC reader

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/28055 ) Change subject: bankd: Log more clearly if we fail to open a PC/SC reader ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/28055 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I424f585a8a37f21806898e59e350201119645a21 Gerrit-Change-Number: 28055 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 06 May 2022 07:40:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022