April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-e1d[master]: e1oip: Add rate_ctr for IP->E1 RIFO overflows

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27841 ) Change subject: e1oip: Add rate_ctr for IP->E1 RIFO overflows ...................................................................... e1oip: Add rate_ctr for IP->E1 RIFO overflows This typically happens if the remote IP peer is transmitting at a faster rate than the E1 side is consuming. Let's add a way to monitor it. Change-Id: Ie0e8bb2f5d2ae4256952f6bf69e514d5c2627a76 --- M src/octoi/e1oip.c M src/octoi/e1oip.h 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/41/27841/1 diff --git a/src/octoi/e1oip.c b/src/octoi/e1oip.c index b767ba7..7f15e45 100644 --- a/src/octoi/e1oip.c +++ b/src/octoi/e1oip.c @@ -46,6 +46,7 @@ static const struct rate_ctr_desc iline_ctr_description[] = { [LINE_CTR_E1oIP_UNDERRUN] = { "e1oip:underrun", "Frames underrun / slipped in IP->E1 direction"}, [LINE_CTR_E1oIP_SUBSTITUTED] = { "e1oip:substituted", "Frames substituted in E1->IP direction"}, + [LINE_CTR_E1oIP_E1T_OVERFLOW] = { "e1oip:e1t_overflow", "Frames overflowing the RIFO in E1->IP direction"}, [LINE_CTR_E1oIP_E1O_OVERFLOW] = { "e1oip:e1o_overflow", "Frames overflowed in IP->E1 direction"}, [LINE_CTR_E1oIP_RX_OUT_OF_ORDER] = { "e1oip:rx:pkt_out_of_order", "Packets out-of-order in IP->E1 direction"}, [LINE_CTR_E1oIP_RX_OUT_OF_WIN] = { "e1oip:rx:pkt_out_of_win", "Packets out-of-rx-window in IP->E1 direction"}, @@ -245,12 +246,15 @@ memcpy(frame_buf, iline->e1t.last_frame, BYTES_PER_FRAME); for (unsigned int i = 0; i < n_frames; i++) { + int rc; for (unsigned int j = 0; j < num_ts; j++) { uint8_t ts_nr = idx2ts[j]; frame_buf[ts_nr] = e1th->data[i*num_ts + j]; } /* FIXME: what to do about TS0? */ - frame_rifo_in(&iline->e1t.rifo, frame_buf, fn32+i); + rc = frame_rifo_in(&iline->e1t.rifo, frame_buf, fn32+i); + if (rc < 0) + iline_ctr_add(iline, LINE_CTR_E1oIP_E1T_OVERFLOW, 1); } /* update local state */ memcpy(iline->e1t.last_frame, frame_buf, BYTES_PER_FRAME); diff --git a/src/octoi/e1oip.h b/src/octoi/e1oip.h index 65ae473..54d299a 100644 --- a/src/octoi/e1oip.h +++ b/src/octoi/e1oip.h @@ -16,6 +16,7 @@ enum e1oip_line_ctr { LINE_CTR_E1oIP_UNDERRUN, LINE_CTR_E1oIP_SUBSTITUTED, + LINE_CTR_E1oIP_E1T_OVERFLOW, LINE_CTR_E1oIP_E1O_OVERFLOW, LINE_CTR_E1oIP_RX_OUT_OF_ORDER, LINE_CTR_E1oIP_RX_OUT_OF_WIN, -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ie0e8bb2f5d2ae4256952f6bf69e514d5c2627a76 Gerrit-Change-Number: 27841 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: octoi: Disconnect the link when >= 7500 underruns/s

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27839 ) Change subject: octoi: Disconnect the link when >= 7500 underruns/s ...................................................................... octoi: Disconnect the link when >= 7500 underruns/s This situation is the result of the peer clock being continuously too slow compared to the local clock, leading to RIFO underruns at [virtually] all of the 8000/s E1 frames. As the current code doesn't recover from this, we might as well disconnect and re-start for recovery. Change-Id: Ie3fffa1c1c20962b40320c8cc088c140b8d64e77 --- M src/octoi/e1oip.h M src/octoi/octoi_clnt_fsm.c M src/octoi/octoi_srv_fsm.c 3 files changed, 45 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/39/27839/1 diff --git a/src/octoi/e1oip.h b/src/octoi/e1oip.h index 1a184d2..99b88f0 100644 --- a/src/octoi/e1oip.h +++ b/src/octoi/e1oip.h @@ -59,6 +59,13 @@ /* TODO: statistics (RTT, frame loss, std deviation, alarms */ }; +/* get the rate of the given counter during the last second */ +static inline uint64_t iline_ctr_get_rate_1s(struct e1oip_line *iline, unsigned int idx) +{ + const struct rate_ctr *ctr = rate_ctr_group_get_ctr(iline->ctrs, idx); + return ctr->intv[RATE_CTR_INTV_SEC].rate; +} + struct e1oip_line *e1oip_line_alloc(struct octoi_peer *peer); void e1oip_line_set_name(struct e1oip_line *line, const char *name); void e1oip_line_reset(struct e1oip_line *iline); diff --git a/src/octoi/octoi_clnt_fsm.c b/src/octoi/octoi_clnt_fsm.c index f2fe989..a3d0518 100644 --- a/src/octoi/octoi_clnt_fsm.c +++ b/src/octoi/octoi_clnt_fsm.c @@ -34,6 +34,7 @@ CLNT_ST_ACCEPTED, CLNT_ST_REJECTED, CLNT_ST_REDIRECTED, + CLNT_ST_WAIT_RECONNECT, }; struct clnt_state { @@ -179,7 +180,8 @@ .name = "ACCEPTED", .in_event_mask = S(OCTOI_CLNT_EV_RX_AUTH_REQ) | S(OCTOI_EV_RX_TDM_DATA), - .out_state_mask = S(CLNT_ST_INIT), + .out_state_mask = S(CLNT_ST_INIT) | + S(CLNT_ST_WAIT_RECONNECT), .action = clnt_st_accepted, .onenter = clnt_st_accepted_onenter, .onleave = clnt_st_accepted_onleave, @@ -196,6 +198,11 @@ .out_state_mask = S(CLNT_ST_SVC_REQ_SENT), .action = clnt_st_redirected, }, + [CLNT_ST_WAIT_RECONNECT] = { + .name = "WAIT_RECONNECT", + .in_event_mask = 0, + .out_state_mask = S(CLNT_ST_INIT), + }, }; static void clnt_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) @@ -235,6 +242,9 @@ PACKAGE_NAME, PACKAGE_VERSION, st->capability_flags); osmo_fsm_inst_state_chg(fi, CLNT_ST_SVC_REQ_SENT, 10, 0); break; + case CLNT_ST_WAIT_RECONNECT: + LOGPFSML(fi, LOGL_INFO, "Re-starting connection\n"); + osmo_fsm_inst_state_chg(fi, CLNT_ST_INIT, 0, 0); } return 0; } @@ -257,6 +267,7 @@ struct osmo_fsm_inst *fi = data; struct clnt_state *st = fi->priv; struct timespec ts; + uint64_t rate; clock_gettime(CLOCK_MONOTONIC, &ts); @@ -264,8 +275,19 @@ LOGPFSML(fi, LOGL_NOTICE, "No TDM data received for >= 3 seconds, declaring peer dead\n"); osmo_fsm_inst_state_chg(fi, CLNT_ST_INIT, 0, 0); osmo_fsm_inst_dispatch(fi, OCTOI_CLNT_EV_REQUEST_SERVICE, NULL); - } else - osmo_timer_schedule(&st->rx_alive_timer, 3, 0); + return; + } + + rate = iline_ctr_get_rate_1s(st->peer->iline, LINE_CTR_E1oIP_UNDERRUN); + if (rate > 7500) { + LOGPFSML(fi, LOGL_ERROR, "More than 7500 RIFO underruns per second: " + "Your clock appears to be too fast. Disconnecting.\n"); + osmo_fsm_inst_state_chg(fi, CLNT_ST_WAIT_RECONNECT, 10, 0); + osmo_fsm_inst_dispatch(fi, OCTOI_CLNT_EV_REQUEST_SERVICE, NULL); + return; + } + + osmo_timer_schedule(&st->rx_alive_timer, 3, 0); } diff --git a/src/octoi/octoi_srv_fsm.c b/src/octoi/octoi_srv_fsm.c index 3990a16..5f51003 100644 --- a/src/octoi/octoi_srv_fsm.c +++ b/src/octoi/octoi_srv_fsm.c @@ -345,14 +345,25 @@ struct osmo_fsm_inst *fi = data; struct srv_state *st = fi->priv; struct timespec ts; + uint64_t rate; clock_gettime(CLOCK_MONOTONIC, &ts); if (ts.tv_sec - st->peer->last_rx_tdm > 3) { LOGPFSML(fi, LOGL_NOTICE, "No TDM data received for >= 3 seconds, declaring peer dead\n"); osmo_fsm_inst_term(fi, OSMO_FSM_TERM_TIMEOUT, NULL); - } else - osmo_timer_schedule(&st->rx_alive_timer, 3, 0); + return; + } + + rate = iline_ctr_get_rate_1s(st->peer->iline, LINE_CTR_E1oIP_UNDERRUN); + if (rate > 7500) { + LOGPFSML(fi, LOGL_ERROR, "More than 7500 RIFO underruns per second: " + "Peer clock is too slow. Disconnecting.\n"); + osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); + return; + } + + osmo_timer_schedule(&st->rx_alive_timer, 3, 0); } /* call-back function for every received OCTOI socket message for given peer */ -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ie3fffa1c1c20962b40320c8cc088c140b8d64e77 Gerrit-Change-Number: 27839 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: check if scheduling of [dummy] FACCH/H is allowed

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27836 ) Change subject: osmo-bts-trx: check if scheduling of [dummy] FACCH/H is allowed ...................................................................... Patch Set 2: (1 comment) File src/osmo-bts-trx/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmo-bts/+/27836/comment/9157e127_f0e7a0f8 PS2, Line 415: goto send_burst; /* send garbage */ Thanks, for the explanation, it's clearer now. I still lack some better definition of what "garbage" is in this scenario. Is it uninitialized memory? zeroed memory? padding? This should be clarified. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6f8af140a6ccf3d5fd7b98f6cb5c18e2c5e2f61b Gerrit-Change-Number: 27836 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Apr 2022 09:58:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: tx_tchh_fn(): make handling of FACCH/H cleaner

by pespin

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27835 ) Change subject: osmo-bts-trx: tx_tchh_fn(): make handling of FACCH/H cleaner ...................................................................... Patch Set 1: (1 comment) File src/osmo-bts-trx/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmo-bts/+/27835/comment/97acb6bf_d67a682f PS1, Line 395: msgb_free(msg); /* steal 2nd speech frame */ > Ack, I can update the comment if you find it cleaner. yes please. when I read "steal" here I get confused because it looks like it is planned to be used somewhere/somehow else. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27835 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib923b8f5cc1063e9fc18acd2bdd003fd09f4b70f Gerrit-Change-Number: 27835 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Apr 2022 09:53:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: use C/I in the AMR link adaptation loop

by osmith

Attention is currently required from: fixeria, pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27758 ) Change subject: osmo-bts-trx: use C/I in the AMR link adaptation loop ...................................................................... Patch Set 5: (2 comments) File src/osmo-bts-trx/amr_loop.c: https://gerrit.osmocom.org/c/osmo-bts/+/27758/comment/0d7fa69b_3bdab3df PS5, Line 76: const int thresh_lower_cb = cfg->mode[chan_state->dl_cmr - 1].threshold * 5; is the hysteresis missing here (see thresh_upper_cb)? https://gerrit.osmocom.org/c/osmo-bts/+/27758/comment/68660b10_06858b55 PS5, Line 86: } else if (chan_state->dl_cmr < chan_state->codecs - 1) { just to be sure, is the "else if" here intentional, instead of just "if"? given that dl_cmr is an uint8_t, it looks like with this logic it can only alternate between 0 and 1. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27758 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ide84bf864f56020c0265cfb9731615d4f7bad7f5 Gerrit-Change-Number: 27758 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 20 Apr 2022 09:18:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in dahdi-linux[master]: icE1usb: Fix inverted logic for clock timing source

by manawyrm

Attention is currently required from: laforge. manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27838 ) Change subject: icE1usb: Fix inverted logic for clock timing source ...................................................................... Patch Set 1: (1 comment) File drivers/dahdi/icE1usb/icE1usb.c: https://gerrit.osmocom.org/c/dahdi-linux/+/27838/comment/45d2edbc_60583764 PS1, Line 694: ieu->cfg.tx.timing = ICE1USB_TX_TIME_SRC_REMITE; REMOTE :) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: If35a5a52c094129c342d0f658f496b488d1826ad Gerrit-Change-Number: 27838 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Wed, 20 Apr 2022 09:11:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in dahdi-linux[master]: icE1usb: Fix inverted logic for clock timing source

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/27838 ) Change subject: icE1usb: Fix inverted logic for clock timing source ...................................................................... icE1usb: Fix inverted logic for clock timing source The 'struct dahdi_lineconfig.sync' parameter originates from the 'timing' field of system.conf. dahdi_cfg passes it via the SPANCONFIG ioctl into the kernel. The DAHDI docs say: > source of the master clock. If you choose 0, the port will never > be used as a source of timing. This is appropriate when you know the > far end should always be a slave to you. So if '0' we should use the local clock, and if > 0, the recovered remote clock. Thanks to Christoph Lauter for pointing this out. Change-Id: If35a5a52c094129c342d0f658f496b488d1826ad --- M drivers/dahdi/icE1usb/icE1usb.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/38/27838/1 diff --git a/drivers/dahdi/icE1usb/icE1usb.c b/drivers/dahdi/icE1usb/icE1usb.c index e829b2d..04a7b04 100644 --- a/drivers/dahdi/icE1usb/icE1usb.c +++ b/drivers/dahdi/icE1usb/icE1usb.c @@ -691,9 +691,9 @@ ieu->cfg.tx.mode = ICE1USB_TX_MODE_TS0; if (lc->sync > 0) - ieu->cfg.tx.timing = ICE1USB_TX_TIME_SRC_LOCAL; + ieu->cfg.tx.timing = ICE1USB_TX_TIME_SRC_REMITE; else - ieu->cfg.tx.timing = ICE1USB_TX_TIME_SRC_REMOTE; + ieu->cfg.tx.timing = ICE1USB_TX_TIME_SRC_LOCAL; /* (re-)set to sane defaults */ ieu->cfg.tx.ext_loopback = ICE1USB_TX_EXT_LOOPBACK_OFF; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/27838 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: If35a5a52c094129c342d0f658f496b488d1826ad Gerrit-Change-Number: 27838 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: check if scheduling of [dummy] FACCH/H is allowed

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27836 ) Change subject: osmo-bts-trx: check if scheduling of [dummy] FACCH/H is allowed ...................................................................... Patch Set 2: (1 comment) File src/osmo-bts-trx/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmo-bts/+/27836/comment/1c1ccc9b_3eaf849b PS1, Line 414: if (!sched_tchh_dl_facch_map[br->fn % 26]) > How will that random garbage not also be detected as BER, too? Right, sending garbage will of course result in decoding errors on the MS side. So this patch does not guard against sporadic gaps in the Downlink TCH queue. However when tch_dl_dequeue() constantly yields nothing, e.g. when we end up with a codec mismatch, then this additional check saves us from starting misaligned FACCH/H transmission. If we start at a wrong TDMA offset, then all subsequent FACCH frames will be scheduled at wrong offsets and thus none of them will be decoded by the MS. We can of course improve this further by sending a cached SID frame instead of dummy FACCH, or sending a BFI if no SID was cached. But this is a topic for a separate patch. As I said, this is the best we can do for now. Better than sending a constant stream of misaligned FACCH. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6f8af140a6ccf3d5fd7b98f6cb5c18e2c5e2f61b Gerrit-Change-Number: 27836 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Apr 2022 22:47:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: octoi: slip frames if RIFO runs empty in IP->E1 direction

by manawyrm

Attention is currently required from: roox, laforge, tnt. manawyrm has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27837 ) Change subject: octoi: slip frames if RIFO runs empty in IP->E1 direction ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: Looking at the unit tests: ``` TEST: correct_order, starting at FN: 0 RIFO_IN(0000000000000000000000000000000000000000000000000000000000000000, 0)=0 RIFO_IN(0101010101010101010101010101010101010101010101010101010101010101, 1)=0 RIFO_IN(0202020202020202020202020202020202020202020202020202020202020202, 2)=0 RIFO_IN(0303030303030303030303030303030303030303030303030303030303030303, 3)=0 RIFO_IN(0404040404040404040404040404040404040404040404040404040404040404, 4)=0 RIFO_IN(0505050505050505050505050505050505050505050505050505050505050505, 5)=0 RIFO_IN(0606060606060606060606060606060606060606060606060606060606060606, 6)=0 RIFO_IN(0707070707070707070707070707070707070707070707070707070707070707, 7)=0 RIFO_IN(0808080808080808080808080808080808080808080808080808080808080808, 8)=0 RIFO_IN(0909090909090909090909090909090909090909090909090909090909090909, 9)=0 RIFO_OUT(0000000000000000000000000000000000000000000000000000000000000000)=0 RIFO_OUT(0101010101010101010101010101010101010101010101010101010101010101)=0 RIFO_OUT(0202020202020202020202020202020202020202020202020202020202020202)=0 RIFO_OUT(0303030303030303030303030303030303030303030303030303030303030303)=0 RIFO_OUT(0404040404040404040404040404040404040404040404040404040404040404)=0 RIFO_OUT(0505050505050505050505050505050505050505050505050505050505050505)=0 RIFO_OUT(0606060606060606060606060606060606060606060606060606060606060606)=0 RIFO_OUT(0707070707070707070707070707070707070707070707070707070707070707)=0 RIFO_OUT(0808080808080808080808080808080808080808080808080808080808080808)=0 RIFO_OUT(ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff)=-2 ``` This doesn't seem quite right? There are some other oddities in there. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ic2a714fedb9a0698c17ef22447904a803c26ebfc Gerrit-Change-Number: 27837 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Tue, 19 Apr 2022 22:19:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: check if scheduling of [dummy] FACCH/H is allowed

by laforge

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27836 ) Change subject: osmo-bts-trx: check if scheduling of [dummy] FACCH/H is allowed ...................................................................... Patch Set 2: (1 comment) File src/osmo-bts-trx/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmo-bts/+/27836/comment/3cc5b332_27d1e2c3 PS1, Line 414: if (!sched_tchh_dl_facch_map[br->fn % 26]) > "Why first try to send dummy stuff" - where? This is not the case. […] How will that random garbage not also be detected as BER, too? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6f8af140a6ccf3d5fd7b98f6cb5c18e2c5e2f61b Gerrit-Change-Number: 27836 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Apr 2022 21:48:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022