April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-e1d[master]: octoi: Fix frame_rifo_depth() function

by laforge

Attention is currently required from: manawyrm, roox, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27848 ) Change subject: octoi: Fix frame_rifo_depth() function ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I088f181e74358eb2c96a7aab7a7c875b9276d980 Gerrit-Change-Number: 27848 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 13:53:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: rifo_test: Use a helper function for the rifo init

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27850 ) Change subject: rifo_test: Use a helper function for the rifo init ...................................................................... Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5d9397be391c60f732c89f158d25660e1f32cfac Gerrit-Change-Number: 27850 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 13:53:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: rifo_test: Use a helper function for the rifo init

by laforge

Attention is currently required from: laforge. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27850 ) Change subject: rifo_test: Use a helper function for the rifo init ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5d9397be391c60f732c89f158d25660e1f32cfac Gerrit-Change-Number: 27850 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: tnt <tnt(a)246tNt.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: deleteVote

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: rifo_test: print rifo_depth + rifo_frames on every IN/OUT

by laforge

Attention is currently required from: manawyrm, roox, tnt. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27847 ) Change subject: rifo_test: print rifo_depth + rifo_frames on every IN/OUT ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I1be1889800c83d251d17801f31040c137c06a46d Gerrit-Change-Number: 27847 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: deleteVote

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: rifo_test: print rifo_depth + rifo_frames on every IN/OUT

by laforge

Attention is currently required from: manawyrm, roox, tnt. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27847 ) Change subject: rifo_test: print rifo_depth + rifo_frames on every IN/OUT ...................................................................... Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I1be1889800c83d251d17801f31040c137c06a46d Gerrit-Change-Number: 27847 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 13:53:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: octoi: Disconnect the link when >= 7500 underruns/s

by laforge

Attention is currently required from: manawyrm, roox. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/27839 ) Change subject: octoi: Disconnect the link when >= 7500 underruns/s ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27839 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ie3fffa1c1c20962b40320c8cc088c140b8d64e77 Gerrit-Change-Number: 27839 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Comment-Date: Wed, 20 Apr 2022 13:53:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: rifo_test: print rifo_depth + rifo_frames on every IN/OUT

by laforge

Attention is currently required from: manawyrm, roox, laforge, tnt. Hello Jenkins Builder, manawyrm, roox, tnt, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/27847 to look at the new patch set (#2). Change subject: rifo_test: print rifo_depth + rifo_frames on every IN/OUT ...................................................................... rifo_test: print rifo_depth + rifo_frames on every IN/OUT This shows that rifo_depth is off-by-one for all but the 'empty' case. It is intended that 'make check' will fail after this commit, before the next commit with the fix is introduced. Change-Id: I1be1889800c83d251d17801f31040c137c06a46d --- M tests/rifo/rifo_test.c M tests/rifo/rifo_test.ok 2 files changed, 230 insertions(+), 226 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/47/27847/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27847 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I1be1889800c83d251d17801f31040c137c06a46d Gerrit-Change-Number: 27847 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: octoi: differentiate UNDERRUN from SUBSTITUTED in counters

by laforge

Attention is currently required from: manawyrm, roox, laforge, tnt. Hello Jenkins Builder, manawyrm, roox, tnt, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/27845 to look at the new patch set (#5). Change subject: octoi: differentiate UNDERRUN from SUBSTITUTED in counters ...................................................................... octoi: differentiate UNDERRUN from SUBSTITUTED in counters A real _underrun_ happens if the RIFO is empty (depth == 0) and should be counted different from a mere frame substition due to packet loss. Change-Id: I5448430b09ec10a16decdfd0a4a40850fe2ed1a6 --- M src/octoi/e1oip.c M src/octoi/e1oip.h M src/octoi/frame_rifo.c M src/octoi/octoi.c M tests/rifo/rifo_test.ok 5 files changed, 38 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/45/27845/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27845 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5448430b09ec10a16decdfd0a4a40850fe2ed1a6 Gerrit-Change-Number: 27845 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Reviewer: roox <mardnh(a)gmx.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: manawyrm <osmocom.account(a)tbspace.de> Gerrit-Attention: roox <mardnh(a)gmx.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: rifo_test: Use a helper function for the rifo init

by laforge

Attention is currently required from: tnt. Hello tnt, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/27850 to review the following change. Change subject: rifo_test: Use a helper function for the rifo init ...................................................................... rifo_test: Use a helper function for the rifo init Because we poke at some of the internals we need to make sure to maintain the internal state consistent. Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I5d9397be391c60f732c89f158d25660e1f32cfac --- M tests/rifo/rifo_test.c 1 file changed, 12 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/50/27850/1 diff --git a/tests/rifo/rifo_test.c b/tests/rifo/rifo_test.c index 06c882c..4e7ae45 100644 --- a/tests/rifo/rifo_test.c +++ b/tests/rifo/rifo_test.c @@ -11,6 +11,13 @@ static void *g_e1d_ctx; static uint32_t init_next_out_fn; +static void rifo_init(struct frame_rifo *rifo) +{ + frame_rifo_init(rifo); + rifo->next_out_fn = init_next_out_fn; + rifo->last_in_fn = init_next_out_fn - 1; +} + static void rifo_in(struct frame_rifo *rifo, uint8_t *frame, uint32_t fn) { int rc = frame_rifo_in(rifo, frame, fn); @@ -32,6 +39,7 @@ struct frame_rifo rifo; frame_rifo_init(&rifo); rifo.next_out_fn = init_next_out_fn; + rifo.last_in_fn = init_next_out_fn - 1; printf("\nTEST: %s, starting at FN: %u\n", __func__, init_next_out_fn); @@ -54,8 +62,7 @@ static void reordered_in(void) { struct frame_rifo rifo; - frame_rifo_init(&rifo); - rifo.next_out_fn = init_next_out_fn; + rifo_init(&rifo); printf("\nTEST: %s, starting at FN: %u\n", __func__, init_next_out_fn); @@ -76,8 +83,7 @@ static void correct_order(void) { struct frame_rifo rifo; - frame_rifo_init(&rifo); - rifo.next_out_fn = init_next_out_fn; + rifo_init(&rifo); printf("\nTEST: %s, starting at FN: %u\n", __func__, init_next_out_fn); @@ -98,8 +104,7 @@ static void too_old_frames(void) { struct frame_rifo rifo; - frame_rifo_init(&rifo); - rifo.next_out_fn = init_next_out_fn; + rifo_init(&rifo); printf("\nTEST: %s, starting at FN: %u\n", __func__, init_next_out_fn); @@ -133,8 +138,7 @@ { uint8_t frame[32]; struct frame_rifo rifo; - frame_rifo_init(&rifo); - rifo.next_out_fn = init_next_out_fn; + rifo_init(&rifo); printf("\nTEST: %s, starting at FN: %u\n", __func__, init_next_out_fn); -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27850 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I5d9397be391c60f732c89f158d25660e1f32cfac Gerrit-Change-Number: 27850 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-e1d[master]: cosmetic: remove dead code {fifo,rifo}_dump() functions

by laforge

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/27849 to look at the new patch set (#2). Change subject: cosmetic: remove dead code {fifo,rifo}_dump() functions ...................................................................... cosmetic: remove dead code {fifo,rifo}_dump() functions Change-Id: I8c6fc5fe82bc3a045a9e5d23965ca6d5532d6112 --- M src/octoi/frame_fifo.c M src/octoi/frame_rifo.c 2 files changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/49/27849/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/27849 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I8c6fc5fe82bc3a045a9e5d23965ca6d5532d6112 Gerrit-Change-Number: 27849 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022