April 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: firmware/apps/hello_world: remove unused test[] buffer

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27874 ) Change subject: firmware/apps/hello_world: remove unused test[] buffer ...................................................................... firmware/apps/hello_world: remove unused test[] buffer Change-Id: I20d41111d6f611202dcefada8091ccda0cc51dad --- M src/target/firmware/apps/hello_world/main.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/target/firmware/apps/hello_world/main.c b/src/target/firmware/apps/hello_world/main.c index aeb5739..ecacc18 100644 --- a/src/target/firmware/apps/hello_world/main.c +++ b/src/target/firmware/apps/hello_world/main.c @@ -165,8 +165,6 @@ void key_handler(enum key_codes code, enum key_states state) { - char test[16]; - if (state != PRESSED) return; 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I20d41111d6f611202dcefada8091ccda0cc51dad Gerrit-Change-Number: 27874 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/apps/rssi: remove redundant block in handle_pm()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27872 ) Change subject: firmware/apps/rssi: remove redundant block in handle_pm() ...................................................................... firmware/apps/rssi: remove redundant block in handle_pm() Below in the common path for both true and false branches we do have a conditional block setting ARFCN_UPLINK if uplink is true. Change-Id: If3adc5d1f11d3f43cb4c17bdb355b160ab61dc56 --- M src/target/firmware/apps/rssi/main.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index 94ecc3b..29c5430 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -916,8 +916,6 @@ a = arfcn; if (pcs && arfcn >= PCS_MIN && arfcn <= PCS_MAX) a |= ARFCN_PCS; - if (uplink) - a |= ARFCN_UPLINK; e = a; pm_mode = PM_SENT; } else { /* mode == MODE_SPECTRUM */ 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If3adc5d1f11d3f43cb4c17bdb355b160ab61dc56 Gerrit-Change-Number: 27872 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27871 ) Change subject: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm() ...................................................................... firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm() In this function we have the following condition: if (pm_mode == PM_IDLE && (mode == MODE_MAIN || mode == MODE_SPECTRUM)) so the 'mode' can be either MODE_MAIN or MODE_SPECTRUM. Still, GCC throws false-positive warnings that 'a' and 'e' may be used uninitialized in handle_pm(). Let's eliminate these warnings by using 'if-else' statement. Change-Id: I86d241c41d4de135f4cd79f56f7fdd18696b7890 --- M src/target/firmware/apps/rssi/main.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/target/firmware/apps/rssi/main.c b/src/target/firmware/apps/rssi/main.c index 9a3f87c..94ecc3b 100644 --- a/src/target/firmware/apps/rssi/main.c +++ b/src/target/firmware/apps/rssi/main.c @@ -920,8 +920,7 @@ a |= ARFCN_UPLINK; e = a; pm_mode = PM_SENT; - } - if (mode == MODE_SPECTRUM) { + } else { /* mode == MODE_SPECTRUM */ if (pcs && arfcn >= PCS_MIN && arfcn <= PCS_MAX) { a = PCS_MIN | ARFCN_PCS; e = PCS_MAX | ARFCN_PCS; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27871 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I86d241c41d4de135f4cd79f56f7fdd18696b7890 Gerrit-Change-Number: 27871 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/layer1: fix unused variable 'l1h' [-Wunused-variable]

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27870 ) Change subject: firmware/layer1: fix unused variable 'l1h' [-Wunused-variable] ...................................................................... firmware/layer1: fix unused variable 'l1h' [-Wunused-variable] Change-Id: If8c3da3908c1dab7a93e69daee13426f9bdbccad --- M src/target/firmware/layer1/l23_api.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/target/firmware/layer1/l23_api.c b/src/target/firmware/layer1/l23_api.c index 2bd57d2..275043b 100644 --- a/src/target/firmware/layer1/l23_api.c +++ b/src/target/firmware/layer1/l23_api.c @@ -346,8 +346,6 @@ /* receive a L1CTL_DM_REL_REQ from L23 */ static void l1ctl_rx_dm_rel_req(struct msgb *msg) { - struct l1ctl_hdr *l1h = (struct l1ctl_hdr *) msg->data; - printd("L1CTL_DM_REL_REQ\n"); l1a_mftask_set(0); l1s.dedicated.type = GSM_DCHAN_NONE; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: If8c3da3908c1dab7a93e69daee13426f9bdbccad Gerrit-Change-Number: 27870 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm()

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27871 ) Change subject: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm() ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: 1+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27871 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I86d241c41d4de135f4cd79f56f7fdd18696b7890 Gerrit-Change-Number: 27871 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 15:25:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in pysim[master]: transport/pcsc: throw ReaderError with a message

by fixeria

Attention is currently required from: laforge, dexter. Hello Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/27882 to look at the new patch set (#3). Change subject: transport/pcsc: throw ReaderError with a message ...................................................................... transport/pcsc: throw ReaderError with a message Before this patch: $ ./pySim-shell.py -p 0 Card reader initialization failed with an exception of type: <class 'pySim.exceptions.ReaderError'> after: $ ./pySim-shell.py -p 0 Card reader initialization failed with exception: No reader found for number 0 Change-Id: Id08c4990857f7083a8d1cefc90ff85fc20ab6fef --- M pySim/transport/pcsc.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/82/27882/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27882 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id08c4990857f7083a8d1cefc90ff85fc20ab6fef Gerrit-Change-Number: 27882 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in pysim[master]: transport/pcsc: throw ReaderError with a message

by fixeria

Attention is currently required from: laforge, dexter. Hello Jenkins Builder, laforge, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/27882 to look at the new patch set (#2). Change subject: transport/pcsc: throw ReaderError with a message ...................................................................... transport/pcsc: throw ReaderError with a message Before this patch: $ ./pySim-shell.py -p 0 Card reader initialization failed with an exception of type: <class 'pySim.exceptions.ReaderError'> after: $ ./pySim-shell.py -p 0 Card reader initialization failed with exception: No reader found with number 0 Change-Id: Id08c4990857f7083a8d1cefc90ff85fc20ab6fef --- M pySim/transport/pcsc.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/82/27882/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27882 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id08c4990857f7083a8d1cefc90ff85fc20ab6fef Gerrit-Change-Number: 27882 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in pysim[master]: transport/pcsc: throw ReaderError with a message

by fixeria

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27882 ) Change subject: transport/pcsc: throw ReaderError with a message ...................................................................... Patch Set 1: (1 comment) File pySim/transport/pcsc.py: https://gerrit.osmocom.org/c/pysim/+/27882/comment/fd14dd43_9e352a68 PS1, Line 37: with > language-wise "No reader found for number X" would make more sense, IMHO. Thanks! Changed in the next patchset. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27882 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id08c4990857f7083a8d1cefc90ff85fc20ab6fef Gerrit-Change-Number: 27882 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 15:24:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: Introduce VTY command 'ccch load-indication-period <0-256>'

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27933 ) Change subject: Introduce VTY command 'ccch load-indication-period <0-256>' ...................................................................... Introduce VTY command 'ccch load-indication-period <0-256>' Change-Id: Id9d23238863c02a72bcf32942f6b0d40be127904 --- M include/osmocom/bsc/bts.h M src/osmo-bsc/bts.c M src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c M src/osmo-bsc/bts_vty.c 4 files changed, 22 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/33/27933/1 diff --git a/include/osmocom/bsc/bts.h b/include/osmocom/bsc/bts.h index 4c1127b..a3c7025 100644 --- a/include/osmocom/bsc/bts.h +++ b/include/osmocom/bsc/bts.h @@ -471,8 +471,10 @@ } pwr_ctrl; /* TS 44.060 Table 12.9.1 */ } gprs; - /* threshold (in percent) when BTS shall send CCCH LOAD IND */ + /* CCCH Load Threshold: threshold (in percent) when BTS shall send CCCH LOAD IND */ uint8_t ccch_load_ind_thresh; + /* CCCH Load Indication Period: how often (secs) to send CCCH LOAD IND when over CCCH Load Threshold. */ + uint8_t ccch_load_ind_period; /* RACH NM values */ int rach_b_thresh; diff --git a/src/osmo-bsc/bts.c b/src/osmo-bsc/bts.c index 87ed44f..a596523 100644 --- a/src/osmo-bsc/bts.c +++ b/src/osmo-bsc/bts.c @@ -266,6 +266,7 @@ bts->c0->ts[0].pchan_from_config = GSM_PCHAN_CCCH_SDCCH4; /* TODO: really?? */ bts->ccch_load_ind_thresh = 10; /* 10% of Load: Start sending CCCH LOAD IND */ + bts->ccch_load_ind_period = 1; /* Send CCCH LOAD IND every 1 second */ bts->rach_b_thresh = -1; bts->rach_ldavg_slots = -1; diff --git a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c index 4f7a487..0c08616 100644 --- a/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c +++ b/src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c @@ -71,7 +71,7 @@ msgb_tv_put(msgb, NM_ATT_CCCH_L_T, bts->ccch_load_ind_thresh); /* CCCH Load Indication Period (3GPP TS 12.21 sec 9.4.11), seconds */ - msgb_tv_put(msgb, NM_ATT_CCCH_L_I_P, 1); + msgb_tv_put(msgb, NM_ATT_CCCH_L_I_P, bts->ccch_load_ind_period); /* RACH Busy Threshold (3GPP TS 12.21 sec 9.4.44), -dBm */ buf[0] = 90; /* -90 dBm as default "busy" threshold */ diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 1411cd3..50ad57f 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -926,6 +926,19 @@ return CMD_SUCCESS; } +DEFUN_USRATTR(cfg_bts_ccch_load_ind_period, + cfg_bts_ccch_load_ind_period_cmd, + X(BSC_VTY_ATTR_RESTART_ABIS_OML_LINK), + "ccch load-indication-period <0-256>", + CCCH_STR + "Period of time at which BTS sends RSL CCCH LOAD IND\n" + "CCCH Load Indication Period in seconds (Default: 1)\n") +{ + struct gsm_bts *bts = vty->index; + bts->ccch_load_ind_period = atoi(argv[0]); + return CMD_SUCCESS; +} + #define NM_STR "Network Management\n" DEFUN_USRATTR(cfg_bts_rach_nm_b_thresh, @@ -4166,6 +4179,9 @@ if (bts->ccch_load_ind_thresh != 10) vty_out(vty, " ccch load-indication-threshold %u%s", bts->ccch_load_ind_thresh, VTY_NEWLINE); + if (bts->ccch_load_ind_period != 1) + vty_out(vty, " ccch load-indication-period %u%s", + bts->ccch_load_ind_period, VTY_NEWLINE); if (bts->rach_b_thresh != -1) vty_out(vty, " rach nm busy threshold %u%s", bts->rach_b_thresh, VTY_NEWLINE); @@ -4479,6 +4495,7 @@ install_element(BTS_NODE, &cfg_bts_chan_desc_bs_ag_blks_res_cmd); install_element(BTS_NODE, &cfg_bts_chan_dscr_bs_ag_blks_res_cmd); install_element(BTS_NODE, &cfg_bts_ccch_load_ind_thresh_cmd); + install_element(BTS_NODE, &cfg_bts_ccch_load_ind_period_cmd); install_element(BTS_NODE, &cfg_bts_rach_nm_b_thresh_cmd); install_element(BTS_NODE, &cfg_bts_rach_nm_ldavg_cmd); install_element(BTS_NODE, &cfg_bts_cell_barred_cmd); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9d23238863c02a72bcf32942f6b0d40be127904 Gerrit-Change-Number: 27933 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmocom-bb[master]: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/27871 ) Change subject: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/27871 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I86d241c41d4de135f4cd79f56f7fdd18696b7890 Gerrit-Change-Number: 27871 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 15:17:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022