February 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: lint: checkpatch: show hint about typedefs_osmo.txt

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27203 ) Change subject: lint: checkpatch: show hint about typedefs_osmo.txt ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icaee700a9cc7896cdbda6cce93db41b6b50a7fa3 Gerrit-Change-Number: 27203 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 13:34:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in libosmocore[master]: stats: sanitize tcp stat name identifiers

by daniel

Attention is currently required from: iedemam, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 ) Change subject: stats: sanitize tcp stat name identifiers ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Yes, the patch is simple but I don't really think the generated strings are less ugly. […] I somehow forgot to send this: The NSVCs currently set a name like this: NSE00102-NSVC-UDP-127_0_0_1:23000-127_0_0_11:8888 This seems wrong for statsd as well, because a colon separates the name from the value - so we already have this issue in other places. How about we: * Keep a statg->name as well as a statg->sanitized_name around * Let the user set any name through set_name() * Internally sanitize the name and save it to sanitized_name, keep the original in name This way we don't need to remember to properly sanitize at every caller and VTY code can still show the pretty name. The control interface could choose to use the (statsd-sanitized) name or sanitize the original name itself. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 13:31:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in ReleaseList

by daniel

Attention is currently required from: laforge, dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 ) Change subject: ranap_rab_ass: add function to check if RAB is in ReleaseList ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Gerrit-Change-Number: 27199 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 13:26:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in ReleaseList

by dexter

Attention is currently required from: laforge, daniel. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 ) Change subject: ranap_rab_ass: add function to check if RAB is in ReleaseList ...................................................................... Patch Set 3: (1 comment) File src/osmo-hnbgw/ranap_rab_ass.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199/comment/306d1186_235c204e PS2, Line 603: Response > Request, above as well Done -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Gerrit-Change-Number: 27199 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 13:05:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: add function to check if RAB is in ReleaseList

by dexter

Attention is currently required from: laforge, daniel. Hello Jenkins Builder, laforge, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 to look at the new patch set (#3). Change subject: ranap_rab_ass: add function to check if RAB is in ReleaseList ...................................................................... ranap_rab_ass: add function to check if RAB is in ReleaseList A RANAP RAB-AssignmentRelease may contain a ReleaseList. In order to detect that a RAB is about to be released we need to be able to check if the RAB we are dealing with is contained in such a ReleaseList. Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Related: OS#5152 --- M include/osmocom/hnbgw/ranap_rab_ass.h M src/osmo-hnbgw/ranap_rab_ass.c M tests/ranap_rab_ass/ranap_rab_ass_test.c M tests/ranap_rab_ass/ranap_rab_ass_test.ok 4 files changed, 97 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/99/27199/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I5b67cc2d35d11de7a09e66c181a1fdd5a58c75bb Gerrit-Change-Number: 27199 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: add typedefs_osmo.txt

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27202 ) Change subject: lint: checkpatch: add typedefs_osmo.txt ...................................................................... lint: checkpatch: add typedefs_osmo.txt Fix false error: ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) in a line with a typedef: int handle_rab_ass_req(..., ranap_message *message); Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c --- M lint/checkpatch/checkpatch_osmo.sh A lint/checkpatch/typedefs_osmo.txt 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Verified dexter: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 8514f9c..93b601b 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -116,6 +116,7 @@ --ignore UNSPECIFIED_INT \ --ignore VOLATILE \ --max-line-length 120 \ + --typedefsfile "$SCRIPT_DIR/typedefs_osmo.txt" \ --no-signoff \ --no-tree \ "$@" diff --git a/lint/checkpatch/typedefs_osmo.txt b/lint/checkpatch/typedefs_osmo.txt new file mode 100644 index 0000000..5164368 --- /dev/null +++ b/lint/checkpatch/typedefs_osmo.txt @@ -0,0 +1 @@ +ranap_message -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c Gerrit-Change-Number: 27202 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: add typedefs_osmo.txt

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27202 ) Change subject: lint: checkpatch: add typedefs_osmo.txt ...................................................................... Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c Gerrit-Change-Number: 27202 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 12:55:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: add typedefs_osmo.txt

by dexter

Attention is currently required from: osmith. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27202 ) Change subject: lint: checkpatch: add typedefs_osmo.txt ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c Gerrit-Change-Number: 27202 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Feb 2022 12:54:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: add typedefs_osmo.txt

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27202 ) Change subject: lint: checkpatch: add typedefs_osmo.txt ...................................................................... lint: checkpatch: add typedefs_osmo.txt Fix false error: ERROR:SPACING: need consistent spacing around '*' (ctx:WxV) in a line with a typedef: int handle_rab_ass_req(..., ranap_message *message); Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c --- M lint/checkpatch/checkpatch_osmo.sh A lint/checkpatch/typedefs_osmo.txt 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/02/27202/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 8514f9c..93b601b 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -116,6 +116,7 @@ --ignore UNSPECIFIED_INT \ --ignore VOLATILE \ --max-line-length 120 \ + --typedefsfile "$SCRIPT_DIR/typedefs_osmo.txt" \ --no-signoff \ --no-tree \ "$@" diff --git a/lint/checkpatch/typedefs_osmo.txt b/lint/checkpatch/typedefs_osmo.txt new file mode 100644 index 0000000..5164368 --- /dev/null +++ b/lint/checkpatch/typedefs_osmo.txt @@ -0,0 +1 @@ +ranap_message -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27202 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icbc46d0c788ca75684a48a73f739265f4a09b09c Gerrit-Change-Number: 27202 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: checkpatch: show hint about typedefs_osmo.txt

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/27203 ) Change subject: lint: checkpatch: show hint about typedefs_osmo.txt ...................................................................... lint: checkpatch: show hint about typedefs_osmo.txt Change-Id: Icaee700a9cc7896cdbda6cce93db41b6b50a7fa3 --- M lint/checkpatch/checkpatch.pl 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/03/27203/1 diff --git a/lint/checkpatch/checkpatch.pl b/lint/checkpatch/checkpatch.pl index 51c406e..d98d79c 100755 --- a/lint/checkpatch/checkpatch.pl +++ b/lint/checkpatch/checkpatch.pl @@ -5151,7 +5151,7 @@ } } elsif ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { if (ERROR("SPACING", - "need consistent spacing around '$op' $at\n" . $hereptr)) { + "need consistent spacing around '$op' $at (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)\n" . $hereptr)) { $good = rtrim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " "; if (defined $fix_elements[$n + 2]) { $fix_elements[$n + 2] =~ s/^\s+//; -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27203 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icaee700a9cc7896cdbda6cce93db41b6b50a7fa3 Gerrit-Change-Number: 27203 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022