Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27213 )
Change subject: Add debian-bullseye-erlang docker image
......................................................................
Patch Set 1:
(1 comment)
File debian-bullseye-erlang/Makefile:
https://gerrit.osmocom.org/c/docker-playground/+/27213/comment/73df73c3_45d…
PS1, Line 1: UPSTREAM_DISTRO=debian:buster
> Are you sure this is correct?
Thanks, I didn't see this.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27213
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I5c13eedcbfa721b7e1939e571470ea7044c00211
Gerrit-Change-Number: 27213
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Feb 2022 14:46:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27212 )
Change subject: gsm0808: Test if we properly decode a SRVCC cell identifier list
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27212
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I608220e8e5dd5a44f85c6bc5ea04622a2cad24ec
Gerrit-Change-Number: 27212
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Feb 2022 14:32:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin, lynxis lazus, dexter.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 )
Change subject: Add hnbgw tests
......................................................................
Patch Set 6:
(5 comments)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/9d73d26d_246e…
PS5, Line 144: mgw_rtp_ip := "1.1.1.1",
> could use a private ip range
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/67b3ebe3_a643…
PS5, Line 150: mgw_rtp_ip := "2.2.2.2",
> could use a private ip range
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/18f51ef2_e75d…
PS5, Line 156: hnb_rtp_ip := "1.1.1.2",
> could use a private ip range
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/af843581_24d6…
PS5, Line 158: cn_rtp_ip := "2.2.2.1",
> could use a private ip range
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/40d97afb_63f3…
PS5, Line 622: f_sleep(10.0);
> 10 seconds are quite long. […]
I added a timer to f_hnbap_register and removed the sleep completely
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0a2fb795aec83337eda8d9972e6ff264ead61076
Gerrit-Change-Number: 27106
Gerrit-PatchSet: 6
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Feb 2022 13:11:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment
Attention is currently required from: pespin, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27223 )
Change subject: mgcp_codec: do not differntiate between oe and bwe when comparing codec
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/27223
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I64731570c287a75d39c79c10e1bc09a37bdd54d6
Gerrit-Change-Number: 27223
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Feb 2022 12:48:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/27224 )
Change subject: gsm_08_08.h: Add Cell Identifier present in newer spec versions
......................................................................
gsm_08_08.h: Add Cell Identifier present in newer spec versions
Those are available in 3GPP TS 48.008 version 16.0.0 Release 16, section
3.2.2.17 Cell Identifier. It can be seen that we have a collision
between the osmocom non-standard format and the SAI standard one.
Related: SYS#5838
Change-Id: Id25e563febdb7640174540136225f399515a0089
---
M include/osmocom/gsm/protocol/gsm_08_08.h
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/24/27224/1
diff --git a/include/osmocom/gsm/protocol/gsm_08_08.h b/include/osmocom/gsm/protocol/gsm_08_08.h
index 983783e..0a5fed3 100644
--- a/include/osmocom/gsm/protocol/gsm_08_08.h
+++ b/include/osmocom/gsm/protocol/gsm_08_08.h
@@ -25,6 +25,8 @@
CELL_IDENT_UTRAN_PLMN_LAC_RNC = 8,
CELL_IDENT_UTRAN_RNC = 9,
CELL_IDENT_UTRAN_LAC_RNC = 10,
+ CELL_IDENT_UTRAN_SAI = 11,
+ CELL_IDENT_UTRAN_PLMN_LAC_RNC_CI = 12,
/* Not in 03.03 nor 08.08 */
CELL_IDENT_WHOLE_GLOBAL_PS = 11, /* CGI with + RAC */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27224
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id25e563febdb7640174540136225f399515a0089
Gerrit-Change-Number: 27224
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: laforge.
pespin has uploaded a new patch set (#2) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/27212 )
Change subject: gsm0808: Test if we properly decode a SRVCC cell identifier list
......................................................................
gsm0808: Test if we properly decode a SRVCC cell identifier list
We don't handle this correctly, as we decided to overload the
meaning of 0b1011 in a cell identifier list (defined by 3GPP
as used in SRVCC) with something osmocom proprietary.
Change-Id: I608220e8e5dd5a44f85c6bc5ea04622a2cad24ec
---
M tests/gsm0808/gsm0808_test.c
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/12/27212/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27212
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I608220e8e5dd5a44f85c6bc5ea04622a2cad24ec
Gerrit-Change-Number: 27212
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset