February 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: stats: use tcp stat names as provided

by pespin

Attention is currently required from: iedemam, daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 ) Change subject: stats: use tcp stat names as provided ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: Makes sense to me. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 3 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 18:04:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy: Only route to an SGSN if the BVC is not blocked

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 ) Change subject: gbproxy: Only route to an SGSN if the BVC is not blocked ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I0b54813c04bae2c63975082ad2dacae8affd3127 Gerrit-Change-Number: 27322 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 18:01:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in libosmo-abis[master]: stats: add BTS index to IPA RSL TCP stats name

by pespin

Attention is currently required from: iedemam. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/27323 ) Change subject: stats: add BTS index to IPA RSL TCP stats name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/27323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If7ae7f0e75de37e2e52a8ed724c861f57d0da574 Gerrit-Change-Number: 27323 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: iedemam <michael(a)kapsulate.com> Gerrit-Comment-Date: Thu, 24 Feb 2022 18:00:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: release call when FSM is not created

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 ) Change subject: mgw_fsm: release call when FSM is not created ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1904f7e95d86bbcecee14f8721bd4075d0e33ab4 Gerrit-Change-Number: 27320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 17:30:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in libosmo-abis[master]: stats: add BTS index to IPA RSL TCP stats name

by iedemam

iedemam has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/27323 ) Change subject: stats: add BTS index to IPA RSL TCP stats name ...................................................................... stats: add BTS index to IPA RSL TCP stats name With this change, the new TCP stat names more closely resemble existing RSL related stat names. Change-Id: If7ae7f0e75de37e2e52a8ed724c861f57d0da574 --- M src/input/ipaccess.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/23/27323/1 diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c index b410a7e..8dc1008 100644 --- a/src/input/ipaccess.c +++ b/src/input/ipaccess.c @@ -296,6 +296,7 @@ struct e1inp_ts *ts; struct osmo_fd *newbfd; struct e1inp_line *new_line; + char tcp_stat_name[32]; sign_link = line->ops->sign_link_up(&unit_data, line, @@ -342,9 +343,9 @@ "could not register FD\n"); goto err; } - char stat_name[16]; - snprintf(stat_name, sizeof(stat_name), "ipa-rsl-%u", unit_data.trx_id); - osmo_stats_tcp_osmo_fd_register(newbfd, stat_name); + snprintf(tcp_stat_name, sizeof(tcp_stat_name), "bts.%u.ipa-rsl.%u", + unit_data.bts_id, unit_data.trx_id); + osmo_stats_tcp_osmo_fd_register(newbfd, tcp_stat_name); e1i_ts = ipaccess_line_ts(newbfd, new_line); ipaccess_bsc_keepalive_fsm_alloc(e1i_ts, newbfd, "rsl_bsc_to_bts"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/27323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: If7ae7f0e75de37e2e52a8ed724c861f57d0da574 Gerrit-Change-Number: 27323 Gerrit-PatchSet: 1 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-hnbgw[master]: ranap_rab_ass: check for more than one RAB assignment req

by daniel

Attention is currently required from: pespin, dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27321 ) Change subject: ranap_rab_ass: check for more than one RAB assignment req ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27321/comment/4749c42f_9ad5f023 PS1, Line 694: then than -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I0f1d868fd0b4dc413533d6fcc5482862825181be Gerrit-Change-Number: 27321 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 16:56:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-hnbgw[master]: mgw_fsm: release call when FSM is not created

by daniel

Attention is currently required from: pespin, dexter. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 ) Change subject: mgw_fsm: release call when FSM is not created ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-hnbgw/mgw_fsm.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320/comment/1128ffdc_37d5ac4a PS1, Line 724: tx_release_req(map); > We could, but then the formatting of the message would be more difficult. […] Ok, I guess it improves the behaviour in any case. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I1904f7e95d86bbcecee14f8721bd4075d0e33ab4 Gerrit-Change-Number: 27320 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 16:55:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy: Only route to an SGSN if the BVC is not blocked

by daniel

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 ) Change subject: gbproxy: Only route to an SGSN if the BVC is not blocked ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: No Test for this yet, but it didn't break any existing tests either... -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I0b54813c04bae2c63975082ad2dacae8affd3127 Gerrit-Change-Number: 27322 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 24 Feb 2022 16:19:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-gbproxy[master]: gbproxy: Only route to an SGSN if the BVC is not blocked

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 ) Change subject: gbproxy: Only route to an SGSN if the BVC is not blocked ...................................................................... gbproxy: Only route to an SGSN if the BVC is not blocked Change-Id: I0b54813c04bae2c63975082ad2dacae8affd3127 --- M src/gb_proxy.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gbproxy refs/changes/22/27322/1 diff --git a/src/gb_proxy.c b/src/gb_proxy.c index 69a58d4..c2b958a 100644 --- a/src/gb_proxy.c +++ b/src/gb_proxy.c @@ -348,6 +348,8 @@ continue; if (sgsn->nse != sgsn_bvc->nse) continue; + if (!bssgp_bvc_fsm_is_unblocked(sgsn_bvc->fi)) + continue; return sgsn_bvc; } -- To view, visit https://gerrit.osmocom.org/c/osmo-gbproxy/+/27322 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gbproxy Gerrit-Branch: master Gerrit-Change-Id: I0b54813c04bae2c63975082ad2dacae8affd3127 Gerrit-Change-Number: 27322 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in libosmocore[master]: stats: use tcp stat names as provided

by iedemam

Attention is currently required from: pespin, daniel. iedemam has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27137 ) Change subject: stats: use tcp stat names as provided ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Hi all, Apologies for changing the sense of this patch so drastically. I wasn't sure if I should start a new changeset but did want to maintain the conversation surrounding the change. After using the new TCP stats in the field for awhile now, we are seeing some issues with the name being tied to the IP+port. As described in the new commit message, this constant name change on reconnects results in distinct stat key names for what is actually a single logical stat making observation difficult. Certainly name sanitation is still an issue elsewhere and should be addressed. I wanted to tackle each item individually though. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib04c2f5bfcbd6c19dd87debf1fc053abf0b9bef2 Gerrit-Change-Number: 27137 Gerrit-PatchSet: 3 Gerrit-Owner: iedemam <michael(a)kapsulate.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 24 Feb 2022 15:56:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022