December 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-abis[master]: GPRS Trau frame encoder/decoder for Ericsson RBS

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717 to look at the new patch set (#3). Change subject: GPRS Trau frame encoder/decoder for Ericsson RBS ...................................................................... GPRS Trau frame encoder/decoder for Ericsson RBS The Ericsson RBS BTS family is using a propritary TRAU frame dialect to communicate with the GPRS/EGPRS part of their CCU. There are essentially two implementations available: - GPRS over 16kbps I.460 subslots (very limited, supports only CS1 and CS4) - GPRS/EGPRS over full 64kbps timeslots (supports CS1-4 and MCS1-9) Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7 Related: OS#5198 --- M include/Makefile.am A include/osmocom/trau/trau_pcu_ericsson.h M src/Makefile.am A src/trau/trau_pcu_ericsson.c M tests/Makefile.am M tests/testsuite.at A tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c A tests/trau_pcu_ericsson/trau_pcu_ericsson_test.ok 8 files changed, 6,266 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/17/30717/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7 Gerrit-Change-Number: 30717 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in libosmocore[master]: ctrl: add optional port to bind command

by osmith

Attention is currently required from: arehbein, laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 ) Change subject: ctrl: add optional port to bind command ...................................................................... Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9 Gerrit-Change-Number: 30444 Gerrit-PatchSet: 12 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 20 Dec 2022 14:27:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-netif[master]: stream: Log error on short send

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30720 ) Change subject: stream: Log error on short send ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9bd257b80a378b779df84e204673f8e394eca5b6 Gerrit-Change-Number: 30720 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 14:25:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-netif[master]: stream: Log error on short send

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-netif/+/30720 ) Change subject: stream: Log error on short send ...................................................................... stream: Log error on short send This is clearly a problem on TCP streams which needs to be addressed in the future. Related: OS#5836 Change-Id: I9bd257b80a378b779df84e204673f8e394eca5b6 --- M src/stream.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/20/30720/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9bd257b80a378b779df84e204673f8e394eca5b6 Gerrit-Change-Number: 30720 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in libosmo-netif[master]: stream: Avoid useless polling if tx_queue becomes empty

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmo-netif/+/30721 ) Change subject: stream: Avoid useless polling if tx_queue becomes empty ...................................................................... stream: Avoid useless polling if tx_queue becomes empty Before this patch, the WRITE poll flag was being left ON and waited to be polled again by the kernel in order to disable it. Let's spate that extra polling cycle which only creates more polling triggers, context switches, etc. Change-Id: I1dd2145249a7322ad95e49be588fd472f00734e1 --- M src/stream.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/21/30721/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I1dd2145249a7322ad95e49be588fd472f00734e1 Gerrit-Change-Number: 30721 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in libosmo-netif[master]: stream: osmo_stream_*_write: Unifiy way to get data and length

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30719 ) Change subject: stream: osmo_stream_*_write: Unifiy way to get data and length ...................................................................... stream: osmo_stream_*_write: Unifiy way to get data and length Change-Id: I5b5d6f7a5a1722bd01c13d32557c21d8a0889966 --- M src/stream.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/19/30719/1 diff --git a/src/stream.c b/src/stream.c index b784b21..e9860c3 100644 --- a/src/stream.c +++ b/src/stream.c @@ -355,7 +355,7 @@ switch (cli->sk_domain) { case AF_UNIX: - ret = send(cli->ofd.fd, msg->data, msg->len, 0); + ret = send(cli->ofd.fd, msgb_data(msg), msgb_length(msg), 0); break; case AF_UNSPEC: case AF_INET: @@ -366,13 +366,13 @@ memset(&sinfo, 0, sizeof(sinfo)); sinfo.sinfo_ppid = htonl(msgb_sctp_ppid(msg)); sinfo.sinfo_stream = msgb_sctp_stream(msg); - ret = sctp_send(cli->ofd.fd, msg->data, msgb_length(msg), + ret = sctp_send(cli->ofd.fd, msgb_data(msg), msgb_length(msg), &sinfo, MSG_NOSIGNAL); break; #endif case IPPROTO_TCP: default: - ret = send(cli->ofd.fd, msg->data, msgb_length(msg), 0); + ret = send(cli->ofd.fd, msgb_data(msg), msgb_length(msg), 0); break; } break; @@ -1317,7 +1317,7 @@ switch (conn->srv->sk_domain) { case AF_UNIX: - ret = send(conn->ofd.fd, msg->data, msg->len, 0); + ret = send(conn->ofd.fd, msgb_data(msg), msgb_length(msg), 0); break; case AF_INET: case AF_INET6: @@ -1328,13 +1328,13 @@ memset(&sinfo, 0, sizeof(sinfo)); sinfo.sinfo_ppid = htonl(msgb_sctp_ppid(msg)); sinfo.sinfo_stream = msgb_sctp_stream(msg); - ret = sctp_send(conn->ofd.fd, msg->data, msgb_length(msg), + ret = sctp_send(conn->ofd.fd, msgb_data(msg), msgb_length(msg), &sinfo, MSG_NOSIGNAL); break; #endif case IPPROTO_TCP: default: - ret = send(conn->ofd.fd, msg->data, msg->len, 0); + ret = send(conn->ofd.fd, msgb_data(msg), msgb_length(msg), 0); break; } break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30719 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5b5d6f7a5a1722bd01c13d32557c21d8a0889966 Gerrit-Change-Number: 30719 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmo-netif[master]: stream: Log error on short send

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30720 ) Change subject: stream: Log error on short send ...................................................................... stream: Log error on short send This is clearly a problem on TCP streams which needs to be addressed in the future. Change-Id: I9bd257b80a378b779df84e204673f8e394eca5b6 --- M src/stream.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/20/30720/1 diff --git a/src/stream.c b/src/stream.c index e9860c3..1ca4e9a 100644 --- a/src/stream.c +++ b/src/stream.c @@ -384,6 +384,8 @@ osmo_stream_cli_reconnect(cli); } LOGSCLI(cli, LOGL_ERROR, "error %d to send\n", ret); + } else if (ret < msgb_length(msg)) { + LOGP(DLINP, LOGL_ERROR, "short send: %d < exp %u\n", ret, msgb_length(msg)); } msgb_free(msg); return 0; @@ -1344,6 +1346,8 @@ } if (ret == -1) /* send(): On error -1 is returned, and errno is set appropriately */ LOGP(DLINP, LOGL_ERROR, "error to send: %s\n", strerror(errno)); + else if (ret < msgb_length(msg)) + LOGP(DLINP, LOGL_ERROR, "short send: %d < exp %u\n", ret, msgb_length(msg)); msgb_free(msg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30720 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I9bd257b80a378b779df84e204673f8e394eca5b6 Gerrit-Change-Number: 30720 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmo-netif[master]: stream: Avoid useless polling if tx_queue becomes empty

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30721 ) Change subject: stream: Avoid useless polling if tx_queue becomes empty ...................................................................... stream: Avoid useless polling if tx_queue becomes empty Before this patch, the WRITE poll flag was being left ON and waited to be polled again by the kernel in order to disable it. Let's spate that extra polling cycle which only creates more polling triggers, context switches, etc. Change-Id: I1dd2145249a7322ad95e49be588fd472f00734e1 --- M src/stream.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/21/30721/1 diff --git a/src/stream.c b/src/stream.c index 1ca4e9a..503fe3c 100644 --- a/src/stream.c +++ b/src/stream.c @@ -387,7 +387,12 @@ } else if (ret < msgb_length(msg)) { LOGP(DLINP, LOGL_ERROR, "short send: %d < exp %u\n", ret, msgb_length(msg)); } + msgb_free(msg); + + if (llist_empty(&cli->tx_queue)) + osmo_fd_write_disable(&cli->ofd); + return 0; } @@ -1351,8 +1356,11 @@ msgb_free(msg); - if (llist_empty(&conn->tx_queue) && (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY)) - osmo_stream_srv_destroy(conn); + if (llist_empty(&conn->tx_queue)) { + osmo_fd_write_disable(&conn->ofd); + if (conn->flags & OSMO_STREAM_SRV_F_FLUSH_DESTROY) + osmo_stream_srv_destroy(conn); + } } static int osmo_stream_srv_cb(struct osmo_fd *ofd, unsigned int what) -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I1dd2145249a7322ad95e49be588fd472f00734e1 Gerrit-Change-Number: 30721 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: GPRS Trau frame encoder/decoder for Ericsson RBS

by Jenkins Builder

Attention is currently required from: dexter. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30717 ) Change subject: GPRS Trau frame encoder/decoder for Ericsson RBS ...................................................................... Patch Set 2: (9 comments) File src/trau/trau_pcu_ericsson.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/6146a453_fbf12b19 PS2, Line 502: osmo_pbit2ubit_ext(trau_bits, 22, (pbit_t *)& ind->tav, 0, 2, 1); space prohibited after that '&' (ctx:VxW) File tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/fc86e842_910738cd PS2, Line 373: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/20adc73c_867f864a PS2, Line 387: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/d39c87fa_288ba7a3 PS2, Line 401: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/ec404d70_a0a831aa PS2, Line 1248: /* [...] shortened since decode wont access filler bits after 'wont' may be misspelled - perhaps 'won't'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/566d580b_35ea8a80 PS2, Line 1307: /* [...] shortened since decode wont access filler bits after 'wont' may be misspelled - perhaps 'won't'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/7434d7b0_05500126 PS2, Line 1319: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/02d33041_ce457d52 PS2, Line 1333: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2121): https://gerrit.osmocom.org/c/libosmo-abis/+/30717/comment/bc51b8a3_a9b61b80 PS2, Line 1347: printf(" ccu_data_ind.gprs.est_acc_del_dev=%i\n", frame.u.ccu_data_ind.est_acc_del_dev); Use %d instead of %i -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7 Gerrit-Change-Number: 30717 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 20 Dec 2022 14:20:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-abis[master]: GPRS Trau frame encoder/decoder for Ericsson RBS

by dexter

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717 to look at the new patch set (#2). Change subject: GPRS Trau frame encoder/decoder for Ericsson RBS ...................................................................... GPRS Trau frame encoder/decoder for Ericsson RBS The Ericsson RBS BTS family is using a propritary TRAU frame dialect to communicate with the GPRS/EGPRS part of their CCU. There are essentially two implementations available: - GPRS over 16kbps I.460 subslots (very limited, supports only CS1 and CS4) - GPRS/EGPRS over full 64kbps timeslots (supports CS1-4 and MCS1-9) Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7 Related: OS#5198 --- M include/Makefile.am A include/osmocom/trau/trau_pcu_ericsson.h M src/Makefile.am A src/trau/trau_pcu_ericsson.c M tests/Makefile.am M tests/testsuite.at A tests/trau_pcu_ericsson/trau_pcu_ericsson_test.c A tests/trau_pcu_ericsson/trau_pcu_ericsson_test.ok 8 files changed, 6,266 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/17/30717/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30717 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib2b232a76588c32cde75b987a7e5fdfddf099cd7 Gerrit-Change-Number: 30717 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022