Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30797 )
Change subject: rlcmac: add decoder and test vectors for IA Rest Octets
......................................................................
Patch Set 1: Verified+1
(1 comment)
Patchset:
PS1:
The linter suggests that the array with test vectors "should probably be const char * const". I don't think this is really that important for a unit test, so overwriting its vote.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30797
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I39a29dc9b5b22ce4374ae33336696014e326d012
Gerrit-Change-Number: 30797
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Dec 2022 01:12:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin.
fixeria has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30797 )
Change subject: rlcmac: add decoder and test vectors for IA Rest Octets
......................................................................
Removed Verified-1 by Jenkins Builder (1000002)
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30797
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I39a29dc9b5b22ce4374ae33336696014e326d012
Gerrit-Change-Number: 30797
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: deleteVote
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30797 )
Change subject: rlcmac: add decoder and test vectors for IA Rest Octets
......................................................................
Patch Set 1:
(1 comment)
File tests/rlcmac/ts_44_018_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-2298):
https://gerrit.osmocom.org/c/libosmo-gprs/+/30797/comment/a2843a18_3e3cd63a
PS1, Line 63: static const char *testData[] = {
static const char * array should probably be static const char * const
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30797
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I39a29dc9b5b22ce4374ae33336696014e326d012
Gerrit-Change-Number: 30797
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 29 Dec 2022 00:50:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment