December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: VTY 'show gtp': more accurately identify local/remote IP

by laforge

Attention is currently required from: neels, arehbein, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30459 ) Change subject: VTY 'show gtp': more accurately identify local/remote IP ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic539ebe84a0853f665e5b8b8489dd587e6907287 Gerrit-Change-Number: 30459 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Dec 2022 12:06:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-upf[master]: gtpu_echo: do not osmo_fd_register twice

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30524 ) Change subject: gtpu_echo: do not osmo_fd_register twice ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30524 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ib498cc8d5252c05e12196f84bd1ea18d67e3052c Gerrit-Change-Number: 30524 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Dec 2022 12:05:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/repo-install-test: adjust for qemu

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30511 ) Change subject: jobs/repo-install-test: adjust for qemu ...................................................................... jobs/repo-install-test: adjust for qemu Related: OS#5365 Change-Id: Ie7675811d1a5d6b7cf7e4378c86d747ef6f7a249 --- M jobs/repo-install-test.yml 1 file changed, 2 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/jobs/repo-install-test.yml b/jobs/repo-install-test.yml index 5343f33..8b25ee0 100644 --- a/jobs/repo-install-test.yml +++ b/jobs/repo-install-test.yml @@ -25,31 +25,25 @@ <li> <a href="https://osmocom.org/issues/3176">OS#3176</a>: install all Osmocom debian packages <li> <a href="https://osmocom.org/issues/3369">OS#3369</a>: check if systemd services start properly <li> <a href="https://osmocom.org/issues/4563">OS#4563</a>: extend for centos + <li> <a href="https://osmocom.org/issues/5365">OS#5365</a>: run in qemu </ul> - node: osmocom-master-debian9 parameters: - string: name: BRANCH_CI description: | osmo-ci.git branch default: 'master' - - string: - name: BRANCH_DP - description: | - docker-playground.git branch - default: 'master' axes: - axis: type: slave name: label - values: !!python/tuple [repo-install-test] + values: !!python/tuple [qemu] - axis: type: user-defined name: feed values: '{obj:feeds}' builders: - shell: | - export OSMO_BRANCH_DOCKER_PLAYGROUND="$BRANCH_DP" export FEED="$feed" scripts/repo-install-test.sh "{distro}" scm: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ie7675811d1a5d6b7cf7e4378c86d747ef6f7a249 Gerrit-Change-Number: 30511 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: print osmocom_packages_all.txt

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30512 ) Change subject: repo-install-test: print osmocom_packages_all.txt ...................................................................... repo-install-test: print osmocom_packages_all.txt While I'm developing this, Jenkins is currently failing here. Make it easier to debug this by printing the file contents. Related: OS#5365 Change-Id: Ifbf4ca7f49c1f4441f84695aea0936515e01ffd4 --- M scripts/repo-install-test/run-inside.sh 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index 7ba69ac..614fb8b 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -321,6 +321,8 @@ "?origin(.*$PROJ.*) ?architecture(native)" | sort \ > osmocom_packages_all.txt + cat osmocom_packages_all.txt + filter_packages_txt apt install -y $(cat osmocom_packages.txt) } @@ -336,6 +338,8 @@ --qf="%{name}" \ > osmocom_packages_all.txt + cat osmocom_packages_all.txt + filter_packages_txt dnf install -y $(cat osmocom_packages.txt) } -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ifbf4ca7f49c1f4441f84695aea0936515e01ffd4 Gerrit-Change-Number: 30512 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: sort centos pkgs from repoquery

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30513 ) Change subject: repo-install-test: sort centos pkgs from repoquery ...................................................................... repo-install-test: sort centos pkgs from repoquery Apparently the output of repoquery isn't always sorted, it started failing on jenkins after moving the test inside qemu. Add an explicit sort. Fix for: + comm -23 osmocom_packages_all.txt blacklist.txt comm: file 1 is not in sorted order Related: OS#5365 Change-Id: Icb00df102555e06b66b1c2597488b625e3c77f1c --- M scripts/repo-install-test/run-inside.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index 614fb8b..251fa3d 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -336,6 +336,7 @@ --repoid="$(proj_with_underscore "$PROJ")" \ --archlist="x86_64,noarch" \ --qf="%{name}" \ + | sort \ > osmocom_packages_all.txt cat osmocom_packages_all.txt -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icb00df102555e06b66b1c2597488b625e3c77f1c Gerrit-Change-Number: 30513 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-remsim[master]: packaging: osmo-remsim-apitool needs py3-requests

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30519 ) Change subject: packaging: osmo-remsim-apitool needs py3-requests ...................................................................... packaging: osmo-remsim-apitool needs py3-requests Related: OS#5817 Change-Id: I3b8f86b03aee145e0b0faf0394ab641666710bea --- M contrib/osmo-remsim.spec.in M debian/control 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/osmo-remsim.spec.in b/contrib/osmo-remsim.spec.in index 0245577..7c67b12 100644 --- a/contrib/osmo-remsim.spec.in +++ b/contrib/osmo-remsim.spec.in @@ -100,6 +100,7 @@ License: GPL-2.0-or-later Group: Productivity/Telephony/Servers Requires: python3 +Requires: python3-requests %description -n osmo-remsim-apitool This is a small python tool for generating API requests to remsim-server, diff --git a/debian/control b/debian/control index a9e2e56..6f424b9 100644 --- a/debian/control +++ b/debian/control @@ -54,7 +54,7 @@ Package: osmo-remsim-apitool Architecture: any Multi-Arch: same -Depends: ${misc:Depends}, python3 +Depends: ${misc:Depends}, python3, python3-requests Description: Osmocom Remote SIM - API tool for server This is a small python tool for generating API requests to remsim-server, which can be used by the system administrator to introspect and/or modify -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3b8f86b03aee145e0b0faf0394ab641666710bea Gerrit-Change-Number: 30519 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: update test_binaries

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30510 ) Change subject: repo-install-test: update test_binaries ...................................................................... repo-install-test: update test_binaries Related: OS#5365 Change-Id: Iaad0260b5872d29b41a97aac3ea5ba0af81c6adb --- M scripts/repo-install-test/run-inside.sh 1 file changed, 28 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index 6f767bc..7ba69ac 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -378,19 +378,29 @@ osmo-bsc \ osmo-bts-trx \ osmo-bts-virtual \ + osmo-cbc \ osmo-gbproxy \ - osmo-gtphub \ osmo-ggsn \ + osmo-gtphub \ osmo-hlr \ osmo-hlr-db-tool \ osmo-hnbgw \ osmo-hnodeb \ osmo-mgw \ osmo-msc \ + osmo-mslookup-client \ + osmo-pcap-client \ + osmo-pcap-server \ osmo-pcu \ + osmo-remsim-bankd \ + osmo-remsim-client-shell \ + osmo-remsim-client-st2 \ + osmo-remsim-server \ osmo-sgsn \ osmo-sip-connector \ + osmo-smlc \ osmo-stp \ + osmo-trx-ipc \ osmo-trx-uhd case "$DISTRO" in @@ -398,7 +408,24 @@ test_binaries_version \ osmo-trx-usrp1 ;; + centos8*) + # OS#5817: not packaged for debian + test_binaries_version \ + osmo-pfcp-tool + ;; esac + + if [ "$DISTRO" != "debian10" ]; then + test_binaries_version \ + osmo-upf + fi + + if [ "$FEED" = "nightly" ]; then + test_binaries_version \ + osmo-bsc-nat \ + osmo-e1d \ + osmo-uecups-daemon + fi } services_check() { -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaad0260b5872d29b41a97aac3ea5ba0af81c6adb Gerrit-Change-Number: 30510 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: update services list

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30508 ) Change subject: repo-install-test: update services list ...................................................................... repo-install-test: update services list Add services from new projects and enable previously disabled services, now that this test runs in qemu and services have more permissions like setting realtime priorities. Related: OS#5365 Change-Id: Iec7db433cac4c77226e0f1ae2ba502de0d1a8a2b --- M scripts/repo-install-test/run-inside.sh 1 file changed, 24 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index da49f7d..d3610cb 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -11,28 +11,36 @@ # Systemd services that must start up successfully after installing all packages (OS#3369) # Disabled services: # * osmo-ctrl2cgi (missing config: /etc/osmocom/ctrl2cgi.ini, OS#4108) +# * osmo-e1d (missing config, OS#5817) +# * osmo-ggsn (conflicting config, OS#5817) +# * osmo-remsim-client (exits immediately without USB device) # * osmo-trap2cgi (missing config: /etc/osmocom/%N.ini, OS#4108) -# * osmo-ggsn (no tun device in docker) +# * osmo-trx-* (exits immediately without trx device) +# * osmo-upf (not available for debian 10, gets added in services_check()) SERVICES=" osmo-bsc osmo-bts-virtual + osmo-cbc osmo-gbproxy osmo-gtphub osmo-hlr osmo-hnbgw + osmo-hnodeb osmo-mgw osmo-msc osmo-pcap-client + osmo-pcap-server osmo-pcu + osmo-remsim-bankd + osmo-remsim-server osmo-sgsn osmo-sip-connector + osmo-smlc osmo-stp " # Services working in nightly, but not yet in latest -# * osmo-pcap-server 0.2.0: VTY port in default config conflicts with osmo-bts (OS#5203) SERVICES_NIGHTLY=" - osmo-pcap-server - osmo-hnodeb + osmo-bsc-nat " distro_obsdir() { @@ -400,6 +408,18 @@ services_feed="$services_feed $SERVICES_NIGHTLY" fi + # We don't build osmo-upf for debian 10 + if [ "$DISTRO" != "debian10" ]; then + # osmo-upf <= 0.1.1 needs GTP kernel module + if [ "$FEED" = "nightly" ]; then + services_feed="$services_feed osmo-upf" + fi + fi + + # OS#5817: osmo-ggsn conflicts with osmo-gtphub; explicitly stop it + # here until it is fixed, as it gets auto-started after installation + systemctl stop osmo-ggsn + systemctl start $services_feed sleep 2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30508 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iec7db433cac4c77226e0f1ae2ba502de0d1a8a2b Gerrit-Change-Number: 30508 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: repo-install-test: fix osmo-trx-usrp1 check

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30509 ) Change subject: repo-install-test: fix osmo-trx-usrp1 check ...................................................................... repo-install-test: fix osmo-trx-usrp1 check The DISTRO variable is either debian10 or debian11, fix the broken check. This condition is there in the first place, because we don't build the usrp1 backend for centos8. Change-Id: I987f27db257961faf06824df2dcc8f9db1fedccf Related: OS#5365 --- M scripts/repo-install-test/run-inside.sh 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, approved diff --git a/scripts/repo-install-test/run-inside.sh b/scripts/repo-install-test/run-inside.sh index d3610cb..6f767bc 100755 --- a/scripts/repo-install-test/run-inside.sh +++ b/scripts/repo-install-test/run-inside.sh @@ -393,10 +393,12 @@ osmo-stp \ osmo-trx-uhd - if [ "$DISTRO" = "debian" ]; then + case "$DISTRO" in + debian*) test_binaries_version \ osmo-trx-usrp1 - fi + ;; + esac } services_check() { -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30509 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I987f27db257961faf06824df2dcc8f9db1fedccf Gerrit-Change-Number: 30509 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-remsim[master]: packaging: osmo-remsim-apitool needs py3-requests

by laforge

Attention is currently required from: osmith, fixeria, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30519 ) Change subject: packaging: osmo-remsim-apitool needs py3-requests ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I3b8f86b03aee145e0b0faf0394ab641666710bea Gerrit-Change-Number: 30519 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Dec 2022 12:04:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022