Attention is currently required from: fixeria.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30327 )
Change subject: mobile: allow enabling/disabling handling of voice in the L1PHY
......................................................................
Patch Set 1:
(1 comment)
File src/host/layer23/src/mobile/vty_interface.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30327/comment/d504df30_e7d7d3f7
PS1, Line 2837: "L1 PHY (e.g. Calypso DSP in Mot C1xx phones)\n"
It's better to spell the complete name Motorola to avoid confusing users.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30327
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I131f213ef7c2736f7310f0183b83f3bc3064cd98
Gerrit-Change-Number: 30327
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 27 Nov 2022 13:38:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30326 )
Change subject: mobile: add MNCC handler selection to settings
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Typo in commit message: extarnal
File src/host/layer23/src/mobile/vty_interface.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/30326/comment/39e1e28b_4a76540d
PS1, Line 1665: DEFUN(cfg_ms_no_mncc_handler, cfg_ms_no_mncc_handler_cmd,
What's the point of introducing redundant vty command if dummy handler can be selected with mncc-handler command above?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30326
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I2df91c7a79ba5c39bc6ceae900ef649129dd0346
Gerrit-Change-Number: 30326
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 27 Nov 2022 13:35:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge, msuraev.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30316 )
Change subject: trxcon: trxcon_fsm: shorten DCCH related event names
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> are those states really only for a "DCCH", a "Dedicated Control CHannel"? If they also include other […]
You're right, it should actually be 'DCH' (like in 3GPP TS 44.004, section 5.1).
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30316
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie388e251677da63306e9e53d98cbcc7c34777980
Gerrit-Change-Number: 30316
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 27 Nov 2022 12:19:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: fixeria, msuraev.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30316 )
Change subject: trxcon: trxcon_fsm: shorten DCCH related event names
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
are those states really only for a "DCCH", a "Dedicated Control CHannel"? If they also include other dedicated channels (like TCH for example, the new name is worse than the old, as its name implies to exclude TCH as it is not a control channel...
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30316
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ie388e251677da63306e9e53d98cbcc7c34777980
Gerrit-Change-Number: 30316
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 27 Nov 2022 11:15:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment