osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30350 )
Change subject: jobs/master-builds: pass ssh agent sock to docker
......................................................................
jobs/master-builds: pass ssh agent sock to docker
Pass the ssh agent to docker for master builds, so we can publish
manuals and other files generated during the builds. This used to work
with the .ssh directory where each lxc had its own key. But we are
changing that to have the keys in jenkins and use the ssh agent, so it
works without additional configuration when adding new nodes/lxcs (such
as the two deb11 lxcs we just added).
Change-Id: I6dc1fd5d7e81ec135f805562608f06cf03a1baeb
---
M jobs/master-builds.yml
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, but someone else must approve
neels: Looks good to me, approved
diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml
index 3ef3f03..cc5f925 100644
--- a/jobs/master-builds.yml
+++ b/jobs/master-builds.yml
@@ -36,15 +36,16 @@
-e OSMO_GSM_MANUALS_DIR="/opt/osmo-gsm-manuals" \
-e PARALLEL_MAKE="$PARALLEL_MAKE" \
-e PUBLISH="1" \
+ -e SSH_AUTH_SOCK=/ssh-agent \
-e WITH_MANUALS="1" \
-w /build -i -u build \
+ -v $(readlink -f $SSH_AUTH_SOCK):/ssh-agent \
-v "$PWD:/build" \
-v "$ARTIFACT_STORE:/artifact_store" \
-v "$HOME/.ssh:/home/build/.ssh:ro" \
docker_img: '$USER/debian-buster-jenkins'
timeout_cmd: '/usr/bin/timeout 30m'
cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh'
- wrappers: []
trigger:
email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org
git_base_url: https://gerrit.osmocom.org
@@ -531,6 +532,9 @@
- email:
recipients: '{obj:email}'
send-to-individuals: true
- wrappers: '{obj:wrappers}'
+ wrappers:
+ - ssh-agent-credentials:
+ users:
+ - 97634b9d-a867-4f6d-825d-1da99813e93d
# vim: expandtab tabstop=2 shiftwidth=2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30350
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I6dc1fd5d7e81ec135f805562608f06cf03a1baeb
Gerrit-Change-Number: 30350
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30345 )
Change subject: paging: Introduce VTY configurable X3113 (Maximum Paging Request Transmit Delay Threshold)
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/30345/comment/63285b51_2b45bfb6
PS1, Line 11: timeouts, etc.
> i'm having a hard time understanding this, clarify a bit? […]
T3113 defines the amount of time that a response for a paging request is expected to take at maximum. Hence after T3113 timeouts the request can be freed/retransmitted because we now for sure that there's no answer for it.
File src/osmo-bsc/net_init.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30345/comment/de69a62b_678d0cc7
PS1, Line 78: PAGING_THRESHOLD_X3113_DEFAULT_SEC
> AFAICT this is the only place where this #define is used. […]
I prefer keeping it in a define in paging.h, where I can describe better the meaning of it, where all related paging information is located.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30345
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ia556ef4e474e6a2d0d1618bab680a3330a3c062b
Gerrit-Change-Number: 30345
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Nov 2022 15:17:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment
neels has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30353 )
Change subject: osmo_tdef_get(): clarify API doc on val_if_not_present
......................................................................
Removed Verified-1 by Jenkins Builder (1000002)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30353
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2301aad86d6d165a3b51c6849bcd8fe02972e0a3
Gerrit-Change-Number: 30353
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: deleteVote
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30353 )
Change subject: osmo_tdef_get(): clarify API doc on val_if_not_present
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
this patch cannot possibly cause the sockets test to fail, will just merge this manually when votes are in
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30353
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2301aad86d6d165a3b51c6849bcd8fe02972e0a3
Gerrit-Change-Number: 30353
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 28 Nov 2022 15:01:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment