November 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by Jenkins Builder

Attention is currently required from: laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29975 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Patch Set 2: (3 comments) File include/osmocom/vty/command.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-686): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/b72cc5e2_4d65ddf9 PS2, Line 445: vector cmd_describe_command(vector vline, struct vty * vty, int *status); "foo * bar" should be "foo *bar" File src/select.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-686): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/48c489c7_8692e5a8 PS2, Line 669: bool osmo_select_shutdown_done(void) { open brace '{' following function definitions go on the next line File src/vty/cpu_sched_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-686): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/62f56d39_6a50fb60 PS2, Line 92: static int get_num_cpus(void) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 Gerrit-Change-Number: 29975 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 03 Nov 2022 10:23:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: jobs: osmo-e1-hardware: split into job types

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29978 ) Change subject: jobs: osmo-e1-hardware: split into job types ...................................................................... jobs: osmo-e1-hardware: split into job types Split the job, so building the software can be done with the regular docker image instead of the fpga-build one (that doesn't have the needed dependencies). Related: osmo-e1-hardware I26e839de419c6eb86bf2a6250a1adf06b761d1fa Change-Id: I90fbe72c722e491f41b9607d1a6389964d7e43b4 --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 28 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/78/29978/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 9db1ebc..cc42a8e 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -165,8 +165,20 @@ cmd: '{docker_run} {docker_img_erlang} {timeout_cmd} /build/contrib/jenkins.sh' - osmo-e1-hardware: - docker_img: 'registry.osmocom.org/$USER/fpga-build' - cmd: 'docker pull {docker_img} && {docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh' + a2_name: JOB_TYPE + a2: !!python/tuple ["firmware", "gateware", "manuals", "software"] + cmd: | + DOCKER_IMG="{docker_img}" + case "$JOB_TYPE" in + firmware|gateware|manuals) + DOCKER_IMG="registry.osmocom.org/$USER/fpga-build" + docker pull "$DOCKER_IMG" + ;; + esac + {docker_run} \ + -e JOB_TYPE="$JOB_TYPE" \ + "$DOCKER_IMG" \ + {timeout_cmd} /build/contrib/jenkins.sh pipeline_binpkgs: false - osmo-ci: diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 86519f7..eb186bf 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -236,8 +236,20 @@ {docker_img} {timeout_cmd} /build/contrib/jenkins_bts_model.sh "$BTS_MODEL" - osmo-e1-hardware: - docker_img: 'registry.osmocom.org/$USER/fpga-build' - cmd: 'docker pull {docker_img} && {docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' + a2_name: JOB_TYPE + a2: !!python/tuple ["firmware", "gateware", "manuals", "software"] + cmd: | + DOCKER_IMG="{docker_img}" + case "$JOB_TYPE" in + firmware|gateware|manuals) + DOCKER_IMG="registry.osmocom.org/$USER/fpga-build" + docker pull "$DOCKER_IMG" + ;; + esac + {docker_run} \ + -e JOB_TYPE="$JOB_TYPE" \ + "$DOCKER_IMG" \ + {timeout_cmd} /build/contrib/jenkins.sh --publish - ice40-usbtrace: git_base_url: https://gitea.osmocom.org/electronics docker_img: 'registry.osmocom.org/$USER/fpga-build' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29978 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I90fbe72c722e491f41b9607d1a6389964d7e43b4 Gerrit-Change-Number: 29978 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: add timeout_cmd

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/29977 ) Change subject: jobs/master-builds: add timeout_cmd ...................................................................... jobs/master-builds: add timeout_cmd Add the default timeout of 30 minutes to each job, just like in gerrit-verifications.yml. Change-Id: I2ed80258d5f2fbcd8cf27db74db125d9a52b9988 --- M jobs/master-builds.yml 1 file changed, 21 insertions(+), 20 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/77/29977/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 3371356..86519f7 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -42,7 +42,8 @@ -v "$ARTIFACT_STORE:/artifact_store" \ -v "$HOME/.ssh:/home/build/.ssh:ro" \ docker_img: '$USER/debian-buster-jenkins' - cmd: '{docker_run} {docker_img} /build/contrib/jenkins.sh' + timeout_cmd: '/usr/bin/timeout 30m' + cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh' wrappers: [] trigger: email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org @@ -76,7 +77,7 @@ git_base_url: https://gitea.osmocom.org/sdr cmd: | {docker_run} \ - {docker_img} sh -ex -c \ + {docker_img} {timeout_cmd} sh -ex -c \ 'autoreconf -fi; \ ./configure; \ $MAKE $PARALLEL_MAKE; \ @@ -136,7 +137,7 @@ a1_name: arch a1: !!python/tuple [arm-none-eabi, amd64] combination_filter: '!(arch=="arm-none-eabi" && label=="FreeBSD_amd64")' - cmd: '{docker_run} {docker_img} /build/contrib/jenkins_arch.sh "$arch"' + cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins_arch.sh "$arch"' # Full triggers would be: # trigger: > # master-libosmo-abis, master-libosmo-netif, master-libosmo-sccp, master-openbsc, @@ -203,7 +204,7 @@ -e IU="$IU" \ -e SMPP="$SMPP" \ -e MGCP="$MGCP" \ - {docker_img} /build/contrib/jenkins.sh + {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - osmo-bsc - osmo-bsc-nat @@ -232,19 +233,19 @@ {docker_run} \ -e FIRMWARE_VERSION="$FIRMWARE_VERSION" \ -e WITH_MANUALS="$WITH_MANUALS" \ - {docker_img} /build/contrib/jenkins_bts_model.sh "$BTS_MODEL" + {docker_img} {timeout_cmd} /build/contrib/jenkins_bts_model.sh "$BTS_MODEL" - osmo-e1-hardware: docker_img: 'registry.osmocom.org/$USER/fpga-build' - cmd: 'docker pull {docker_img} && {docker_run} {docker_img} /build/contrib/jenkins.sh --publish' + cmd: 'docker pull {docker_img} && {docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' - ice40-usbtrace: git_base_url: https://gitea.osmocom.org/electronics docker_img: 'registry.osmocom.org/$USER/fpga-build' - cmd: 'docker pull {docker_img} && {docker_run} {docker_img} /build/contrib/jenkins.sh --publish' + cmd: 'docker pull {docker_img} && {docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' - no2bootloader: git_base_url: https://github.com/no2fpga docker_img: 'registry.osmocom.org/$USER/fpga-build' - cmd: 'docker pull {docker_img} && {docker_run} {docker_img} /build/contrib/jenkins.sh --publish' + cmd: 'docker pull {docker_img} && {docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de 246tnt(a)gmail.com - osmo-fl2k: @@ -261,7 +262,7 @@ {docker_run} \ -e GTP="$GTP" \ -e WITH_MANUALS="$WITH_MANUALS" \ - {docker_img} /build/contrib/jenkins.sh + {docker_img} {timeout_cmd} /build/contrib/jenkins.sh trigger: master-osmo-sgsn - osmo-upf @@ -274,7 +275,7 @@ node: 'osmocom-master-debian9' - osmo-gsm-tester: - cmd: '{docker_run} {docker_img} /build/contrib/jenkins-build-manuals.sh' + cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins-build-manuals.sh' - osmo-hlr @@ -304,7 +305,7 @@ {docker_run} \ -e IU="$IU" \ -e WITH_MANUALS="$WITH_MANUALS" \ - {docker_img} /build/contrib/jenkins.sh + {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - osmo-pcap @@ -331,7 +332,7 @@ -e with_vty="$with_vty" \ -e with_dsp="$with_dsp" \ -e WITH_MANUALS="$WITH_MANUALS" \ - {docker_img} /build/contrib/jenkins.sh + {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - osmo-sgsn: a1_name: IU @@ -345,7 +346,7 @@ {docker_run} \ -e IU="$IU" \ -e WITH_MANUALS="$WITH_MANUALS" \ - {docker_img} /build/contrib/jenkins.sh + {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - osmo-sip-connector: email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org holger(a)freyther.de @@ -368,24 +369,24 @@ {docker_run} \ -e INSTR="$INSTR" \ -e WITH_MANUALS="$WITH_MANUALS" \ - {docker_img} /build/contrib/jenkins.sh + {docker_img} {timeout_cmd} /build/contrib/jenkins.sh - osmocom-bb - osmo-sysmon - osmo-remsim - osmo-asf4-dfu: - cmd: '{docker_run} {docker_img} /build/contrib/jenkins.sh --publish' + cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org ewild(a)sysmocom.de - osmo-ccid-firmware: - cmd: '{docker_run} {docker_img} /build/contrib/jenkins.sh --publish' + cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org ewild(a)sysmocom.de - simtrace2: - cmd: '{docker_run} {docker_img} /build/contrib/jenkins.sh --publish' + cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de - osmo-opencm3-projects: git_base_url: https://gitea.osmocom.org/electronics docker_img: '$USER/debian-bullseye-jenkins' - cmd: '{docker_run} {docker_img} /build/contrib/jenkins.sh --publish' + cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins.sh --publish' email: jenkins-notifications(a)lists.osmocom.org laforge(a)gnumonks.org kredon(a)sysmocom.de - osmo-e1d @@ -406,11 +407,11 @@ - pysim: concurrent: false slave_axis: !!python/tuple [simtester] - cmd: 'PUBLISH=1 WITH_MANUALS=1 /usr/bin/timeout 30m ./contrib/jenkins.sh' + cmd: 'PUBLISH=1 WITH_MANUALS=1 {timeout_cmd} ./contrib/jenkins.sh' - sysmo-usim-tool: concurrent: false - cmd: cd ./tests; ./run-tests + cmd: cd ./tests; {timeout_cmd} ./run-tests slave_axis: !!python/tuple [simtester] git_base_url: https://gitea.sysmocom.de/sysmocom -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29977 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2ed80258d5f2fbcd8cf27db74db125d9a52b9988 Gerrit-Change-Number: 29977 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/29975 to look at the new patch set (#2). Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore cold that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 --- M include/osmocom/core/counter.h M include/osmocom/core/select.h M include/osmocom/gprs/gprs_bssgp.h M include/osmocom/gsm/gsm0808.h M include/osmocom/vty/command.h M include/osmocom/vty/logging.h M src/counter.c M src/gb/gprs_bssgp.c M src/gsm/gsm0808.c M src/select.c M src/time_cc.c M src/vty/cpu_sched_vty.c M src/vty/logging_vty.c M src/vty/stats_vty.c M utils/osmo-aka-verify.c M utils/osmo-auc-gen.c 16 files changed, 25 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/29975/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 Gerrit-Change-Number: 29975 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-e1-hardware[master]: contrib/jenkins.sh: Build e1-tracer host software

by osmith

Attention is currently required from: osmith. osmith has uploaded a new patch set (#5) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29921 ) Change subject: contrib/jenkins.sh: Build e1-tracer host software ...................................................................... contrib/jenkins.sh: Build e1-tracer host software Run the different job types based on a new environment variable, as the software has to be built with a different docker image. The related osmo-ci patch adjusts the jenkins jobs accordingly. Co-developed-by: Oliver Smith <osmith(a)sysmocom.de> Related: osmo-ci I90fbe72c722e491f41b9607d1a6389964d7e43b4 Change-Id: I26e839de419c6eb86bf2a6250a1adf06b761d1fa --- M contrib/jenkins.sh 1 file changed, 67 insertions(+), 53 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/21/29921/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29921 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I26e839de419c6eb86bf2a6250a1adf06b761d1fa Gerrit-Change-Number: 29921 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-abis[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-abis/+/29976 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore cold that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I5ca56d885b5ce4d4c9f91ffc083c05a48d1306e4 --- M src/trau/osmo_ortp.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/76/29976/1 diff --git a/src/trau/osmo_ortp.c b/src/trau/osmo_ortp.c index 5761d78..b681888 100644 --- a/src/trau/osmo_ortp.c +++ b/src/trau/osmo_ortp.c @@ -262,7 +262,7 @@ return 0; } -static void create_payload_types() +static void create_payload_types(void) { PayloadType *pt; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/29976 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5ca56d885b5ce4d4c9f91ffc083c05a48d1306e4 Gerrit-Change-Number: 29976 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29975 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Patch Set 1: (3 comments) File include/osmocom/vty/command.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-683): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/67fb4827_559acc14 PS1, Line 445: vector cmd_describe_command(vector vline, struct vty * vty, int *status); "foo * bar" should be "foo *bar" File src/select.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-683): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/dd53efbb_42466ed6 PS1, Line 669: bool osmo_select_shutdown_done(void) { open brace '{' following function definitions go on the next line File src/vty/cpu_sched_vty.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-683): https://gerrit.osmocom.org/c/libosmocore/+/29975/comment/4822a614_18d4da93 PS1, Line 92: static int get_num_cpus(void) { open brace '{' following function definitions go on the next line -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 Gerrit-Change-Number: 29975 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 03 Nov 2022 10:15:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Support building with -Werror=strict-prototypes / -Werror=old-style-d...

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/29975 ) Change subject: Support building with -Werror=strict-prototypes / -Werror=old-style-definition ...................................................................... Support building with -Werror=strict-prototypes / -Werror=old-style-definition Unfortunately "-std=c99" is not sufficient to make gcc ignore cold that uses constructs of earlier C standards, which were abandoned in C99. See https://lwn.net/ml/fedora-devel/Y1kvF35WozzGBpc8@redhat.com/ for some related discussion. Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 --- M include/osmocom/core/counter.h M include/osmocom/core/select.h M include/osmocom/gprs/gprs_bssgp.h M include/osmocom/gsm/gsm0808.h M include/osmocom/vty/command.h M include/osmocom/vty/logging.h M src/counter.c M src/gb/gprs_bssgp.c M src/gsm/gsm0808.c M src/select.c M src/vty/cpu_sched_vty.c M src/vty/logging_vty.c M src/vty/stats_vty.c M utils/osmo-aka-verify.c M utils/osmo-auc-gen.c 15 files changed, 24 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/29975/1 diff --git a/include/osmocom/core/counter.h b/include/osmocom/core/counter.h index 0d56bc4..7b677cb 100644 --- a/include/osmocom/core/counter.h +++ b/include/osmocom/core/counter.h @@ -52,7 +52,7 @@ int osmo_counters_for_each(int (*handle_counter)(struct osmo_counter *, void *), void *data); -int osmo_counters_count(); +int osmo_counters_count(void); struct osmo_counter *osmo_counter_get_by_name(const char *name); diff --git a/include/osmocom/core/select.h b/include/osmocom/core/select.h index e9f19a5..fc14851 100644 --- a/include/osmocom/core/select.h +++ b/include/osmocom/core/select.h @@ -105,8 +105,8 @@ struct osmo_signalfd * osmo_signalfd_setup(void *ctx, sigset_t set, osmo_signalfd_cb *cb, void *data); -void osmo_select_shutdown_request(); -int osmo_select_shutdown_requested(); -bool osmo_select_shutdown_done(); +void osmo_select_shutdown_request(void); +int osmo_select_shutdown_requested(void); +bool osmo_select_shutdown_done(void); /*! @} */ diff --git a/include/osmocom/gprs/gprs_bssgp.h b/include/osmocom/gprs/gprs_bssgp.h index 09f640d..6c04332 100644 --- a/include/osmocom/gprs/gprs_bssgp.h +++ b/include/osmocom/gprs/gprs_bssgp.h @@ -235,7 +235,7 @@ int bssgp_fc_ms_init(struct bssgp_flow_control *fc_ms, uint16_t bvci, uint16_t nsei, uint32_t max_queue_depth); -void bssgp_flush_all_queues(); +void bssgp_flush_all_queues(void); void bssgp_fc_flush_queue(struct bssgp_flow_control *fc); /* gprs_bssgp_vty.c */ diff --git a/include/osmocom/gsm/gsm0808.h b/include/osmocom/gsm/gsm0808.h index b4c7803..dcff415 100644 --- a/include/osmocom/gsm/gsm0808.h +++ b/include/osmocom/gsm/gsm0808.h @@ -73,7 +73,7 @@ struct msgb *gsm0808_create_cipher_complete(struct msgb *layer3, uint8_t alg_id); struct msgb *gsm0808_create_cipher_reject(enum gsm0808_cause cause); struct msgb *gsm0808_create_cipher_reject_ext(enum gsm0808_cause_class class, uint8_t ext); -struct msgb *gsm0808_create_classmark_request(); +struct msgb *gsm0808_create_classmark_request(void); struct msgb *gsm0808_create_classmark_update(const uint8_t *cm2, uint8_t cm2_len, const uint8_t *cm3, uint8_t cm3_len); struct msgb *gsm0808_create_sapi_reject_cause(uint8_t link_id, uint16_t cause); @@ -269,8 +269,8 @@ }; struct msgb *gsm0808_create_handover_command(const struct gsm0808_handover_command *params); -struct msgb *gsm0808_create_handover_detect(); -struct msgb *gsm0808_create_handover_succeeded(); +struct msgb *gsm0808_create_handover_detect(void); +struct msgb *gsm0808_create_handover_succeeded(void); struct gsm0808_handover_complete { bool rr_cause_present; diff --git a/include/osmocom/vty/command.h b/include/osmocom/vty/command.h index e3919fb..57fbe0e 100644 --- a/include/osmocom/vty/command.h +++ b/include/osmocom/vty/command.h @@ -442,8 +442,8 @@ vector cmd_make_strvec(const char *); int cmd_make_strvec2(const char *string, char **indent, vector *strvec_p); void cmd_free_strvec(vector); -vector cmd_describe_command(); -char **cmd_complete_command(); +vector cmd_describe_command(vector vline, struct vty * vty, int *status); +char **cmd_complete_command(vector vline, struct vty *vty, int *status); const char *cmd_prompt(enum node_type); int config_from_file(struct vty *, FILE *); enum node_type node_parent(enum node_type); diff --git a/include/osmocom/vty/logging.h b/include/osmocom/vty/logging.h index 90c8fa1..0ea6432 100644 --- a/include/osmocom/vty/logging.h +++ b/include/osmocom/vty/logging.h @@ -6,7 +6,7 @@ #define FILTER_STR "Filter log messages\n" struct log_info; -void logging_vty_add_cmds(); +void logging_vty_add_cmds(void); void logging_vty_add_deprecated_subsys(void *ctx, const char *name); struct vty; struct log_target *osmo_log_vty2tgt(struct vty *vty); diff --git a/src/counter.c b/src/counter.c index cbee7b9..dace15f 100644 --- a/src/counter.c +++ b/src/counter.c @@ -75,7 +75,7 @@ /*! Counts the registered counter * \returns amount of counters */ -int osmo_counters_count() +int osmo_counters_count(void) { return llist_count(&counters); } diff --git a/src/gb/gprs_bssgp.c b/src/gb/gprs_bssgp.c index c967f73..7abef80 100644 --- a/src/gb/gprs_bssgp.c +++ b/src/gb/gprs_bssgp.c @@ -1428,7 +1428,7 @@ /*! * \brief Flush the queues of all BSSGP contexts. */ -void bssgp_flush_all_queues() +void bssgp_flush_all_queues(void) { struct bssgp_bvc_ctx *bctx; diff --git a/src/gsm/gsm0808.c b/src/gsm/gsm0808.c index e057832..89a8874 100644 --- a/src/gsm/gsm0808.c +++ b/src/gsm/gsm0808.c @@ -418,7 +418,7 @@ /*! Create BSSMAP Classmark Request message * \returns callee-allocated msgb with BSSMAP Classmark Request message */ -struct msgb *gsm0808_create_classmark_request() +struct msgb *gsm0808_create_classmark_request(void) { struct msgb *msg = msgb_alloc_headroom(BSSMAP_MSG_SIZE, BSSMAP_MSG_HEADROOM, "classmark-request"); @@ -1110,7 +1110,7 @@ /*! Create BSSMAP HANDOVER DETECT message, 3GPP TS 48.008 3.2.1.40. * Sent from the MT BSC back to the MSC when the MS has sent a handover RACH request and the MT BSC has * received the Handover Detect message. */ -struct msgb *gsm0808_create_handover_detect() +struct msgb *gsm0808_create_handover_detect(void) { struct msgb *msg; @@ -1129,7 +1129,7 @@ /*! Create BSSMAP HANDOVER SUCCEEDED message, 3GPP TS 48.008 3.2.1.13. * Sent from the MSC back to the old BSS to notify that the MS has successfully accessed the new BSS. */ -struct msgb *gsm0808_create_handover_succeeded() +struct msgb *gsm0808_create_handover_succeeded(void) { struct msgb *msg; diff --git a/src/select.c b/src/select.c index 735ea3e..5aee7d8 100644 --- a/src/select.c +++ b/src/select.c @@ -653,20 +653,20 @@ * } * } */ -void osmo_select_shutdown_request() +void osmo_select_shutdown_request(void) { _osmo_select_shutdown_requested++; }; /*! Return the number of times osmo_select_shutdown_request() was called before. */ -int osmo_select_shutdown_requested() +int osmo_select_shutdown_requested(void) { return _osmo_select_shutdown_requested; }; /*! Return true after osmo_select_shutdown_requested() was called, and after an osmo_select poll loop found no more * pending OSMO_FD_WRITE on any registered socket. */ -bool osmo_select_shutdown_done() { +bool osmo_select_shutdown_done(void) { return _osmo_select_shutdown_done; }; diff --git a/src/vty/cpu_sched_vty.c b/src/vty/cpu_sched_vty.c index dbb3cd5..301e7a6 100644 --- a/src/vty/cpu_sched_vty.c +++ b/src/vty/cpu_sched_vty.c @@ -89,7 +89,7 @@ }; /* returns number of configured CPUs in the system, or negative otherwise */ -static int get_num_cpus() { +static int get_num_cpus(void) { static unsigned int num_cpus = 0; long ln; diff --git a/src/vty/logging_vty.c b/src/vty/logging_vty.c index c83dafd..59c8a9c 100644 --- a/src/vty/logging_vty.c +++ b/src/vty/logging_vty.c @@ -1196,7 +1196,7 @@ /*! Register logging related commands to the VTY. Call this once from * your application if you want to support those commands. */ -void logging_vty_add_cmds() +void logging_vty_add_cmds(void) { install_lib_element_ve(&enable_logging_cmd); install_lib_element_ve(&disable_logging_cmd); diff --git a/src/vty/stats_vty.c b/src/vty/stats_vty.c index e5acfa2..299ec24 100644 --- a/src/vty/stats_vty.c +++ b/src/vty/stats_vty.c @@ -742,7 +742,7 @@ * Call this once during your application initialization if you would * like to have stats VTY commands enabled. */ -void osmo_stats_vty_add_cmds() +void osmo_stats_vty_add_cmds(void) { install_lib_element_ve(&show_stats_cmd); install_lib_element_ve(&show_stats_level_cmd); diff --git a/utils/osmo-aka-verify.c b/utils/osmo-aka-verify.c index bbc65ef..f23c349 100644 --- a/utils/osmo-aka-verify.c +++ b/utils/osmo-aka-verify.c @@ -88,7 +88,7 @@ } -static void help() +static void help(void) { printf( "Static SIM card parameters:\n" "-k --key\tSpecify Ki / K\n" diff --git a/utils/osmo-auc-gen.c b/utils/osmo-auc-gen.c index 72f1fcd..e3e1b43 100644 --- a/utils/osmo-auc-gen.c +++ b/utils/osmo-auc-gen.c @@ -85,7 +85,7 @@ .algo = OSMO_AUTH_ALG_NONE, }; -static void help() +static void help(void) { int alg; printf( "-2 --2g\tUse 2G (GSM) authentication\n" -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29975 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I84fd99442d0cc400fa562fa33623c142649230e2 Gerrit-Change-Number: 29975 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: tbf_fsm: Introduce new event to act upon contention resolution success

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29932 ) Change subject: tbf_fsm: Introduce new event to act upon contention resolution success ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I8b9555864d3615ce0a024b641c67921f82273a8d Gerrit-Change-Number: 29932 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Nov 2022 10:09:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Avoid losing DL-TBF during MS merge

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29931 ) Change subject: Avoid losing DL-TBF during MS merge ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29931 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I29f4ffa904d79d58275c6596cc5ef6790b6e68c6 Gerrit-Change-Number: 29931 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 03 Nov 2022 10:08:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022