November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: lint: enable FUNCTION_WITHOUT_ARGS

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30003 ) Change subject: lint: enable FUNCTION_WITHOUT_ARGS ...................................................................... lint: enable FUNCTION_WITHOUT_ARGS Complain if one writes func() instead of func(void). Change-Id: Ic00041025ac2584f250b5a096eae8fd0d857d9fb --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/03/30003/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 7a60ad6..bc45f85 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -61,7 +61,6 @@ # * EMBEDDED_FUNCTION_NAME: often __func__ isn't used, arguably not much benefit in changing this when touching code # * EXECUTE_PERMISSIONS: not followed, files need to be executable: git-version-gen, some in debian/ # * FILE_PATH_CHANGES: we don't use a MAINTAINERS file -# * FUNCTION_WITHOUT_ARGS: not followed: warns about func() instead of func(void) # * GLOBAL_INITIALISERS: we initialise globals to NULL for talloc ctx (e.g. *tall_lapd_ctx = NULL) # * IF_0: used intentionally # * INITIALISED_STATIC: we use this, see also http://lkml.iu.edu/hypermail/linux/kernel/0808.1/2235.html @@ -100,7 +99,6 @@ --ignore EMBEDDED_FUNCTION_NAME \ --ignore EXECUTE_PERMISSIONS \ --ignore FILE_PATH_CHANGES \ - --ignore FUNCTION_WITHOUT_ARGS \ --ignore GLOBAL_INITIALISERS \ --ignore IF_0 \ --ignore INITIALISED_STATIC \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30003 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic00041025ac2584f250b5a096eae8fd0d857d9fb Gerrit-Change-Number: 30003 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Improve MS logging

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29996 ) Change subject: Improve MS logging ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: If9b325764c8fd540d60b6419f32223fd7f5a5898 Gerrit-Change-Number: 29996 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Nov 2022 10:20:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: add more pysim related deps

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29913 ) Change subject: debian-buster-jenkins: add more pysim related deps ...................................................................... debian-buster-jenkins: add more pysim related deps Install all depends to properly generate the manuals. Otherwise it prints errors like the following and the resulting manual has empty sections: /build/docs/shell.rst:329: ERROR: Failed to import "LinFixedEF" from "pySim.filesystem". No module named 'smartcard' Get the requirements.txt directly from the git repository, so we don't need to update the list of dependencies here. Remove the dependencies from the list that I added recently for pysim, and which are are also in requirements.txt. Add swig, as otherwise pyscard fails to install. Related: OS#5497 Change-Id: I13a0b0dc8be81bf4034b08b1ef1100f1420fa3a1 --- M debian-buster-jenkins/Dockerfile 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index ca11719..44c2ee3 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -143,14 +143,14 @@ 'git+https://github.com/eriwen/lcov-to-cobertura-xml.git' \ 'git+https://github.com/osmocom/sphinx-argparse@master#egg=sphinx-argparse' \ 'git+https://github.com/podshumok/python-smpplib.git' \ - 'construct>=2.9.51' \ 'pydbus' \ 'pylint' \ 'pysispm' \ - 'pytlv' \ - 'pyyaml>=5.1' \ 'sphinx' \ - 'sphinxcontrib-napoleon' + 'sphinxcontrib-napoleon' \ + 'swig' +ADD https://gitea.osmocom.org/sim-card/pysim/raw/branch/master/requirements.txt /tmp/pysim_requirements.txt +RUN pip3 install -r /tmp/pysim_requirements.txt # match the outside user RUN useradd --uid=1000 build -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I13a0b0dc8be81bf4034b08b1ef1100f1420fa3a1 Gerrit-Change-Number: 29913 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: add more pysim related deps

by osmith

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29913 ) Change subject: debian-buster-jenkins: add more pysim related deps ...................................................................... Patch Set 2: Code-Review+2 (2 comments) Patchset: PS2: re-applying +2 after fixup File debian-buster-jenkins/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/29913/comment/9f4596dc_31c… PS1, Line 149: pyyaml > Can also be removed because it's present in requirements.txt. Done -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I13a0b0dc8be81bf4034b08b1ef1100f1420fa3a1 Gerrit-Change-Number: 29913 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 04 Nov 2022 10:18:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: add more pysim related deps

by osmith

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, laforge, pespin, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/docker-playground/+/29913 to look at the new patch set (#2). Change subject: debian-buster-jenkins: add more pysim related deps ...................................................................... debian-buster-jenkins: add more pysim related deps Install all depends to properly generate the manuals. Otherwise it prints errors like the following and the resulting manual has empty sections: /build/docs/shell.rst:329: ERROR: Failed to import "LinFixedEF" from "pySim.filesystem". No module named 'smartcard' Get the requirements.txt directly from the git repository, so we don't need to update the list of dependencies here. Remove the dependencies from the list that I added recently for pysim, and which are are also in requirements.txt. Add swig, as otherwise pyscard fails to install. Related: OS#5497 Change-Id: I13a0b0dc8be81bf4034b08b1ef1100f1420fa3a1 --- M debian-buster-jenkins/Dockerfile 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/13/29913/2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29913 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I13a0b0dc8be81bf4034b08b1ef1100f1420fa3a1 Gerrit-Change-Number: 29913 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: ggsn-kernel-gtp: Use new OBS package feed, not old obs.osmocom.org

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30001 ) Change subject: ggsn-kernel-gtp: Use new OBS package feed, not old obs.osmocom.org ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/30001/comment/a1580c9e_46674650 PS1, Line 7: , not old obs.osmocom.org (drop this part? obs.osmocom.org is the new one) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1566daa23425973bb4155a40f1cdd6040b494420 Gerrit-Change-Number: 30001 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 04 Nov 2022 10:14:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: ggsn-kernel-gtp: Use my current SSH public key

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30002 ) Change subject: ggsn-kernel-gtp: Use my current SSH public key ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I64b8c853fd34de4210da43165bebc6f8514b2e1a Gerrit-Change-Number: 30002 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 04 Nov 2022 10:13:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: ggsn-kernel-gtp: Use my current SSH public key

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30002 ) Change subject: ggsn-kernel-gtp: Use my current SSH public key ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30002 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I64b8c853fd34de4210da43165bebc6f8514b2e1a Gerrit-Change-Number: 30002 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 04 Nov 2022 09:43:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: ggsn-kernel-gtp: Use new OBS package feed, not old obs.osmocom.org

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30001 ) Change subject: ggsn-kernel-gtp: Use new OBS package feed, not old obs.osmocom.org ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30001 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1566daa23425973bb4155a40f1cdd6040b494420 Gerrit-Change-Number: 30001 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 04 Nov 2022 09:42:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-def...

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29983 ) Change subject: Add -Werror=implicit-int -Werror=int-conversion -Werror=old-style-definition ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29983 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I8acd1b276f1ff8f015856d70fd582e457915ea11 Gerrit-Change-Number: 29983 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 04 Nov 2022 09:41:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022