November 2022 - gerrit-log - lists.osmocom.org

Change in osmocom-bb[master]: trxcon: configure.ac: call LT_INIT after setting CFLAGS

by Hoernchen

Attention is currently required from: fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30060 ) Change subject: trxcon: configure.ac: call LT_INIT after setting CFLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8d8eb1e3428ffcb84ddd53230fada39328337d15 Gerrit-Change-Number: 30060 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Nov 2022 16:58:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: fw: Add initial support for Sony Ericsson K200i/K220i phones

by falconia

Attention is currently required from: fixeria, steve-m. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30051 ) Change subject: fw: Add initial support for Sony Ericsson K200i/K220i phones ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Overall looks OK for first draft. I see that you aren't doing any model-specific GPIO config, but since you leave everything in power-up default state, it should be safe to run. To get correct GPIO config, someone would have to disasm original fw deep enough to find those settings, ditto for MEMIF. I did a little disasm, but not deep enough to reach those bits - I only got as far as the bootloader so far. RF tables: look in my freecalypso-reveng repository, se_k200i directory - the rf_XXX.c files you'll find there are extracts from original fw. Basically you would need to copy gta0x/rf_tables.c, keep the levels tables unchanged (SE fw left them unchanged from TI's version too, as you can see in my rf_XXX.c extracts), but replace all ramps with those from se_k200i/rf_XXX.c files. However, what APC offset is used by the original fw is the big unknown, and if it's wrong, all levels will off despite reading calibration records - this part is always a bummer. AFC params: use "tiffs $flashdump 256x13 decode afcparams" to look at factory numbers on a few units, then use my little osmo2psi hack in freecalypso-reveng to find an AFC slope number in your style that is approximately close. File src/target/firmware/board/se_k2x0/init.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30051/comment/0fc8af61_6b666781 PS1, Line 62: compal loader > There's actually no Compal's loader in these SE phones (unlike the J100i). […] TI's boot ROM does not leave watchdog enabled when jumping to serially downloaded code, but explicitly disabling it in your own firmwsres should be considered good practice, so you are not dependent on this or that bootloader and its peculiarities. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30051 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I711702862b1cec5a8089dac071f8a171ca026003 Gerrit-Change-Number: 30051 Gerrit-PatchSet: 1 Gerrit-Owner: steve-m <steve(a)steve-m.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: steve-m <steve(a)steve-m.de> Gerrit-Comment-Date: Wed, 09 Nov 2022 16:31:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: Fix typos in copyright statements.

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/30067 ) Change subject: Fix typos in copyright statements. ...................................................................... Fix typos in copyright statements. Change-Id: I783c56bb1d216ce3a47a19da230ee5f50aca2ab3 --- M src/context.c M src/mnl.c M src/select.c 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/67/30067/1 diff --git a/src/context.c b/src/context.c index 8ab6f87..6b58565 100644 --- a/src/context.c +++ b/src/context.c @@ -2,7 +2,7 @@ * talloc context handling. * * (C) 2019 by Harald Welte <laforge(a)gnumonks.org> - * All Rights Reserverd. + * All Rights Reserved. * * SPDX-License-Identifier: GPL-2.0+ * diff --git a/src/mnl.c b/src/mnl.c index f32367d..c3f5fe6 100644 --- a/src/mnl.c +++ b/src/mnl.c @@ -8,7 +8,7 @@ /* * (C) 2020 by Harald Welte <laforge(a)gnumonks.org> - * All Rights Reserverd. + * All Rights Reserved. * * SPDX-License-Identifier: GPL-2.0+ * diff --git a/src/select.c b/src/select.c index 5aee7d8..026d457 100644 --- a/src/select.c +++ b/src/select.c @@ -5,7 +5,7 @@ * of the linux 2.4 netfilter subsystem. */ /* * (C) 2000-2020 by Harald Welte <laforge(a)gnumonks.org> - * All Rights Reserverd. + * All Rights Reserved. * * SPDX-License-Identifier: GPL-2.0+ * -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30067 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I783c56bb1d216ce3a47a19da230ee5f50aca2ab3 Gerrit-Change-Number: 30067 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmocore[master]: */Makefile.am: do not mix up AM_CFLAGS with AM_CPPFLAGS

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30057 ) Change subject: */Makefile.am: do not mix up AM_CFLAGS with AM_CPPFLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30057 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2c1d5f9c61714f487fbbe60603b2682f2c0a4c6b Gerrit-Change-Number: 30057 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Nov 2022 15:49:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: bts_vty: fix wrong description used for C/I threshold values

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30058 ) Change subject: bts_vty: fix wrong description used for C/I threshold values ...................................................................... bts_vty: fix wrong description used for C/I threshold values Found this bug when building with CPPFLAGS="-Wunused-macros". Change-Id: I02828acebe2d607f0e7fd3c61ce45f2af5237e49 --- M src/osmo-bsc/bts_vty.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bsc/bts_vty.c b/src/osmo-bsc/bts_vty.c index 711ab06..732ed57 100644 --- a/src/osmo-bsc/bts_vty.c +++ b/src/osmo-bsc/bts_vty.c @@ -3432,9 +3432,9 @@ "Set target C/I thresholds (for dynamic mode), only available in ms-power-control\n" VTY_DESC_CI_TYPE "Lower C/I value\n" - "Lower " POWER_CONTROL_MEAS_RXQUAL_DESC + "Lower " POWER_CONTROL_MEAS_CI_DESC "Upper C/I value\n" - "Upper " POWER_CONTROL_MEAS_RXQUAL_DESC) + "Upper " POWER_CONTROL_MEAS_CI_DESC) { struct gsm_power_ctrl_params *params = vty->index; const char *type = argv[0]; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02828acebe2d607f0e7fd3c61ce45f2af5237e49 Gerrit-Change-Number: 30058 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-bsc[master]: bts_vty: fix wrong description used for C/I threshold values

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30058 ) Change subject: bts_vty: fix wrong description used for C/I threshold values ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I02828acebe2d607f0e7fd3c61ce45f2af5237e49 Gerrit-Change-Number: 30058 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Nov 2022 15:48:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-pcu[master]: Makefile.am: drop unneeded '-ldl -pthread' from AM_CXXFLAGS

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30059 ) Change subject: Makefile.am: drop unneeded '-ldl -pthread' from AM_CXXFLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I833864aa51059be9c97c16329bc16913c53e171d Gerrit-Change-Number: 30059 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Nov 2022 15:48:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: configure.ac: call LT_INIT after setting CFLAGS

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30060 ) Change subject: trxcon: configure.ac: call LT_INIT after setting CFLAGS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8d8eb1e3428ffcb84ddd53230fada39328337d15 Gerrit-Change-Number: 30060 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Nov 2022 15:47:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: fixup: handle DATA.cnf/TRAFFIC.cnf via TRXCON_EV_TX_DATA_CNF

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30056 ) Change subject: trxcon: fixup: handle DATA.cnf/TRAFFIC.cnf via TRXCON_EV_TX_DATA_CNF ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifc538f940571172fa237ecb7000f3cfea3655edc Gerrit-Change-Number: 30056 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 09 Nov 2022 15:47:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-e1-hardware[master]: icE1usb fw: Add device request to read/write I2C device registers

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/30066 ) Change subject: icE1usb fw: Add device request to read/write I2C device registers ...................................................................... icE1usb fw: Add device request to read/write I2C device registers Signed-off-by: Sylvain Munaut <tnt(a)246tNt.com> Change-Id: I55a72762d535827a51e5ea1775e9abbd116bc8a8 --- M firmware/ice40-riscv/icE1usb/ice1usb_proto.h M firmware/ice40-riscv/icE1usb/usb_dev.c 2 files changed, 14 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/firmware/ice40-riscv/icE1usb/ice1usb_proto.h b/firmware/ice40-riscv/icE1usb/ice1usb_proto.h index 5b65d76..8cf8439 100644 --- a/firmware/ice40-riscv/icE1usb/ice1usb_proto.h +++ b/firmware/ice40-riscv/icE1usb/ice1usb_proto.h @@ -20,6 +20,10 @@ /*! returns a string describing the firmware version */ #define ICE1USB_DEV_GET_FW_BUILD 0x02 +/*! performs an I2C register access (read/write depends on direction) */ +#define ICE1USB_DEV_I2C_REG_ACCESS 0x10 + + enum e1usb_dev_capability { /*! Does this board have a GPS-DO */ ICE1USB_DEV_CAP_GPSDO, diff --git a/firmware/ice40-riscv/icE1usb/usb_dev.c b/firmware/ice40-riscv/icE1usb/usb_dev.c index e834142..da1e7f2 100644 --- a/firmware/ice40-riscv/icE1usb/usb_dev.c +++ b/firmware/ice40-riscv/icE1usb/usb_dev.c @@ -12,6 +12,7 @@ #include <no2usb/usb_proto.h> #include "console.h" +#include "i2c.h" #include "misc.h" #include "ice1usb_proto.h" @@ -24,6 +25,10 @@ _usb_dev_ctrl_req_write(struct usb_ctrl_req *req, struct usb_xfer *xfer) { switch (req->bRequest) { + case ICE1USB_DEV_I2C_REG_ACCESS: + if (!i2c_write_reg((req->wIndex >> 8), req->wIndex & 0xff, req->wValue & 0xff)) + return USB_FND_ERROR; + break; default: return USB_FND_ERROR; } @@ -43,6 +48,11 @@ xfer->data = (void*) fw_build_str; xfer->len = strlen(fw_build_str); break; + case ICE1USB_DEV_I2C_REG_ACCESS: + if (!i2c_read_reg((req->wIndex >> 8), req->wIndex & 0xff, &xfer->data[0])) + return USB_FND_ERROR; + xfer->len = 1; + break; default: return USB_FND_ERROR; } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/30066 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I55a72762d535827a51e5ea1775e9abbd116bc8a8 Gerrit-Change-Number: 30066 Gerrit-PatchSet: 2 Gerrit-Owner: tnt <tnt(a)246tNt.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022