November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-remsim[master]: bankd, client, server: add -L option to disable log coloring

by jtavares

Attention is currently required from: laforge. jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30154 ) Change subject: bankd, client, server: add -L option to disable log coloring ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > traditionally, a lot of osmo-* programs use "-s" aka "--disable-color" for this command line argumen […] No problem on the long option, but can you clarify if you want all the osmo-remsim programs to be consistent with the use of -L, or do you want the ones who can use -s to use -s? PS1: Please clarify short option preference -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6955b0af1ceb11a4029383e32bb298ee8da7503f Gerrit-Change-Number: 30154 Gerrit-PatchSet: 1 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 15 Nov 2022 12:37:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-sgsn[master]: contrib/jenkins.sh: use enable-werror with IU too

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30156 ) Change subject: contrib/jenkins.sh: use enable-werror with IU too ...................................................................... contrib/jenkins.sh: use enable-werror with IU too Now that the warnings in osmo-iuh have been fixed, we should be able to build the IU version of OsmoSGSN with --enable-werror too. Related: OS#4462 Change-Id: I8cc4e209e21acfe513bef72927499f1ccdead783 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/56/30156/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 2325897..321beef 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -37,14 +37,11 @@ osmo-build-dep.sh osmo-ggsn osmo-build-dep.sh osmo-hlr -enable_werror="" if [ "x$IU" = "x--enable-iu" ]; then osmo-build-dep.sh libosmo-sccp osmo-build-dep.sh libasn1c #osmo-build-dep.sh asn1c aper-prefix # only needed for make regen in osmo-iuh osmo-build-dep.sh osmo-iuh -else - enable_werror="--enable-werror" fi # Additional configure options and depends @@ -63,12 +60,12 @@ cd "$base" autoreconf --install --force -./configure --enable-sanitize $enable_werror $IU --enable-external-tests $CONFIG +./configure --enable-sanitize --enable-werror $IU --enable-external-tests $CONFIG $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check \ || cat-testlogs.sh LD_LIBRARY_PATH="$inst/lib" \ - DISTCHECK_CONFIGURE_FLAGS="$enable_werror $IU --enable-external-tests $CONFIG" \ + DISTCHECK_CONFIGURE_FLAGS="--enable-werror $IU --enable-external-tests $CONFIG" \ $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8cc4e209e21acfe513bef72927499f1ccdead783 Gerrit-Change-Number: 30156 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: remsim-client-st2: Proper error if not all endpoints can be found

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30152 ) Change subject: remsim-client-st2: Proper error if not all endpoints can be found ...................................................................... remsim-client-st2: Proper error if not all endpoints can be found Let's avoid a segfault and rather print a proper error message in case we cannot find all the required USB endpoints when opening the user-specified interface/config/device. This can happen if the device is currently in DFU mode, or a completely wrong device/interface was specified. Before this patch: Assert failed rc == 0 user_simtrace2.c:305 After this patch: DMAIN ERROR user_simtrace2.c:448 specified USB dev/config/interface doesn't have at least one IN, OUT and IRQ_IN endpoint Closes: OS#5416 Change-Id: Icfcc482fff106a232c5125ed8ab463ecc13824ae --- M src/client/user_simtrace2.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/client/user_simtrace2.c b/src/client/user_simtrace2.c index f71c720..29ab196 100644 --- a/src/client/user_simtrace2.c +++ b/src/client/user_simtrace2.c @@ -444,6 +444,12 @@ goto close_exit; } + if (!transp->usb_ep.in || !transp->usb_ep.out || !transp->usb_ep.irq_in) { + LOGP(DMAIN, LOGL_ERROR, "specified USB dev/config/interface doesn't have " + "at least one IN, OUT and IRQ_IN endpoint\n"); + goto close_exit; + } + allocate_and_submit_irq(ci); /* submit multiple IN URB in order to work around OS#4409 */ for (i = 0; i < 4; i++) -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icfcc482fff106a232c5125ed8ab463ecc13824ae Gerrit-Change-Number: 30152 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: remsim-client-st2: Proper error if not all endpoints can be found

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30152 ) Change subject: remsim-client-st2: Proper error if not all endpoints can be found ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30152 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: Icfcc482fff106a232c5125ed8ab463ecc13824ae Gerrit-Change-Number: 30152 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 15 Nov 2022 12:01:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd: Add GSMTAP functionality for SIM traffic

by laforge

Attention is currently required from: jtavares. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30139 ) Change subject: bankd: Add GSMTAP functionality for SIM traffic ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: > Marking issues as resolved. […] the usual process is just to wait and hope somebody feels like reviewing. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I05b599858d8758633aa56c3f12f258c27cf42d08 Gerrit-Change-Number: 30139 Gerrit-PatchSet: 4 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-Comment-Date: Tue, 15 Nov 2022 12:00:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jtavares <jtavares(a)kvh.com> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd, client, server: add -L option to disable log coloring

by laforge

Attention is currently required from: jtavares. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30154 ) Change subject: bankd, client, server: add -L option to disable log coloring ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: traditionally, a lot of osmo-* programs use "-s" aka "--disable-color" for this command line argument, see osmo-{bts,bsc,gbproxy,hlr,hnbgw,hnodeb,mgw,msc,pcap,sgsn,uecups}. I understand that "-s" is already occupied at least in bankd, but then let's at least keep the long-option in-line with other osmocom programs. -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6955b0af1ceb11a4029383e32bb298ee8da7503f Gerrit-Change-Number: 30154 Gerrit-PatchSet: 1 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-Comment-Date: Tue, 15 Nov 2022 11:59:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: contrib/jenkins.sh: use enable-werror with IU too

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/30155 ) Change subject: contrib/jenkins.sh: use enable-werror with IU too ...................................................................... contrib/jenkins.sh: use enable-werror with IU too Now that the warnings in osmo-iuh have been fixed, we should be able to build the IU version of OsmoMSC with --enable-werror too. Related: OS#4462 Change-Id: Id54be9dd1aa66cc27eb5ee4010be9e495865b331 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/55/30155/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index e1bbad4..558b6dc 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -39,13 +39,10 @@ osmo-build-dep.sh osmo-mgw osmo-build-dep.sh osmo-hlr -enable_werror="" if [ "x$IU" = "x--enable-iu" ]; then osmo-build-dep.sh libasn1c #osmo-build-dep.sh asn1c aper-prefix # only needed for make regen in osmo-iuh osmo-build-dep.sh osmo-iuh -else - enable_werror="--enable-werror" fi # Additional configure options and depends @@ -64,12 +61,12 @@ cd "$base" autoreconf --install --force -./configure --enable-sanitize $enable_werror --enable-smpp $IU --enable-external-tests $CONFIG +./configure --enable-sanitize --enable-werror --enable-smpp $IU --enable-external-tests $CONFIG $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check \ || cat-testlogs.sh LD_LIBRARY_PATH="$inst/lib" \ - DISTCHECK_CONFIGURE_FLAGS="$enable_werror --enable-smpp $IU --enable-external-tests $CONFIG" \ + DISTCHECK_CONFIGURE_FLAGS="--enable-werror --enable-smpp $IU --enable-external-tests $CONFIG" \ $MAKE $PARALLEL_MAKE distcheck \ || cat-testlogs.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30155 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id54be9dd1aa66cc27eb5ee4010be9e495865b331 Gerrit-Change-Number: 30155 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-hnodeb[master]: contrib/jenkins.sh: use --enable-werror

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26212 ) Change subject: contrib/jenkins.sh: use --enable-werror ...................................................................... contrib/jenkins.sh: use --enable-werror Fixes: OS#5290 Change-Id: Ic32464b9a52a5de4ee81fc3a4dbb5717b3b43e39 --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index 7001013..7c462c8 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -52,7 +52,7 @@ cd "$base" autoreconf --install --force -./configure --enable-sanitize --enable-external-tests $CONFIG +./configure --enable-sanitize --enable-external-tests --enable-werror $CONFIG $MAKE $PARALLEL_MAKE LD_LIBRARY_PATH="$inst/lib" $MAKE check \ || cat-testlogs.sh -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ic32464b9a52a5de4ee81fc3a4dbb5717b3b43e39 Gerrit-Change-Number: 26212 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 7 months

1
0
0 0

Change in osmo-hnodeb[master]: contrib/jenkins.sh: use --enable-werror

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26212 ) Change subject: contrib/jenkins.sh: use --enable-werror ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26212 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnodeb Gerrit-Branch: master Gerrit-Change-Id: Ic32464b9a52a5de4ee81fc3a4dbb5717b3b43e39 Gerrit-Change-Number: 26212 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 11:42:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Rework log formatting when replaying detected RTP gaps

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30148 ) Change subject: osmux: Rework log formatting when replaying detected RTP gaps ...................................................................... Patch Set 1: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/30148/comment/94d0dde8_5f58a98d PS1, Line 366: d > did you consider sequence wrap-around here? What if for example last_seq == 65535 and cur_seq == 0 o […] Indeed I have my doubts this code is 100% correct when wrap around is in place. I started looking into exact this already before submitting this patch. That's why I wrote in the commit log that flaws will be fixed in follow up patches. I submitted this patch because it is actually not really changing the arithmetic here, only rearranging a few parts to have a more meaningful log line. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5fd64acf7bc1e53efae0674d0c906d1255a9bbf6 Gerrit-Change-Number: 30148 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 15 Nov 2022 11:41:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022