November 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: osmux: Fix naming of functions operating on osmux circuits

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30160 ) Change subject: osmux: Fix naming of functions operating on osmux circuits ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30160 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ieaac449fe04831e47ff932c234c18994f157df88 Gerrit-Change-Number: 30160 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 14:16:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in docker-playground[master]: open5gs-latest: migrate from debian:buster to debian:bullseye

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30161 ) Change subject: open5gs-latest: migrate from debian:buster to debian:bullseye ...................................................................... open5gs-latest: migrate from debian:buster to debian:bullseye Change-Id: Ia09aa712a916686f7220da9a5d2f4a02a8b7b8db --- M open5gs-latest/Dockerfile 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/61/30161/1 diff --git a/open5gs-latest/Dockerfile b/open5gs-latest/Dockerfile index e8424de..519701c 100644 --- a/open5gs-latest/Dockerfile +++ b/open5gs-latest/Dockerfile @@ -1,5 +1,5 @@ ARG REGISTRY=docker.io -FROM ${REGISTRY}/debian:buster +FROM ${REGISTRY}/debian:bullseye RUN apt-get update && \ @@ -7,14 +7,14 @@ ca-certificates \ gnupg -ADD https://download.opensuse.org/repositories/home:/acetcom:/open5gs:/latest/D… /tmp/Release.key -ADD https://pgp.mongodb.com/server-4.2.asc /tmp/server-4.2.asc +ADD https://download.opensuse.org/repositories/home:/acetcom:/open5gs:/latest/D… /tmp/Release.key +ADD https://pgp.mongodb.com/server-5.0.asc /tmp/server-5.0.asc -RUN echo "deb http://download.opensuse.org/repositories/home:/acetcom:/open5gs:/latest/De… ./" \ +RUN echo "deb http://download.opensuse.org/repositories/home:/acetcom:/open5gs:/latest/De… ./" \ > /etc/apt/sources.list.d/open5gs.list -RUN echo "deb http://repo.mongodb.org/apt/debian buster/mongodb-org/4.2 main" \ +RUN echo "deb http://repo.mongodb.org/apt/debian bullseye/mongodb-org/5.0 main" \ > /etc/apt/sources.list.d/mongodb-org.list -RUN apt-key add /tmp/Release.key && apt-key add /tmp/server-4.2.asc +RUN apt-key add /tmp/Release.key && apt-key add /tmp/server-5.0.asc RUN apt-get update && \ apt-get install -y \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ia09aa712a916686f7220da9a5d2f4a02a8b7b8db Gerrit-Change-Number: 30161 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-bts[master]: osmux: Rotate over available Osmux CID when allocating a new one

by osmith

Attention is currently required from: pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30158 ) Change subject: osmux: Rotate over available Osmux CID when allocating a new one ...................................................................... Patch Set 1: (1 comment) File src/common/osmux.c: https://gerrit.osmocom.org/c/osmo-bts/+/30158/comment/fd206593_acd37ade PS1, Line 67: <= should probably be <, otherwise you check start_i twice? it's also < below for the start_j check -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72803fb172accbabfc81923572890f8ecb06cefd Gerrit-Change-Number: 30158 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 13:58:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Fix naming of functions operating on osmux circuits

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30160 ) Change subject: osmux: Fix naming of functions operating on osmux circuits ...................................................................... osmux: Fix naming of functions operating on osmux circuits Let's put the object and update the naming of the functions accordingly. Change-Id: Ieaac449fe04831e47ff932c234c18994f157df88 --- M src/osmux_input.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/60/30160/1 diff --git a/src/osmux_input.c b/src/osmux_input.c index c1cd2c6..aa48049 100644 --- a/src/osmux_input.c +++ b/src/osmux_input.c @@ -81,7 +81,7 @@ }; /* returns: 1 if batch is full, 0 if batch still not full, negative on error. */ -static int osmux_batch_enqueue(struct msgb *msg, struct osmux_circuit *circuit, +static int osmux_circuit_enqueue(struct osmux_circuit *circuit, struct msgb *msg, uint8_t batch_factor) { /* Validate amount of messages per batch. The counter field of the @@ -104,7 +104,7 @@ return 0; } -static void osmux_batch_dequeue(struct msgb *msg, struct osmux_circuit *circuit) +static void osmux_circuit_dequeue(struct osmux_circuit *circuit, struct msgb *msg) { llist_del(&msg->list); circuit->nmsgs--; @@ -114,7 +114,7 @@ { struct msgb *cur, *tmp; llist_for_each_entry_safe(cur, tmp, &circuit->msg_list, list) { - osmux_batch_dequeue(cur, circuit); + osmux_circuit_dequeue(circuit, cur); msgb_free(cur); batch->nmsgs--; } @@ -257,7 +257,7 @@ } osmux_batch_put(batch, &state); - osmux_batch_dequeue(cur, circuit); + osmux_circuit_dequeue(circuit, cur); prev_amr_ft = state.amrh->ft; ctr++; msgb_free(cur); @@ -398,7 +398,7 @@ DELTA_RTP_TIMESTAMP); /* No more room in this batch, skip padding with more clones */ - rc = osmux_batch_enqueue(clone, circuit, batch_factor); + rc = osmux_circuit_enqueue(circuit, clone, batch_factor); if (rc != 0) { msgb_free(clone); return rc; @@ -502,7 +502,7 @@ return rc; /* This batch is full, force batch delivery */ - rc = osmux_batch_enqueue(msg, circuit, batch_factor); + rc = osmux_circuit_enqueue(circuit, msg, batch_factor); if (rc != 0) return rc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30160 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ieaac449fe04831e47ff932c234c18994f157df88 Gerrit-Change-Number: 30160 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-msc[master]: fix sdp_msg_to_sdp_str(), never add fmtp for unset codec

by neels

Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30111 ) Change subject: fix sdp_msg_to_sdp_str(), never add fmtp for unset codec ...................................................................... Patch Set 1: (1 comment) File src/libmsc/sdp_msg.c: https://gerrit.osmocom.org/c/osmo-msc/+/30111/comment/1c59d526_16fe6156 PS1, Line 271: if (!sdp_audio_codec_is_set(codec)) > """ […] this patch is really not that important, it is just something that "fell out" when i separated the code bomb resulting from experimental hacking on codecs into smaller chunks. i think this could be dropped ... but why bother, this is trivial. the most significant difference is the added 'continue;' The old code would print "a=fmtp..." even if subtype_name[0] == 0. There is no real practical implication, normally the audio_codecs->count indicates the actually populated entries and there shouldn't be empty entries among those. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I1892efd9360585f98419ebbd0df180f7f3a8160d Gerrit-Change-Number: 30111 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 13:46:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Rotate over available Osmux CID when allocating a new one

by daniel

Attention is currently required from: osmith, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30157 ) Change subject: osmux: Rotate over available Osmux CID when allocating a new one ...................................................................... Patch Set 1: (1 comment) File src/libosmo-mgcp/mgcp_osmux.c: https://gerrit.osmocom.org/c/osmo-mgw/+/30157/comment/7dc72c7b_f61b36f6 PS1, Line 748: start_j = next_free_osmux_cid_lookup & 0x07; I think it would be clearer if you used /8 and %8 here, I had to read it three times. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30157 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I9dfbcc5e4b4c61ce217020e533d68fbcfa6b9f56 Gerrit-Change-Number: 30157 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 13:39:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in docker-playground[master]: ttcn3-pgw-test: update freeDiameter-smf.conf

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30159 ) Change subject: ttcn3-pgw-test: update freeDiameter-smf.conf ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic90f713fb127f8d5407c18553b29b3c2be141420 Gerrit-Change-Number: 30159 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 15 Nov 2022 13:36:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in docker-playground[master]: ttcn3-pgw-test: update freeDiameter-smf.conf

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30159 ) Change subject: ttcn3-pgw-test: update freeDiameter-smf.conf ...................................................................... ttcn3-pgw-test: update freeDiameter-smf.conf Recent open5gs changed location of the TLS key and certificate files: commit 0859dd44530a944076c207c750188572effc2709 Author: Sukchan Lee <acetcom(a)gmail.com> Date: Sat Nov 12 09:37:43 2022 +0900 Follow-up on #1865 Updating paths makes the open5gs-master work, however the -latest still installs these files to '/etc/freeDiameter/'. Let's comment both 'TLS_Cred' and 'TLS_CA' out, we are not using TLS anyway. Change-Id: Ic90f713fb127f8d5407c18553b29b3c2be141420 --- M ttcn3-pgw-test/freeDiameter-smf.conf 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/59/30159/1 diff --git a/ttcn3-pgw-test/freeDiameter-smf.conf b/ttcn3-pgw-test/freeDiameter-smf.conf index 19e41f6..a05195c 100644 --- a/ttcn3-pgw-test/freeDiameter-smf.conf +++ b/ttcn3-pgw-test/freeDiameter-smf.conf @@ -106,7 +106,7 @@ # Default : NO DEFAULT #TLS_Cred = "<x509 certif file.PEM>" , "<x509 private key file.PEM>"; #TLS_Cred = "/etc/ssl/certs/freeDiameter.pem", "/etc/ssl/private/freeDiameter.key"; -TLS_Cred = "/etc/freeDiameter/smf.cert.pem", "/etc/freeDiameter/smf.key.pem"; +#TLS_Cred = "/etc/open5gs/tls/smf.crt", "/etc/open5gs/tls/smf.key"; # Certificate authority / trust anchors # The file containing the list of trusted Certificate Authorities (PEM list) @@ -114,7 +114,7 @@ # The directive can appear several times to specify several files. # Default : GNUTLS default behavior #TLS_CA = "<file.PEM>"; -TLS_CA = "/etc/freeDiameter/cacert.pem"; +#TLS_CA = "/etc/open5gs/tls/ca.crt"; # Certificate Revocation List file # The information about revoked certificates. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ic90f713fb127f8d5407c18553b29b3c2be141420 Gerrit-Change-Number: 30159 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd, client, server: add -L option to disable log coloring

by jtavares

Attention is currently required from: laforge. jtavares has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/30154 ) Change subject: bankd, client, server: add -L option to disable log coloring ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > No problem on the long option, but can you clarify if you want all the osmo-remsim programs to be co […] --disable-color fixed in patchset #2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6955b0af1ceb11a4029383e32bb298ee8da7503f Gerrit-Change-Number: 30154 Gerrit-PatchSet: 2 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 15 Nov 2022 13:08:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: jtavares <jtavares(a)kvh.com> Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-remsim[master]: bankd, client, server: add -L option to disable log coloring

by jtavares

Attention is currently required from: jtavares. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-remsim/+/30154 to look at the new patch set (#2). Change subject: bankd, client, server: add -L option to disable log coloring ...................................................................... bankd, client, server: add -L option to disable log coloring When the stderr of these services is sent to syslog, for example by using systemd's StandardError=syslog, syslog's escaping of ANSI color ESC sequences in log messages really clutter the log files. This option allows log coloring to be disabled on the command line. Change-Id: I6955b0af1ceb11a4029383e32bb298ee8da7503f --- M src/bankd/bankd_main.c M src/client/remsim_client_main.c M src/server/remsim_server.c 3 files changed, 22 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/54/30154/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/30154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-remsim Gerrit-Branch: master Gerrit-Change-Id: I6955b0af1ceb11a4029383e32bb298ee8da7503f Gerrit-Change-Number: 30154 Gerrit-PatchSet: 2 Gerrit-Owner: jtavares <jtavares(a)kvh.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: jtavares <jtavares(a)kvh.com> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022