November 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: osmux: Add internal backpointer to in_handle to simplify param passing

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30163 ) Change subject: osmux: Add internal backpointer to in_handle to simplify param passing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5c226c5c809a240f9eb80aa2e83679adc717d717 Gerrit-Change-Number: 30163 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Nov 2022 13:07:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: jobs/coverity: remove display-name

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30186 ) Change subject: jobs/coverity: remove display-name ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf1a8db45daf75ae110cfae3042627fbcdd14575 Gerrit-Change-Number: 30186 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Nov 2022 13:06:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmocom-api: add jenkins-job-builder config

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30185 ) Change subject: jobs/osmocom-api: add jenkins-job-builder config ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia518979307ce633ccd2c431a8e8eea866da2a50d Gerrit-Change-Number: 30185 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Nov 2022 13:06:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Add internal backpointer to in_handle to simplify param passing

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30163 ) Change subject: osmux: Add internal backpointer to in_handle to simplify param passing ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30163 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5c226c5c809a240f9eb80aa2e83679adc717d717 Gerrit-Change-Number: 30163 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Nov 2022 12:56:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: osmux: rename internal struct osmux_batch -> osmux_link

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30162 ) Change subject: osmux: rename internal struct osmux_batch -> osmux_link ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib118fd2c1fead78655756156ce5d4ce4a6d080df Gerrit-Change-Number: 30162 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 16 Nov 2022 12:50:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: jobs/coverity: remove display-name

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30186 ) Change subject: jobs/coverity: remove display-name ...................................................................... jobs/coverity: remove display-name Make it consistent with all other jobs and don't set a display name. This way the job will be sorted properly in the list of jobs and won't weirdly jump to the top when loading the page. Change-Id: Idf1a8db45daf75ae110cfae3042627fbcdd14575 --- M jobs/coverity.yml 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/86/30186/1 diff --git a/jobs/coverity.yml b/jobs/coverity.yml index 74803c7..242d1aa 100644 --- a/jobs/coverity.yml +++ b/jobs/coverity.yml @@ -9,7 +9,6 @@ project-type: freestyle defaults: global description: 'Generated by job-builder' - display-name: 'Coverity-Upload' node: coverity builders: - shell: | -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30186 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf1a8db45daf75ae110cfae3042627fbcdd14575 Gerrit-Change-Number: 30186 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmocom-api: add jenkins-job-builder config

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30185 ) Change subject: jobs/osmocom-api: add jenkins-job-builder config ...................................................................... jobs/osmocom-api: add jenkins-job-builder config Add a jenkins-job-builder configuration for the existing Osmocom_API job and refactor it to not use the deprecated multi-scm plugin. Also update the git clone urls. Related: OS#5763 Change-Id: Ia518979307ce633ccd2c431a8e8eea866da2a50d --- A jobs/osmocom-api.yml 1 file changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/85/30185/1 diff --git a/jobs/osmocom-api.yml b/jobs/osmocom-api.yml new file mode 100644 index 0000000..f91779d --- /dev/null +++ b/jobs/osmocom-api.yml @@ -0,0 +1,89 @@ +- job: + concurrent: false + description: This job builds the doxygen API documentation for latest libosmo* + and uploads it to <a href="https://downloads.osmocom.org/api/latest/" + >https://downloads.osmocom.org/api/latest/</a> + name: Osmocom_API + node: osmocom-master-debian9 + project-type: freestyle + publishers: + - email: + notify-every-unstable-build: true + recipients: jenkins-notifications(a)lists.osmocom.org + triggers: + - timed: "H H * * *" + wrappers: + - ssh-agent-credentials: + users: + - api@osmocom + parameters: + - string: + name: BRANCH + description: osmo-ci.git branch + default: 'master' + scm: + - git: + branches: + - '$BRANCH' + url: https://gerrit.osmocom.org/osmo-ci + git-config-name: 'Jenkins Builder' + git-config-email: 'jenkins(a)osmocom.org' + wipe-workspace: true + builders: + - shell: | + # Repositories for which doxygen documentation will be generated and + # uploaded, also dependencies which need to be built + repos_api=" + libosmocore + libosmo-abis + libosmo-dsp + libosmo-netif + libosmo-sccp + osmo-gmr" + + # Source common.sh from osmo-ci.git for osmo_git_clone_url() + . scripts/common.sh + + # Put git repos and install data in a subdir, so it isn't in the root + # of the cloned osmo-ci.git repository + mkdir _osmocom_api + cd _osmocom_api + + # Prepare pkgconfig path + export PKG_CONFIG_PATH=$PWD/install/lib/pkgconfig + mkdir -p "$PKG_CONFIG_PATH" + + # Prepare known_hosts + cat > known_hosts <<EOF + [ftp.osmocom.org]:48 ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDDgQ9HntlpWNmh953a2Gc8NysKE4orOatVT1wQkyzhARnfYUerRuwyNr1GqMyBKdSI9amYVBXJIOUFcpV81niA7zQRUs66bpIMkE9/rHxBd81SkorEPOIS84W4vm3SZtuNqa+fADcqe88Hcb0ZdTzjKILuwi19gzrQyME2knHY71EOETe9Yow5RD2hTIpB5ecNxI0LUKDq+Ii8HfBvndPBIr0BWYDugckQ3Bocf+yn/tn2/GZieFEyFpBGF/MnLbAAfUKIdeyFRX7ufaiWWz5yKAfEhtziqdAGZaXNaLG6gkpy3EixOAy6ZXuTAk3b3Y0FUmDjhOHllbPmTOcKMry9 + [ftp.osmocom.org]:48 ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBPdWn1kEousXuKsZ+qJEZTt/NSeASxCrUfNDW3LWtH+d8Ust7ZuKp/vuyG+5pe5pwpPOgFu7TjN+0lVjYJVXH54= + [ftp.osmocom.org]:48 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIK8iivY70EiR5NiGChV39gRLjNpC8lvu1ZdHtdMw2zuX + EOF + + # Clone and build the repositories + for i in $repos_api; do + git clone "$(osmo_git_clone_url "$i")" + cd "$i" + autoreconf -fi + ./configure \ + --prefix=$PWD/../install \ + --with-systemdsystemunitdir=no + make $PARALLEL_MAKE install + cd .. + done + + # Upload all docs + for i in $repos_api; do + if ! [ -d "$i"/doc ]; then + # e.g. libosmo-abis is built as dependency for others but doesn't + # have its own doxygen documentation as of writing + continue + fi + + rsync \ + -avz \ + --delete \ + -e "ssh -o 'UserKnownHostsFile=known_hosts' -p 48" \ + ./"$i"/doc/ \ + api@ftp.osmocom.org:web-files/latest/"$i"/ + done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia518979307ce633ccd2c431a8e8eea866da2a50d Gerrit-Change-Number: 30185 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: tests/osmux: Test incoming RTP stream with seqnum jumps during wrapar...

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/30184 to look at the new patch set (#2). Change subject: tests/osmux: Test incoming RTP stream with seqnum jumps during wraparound ...................................................................... tests/osmux: Test incoming RTP stream with seqnum jumps during wraparound Related: SYS#6161 Change-Id: Idd3a609452767f9c480c7c5ba9fc2a3e0a499968 --- M tests/osmux/osmux_input_test.c M tests/osmux/osmux_input_test.ok 2 files changed, 51 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/84/30184/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Idd3a609452767f9c480c7c5ba9fc2a3e0a499968 Gerrit-Change-Number: 30184 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 7 months

1
0
0 0

Change in libosmo-netif[master]: tests/osmux: Test incoming RTP stream with seqnum jumps during wrapar...

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30184 ) Change subject: tests/osmux: Test incoming RTP stream with seqnum jumps during wraparound ...................................................................... tests/osmux: Test incoming RTP stream with seqnum jumps during wraparound Related: SYS#6161 Change-Id: Idd3a609452767f9c480c7c5ba9fc2a3e0a499968 --- M tests/osmux/osmux_input_test.c 1 file changed, 8 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/84/30184/1 diff --git a/tests/osmux/osmux_input_test.c b/tests/osmux/osmux_input_test.c index 66335cd..aaab557 100644 --- a/tests/osmux/osmux_input_test.c +++ b/tests/osmux/osmux_input_test.c @@ -515,7 +515,7 @@ *osmux_transmitted = true; } -static void test_rtp_pkt_gap(void) +static void test_rtp_pkt_gap(uint16_t rtp_start_seqnum) { struct msgb *msg; int rc; @@ -523,11 +523,11 @@ bool osmux_transmitted = false; struct osmux_in_handle *h_input; - printf("===%s===\n", __func__); + printf("===%s(%" PRIu16 ")===\n", __func__, rtp_start_seqnum); clock_override_enable(true); clock_override_set(0, 0); - rtp_init(60, 18000); + rtp_init(rtp_start_seqnum, 18000); h_input = osmux_xfrm_input_alloc(tall_ctx); osmux_xfrm_input_set_initial_seqnum(h_input, 123); @@ -595,7 +595,11 @@ test_last_amr_cmr_f_q_used(); test_initial_osmux_seqnum(); test_rtp_dup(); - test_rtp_pkt_gap(); + test_rtp_pkt_gap(60); + /* Test several wraparound scenarios: */ + test_rtp_pkt_gap(65533); + test_rtp_pkt_gap(65534); + test_rtp_pkt_gap(65535); fprintf(stdout, "OK: Test passed\n"); return EXIT_SUCCESS; -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30184 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Idd3a609452767f9c480c7c5ba9fc2a3e0a499968 Gerrit-Change-Number: 30184 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 7 months

1
0
0 0

Change in simtrace2[master]: firmware/sniffer: Group global variables in structs

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30183 ) Change subject: firmware/sniffer: Group global variables in structs ...................................................................... Patch Set 1: (1 comment) File firmware/libcommon/source/sniffer.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1052): https://gerrit.osmocom.org/c/simtrace2/+/30183/comment/5aee55d6_85ac3b26 PS1, Line 479: if (ATR_S_WAIT_TC == g_atr.state && 2==i) { spaces required around that '==' (ctx:VxV) -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/30183 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I3e02f6c6b063ebc860b7a2a54dfc6051f1ea584f Gerrit-Change-Number: 30183 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 16 Nov 2022 11:04:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 7 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022