Attention is currently required from: pespin.
Hello osmith, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/30174
to look at the new patch set (#3).
Change subject: osmux: Obey current batch_size restrictions when creating forged RTP packets to fill holes
......................................................................
osmux: Obey current batch_size restrictions when creating forged RTP packets to fill holes
osmux_link_add() is renamed to osmux_link_handle_rtp_req(), and the last
part of it is split out and kept as osmux_link_add().
hence osmux_link_handle_rtp_req() does proper input checking (like
duplicates, holes, etc.) while osmux_link_add() expects all that to be
sorted out.
Reuse osmux_link_add() in osmux_replay_lost_packets() to properly update
the link state of the to-be-transmitted packet, circuit state, etc.
Change-Id: I4ea435bfb2490a375ad3e5068ee926e48b53cf5c
---
M src/osmux_input.c
M tests/osmux/osmux_input_test.c
M tests/osmux/osmux_input_test.ok
3 files changed, 125 insertions(+), 110 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/74/30174/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30174
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I4ea435bfb2490a375ad3e5068ee926e48b53cf5c
Gerrit-Change-Number: 30174
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/30195
to look at the new patch set (#2).
Change subject: osmux: Avoid filling in seqnum holes upon rx of RTP pkt with M bit set
......................................................................
osmux: Avoid filling in seqnum holes upon rx of RTP pkt with M bit set
Change-Id: I561fb836989d31f43a15b193ed9bec4103ea0f2b
---
M src/osmux_input.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/95/30195/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30195
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I561fb836989d31f43a15b193ed9bec4103ea0f2b
Gerrit-Change-Number: 30195
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/30196
to look at the new patch set (#2).
Change subject: osmux: Set M bit in osmuxhdr if seqnum hole found encoding RTP pkts
......................................................................
osmux: Set M bit in osmuxhdr if seqnum hole found encoding RTP pkts
So far only small intra-batch seqnum jumps are filled in with forged RTP
packets when storing the incoming RTP packets.
Under some conditions, holes may still exist in the queue of RTP packets
for a stream:
* Seqnum detected when first incoming RTP in batch is queued (this can
be improved in the future).
* Big seqnum jumps > batch_factor or simply filling out of bounds for currently
enqueued batch.
Specially the second case can come from long network dropouts, or simply
due to a bug in the RTP being feed to osmux layer (be it from local code
or peer). In that case (long jumps) we don't want to generate tons of
packets filling in several entire batches (potentially incredibly big
amount of batches).
Instead, in these scenarios, simply let the osmux peer know there was a
jump by setting the M bit on the next osmux header for that circuit
after the seq jump has been detected.
Related: SYS#6161
Change-Id: I05b1eae400cb60d1f4e927f853619d5ff470163f
---
M src/osmux_input.c
M tests/osmux/osmux_input_test.c
M tests/osmux/osmux_input_test.ok
M tests/osmux/osmux_test.c
M tests/osmux/osmux_test.ok
5 files changed, 155 insertions(+), 141 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/96/30196/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30196
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I05b1eae400cb60d1f4e927f853619d5ff470163f
Gerrit-Change-Number: 30196
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/30197
to look at the new patch set (#2).
Change subject: osmux: Support recreating lost RTP packets at start of the batch
......................................................................
osmux: Support recreating lost RTP packets at start of the batch
Previously, if RTP jumps were detected in the incoming RTP stream and
osmux state for that circuit was to start the next batch, the hole would
not been filled during queueing time and instead the encoder would have
set th M bit in the osmuxhdr to announce a sync point.
For small holes (eg less than the batch factor) it makes sense to start
filling the batch with crafted RTP packets in order to avoid the encoder
later on setting the M bit and hence avoid the peer receiving the Osmux
frame having to start a new syncrhonization point.
Related: SYS#6161
Change-Id: I9596501adf5b7b91983618c92c7b1792ee9461a3
---
M src/osmux_input.c
M tests/osmux/osmux_test.c
M tests/osmux/osmux_test.ok
3 files changed, 626 insertions(+), 426 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/97/30197/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30197
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I9596501adf5b7b91983618c92c7b1792ee9461a3
Gerrit-Change-Number: 30197
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30196 )
Change subject: osmux: Set M bit in osmuxhdr if seqnum hole found encoding RTP pkts
......................................................................
Patch Set 1:
(2 comments)
File tests/osmux/osmux_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1078):
https://gerrit.osmocom.org/c/libosmo-netif/+/30196/comment/700bff3f_fa925617
PS1, Line 206: if (k==0 || k==1)
spaces required around that '==' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1078):
https://gerrit.osmocom.org/c/libosmo-netif/+/30196/comment/5bb89f8c_aa0b837e
PS1, Line 206: if (k==0 || k==1)
spaces required around that '==' (ctx:VxV)
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30196
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I05b1eae400cb60d1f4e927f853619d5ff470163f
Gerrit-Change-Number: 30196
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 16 Nov 2022 18:40:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30194 )
Change subject: osmux: Use better rationale when limiting amount of lost & forged RTP incoming packets
......................................................................
Patch Set 1:
(1 comment)
File src/osmux_input.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1075):
https://gerrit.osmocom.org/c/libosmo-netif/+/30194/comment/5d30d5d3_4afba96c
PS1, Line 463: * returning 1 signalling "tranmission needed, call deliver() and retry".
'tranmission' may be misspelled - perhaps 'transmission'?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30194
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I4ea700dbbf469498befc939a844324259bbe332a
Gerrit-Change-Number: 30194
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Wed, 16 Nov 2022 18:40:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/30195 )
Change subject: osmux: Avoid filling in seqnum holes upon rx of RTP pkt with M bit set
......................................................................
osmux: Avoid filling in seqnum holes upon rx of RTP pkt with M bit set
Change-Id: I561fb836989d31f43a15b193ed9bec4103ea0f2b
---
M src/osmux_input.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/95/30195/1
diff --git a/src/osmux_input.c b/src/osmux_input.c
index c7f0f1e..c942036 100644
--- a/src/osmux_input.c
+++ b/src/osmux_input.c
@@ -435,6 +435,10 @@
int i, rc;
struct osmux_in_req clone_req;
+ /* If M bit is set, this is a sync point, so any sort of seq jump is expected and has no real meaning. */
+ if (req->rtph->marker)
+ return 0;
+
/* Have we seen any RTP packet in this batch before? */
if (llist_empty(&req->circuit->msg_list))
return 0;
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30195
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I561fb836989d31f43a15b193ed9bec4103ea0f2b
Gerrit-Change-Number: 30195
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange