Attention is currently required from: pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30127 )
Change subject: WIP: dumpcap-start/stop: Make script fail, not hang on sudo prompt
......................................................................
Patch Set 1:
(1 comment)
File ttcn3-dumpcap-start.sh:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30127/comment/2b988dfa_01ef…
PS1, Line 19: sudo -k
> this is dropping the sudo password from my currently active shell? Meanng each time after running an […]
Thanks for your comments, this branch is a result of me playing around and getting familiar with the code... I encountered some weird bug that threw me way off and some of the result of that is seen in these changes.
I didn't intend for it to go anywhere but this remote branch for the time being; it was more like 'ok maybe look at this again later ' when I use these.
(Another late reply due to the draft-feature..)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30127
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: arehbein/ttcn3-dumpcap-changes
Gerrit-Change-Id: Id160384bf624a4eb0f419cb8ba07d8b69bb693f3
Gerrit-Change-Number: 30127
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Nov 2022 19:32:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30134 )
Change subject: WIP: ttcn3-dumpcap*.sh: Don't use lsof
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> why has this been merged with a self +2 and having "WIP" in the commit log?!
I haven't yet read anything about how WIP-branches are to be used here. As indicated by my previous question in the 'sob'-chat, I was looking for a way to be able to have 'docker-playground' point at my changes so I can have them tested - for me that's quicker and easier right now than manually setting up tests.
So, to be clear, for me this branch is just a 'WIP'-remote that I can have my branch of 'docker-playground' point to in order to see if my changes are breaking anything or not by running 'jenkins.sh' locally on my 'docker-playground' branch.
I didn't see any other way of having my changes appear in the remote repo for fetching back to my local repo except for submitting them on Gerrit - the idea being that as long as it stays in my WIP-branch, it doesn't matter.
If that is not acceptable, please tell me where I can push such WIP changes that I want to try out, and I'd be curious to know what other devs use their WIP branches for (or point me to a Wiki page, I guess... I did read around in the Wikis but don't recall reading about WIP branches)/how they make WIP commits appear in their remote for fetching without submitting them.
I'm not yet aware where else I could/should push such changes.
Edit: I wrote this earlier, but I still have to get used to the the draft-feature for replies so here goes a late reply. I think next time I'll try the private branch feature of Gerrit (I think appending a %private), if our server supports it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30134
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: arehbein/wip
Gerrit-Change-Id: Ie34eaa778f78b9685dd601d5e9898829caf0c7ca
Gerrit-Change-Number: 30134
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Nov 2022 19:31:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/30210
to look at the new patch set (#2).
Change subject: osmux: Introduce API osmux_xfrm_input_set_name()
......................................................................
osmux: Introduce API osmux_xfrm_input_set_name()
This will be used internally by osmux code to print more meaningful
lines.
Since the name is set later than alloc time, the first log line contains
a pointer address (default identification method) which makes unit test
fail, hence we need to filter & replace those pointer addresses when
running the testsuite.
Related: SYS#6161
Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6
---
M include/osmocom/netif/osmux.h
M src/osmux_input.c
M tests/osmux/osmux_test.c
M tests/osmux/osmux_test.ok
M tests/testsuite.at
5 files changed, 22 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/10/30210/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30210
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ibbcfdb23a6015ce45840bb64b2b560c2806f7ff6
Gerrit-Change-Number: 30210
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/30211
to look at the new patch set (#2).
Change subject: osmux: Improve logging of osmux_xfrm_input
......................................................................
osmux: Improve logging of osmux_xfrm_input
This allows easily identifying and following state and lifecycle of
CIDs when looking at logs.
Related: SYS#6161
Change-Id: I6a3113dfaef0adbb20162985e3b7d57c46dbc016
---
M src/osmux_input.c
M tests/osmux/osmux_test.ok
2 files changed, 270 insertions(+), 230 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/11/30211/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/30211
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I6a3113dfaef0adbb20162985e3b7d57c46dbc016
Gerrit-Change-Number: 30211
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/30213 )
Change subject: osmux: Use new osmux_xfrm_input API to set name on each link
......................................................................
osmux: Use new osmux_xfrm_input API to set name on each link
Change-Id: Iaea980a2e11282add12f9af585500d90f0462279
Depends: libosmo-netif.git Change-Id 8bb688e4827f345416c2a4526ced956a07fcc60b
---
M src/common/osmux.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/13/30213/1
diff --git a/src/common/osmux.c b/src/common/osmux.c
index fa0f7cc..d74cce3 100644
--- a/src/common/osmux.c
+++ b/src/common/osmux.c
@@ -165,6 +165,7 @@
static struct osmux_handle *osmux_handle_alloc(struct gsm_bts *bts, const struct osmo_sockaddr *rem_addr)
{
struct osmux_handle *h;
+ char name[128] = "to_";
h = talloc_zero(bts, struct osmux_handle);
if (!h)
@@ -178,6 +179,9 @@
talloc_free(h);
return NULL;
}
+
+ osmo_sockaddr_to_str_buf(name + 3, sizeof(name) - 3, rem_addr);
+ osmux_xfrm_input_set_name(h->in, name);
/* sequence number to start OSMUX message from */
osmux_xfrm_input_set_initial_seqnum(h->in, 0);
osmux_xfrm_input_set_batch_factor(h->in, bts->osmux.batch_factor);
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30213
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iaea980a2e11282add12f9af585500d90f0462279
Gerrit-Change-Number: 30213
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30212 )
Change subject: osmux: Use new osmux_xfrm_input API to set name on each link
......................................................................
osmux: Use new osmux_xfrm_input API to set name on each link
Depends: libosmo-netif.git Change-Id 8bb688e4827f345416c2a4526ced956a07fcc60b
Change-Id: Id5b7d497be4b3405403d30e40e1a52f13101cf5f
---
M src/libosmo-mgcp/mgcp_osmux.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/12/30212/1
diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c
index fcff841..50a5b98 100644
--- a/src/libosmo-mgcp/mgcp_osmux.c
+++ b/src/libosmo-mgcp/mgcp_osmux.c
@@ -155,6 +155,7 @@
{
struct osmux_handle *h;
const struct mgcp_config *cfg = trunk->cfg;
+ char name[128] = "to_";
h = talloc_zero(trunk, struct osmux_handle);
if (!h)
@@ -167,6 +168,9 @@
talloc_free(h);
return NULL;
}
+
+ osmo_sockaddr_to_str_buf(name + 3, sizeof(name) - 3, rem_addr);
+ osmux_xfrm_input_set_name(h->in, name);
/* sequence number to start OSMUX message from */
osmux_xfrm_input_set_initial_seqnum(h->in, 0);
osmux_xfrm_input_set_batch_factor(h->in, cfg->osmux.batch_factor);
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30212
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id5b7d497be4b3405403d30e40e1a52f13101cf5f
Gerrit-Change-Number: 30212
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange