October 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: linuxlist: add llist_entry_empty()

by lynxis lazus

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/29792 ) Change subject: linuxlist: add llist_entry_empty() ...................................................................... linuxlist: add llist_entry_empty() Return true if an entry is not included in a llist or NULL. Change-Id: Ia4afe3e77f53728db1d139bded5925183dca011f --- M include/osmocom/core/linuxlist.h 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/92/29792/1 diff --git a/include/osmocom/core/linuxlist.h b/include/osmocom/core/linuxlist.h index 2fc3fa7..398128d 100644 --- a/include/osmocom/core/linuxlist.h +++ b/include/osmocom/core/linuxlist.h @@ -171,6 +171,17 @@ return head->next == head; } +/*! + * Test whether a linked list entry is empty or not included by any list. + * \param[in] entry the llist to test + * \return 1 if the entry is NULL or not included by any llist. + */ +static inline int llist_entry_empty(const struct llist_head *entry) +{ + return entry == NULL || (!entry->next && !entry->prev) + || (entry->next == LLIST_POISON1 && entry->prev == LLIST_POISON2); +} + static inline void __llist_splice(struct llist_head *llist, struct llist_head *head) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29792 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia4afe3e77f53728db1d139bded5925183dca011f Gerrit-Change-Number: 29792 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Introduce support for libosmo-mgcp-client MGW pooling

by pespin

Attention is currently required from: pespin, fixeria, daniel, dexter. Hello osmith, Jenkins Builder, fixeria, daniel, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/29782 to look at the new patch set (#4). Change subject: Introduce support for libosmo-mgcp-client MGW pooling ...................................................................... Introduce support for libosmo-mgcp-client MGW pooling Large RAN installations may benefit from distributing the RTP voice stream load over multiple media gateways. libosmo-mgcp-client supports MGW pooling since version 1.8.0 (more than one year ago). OsmoBSC has already been making use of it since then (see osmo-bsc.git 8d22e6870637ed6d392a8a77aeaebc51b23a8a50); lets use this feature in osmo-msc too. This commit is also part of a series of patches cleaning up libosmo-mgcp-client and slowly getting rid of the old non-mgw-pooled VTY configuration, in order to keep only 1 way to configure libosmo-mgcp-client through VTY. Related: SYS#5091 Related: SYS#5987 Change-Id: I7670ba56fe989706579224a364595fdd4b4708ff --- M doc/examples/osmo-msc/osmo-msc.cfg M doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg M doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg M doc/manuals/chapters/running.adoc M include/osmocom/msc/gsm_data.h M include/osmocom/msc/vty.h M src/libmsc/call_leg.c M src/libmsc/msc_vty.c M src/osmo-msc/msc_main.c M tests/msc_vlr/msc_vlr_tests.c M tests/test_nodes.vty 11 files changed, 91 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/82/29782/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7670ba56fe989706579224a364595fdd4b4708ff Gerrit-Change-Number: 29782 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-bsc-nat[master]: [do not merge] test rpm/deb CI

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29492 ) Change subject: [do not merge] test rpm/deb CI ...................................................................... Abandoned works fine :) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/29492 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I6842b5c641e6b6a0cfb428c7538e0a041751143e Gerrit-Change-Number: 29492 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: lint: ignore STATIC_CONST_CHAR_ARRAY

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29448 ) Change subject: lint: ignore STATIC_CONST_CHAR_ARRAY ...................................................................... Abandoned let's not ignore it, see discussion -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29448 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I09eecd9382842293ab231eb9cc92756fbe7723c1 Gerrit-Change-Number: 29448 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Introduce support for libosmo-mgcp-client MGW pooling

by osmith

Attention is currently required from: pespin, fixeria, daniel, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29782 ) Change subject: Introduce support for libosmo-mgcp-client MGW pooling ...................................................................... Patch Set 3: (2 comments) File src/libmsc/call_leg.c: https://gerrit.osmocom.org/c/osmo-msc/+/29782/comment/e7bac975_17403a24 PS3, Line 20: #include <asm-generic/errno-base.h> why not errno.h? File src/osmo-msc/msc_main.c: https://gerrit.osmocom.org/c/osmo-msc/+/29782/comment/7784f242_0ad2adae PS3, Line 561: , (ignoring MGW configuration in VTY node 'msc'). maybe only print this part, and maybe as warning, if there's actually a mgw configuration in vty node msc? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7670ba56fe989706579224a364595fdd4b4708ff Gerrit-Change-Number: 29782 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Oct 2022 10:50:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-pcap[master]: doc/manuals: update git URLs (git -> https; gitea)

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/29790 ) Change subject: doc/manuals: update git URLs (git -> https; gitea) ...................................................................... doc/manuals: update git URLs (git -> https; gitea) Change-Id: I5d510f324f59303c79c3a0fb2c15f79e7cb3a8c4 --- M doc/manuals/osmopcap-usermanual-docinfo.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/doc/manuals/osmopcap-usermanual-docinfo.xml b/doc/manuals/osmopcap-usermanual-docinfo.xml index 528635c..cede5ab 100644 --- a/doc/manuals/osmopcap-usermanual-docinfo.xml +++ b/doc/manuals/osmopcap-usermanual-docinfo.xml @@ -40,8 +40,8 @@ </para> <para> The Asciidoc source code of this manual can be found at - <ulink url="http://git.osmocom.org/osmo-gsm-manuals/"> - http://git.osmocom.org/osmo-gsm-manuals/ + <ulink url="https://gitea.osmocom.org/cellular-infrastructure/osmo-gsm-manuals"> + https://gitea.osmocom.org/cellular-infrastructure/osmo-gsm-manuals </ulink> </para> </legalnotice> -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/29790 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I5d510f324f59303c79c3a0fb2c15f79e7cb3a8c4 Gerrit-Change-Number: 29790 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: vty: Write deprecation warning using non-mgw nodes

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29778 ) Change subject: mgcp-client: vty: Write deprecation warning using non-mgw nodes ...................................................................... mgcp-client: vty: Write deprecation warning using non-mgw nodes Let's advise all our users to migrate to the new pooled mode, the old VTY interface should be dropped at some point to avoid making it overcomplex to configure MGW. There's no need to maintain the same set of commands under 2 different places. Change-Id: I95f717a0fcd3c4ca622e3989baa28fac1f7ec1ca --- M src/libosmo-mgcp-client/mgcp_client_vty.c 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c b/src/libosmo-mgcp-client/mgcp_client_vty.c index da017f6..76f8c4f 100644 --- a/src/libosmo-mgcp-client/mgcp_client_vty.c +++ b/src/libosmo-mgcp-client/mgcp_client_vty.c @@ -52,8 +52,13 @@ { if (global_mgcp_client_pool && vty->node == global_mgcp_client_pool->vty_node->node) return vty->index; - else - return global_mgcp_client_conf; + + /* Global single MGCP config, deprecated: */ + vty_out(vty, "%% MGCP commands outside of 'mgw' nodes are deprecated. " + "You should consider reading User Manual and migrating to 'mgw' node.%s", + VTY_NEWLINE); + + return global_mgcp_client_conf; } DEFUN(cfg_mgw_local_ip, cfg_mgw_local_ip_cmd, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I95f717a0fcd3c4ca622e3989baa28fac1f7ec1ca Gerrit-Change-Number: 29778 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Use random free local port by default

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29784 ) Change subject: mgcp-client: Use random free local port by default ...................................................................... mgcp-client: Use random free local port by default Deprecate mgcp_client_connect2() and all the related messy system where configured port is incremented until a free port is found. Let's simply use local_port=0 by default and let the kernel take care of doing all that. The mgcp_client_connect2() is actually not being used anywhere outside of libosmo-mgcp-client, so it's not a real problem deprecating it. We could poitentially remove it too. This helps in fixing a regression in recent refactoring commit f48cd95bbc1383f33ad9cd9cf0b0a02f9371b21a, which unified calls to mgcp_client_connect() and in the process dropped the code path which was setting the retry_n_ports=99. As a result, since all libosmo-mgcp-client instances set local_port=2727 and addr=NULL by default, using MGW pooling or having several osmo-bsc or osmo-msc processes would make creating the socket fail. Change-Id: I5683bcf3b2c4e8058338433f2cd1b143753f6512 --- M include/osmocom/mgcp_client/mgcp_client.h M src/libosmo-mgcp-client/mgcp_client.c M src/libosmo-mgcp-client/mgcp_client_pool.c 3 files changed, 11 insertions(+), 53 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmocom/mgcp_client/mgcp_client.h b/include/osmocom/mgcp_client/mgcp_client.h index d421273..b40923d 100644 --- a/include/osmocom/mgcp_client/mgcp_client.h +++ b/include/osmocom/mgcp_client/mgcp_client.h @@ -7,7 +7,7 @@ /* See also: RFC 3435, chapter 3.5 Transmission over UDP */ #define MGCP_CLIENT_LOCAL_ADDR_DEFAULT NULL /* INADDR(6)_ANY */ -#define MGCP_CLIENT_LOCAL_PORT_DEFAULT 2727 +#define MGCP_CLIENT_LOCAL_PORT_DEFAULT 0 #define MGCP_CLIENT_REMOTE_ADDR_DEFAULT "127.0.0.1" #define MGCP_CLIENT_REMOTE_PORT_DEFAULT 2427 @@ -140,7 +140,7 @@ struct mgcp_client *mgcp_client_init(void *ctx, struct mgcp_client_conf *conf); int mgcp_client_connect(struct mgcp_client *mgcp); -int mgcp_client_connect2(struct mgcp_client *mgcp, unsigned int retry_n_ports); +int mgcp_client_connect2(struct mgcp_client *mgcp, unsigned int retry_n_ports) OSMO_DEPRECATED("Use mgcp_client_connect() instead"); void mgcp_client_disconnect(struct mgcp_client *mgcp); const char *mgcp_client_remote_addr_str(struct mgcp_client *mgcp); diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c index 2ca3b66..6f1ab6b 100644 --- a/src/libosmo-mgcp-client/mgcp_client.c +++ b/src/libosmo-mgcp-client/mgcp_client.c @@ -769,7 +769,7 @@ mgcp->actual.local_addr = conf->local_addr ? conf->local_addr : MGCP_CLIENT_LOCAL_ADDR_DEFAULT; - mgcp->actual.local_port = conf->local_port >= 0 ? (uint16_t)conf->local_port : + mgcp->actual.local_port = conf->local_port > 0 ? (uint16_t)conf->local_port : MGCP_CLIENT_LOCAL_PORT_DEFAULT; mgcp->actual.remote_addr = conf->remote_addr ? conf->remote_addr : @@ -799,49 +799,6 @@ return mgcp; } -static int init_socket(struct mgcp_client *mgcp, unsigned int retry_n_ports) -{ - int rc; - struct osmo_wqueue *wq; - unsigned int i; - - wq = &mgcp->wq; - - for (i = 0; i < retry_n_ports + 1; i++) { - - /* Initialize socket with the currently configured port number */ - rc = osmo_sock_init2_ofd(&wq->bfd, AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, mgcp->actual.local_addr, - mgcp->actual.local_port, mgcp->actual.remote_addr, mgcp->actual.remote_port, - OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT); - if (rc > 0) - return rc; - - /* If there is a different port than the default port configured then we assume that the user has - * chosen that port conciously and we will not try to resolve this by silently choosing a different - * port. */ - if (mgcp->actual.local_port != MGCP_CLIENT_LOCAL_PORT_DEFAULT && i == 0) - return -EINVAL; - - if (i == retry_n_ports) { - /* Last try failed */ - LOGPMGW(mgcp, LOGL_NOTICE, "Failed to bind to %s:%d -- check configuration!\n", - mgcp->actual.local_addr ? mgcp->actual.local_addr : "(any)", mgcp->actual.local_port); - if (retry_n_ports == 0) - return -EINVAL; - } else { - /* Choose a new port number to try next */ - LOGPMGW(mgcp, LOGL_NOTICE, - "Failed to bind to %s:%d, retrying with port %d -- check configuration!\n", - mgcp->actual.local_addr ? mgcp->actual.local_addr : "(any)", mgcp->actual.local_port, - mgcp->actual.local_port + 1); - mgcp->actual.local_port++; - } - } - - LOGPMGW(mgcp, LOGL_FATAL, "Failed to find a port to bind on %u times -- check configuration!\n", i); - return -EINVAL; -} - /* Safely ignore the MGCP response to the DLCX sent via _mgcp_client_send_dlcx() */ static void _ignore_mgcp_response(struct mgcp_response *response, void *priv) { } @@ -878,9 +835,8 @@ /*! Initialize client connection (opens socket) * \param[in,out] mgcp MGCP client descriptor. - * \param[in] retry_n_ports number of consecutive local ports that should be used to retry on failure. * \returns 0 on success, -EINVAL on error. */ -int mgcp_client_connect2(struct mgcp_client *mgcp, unsigned int retry_n_ports) +int mgcp_client_connect(struct mgcp_client *mgcp) { struct osmo_wqueue *wq; int rc; @@ -899,7 +855,9 @@ osmo_fd_setup(&wq->bfd, -1, OSMO_FD_READ, osmo_wqueue_bfd_cb, mgcp, 0); - rc = init_socket(mgcp, retry_n_ports); + rc = osmo_sock_init2_ofd(&wq->bfd, AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, mgcp->actual.local_addr, + mgcp->actual.local_port, mgcp->actual.remote_addr, mgcp->actual.remote_port, + OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT); if (rc < 0) { LOGPMGW(mgcp, LOGL_FATAL, "Failed to initialize socket %s:%u -> %s:%u for MGW: %s\n", @@ -925,12 +883,12 @@ return rc; } -/*! Initialize client connection (opens socket) +/*! DEPRECATED: Initialize client connection (opens socket) * \param[in,out] mgcp MGCP client descriptor. * \returns 0 on success, -EINVAL on error. */ -int mgcp_client_connect(struct mgcp_client *mgcp) +int mgcp_client_connect2(struct mgcp_client *mgcp, unsigned int retry_n_ports) { - return mgcp_client_connect2(mgcp, 99); + return mgcp_client_connect(mgcp); } /*! Terminate client connection diff --git a/src/libosmo-mgcp-client/mgcp_client_pool.c b/src/libosmo-mgcp-client/mgcp_client_pool.c index caec535..fe3cccd 100644 --- a/src/libosmo-mgcp-client/mgcp_client_pool.c +++ b/src/libosmo-mgcp-client/mgcp_client_pool.c @@ -236,7 +236,7 @@ pool_member->client->pool_member = pool_member; /* Connect client */ - if (mgcp_client_connect2(pool_member->client, 0)) { + if (mgcp_client_connect(pool_member->client)) { LOGPPMGW(pool_member, LOGL_ERROR, "MGCP client connect failed at (%s:%u)\n", pool_member->conf.remote_addr, pool_member->conf.remote_port); talloc_free(pool_member->client); -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I5683bcf3b2c4e8058338433f2cd1b143753f6512 Gerrit-Change-Number: 29784 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Use random free local port by default

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29784 ) Change subject: mgcp-client: Use random free local port by default ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I5683bcf3b2c4e8058338433f2cd1b143753f6512 Gerrit-Change-Number: 29784 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Oct 2022 10:46:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: vty: Write deprecation warning using non-mgw nodes

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29778 ) Change subject: mgcp-client: vty: Write deprecation warning using non-mgw nodes ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29778 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I95f717a0fcd3c4ca622e3989baa28fac1f7ec1ca Gerrit-Change-Number: 29778 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 18 Oct 2022 10:46:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022