October 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: doc: correct typo in ticket reference

by msuraev

msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29814 ) Change subject: doc: correct typo in ticket reference ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29814 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icf13b351dc74508fc312c535d68b13b7ce9b7e1e Gerrit-Change-Number: 29814 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Wed, 19 Oct 2022 17:48:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp_send: Use mgcp_conn_rtp_is_iuup() helper

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29813 ) Change subject: mgcp_send: Use mgcp_conn_rtp_is_iuup() helper ...................................................................... mgcp_send: Use mgcp_conn_rtp_is_iuup() helper Change-Id: I6988337f395168b88959876fe3827d8e67b8fc00 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/13/29813/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 7261b9a..bb8cfa3 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -1168,7 +1168,7 @@ * course unable to patch the payload type. A situation like this * should not occur if transcoding is consequently avoided. Until * we have transcoding support in osmo-mgw we can not resolve this. */ - if (is_rtp && conn_dst->type != MGCP_RTP_IUUP) { + if (is_rtp && !mgcp_conn_rtp_is_iuup(conn_dst)) { rc = mgcp_patch_pt(conn_src, conn_dst, msg); if (rc < 0) { LOGPENDP(endp, DRTP, LOGL_DEBUG, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6988337f395168b88959876fe3827d8e67b8fc00 Gerrit-Change-Number: 29813 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: Fix misleading error log

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29812 ) Change subject: Fix misleading error log ...................................................................... Fix misleading error log The check is not for an AMR RTP packet. It actually only checks for RTP header. Change-Id: I60d7dbfeb2977bcb7102eed19e1c73c9433151a7 --- M src/libosmo-mgcp/mgcp_network.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/12/29812/1 diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c index 3981975..7261b9a 100644 --- a/src/libosmo-mgcp/mgcp_network.c +++ b/src/libosmo-mgcp/mgcp_network.c @@ -691,7 +691,7 @@ { struct rtp_hdr *rtp_hdr; if (msgb_length(msg) < sizeof(struct rtp_hdr)) { - LOGPENDP(endp, DRTP, LOGL_ERROR, "AMR RTP packet too short (%d < %zu)\n", + LOGPENDP(endp, DRTP, LOGL_ERROR, "RTP packet too short (%d < %zu)\n", msgb_length(msg), sizeof(struct rtp_hdr)); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29812 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I60d7dbfeb2977bcb7102eed19e1c73c9433151a7 Gerrit-Change-Number: 29812 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: call_leg: Fix EV_MGW_ENDPOINT_GONE not processed in RELEASE state

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/29811 to look at the new patch set (#3). Change subject: call_leg: Fix EV_MGW_ENDPOINT_GONE not processed in RELEASE state ...................................................................... call_leg: Fix EV_MGW_ENDPOINT_GONE not processed in RELEASE state Since call_leg_fsm_releasing_onenter() calls immediatelly osmo_fsm_inst_term(), it meant we couldn't receive any event in that state because osmo_fsm disables event dispatching to FSMs being terminated. As a result, CALL_LEG_EV_MGW_ENDPOINT_GONE was never received and hence call_leg_mgw_endpoint_gone() was never called, which means the mgcp_client used in cl->mgw_endpoint was never put back to the pool. By first freeing all the children (rtp_streams), we make sure cl->mgw_endpoint ends up with no conns and sends us the GONE event before we go ourselves into termination state. Related: SYS#5987 Change-Id: I2126578c4e64c9f336e8a1f6ee98de970866b8dc --- M src/libmsc/call_leg.c M tests/msc_vlr/msc_vlr_test_call.err 2 files changed, 36 insertions(+), 30 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/29811/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2126578c4e64c9f336e8a1f6ee98de970866b8dc Gerrit-Change-Number: 29811 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: call_leg: Fix EV_MGW_ENDPOINT_GONE not processed in RELEASE state

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-msc/+/29811 ) Change subject: call_leg: Fix EV_MGW_ENDPOINT_GONE not processed in RELEASE state ...................................................................... call_leg: Fix EV_MGW_ENDPOINT_GONE not processed in RELEASE state Since call_leg_fsm_releasing_onenter() calls immediatelly osmo_fsm_inst_term(), it meant we couldn't receive any event in that state because osmo_fsm disables event dispatching to FSMs being terminated. As a result, CALL_LEG_EV_MGW_ENDPOINT_GONE was never received and hence call_leg_mgw_endpoint_gone() was never called, which means the mgcp_client used in cl->mgw_endpoint was never put back to the pool. By first freeing all the children (rtp_streams), we make sure cl->mgw_endpoint ends up with no conns and sends us the GONE event before we go ourselves into termination state. Related: SYS#5987 Change-Id: I2126578c4e64c9f336e8a1f6ee98de970866b8dc --- M src/libmsc/call_leg.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/29811/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2126578c4e64c9f336e8a1f6ee98de970866b8dc Gerrit-Change-Number: 29811 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Introduce support for libosmo-mgcp-client MGW pooling

by pespin

Attention is currently required from: osmith, fixeria, daniel, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29782 ) Change subject: Introduce support for libosmo-mgcp-client MGW pooling ...................................................................... Patch Set 11: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I7670ba56fe989706579224a364595fdd4b4708ff Gerrit-Change-Number: 29782 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Oct 2022 16:37:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: call_leg: Fix EV_MGW_ENDPOINT_GONE not processed in RELEASE state

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/29811 ) Change subject: call_leg: Fix EV_MGW_ENDPOINT_GONE not processed in RELEASE state ...................................................................... call_leg: Fix EV_MGW_ENDPOINT_GONE not processed in RELEASE state Since call_leg_fsm_releasing_onenter() calls immediatelly osmo_fsm_inst_term(), it meant we couldn't receive any event in that state because osmo_fsm fisables event dispatching to FSMs being terminated. As a result, CALL_LEG_EV_MGW_ENDPOINT_GONE was never received and hence call_leg_mgw_endpoint_gone() was never called, which means the mgcp_client used in cl->mgw_endpoint was never put back to the pool. By first freeing all the children (rtp_streams), we make sure cl->mgw_endpoint ends up with no conns and sends us the GONE event before we go ourselves into termination state. Related: SYS#5987 Change-Id: I2126578c4e64c9f336e8a1f6ee98de970866b8dc --- M src/libmsc/call_leg.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/29811/1 diff --git a/src/libmsc/call_leg.c b/src/libmsc/call_leg.c index f8a75c4..03c9882 100644 --- a/src/libmsc/call_leg.c +++ b/src/libmsc/call_leg.c @@ -188,6 +188,12 @@ void call_leg_fsm_releasing_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) { + /* Trigger termination of children FSMs (rtp_stream(s)) before + * terminating ourselves, otherwise we are not able to receive + * CALL_LEG_EV_MGW_ENDPOINT_GONE from cl->mgw_endpoint (call_leg => + * rtp_stream => mgw_endpoint), because osmo_fsm disabled dispatching + * events to an FSM in process of terminating. */ + osmo_fsm_inst_term_children(fi, OSMO_FSM_TERM_PARENT, NULL); osmo_fsm_inst_term(fi, OSMO_FSM_TERM_REGULAR, NULL); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2126578c4e64c9f336e8a1f6ee98de970866b8dc Gerrit-Change-Number: 29811 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: tests/test_nodes.vty: Avoid listing commands provided by lib

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/29802 to look at the new patch set (#4). Change subject: tests/test_nodes.vty: Avoid listing commands provided by lib ...................................................................... tests/test_nodes.vty: Avoid listing commands provided by lib Those commands are not controlled/implemented in this repository, so it's a bad idea having them show up here, since they may change. be modified, become deprecated, etc. They are actually becoming deprecated now in libosmo-mgcp-client (osmo-mgw.git Change-Id Id55af13d2ecde49d968b9dca6a2f8108a17ec484) and hence they don't appear anymore when listing the node. Change-Id: I5d908f9e3023f725d49ed039158bd3d09828f12c --- M tests/test_nodes.vty 1 file changed, 1 insertion(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/02/29802/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I5d908f9e3023f725d49ed039158bd3d09828f12c Gerrit-Change-Number: 29802 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Use new mgcp-client VTY commands under mgw node

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/29803 to look at the new patch set (#4). Change subject: Use new mgcp-client VTY commands under mgw node ...................................................................... Use new mgcp-client VTY commands under mgw node New VTY commands have been added recently to the "mgw" node which drop the redundant "mgw" prefix on each fo them. Change-Id: I8ac11388e9493416b644812638e1374251725584 Depends: osmo-mgw.git Change-Id: Id55af13d2ecde49d968b9dca6a2f8108a17ec484 Related: SYS#5987 --- M doc/examples/osmo-msc/osmo-msc.cfg M doc/examples/osmo-msc/osmo-msc_custom-sccp.cfg M doc/examples/osmo-msc/osmo-msc_multi-cs7.cfg M doc/manuals/chapters/running.adoc 4 files changed, 12 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/03/29803/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I8ac11388e9493416b644812638e1374251725584 Gerrit-Change-Number: 29803 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgcp-client: Fix no 'mgw ' prefix written in old VTY node

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29810 ) Change subject: mgcp-client: Fix no 'mgw ' prefix written in old VTY node ...................................................................... mgcp-client: Fix no 'mgw ' prefix written in old VTY node Recent commit dropped the 'mgw ' prefix in commands under the "mgw" VTY node because it was redundant. However, for old apps still not supporting the 'mgw' node, the commands are still printed in another node and hence the 'mgw ' prefix must still be appeneded to them, to avoid breaking backward compatibility. Related: SYS#5987 Fixes: 8c138fe89cc070f860eca641481a092225b1247e Change-Id: Ifbfb71f8864b425c1b842cdee241ce279d17a8ba --- M src/libosmo-mgcp-client/mgcp_client_vty.c 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/libosmo-mgcp-client/mgcp_client_vty.c b/src/libosmo-mgcp-client/mgcp_client_vty.c index 4f71e3d..704203c 100644 --- a/src/libosmo-mgcp-client/mgcp_client_vty.c +++ b/src/libosmo-mgcp-client/mgcp_client_vty.c @@ -286,33 +286,36 @@ int port; struct reset_ep *reset_ep; - if (conf->description) + /* If caller doesn't the MGW pool API (mgcp_client_pool_vty_init was never called), + * then the "mgw" cmd prefix must be added since the old node always contained it. + */ + const char *mgw_prefix = global_mgcp_client_pool ? "" : "mgw "; + + if (conf->description) /* description never had "mgw" prefix even on old node: */ vty_out(vty, "%sdescription %s%s", indent, conf->description, VTY_NEWLINE); addr = conf->local_addr; if (addr) - vty_out(vty, "%slocal-ip %s%s", indent, addr, - VTY_NEWLINE); + vty_out(vty, "%s%slocal-ip %s%s", indent, mgw_prefix, addr, VTY_NEWLINE); port = conf->local_port; if (port >= 0) - vty_out(vty, "%slocal-port %u%s", indent, + vty_out(vty, "%s%slocal-port %u%s", indent, mgw_prefix, (uint16_t)port, VTY_NEWLINE); addr = conf->remote_addr; if (addr) - vty_out(vty, "%sremote-ip %s%s", indent, addr, - VTY_NEWLINE); + vty_out(vty, "%s%sremote-ip %s%s", indent, mgw_prefix, addr, VTY_NEWLINE); port = conf->remote_port; if (port >= 0) - vty_out(vty, "%sremote-port %u%s", indent, + vty_out(vty, "%s%sremote-port %u%s", indent, mgw_prefix, (uint16_t)port, VTY_NEWLINE); if (conf->endpoint_domain_name[0]) - vty_out(vty, "%sendpoint-domain %s%s", indent, + vty_out(vty, "%s%sendpoint-domain %s%s", indent, mgw_prefix, conf->endpoint_domain_name, VTY_NEWLINE); llist_for_each_entry(reset_ep, &conf->reset_epnames, list) - vty_out(vty, "%sreset-endpoint %s%s", indent, reset_ep->name, VTY_NEWLINE); + vty_out(vty, "%s%sreset-endpoint %s%s", indent, mgw_prefix, reset_ep->name, VTY_NEWLINE); return CMD_SUCCESS; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29810 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifbfb71f8864b425c1b842cdee241ce279d17a8ba Gerrit-Change-Number: 29810 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022